Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

2018-09-26 Thread Jody Garnett
> By the way, how does Jigsaw work with optional dependencies? Can we > still leave out unused dependencies like with the current classpath? Or > will Java 11 spit the dummy? > Good question, here is my speculation: If the dependency is something like log4j and we have adapting code that we can u

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

2018-09-26 Thread Ben Caradoc-Davies
On 27/09/2018 10:01, Jody Garnett wrote: Hey Ben - are you available for the code sprint? Completely understand if you are not being a small business, but we would really love your help. Sorry, I am not likely to be available. Additional comments/confusion inline: On Wed, 26 Sep 2018 at 14:50

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

2018-09-26 Thread Jody Garnett
Hey Ben - are you available for the code sprint? Completely understand if you are not being a small business, but we would really love your help. Additional comments/confusion inline: On Wed, 26 Sep 2018 at 14:50, Ben Caradoc-Davies wrote: > Does Jigsaw prevent classpath trickery like gt-xsd-gml

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

2018-09-26 Thread Ben Caradoc-Davies
Does Jigsaw prevent classpath trickery like gt-xsd-gml3 org.geotools.referencing.crs.EPSGCRSAuthorityFactory? This is required to make tests pass in Eclipse. Are modules like gt-app-schema that define classes in several packages also defined in other modules affected by this change? I guess th

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

2018-09-26 Thread Andrea Aime
On Wed, Sep 26, 2018 at 8:12 PM Jody Garnett wrote: > > "I think it is a requirement for the work". The work is "Restructure >> GeoTools into Jigsaw modules" and covers two items: >> * Providing an automatic module name for each jar >> * Refactoring the codebase to avoid package conflicts >> >> C

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

2018-09-26 Thread Jody Garnett
> "I think it is a requirement for the work". The work is "Restructure > GeoTools into Jigsaw modules" and covers two items: > * Providing an automatic module name for each jar > * Refactoring the codebase to avoid package conflicts > > Can you explain how this package renaming is required for the

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

2018-09-26 Thread Andrea Aime
On Tue, Sep 25, 2018 at 9:13 PM Jody Garnett wrote: > I like the direction, but does not seem a requirement, more of a nice to >> have. Can we do it towards the end, when everything >> is building and ready to merge in mainline? >> > > We may be able to move it near the end - but I think it is a