Re: [Geotools-devel] JDK11: run build with illegal reflective access checks, here is a report

2018-10-21 Thread Jody Garnett
> > *4) NIOUtilities* > WARNING: Illegal reflective access by org.geotools.resources.NIOUtilities > (file:/home/aaime/devel/git-gt/modules/library/metadata/target/gt-metadata-21-SNAPSHOT.jar) > to method java.nio.DirectByteBuffer.cleaner() > > This is legit, but without that cleaner on Windows shap

Re: [Geotools-devel] OGR Module Support

2018-10-21 Thread Andrea Aime
Hi, overall the changes look fine to me, but it would be easier to review them on a PR. Could you make one? Sorry for the late reply, during the week it's really hard to find time, and the JDK11 upgrade sprint has been sucking away spare time too Cheers Andrea On Sun, Oct 14, 2018 at 10:58 PM Ja

Re: [Geotools-devel] JDK11: run build with illegal reflective access checks, here is a report

2018-10-21 Thread Andrea Aime
I've uploaded here a log of a full sequential (-T1) build with "--illlegal-access=debug" turned on, meaning each illegal access warning also has a stack trace of where it came from, useful for locating sources of a particular violation without running a full build locally: https://drive.google.co

[Geotools-devel] JDK11: run build with illegal reflective access checks, here is a report

2018-10-21 Thread Andrea Aime
Hi, I've enabled emitting warning for all illegal access (committed and pushed) and then grepped in the sources, did not find much that we can actually act on. Here is what I have. *1) Protobuf illegal access* WARNING: Illegal reflective access by com.google.protobuf.UnsafeUtil (file:/home/aaime/.