Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Andrea Aime
On Thu, Nov 29, 2018 at 10:24 AM Peilke, Hendrik wrote: > Hi Andrea, > > > > thanks for your answer. I think the basic design of the ifs (up until > filtering) is correct: Since the DiffFeatureReader can filter and sorts out > the modified features filtered by the native reader. Passing the query

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Peilke, Hendrik
Hi Andrea, thanks for your answer. I think the basic design of the ifs (up until filtering) is correct: Since the DiffFeatureReader can filter and sorts out the modified features filtered by the native reader. Passing the query fixed our bug, which was only connect to filtering. If I understoo

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Andrea Aime
Hi, looking at the code, I believe that the chain of ifs in the area you're looking at is wrong... if there is a transaction going, from that point on any native support for filtering, sorting, paging should be foregone, because the DiffFeatureReeader is altering the reader contents with informatio

Re: [Geotools-devel] Shapefile datastore does not support transactions and filters correctly

2018-11-29 Thread Peilke, Hendrik
Thanks for your reply. I understand that, but I expect of a call to source.getFeatures(filter) on a ShapefileFeatureSource with an ongoing transaction, that I only get the features, that the filter accepts. At the moment it gives back the correctly filtered features not modified or added inside