Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-12 Thread Jim Hughes
Hi Andrea, Ah!  The context that some of the Objects need closing and others do not helps clarify things. I just wrote a client side version of such a wrapper to see if it'd work (it does).  Sounds like an amendment to 'toWriter' to have a no-op-close wrapper around the 1) BufferedWriter, 2)

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-12 Thread Jim Hughes
I'm hitting issues with the looking up EPSG codes in with FilterFactory(2).bbox.  E.g. things like ff.bbox("geom",49.0,79.0,51.0,80.0,"EPSG:4326") Are throwing errors like: java.lang.RuntimeException: Failed to setup bbox SRS Caused by: org.opengis.referencing.FactoryException: Type "EPSG" is

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-12 Thread Andrea Aime
Hi, the API is problematic because it happens to create a Writer out of Object, using this method: https://github.com/geotools/geotools/blob/master/modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java#L117 Some of the "things" passed in need closing (the FileWriter creat

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-12 Thread Andrea Aime
On Thu, Mar 12, 2020 at 7:51 PM Jim Hughes wrote: > Hi all, > > As a happy coincidence, I was able to test the GeoTools RC with GeoMesa. > I did hit an issue or two. > Hum... or two? What's the second? Cheers Andrea == GeoServer Professional Services from the experts! Visit http://goo.gl/it48

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-12 Thread Jim Hughes
From API point-of-view, that makes sense.  From a code point-of-view, there's a writer created on line 274: https://github.com/geotools/geotools/blob/master/modules/unsupported/geojson/src/main/java/org/geotools/geojson/GeoJSONUtil.java#L274-L278... that writer isn't returned, so as-is, the code

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-12 Thread Jody Garnett
Good timing on testing, it seems rough closing the writer after one feature? I would update the javadoc to be clear about the API contract and leave the writer open. On Thu, Mar 12, 2020 at 11:50 AM Jim Hughes wrote: > Hi all, > > As a happy coincidence, I was able to test the GeoTools RC with G

Re: [Geotools-devel] GeoTools 23-RC ready for testing - part II the return of testing

2020-03-12 Thread Jim Hughes
Hi all, As a happy coincidence, I was able to test the GeoTools RC with GeoMesa.  I did hit an issue or two. The first one is that GeoMesa uses GeoTools library code to write out GeoJson.  Calls to FeatureJSON.writeFeature(SimpleFeature feature, Object output) use GeoJSONUtil.encode(String,

Re: [Geotools-devel] Upgrade to ojdbc8 oracle driver?

2020-03-12 Thread Andrea Aime
Hi Mark, I've run the tests some time ago, but relatively recently I think, like... a month or two ago? I only remember the Oracle3DOnlineTest#testBBOX3DOutsideLine test to fail Cheers Andrea On Thu, Mar 12, 2020 at 6:40 PM Mark Prins wrote: > I've started factoring out the deprecations and se

Re: [Geotools-devel] Upgrade to ojdbc8 oracle driver?

2020-03-12 Thread Mark Prins
I've started factoring out the deprecations and seeing some test failures that don't seem related. So I'm curious if anybody ran the oracle online tests recently? and if there are known failures. Notably: =1= a failing test: Oracle3DOnlineTest#testBBOX3DOutsideLine() inherited from JDBCGeneri