Re: [Geotools-devel] API/ABI change to move XMLTestSupport to test jar.

2018-07-25 Thread Ben Caradoc-Davies
Merged on master. Kind regards, Ben. On 24/07/18 17:30, Andrea Aime wrote: +1 here, thanks! Cheers Andrea Il mar 24 lug 2018, 03:55 ha scritto: https://github.com/geotools/geotools/pull/1986 is a proposal to remove xmlunit (and junit) as dependencies we ship in geotools. The reason why

Re: [Geotools-devel] API/ABI change to move XMLTestSupport to test jar.

2018-07-23 Thread Andrea Aime
+1 here, thanks! Cheers Andrea Il mar 24 lug 2018, 03:55 ha scritto: > https://github.com/geotools/geotools/pull/1986 is a proposal to remove > xmlunit (and junit) as dependencies we ship in geotools. > > > > The reason why we were providing that is partly because some of the > dependency defi

Re: [Geotools-devel] API/ABI change to move XMLTestSupport to test jar.

2018-07-23 Thread Ben Caradoc-Davies
Thanks, Brad. I think this is a good change, so +1 from me. Here is the corresponding GeoServer change: https://github.com/geoserver/geoserver/pull/3019 There are two types of downstream breakages. The first are downstream tests that use XMLTestSupport and so need to depend on the new gt-xsd-c

[Geotools-devel] API/ABI change to move XMLTestSupport to test jar.

2018-07-23 Thread bradh
https://github.com/geotools/geotools/pull/1986 is a proposal to remove xmlunit (and junit) as dependencies we ship in geotools. The reason why we were providing that is partly because some of the dependency definitions were not test scoped, and partly because we actually do depend on it, for on