Re: [Geotools-devel] AttributeDescriptor reporting wrong type name

2022-05-27 Thread Jody Garnett
I prefer the fluent approach for code examples, and that is a good idea using AttributeTypeBuilder as a delegate to avoid duplicating code. Jody On Fri, May 27, 2022 at 12:31 AM Roar Brænden wrote: > Hi, > > Thanks for the feedback. There wasn't that much of problems with unit > tests as I was

Re: [Geotools-devel] AttributeDescriptor reporting wrong type name

2022-05-27 Thread Roar Brænden
Hi, Thanks for the feedback. There wasn't that much of problems with unit tests as I was afraid of. When looking into the code I saw that these methods should have been in an AttributeDescriptorBuilder. I have been thinking more about it, and see that it could be using a AttributeTypeBuilder

Re: [Geotools-devel] AttributeDescriptor reporting wrong type name

2022-05-26 Thread Jody Garnett
I remember annoying cite test style problems where tests were checking that an attribute named "location" was required to be a PointPropertyType. OGC 07-036r1 *Table 11* GML object element: gml:Point GML type: gml:PointType GML property type: gml:PointPropertyType *F.2.1.2.4 Default property

Re: [Geotools-devel] AttributeDescriptor reporting wrong type name

2022-05-26 Thread Andrea Aime
I'm actually not sure we ever use the type name... just the descriptor name. I have faint memories about this, but I think the parallel was: - descriptor is like an XML element name - type is like the XML type backing the element They can have legitimately two different names, no? In theory the

Re: [Geotools-devel] AttributeDescriptor reporting wrong type name

2022-05-26 Thread Jody Garnett
Please go ahead with the fix, now that GeoServer has the ability to redefine schema attributes (and I hope to add the ability to edit title / abstract) this information will be more widely used and relied on. Jody On Wed, May 25, 2022 at 11:32 PM Roar Brænden wrote: > Hi, > > I was reading

[Geotools-devel] AttributeDescriptor reporting wrong type name

2022-05-26 Thread Roar Brænden
Hi, I was reading some shapefiles when it came to my attention that something was strange with the schema's reported: TS14_max identified extends polygonFeature(the_geom:MultiPolygon,ID1:ID1,AV_Time:AV_Time,Shape_Leng:Shape_Leng,Shape_Area:Shape_Area) TS21_min identified extends