Re: [Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-08 Thread Andrea Aime
On Fri, Apr 8, 2016 at 9:00 PM, Jody Garnett wrote: > >> I don't remember seeing a negative comment on backwards compatible >> additions to base classes. >> > > I have asked people to hold off API changes before, in this case it is a > new public class (an enumeration) which is being added. I und

Re: [Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-08 Thread Jody Garnett
> Jody, I'm a confused by your statement. Almost any new functionality (and > some bug fixes) come with API changes if > we include in the notion of API changes new classes and new methods > (normally I would limit "API changes" to > ones that break the library users). > In this case (in part due

Re: [Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-08 Thread Andrea Aime
On Thu, Apr 7, 2016 at 9:42 PM, Jody Garnett wrote: > I am a little bit uncomfortable back porting as the work involves an API > change. It is additive in nature and does not harm stability. > Jody, I'm a confused by your statement. Almost any new functionality (and some bug fixes) come with API

Re: [Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-07 Thread Jody Garnett
Waiting won't help, please proceed - I will view being uncomfortable as part of the price to pay for the spring-4-upgrade kicking us out of our release schedule :( -- Jody Garnett On 7 April 2016 at 12:54, Simone Giannecchini < simone.giannecch...@geo-solutions.it> wrote: > Ciao Jody, > can we d

Re: [Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-07 Thread Simone Giannecchini
Ciao Jody, can we do something to make you happier? Like waiting a bit more? Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Simone Giannecchini @simogeo Founder/Director GeoSolutions S.A.S. Via di Montram

Re: [Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-07 Thread Jody Garnett
I am a little bit uncomfortable back porting as the work involves an API change. It is additive in nature and does not harm stability. I will vote -0 to reflect being uncomfortable. -- Jody Garnett On 7 April 2016 at 06:37, Nuno Oliveira wrote: > Hello, > > I would like to backport the group b

Re: [Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-07 Thread Simone Giannecchini
Ciao Nuno, i would make sure there are no conflicts and things build fine. That said, I am +1 as this is a functionality we have been wanting for a while. Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Si

[Geotools-devel] Backport the group by visitor to geotools 14.x

2016-04-07 Thread Nuno Oliveira
Hello, I would like to backport the group by vistor: http://osgeo-org.1560.x6.nabble.com/Adding-quot-group-by-quot-support-to-the-current-aggregation-visitors-td5249393.html to geotools 14.x. I missed the one month cool down rule for new features backports in the docs (sorry) and I have already