Cool, thanks guys, happy (re)formatting ;0
On Tue, Mar 20, 2018 at 10:10 AM Andrea Aime
wrote:
> Hi Eric,
> we discussed it at today's PSC meeting, I'm going to propose the 4 spaced
> one (for official vote), the bulk of the
> core devs are used to it, and for a very long time.
>
> Cheers
> And
Hi Eric,
we discussed it at today's PSC meeting, I'm going to propose the 4 spaced
one (for official vote), the bulk of the
core devs are used to it, and for a very long time.
Cheers
Andrea
On Mon, Mar 19, 2018 at 5:41 PM, Eric Engle wrote:
> Just my $.02, as a long-time lurker who would love
On Tue, Mar 20, 2018 at 10:27 AM, Nuno Oliveira <
nuno.olive...@geo-solutions.it> wrote:
> Hi all,
>
> Indeed the 4 spaces tab is better and I can live with the other changes,
> I doubt we will ever found a format that will make everyone happy :P
>
Yes indeed, we just need to find something that
On Tue, Mar 20, 2018 at 10:27 AM, Nuno Oliveira <
nuno.olive...@geo-solutions.it> wrote:
> Hi all,
>
> Indeed the 4 spaces tab is better and I can live with the other changes,
> I doubt we will ever found a format that will make everyone happy :P
>
Yes indeed, we just need to find something that
Hi all,
Indeed the 4 spaces tab is better and I can live with the other changes,
I doubt we will ever found a format that will make everyone happy :P
So in practice:
1. we would run this once
2. then run a check for each build
3. developers will have two ways of applying this style:
1. usin
Just my $.02, as a long-time lurker who would love to simplify
contributions as much as possible: I use 2 space indentation in my day job,
and contributing some of that work upstream to you is certainly simpler if
that also uses two spaces ;-]
Best regards,
Eric
On Sun, Mar 18, 2018 at 3:22 AM
On 18 March 2018 at 09:49, Andrea Aime wrote:
> Hi,
> given the issues on the intellij + checkstyle approach I had a second look
> at the google variant
> and cleaned up the branch to have a good separation of pom changes and
> reformats:
>
> https://github.com/aaime/geotools/tree/intellij_checks
Hi all,
interesting news, the formatter has basically a single format style option
that I did overlook
before, choosing between google style and AOSP one, Android Open Source
Project.
Checking the google formatter source code, I found just one significant
difference between the two...
AOSP uses 4
Hi,
given the issues on the intellij + checkstyle approach I had a second look
at the google variant
and cleaned up the branch to have a good separation of pom changes and
reformats:
https://github.com/aaime/geotools/tree/intellij_checkstyle2
Indeed, it took 3 runs to get to a stable formatting,
