Re: [Geotools-devel] JDBC Transaction mock test keeps on failing on Travis

2016-12-18 Thread Ben Caradoc-Davies
On 18/12/16 21:20, Andrea Aime wrote: > On Sat, Dec 17, 2016 at 11:31 PM, Ben Caradoc-Davies > wrote: >> it looks like the problem was a race condition between the GC thread >> calling a finalizer for a data store leaked from another test and the >> stubbing setup for the test log handler, mediate

Re: [Geotools-devel] JDBC Transaction mock test keeps on failing on Travis

2016-12-18 Thread Andrea Aime
On Sat, Dec 17, 2016 at 11:31 PM, Ben Caradoc-Davies wrote: > Andrea, > > it looks like the problem was a race condition between the GC thread > calling a finalizer for a data store leaked from another test and the > stubbing setup for the test log handler, mediated by the shared > ContentDataSto

Re: [Geotools-devel] JDBC Transaction mock test keeps on failing on Travis

2016-12-17 Thread Ben Caradoc-Davies
Andrea, it looks like the problem was a race condition between the GC thread calling a finalizer for a data store leaked from another test and the stubbing setup for the test log handler, mediated by the shared ContentDataStore logger. Fix is to register the mock log handler only after stubbin

Re: [Geotools-devel] JDBC Transaction mock test keeps on failing on Travis

2016-12-17 Thread Ben Caradoc-Davies
Andrea, I can repeat this intermittent failure by running all tests (only) for this module in Maven and Eclipse: https://osgeo-org.atlassian.net/browse/GEOT-5603 Kind regards, Ben. On 22/11/16 04:51, Andrea Aime wrote: > Hi, > I keep on seen this error in pull request: > > SEVERE: There's code

[Geotools-devel] JDBC Transaction mock test keeps on failing on Travis

2016-11-21 Thread Andrea Aime
Hi, I keep on seen this error in pull request: SEVERE: There's code using JDBC based datastore and not disposing them. This may lead to temporary loss of database connections. Please make sure all data access code calls DataStore.dispose() before freeing all references to it Tests run: 2, Failures