Re: [Geotools-devel] OGR Module Support

2018-10-21 Thread Andrea Aime
Hi, overall the changes look fine to me, but it would be easier to review them on a PR. Could you make one? Sorry for the late reply, during the week it's really hard to find time, and the JDK11 upgrade sprint has been sucking away spare time too Cheers Andrea On Sun, Oct 14, 2018 at 10:58 PM Ja

Re: [Geotools-devel] OGR Module Support

2018-10-15 Thread Jared Erickson
We could, but I would like to keep it enabled. It is still useful for reading and writing even when GEOS is not supported. We could log a warning though when a spatial filter is set. That would require a change to the OGR interface for something like boolean isGEOSEnabled(). You can check by tr

Re: [Geotools-devel] OGR Module Support

2018-10-14 Thread Jody Garnett
Q: For (2) is it possible to detect when GDAL is not compiled with GEOS support - and disable the OGR module? -- Jody Garnett On Sun, 14 Oct 2018 at 13:58, Jared Erickson wrote: > I would like to volunteer to be the maintainer of the ogr module. I am > working on a branch with three fixes: > >

Re: [Geotools-devel] OGR Module Support

2018-10-14 Thread Jared Erickson
I would like to volunteer to be the maintainer of the ogr module. I am working on a branch with three fixes: https://github.com/jericks/geotools/commit/110f5803e87262367dab69272e4f6ae1aef6288f 1. The GeoJSON format in older versions of GDAL doesn't support LayerCanCreateField correctly. I added

Re: [Geotools-devel] OGR Module Support

2018-10-09 Thread Andrea Aime
Hi Jared, the module was dropped out of build because it was breaking the build, and had no maintainer. So in order to bring it back to "life" it needs someone appointed as a maintainer (you?) and do whatever is necessary to fix its build. There is no requirement to bring it up fully, e.g., you mig

[Geotools-devel] OGR Module Support

2018-10-07 Thread Jared Erickson
Hi all! I would like to get the GeoTools OGR modules back into a status where they are published to a maven repo. The GeoScript Groovy projects uses these modules so I would like to volunteer to keep them compiling. What do I need to do to get them publishing to maven again? Thanks, Jared _