Re: [Geotools-devel] Odd failiure in Travis

2018-05-08 Thread Andrea Aime
Yep... I will try to make it better (better error message). In any case, just remember to do a build before committing, and the proper-formatting should follow automatically (there are a few cases in which one has to build twice to get a stable formatting, but it should be rare) Cheers Andrea O

Re: [Geotools-devel] Odd failiure in Travis

2018-05-08 Thread Nuno Oliveira
Ah! I had the same issue as Ian in one of my open PR (I used a non valid formatation for a JavaDoc), happy to see this check working :) On 05/08/2018 03:06 PM, Andrea Aime wrote: Hi Ian, yes, it's the check that I added to make sure the files were always properly formatted before checking. The

Re: [Geotools-devel] Odd failiure in Travis

2018-05-08 Thread Andrea Aime
Hi Ian, yes, it's the check that I added to make sure the files were always properly formatted before checking. The formatting happens during the build, and there is a check in a profile that fails the build if further changes happen on Travis. Thinking about it, it would probably be best to switc

[Geotools-devel] Odd failiure in Travis

2018-05-08 Thread Ian Turton
I'm seeing a fail in Travis (https://github.com/geotools/geotools/pull/1878) that I've never noticed before, I'm wondering if it is due to the reformatting? All the tests pass as expected but it then fails due to a local modification. Here is the relevant part of the log: Tests run: 357, Failures