Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-27 Thread Jody Garnett
I see; since I have not applied any of the changes from trunk this does not apply for what I am doing right now. Thanks for the explanation. Jody On 27/04/2010, at 11:27 PM, Michael Bedward wrote: >> What does reintegrate do? >> > > From the svn book... > > Notice our use of the --reintegra

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-27 Thread Michael Bedward
> What does reintegrate do? > >From the svn book... Notice our use of the --reintegrate option this time around. The option is critical for reintegrating changes from a branch back into its original line of development—don't forget it! It's needed because this sort of “merge back” is a different

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-27 Thread Jody Garnett
On 27/04/2010, at 11:11 PM, Michael Bedward wrote: > Hi Jody, > >> Just noticed you updated the example apps to use SimpleFeatureIterator - did >> you learn anything during updating of note? > > They were just trivial changes and the apps worked afterwards :) > >> I did not do any search and re

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-27 Thread Michael Bedward
Hi Jody, > Just noticed you updated the example apps to use SimpleFeatureIterator - did > you learn anything during updating of note? They were just trivial changes and the apps worked afterwards :) > I did not do any search and replace for these ones; do you think it is worth > it? You mean i

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-27 Thread Jody Garnett
Thanks Micheal; Just noticed you updated the example apps to use SimpleFeatureIterator - did you learn anything during updating of note? I did not do any search and replace for these ones; do you think it is worth it? I am going through the motions locally to apply the patch to trunk; the comman

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-27 Thread Michael Bedward
Hi Jody, The new code builds for me without any problems. Michael -- ___ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/li

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-27 Thread Jody Garnett
I have gone ahead and done that on the branch; no surprises. Will run tests now and then commit. Other then that I would like to go ahead on this proposal; it should be as simple as an svn merge. Jody On 27/04/2010, at 2:32 PM, Michael Bedward wrote: > +1 > > I've tested the code on the simp

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Michael Bedward
You're a champion :-) On 27 April 2010 14:53, Jody Garnett wrote: > Well if that will kick it over the line I will try and add it tonight. > Jody > -- ___ Geotools-devel mailin

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Jody Garnett
Well if that will kick it over the line I will try and add it tonight. Jody On 27/04/2010, at 2:32 PM, Michael Bedward wrote: > +1 > > I've tested the code on the simple-features branch and had no problems > so far (osx, java 5) > > As per another thread, it would be great to also have SimpleFe

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Michael Bedward
+1 I've tested the code on the simple-features branch and had no problems so far (osx, java 5) As per another thread, it would be great to also have SimpleFeatureIterator. Michael --

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Ben Caradoc-Davies
On 27/04/10 01:05, Andrea Aime wrote: > Jody Garnett ha scritto: >>> As stated before I like the direction this is going, just worried a >>> bit about the timing and the fact this would make porting patches >>> over from 2.6.x to trunk (or vice versa) harder for a few months >>> (until we release 2

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Andrea Aime
Jody Garnett ha scritto: >> As stated before I like the direction this is going, just worried a >> bit about the timing and the fact this would make porting patches >> over from 2.6.x to trunk (or vice versa) harder for a few months >> (until we release 2.7.0) > > > So is that worry enough for

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Jody Garnett
On 26/04/2010, at 7:11 PM, Andrea Aime wrote: > This hits another thing I've been hating quite a bit working on GSS, > having to either sprinkle generics all around turning the code into > an unreadable soup or bear up with Eclipse > complaints about the code not having the generics. I have been

Re: [Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Andrea Aime
Jody Garnett ha scritto: > I have updated the proposal in a few spots as per questions on IRC: > - http://docs.codehaus.org/display/GEOTOOLS/Clean+up+Generics+from+DataStore This hits another thing I've been hating quite a bit working on GSS, having to either sprinkle generics all around turning t

[Geotools-devel] PMC: Proposal Clean up Generics from DataStore

2010-04-26 Thread Jody Garnett
I have updated the proposal in a few spots as per questions on IRC: - http://docs.codehaus.org/display/GEOTOOLS/Clean+up+Generics+from+DataStore Discussion has already started (see SimpleFeatureSource proposal ready email). Jody--