Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

As discussed during the meeting, I am going to merge now. Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Simone Giannecchini @simogeo Founder/Director GeoSolutions S.A.S. Via di Montramito 3/A 55054

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Yes, we worked together to isolate the changes into simple SPI mechanism. Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Simone Giannecchini @simogeo Founder/Director GeoSolutions S.A.S. Via di Montramito

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Dear All, me, Devon and Jody have worked together on refining the code being the proposal to round some corners. Now I can give my +1. Regards, Simone Giannecchini == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Simone Giannecchini

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Dear Devon, some feedback on the proposal: -1- I would rename GranuleGeometryHandler to GranuleHandler (or something GranuleiNDEXHandler) like sine one can pretty much do anything with this -2- I would want two different methods just one like: void handleGeometry(

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Thanks, proposal is clear, scope/purpose clear, technical details are easier to follow with class diagram. +1 And it looks like you are pretty much done the work, except for user docs... -- Jody Garnett On 21 June 2016 at 17:04, Devon Tucker wrote: > Yes, it's ready

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Yes, it's ready for review :D On Tue, Jun 21, 2016 at 5:01 PM, Jody Garnett wrote: > We can always squash the commits when merging to master. > > Is the proposal ready for review now? > > -- > Jody Garnett > > On 21 June 2016 at 16:55, Devon Tucker

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

We can always squash the commits when merging to master. Is the proposal ready for review now? -- Jody Garnett On 21 June 2016 at 16:55, Devon Tucker wrote: > Ok so after going down the road of using the PropertiesCollector interface > for doing the granule geometry

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Ok so after going down the road of using the PropertiesCollector interface for doing the granule geometry handling and decided to go with my original plan of creating a separate interface for this. I have updated the proposal accordingly. Also, I created a pull request for reference, since it

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

The GranuleAcceptor stuff is done on that branch. I have the PropertiesCollector stuff done locally, but there's some iffy stuff there. Handling the granule envelope in a PropertiesCollector should be fine, but there is an issue with how StructuredGridCoverages are handled:

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Reviewing https://github.com/geotools/geotools/wiki/Refactor-ImageMosaic-Index-and-Catalog-management-for-improved-extensibility it appears up to date (with a remove CatalogManager heading). Are you going to verify the approach (on that branch) and then send us an email for the completed proposal?

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Hi all, Based on discussions with Simone and Jody we have made a few changes to this proposal: - CatalogManager gets deleted, its methods moved either to ImageMosaicConfigHandler, Utils, or the GranuleCatalog implementations - Instead of delegating granule acceptance to CatalogManager, as was

Re: [Geotools-devel] Proposal: Refactor ImageMosaic index management

Dear Devon, a few things: -0- we should really get rid of this CatalogManager as is (a class with only static methods as its state its spread over N other classes) -1- we can already mosaick images with different colormodels (to a certain extent, it does not make sense to mosaick a float raster

[Geotools-devel] Proposal: Refactor ImageMosaic index management

Hi all, After discussions about the ImageMosaic API proposal we have decided to break it up into a few smaller pieces that are hopefully both more manageable to implement and easier to understand. First up is a proposal to refactor the ImageMosaic CatalogManager to allow parts of it to be