A couple bits of feedback...
To confirm, ClipToMinimumMaximum is a normalization algorithm, and not an
alternative ContrastEnhancement.getType() ? Like I would only expect it to
work if ContrastEnhancement.getType() is NORMALIZE ...
For CSS all vendor options follow the same approach with -gt- pr
On Wed, 5 Aug, 2015 at 5:50 PM, ian wrote:
On Wed, 5 Aug, 2015 at 5:27 PM, Jody Garnett
wrote:
There is a really different track here on how to modify the style
interfaces in a safe manner (between this proposals and anime's. I
made the suggestion for FeatureTypeStyle.getSortBy() ... and
On Wed, 5 Aug, 2015 at 5:27 PM, Jody Garnett
wrote:
There is a really different track here on how to modify the style
interfaces in a safe manner (between this proposals and anime's. I
made the suggestion for FeatureTypeStyle.getSortBy() ... and the
answer was to consistently use the vendor
There is a really different track here on how to modify the style
interfaces in a safe manner (between this proposals and anime's. I made the
suggestion for FeatureTypeStyle.getSortBy() ... and the answer was to
consistently use the vendor options parameter map. Down a few levels here
to RasterSymb
Hi Jody,
I see your point about StyleVisitor implementations not covered by Abstract
StyleVisitors which may break.
However, as far as I can see from Ian changes on his branch, he has already
made several visitors extending the AbstractStyleVisitor which implements
the new method so that change sho
It's doable that way but I'm not really happy about storing a bunch of
algorithm specific information at the ContrastEnhancer level. Or it leads
to a nasty mix of org.opengis.style.ContrastMethod and
org.geotools.styling.ContrastMethod and a whole bunch of messing about to
try to make sure everyone
Sorry Ian, getting muddle between your proposal text and the subsequent API
change section.
Reviewing both together, you are not just talking about changing from
CodeList values to Strings, you are talking about changing ContrastMethod
to a class ... with a type and some of those types need parame
ContrastMethod is already a code list so you should be able to add the
options you need no problem.
The interface ContrastEnhancement is here:
public interface ContrastEnhancement {
public ContrastMethod getMethod();
Expression getGammaValue();
}
Where ContrastMethod is an enum:
public fina
+0. (I updated the wiki page.)
On 05/08/15 01:45, Ian Turton wrote:
> In conjunction with GeoSolutions I've written a proposal for the
> implementation of the changes needed to make Contrast Enhancement work with
> specified algorithms and parameters rather than just doing it as a black
> box as c
On 4 August 2015 at 19:26, Jody Garnett wrote:
> Added my +1, got a couple questions/clarifications.
>
> *ContrastMethod*
>
> The proposal has been implemented in such a way that existing code will
>> compile without change. One item to note is that `ContrastMethod.NORMALIZE`
>> and `ContrastMeth
Added my +1, got a couple questions/clarifications.
*ContrastMethod*
The proposal has been implemented in such a way that existing code will
> compile without change. One item to note is that `ContrastMethod.NORMALIZE`
> and `ContrastMethod.HISTOGRAM` are no longer enums but are now Strings.
Th
Hi Ian,
works for me, +1
Cheers
Andrea
On Tue, Aug 4, 2015 at 3:45 PM, Ian Turton wrote:
>
> In conjunction with GeoSolutions I've written a proposal for the
> implementation of the changes needed to make Contrast Enhancement work with
> specified algorithms and parameters rather than just doin
+0
Regards,
Simone Giannecchini
==
GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.
==
Ing. Simone Giannecchini
@simogeo
Founder/Director
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +3
In conjunction with GeoSolutions I've written a proposal for the
implementation of the changes needed to make Contrast Enhancement work with
specified algorithms and parameters rather than just doing it as a black
box as currently.
The proposal is at
https://github.com/geotools/geotools/wiki/Exten
14 matches
Mail list logo
