Re: [Geotools-devel] Starting to work on automatic code cleanups

2020-12-19 Thread Andrea Aime
Ok folks, first batch (unnecessary casts) is in, second one, diamond operator, is on: - https://github.com/geotools/geotools/pull/3264 - https://github.com/GeoWebCache/geowebcache/pull/902 - https://github.com/geoserver/geoserver/pull/4605 Given the low amount of feedback, I'm tempted to

Re: [Geotools-devel] Starting to work on automatic code cleanups

2020-12-17 Thread Nuno Oliveira
+1, and thx! On Thu, Dec 17, 2020 at 9:31 AM Andrea Aime wrote: > Hi all, > given the lack of negative comments, I'll move on and merge during the > weekend, and if time allows, > prepare another set of PRs for the "diamond" case > > Cheers > Andrea > > > On Sat, Dec 12, 2020 at 2:33 PM Andrea A

Re: [Geotools-devel] Starting to work on automatic code cleanups

2020-12-17 Thread Andrea Aime
Hi all, given the lack of negative comments, I'll move on and merge during the weekend, and if time allows, prepare another set of PRs for the "diamond" case Cheers Andrea On Sat, Dec 12, 2020 at 2:33 PM Andrea Aime wrote: > Hi all, > the unchecked warnings cleanups is done, has just been merg

Re: [Geotools-devel] Starting to work on automatic code cleanups

2020-12-14 Thread Gabriel Roldan
I think that's impressive and a big help in avoiding a lot of code rotting, big +1 from me, and a huge thanks for the "unchecked" work. On Sat, 12 Dec 2020 at 10:33, Andrea Aime wrote: > Hi all, > the unchecked warnings cleanups is done, has just been merged in > GeoServer, completing coverage

[Geotools-devel] Starting to work on automatic code cleanups

2020-12-12 Thread Andrea Aime
Hi all, the unchecked warnings cleanups is done, has just been merged in GeoServer, completing coverage in all three projects. Working on it, I leveraged IntelliJ inspections a lot to clean up the projects quicker. Now, I could not use automatic cleanups for the unchecked warnings, but there are a