Re: [Geotools-devel] UUID Support

2011-11-17 Thread Andrea Aime
On Thu, Nov 17, 2011 at 3:50 AM, John Hudson wrote: > I have added more tests to the patch and uploaded it to the JIRA issue: > > > > http://jira.codehaus.org/browse/GEOT-3016 > > > > I have run the JDBC tests locally and all are successful. Can we review this > for applying to tunk? I'll try to

Re: [Geotools-devel] UUID Support

2011-11-16 Thread John Hudson
: Wednesday, 16 November 2011 1:50 PM To: Jody Garnett Cc: [email protected] Subject: Re: [Geotools-devel] UUID Support There is: modules/library/jdbc/src/test/java/org/geotools/jdbc/JDBCUuidTest.java tho it only tests getting features. I will fill it out a bit more. From: Jody Garnett

Re: [Geotools-devel] UUID Support

2011-11-15 Thread Jody Garnett
I suspect John that we need to write some test cases to confirm the functionality works (and remains working). Did the patch include a JUnit test case? If not could you write one and attach it to the JIRA? Thanks muchly, Jody Garnett -- Jody Garnett On Wednesday, 16 November 2011 at 2:08

Re: [Geotools-devel] UUID Support

2011-11-15 Thread John Hudson
@lists.sourceforge.net Subject: Re: [Geotools-devel] UUID Support I suspect John that we need to write some test cases to confirm the functionality works (and remains working). Did the patch include a JUnit test case? If not could you write one and attach it to the JIRA? Thanks muchly, Jody Garnett -- Jody

Re: [Geotools-devel] UUID Support

2011-11-15 Thread John Hudson
ARNING: No class for sql type I will look into this as part of this change, John From: John Hudson [mailto:[email protected]] Sent: Wednesday, 16 November 2011 1:38 PM To: [email protected] Subject: [Geotools-devel] UUID Support Hello, I have been working on

Re: [Geotools-devel] UUID Support

2011-11-15 Thread Jody Garnett
I suspect John that we need to write some test cases to confirm the functionality works (and remains working). Did the patch include a JUnit test case? If not could you write one and attach it to the JIRA? Thanks muchly, Jody Garnett -- Jody Garnett On Wednesday, 16 November 2011 at 2:08

[Geotools-devel] UUID Support

2011-11-15 Thread John Hudson
Hello, I have been working on getting a datastore with a primary key as a UUID and found this: http://jira.codehaus.org/browse/GEOT-3016 I have applied it to the current trunk and have done some tests which show its working. I noted the TODO's on the JIRA: 1. Implement the UUID support into