Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

Awesome, thanks! Cheers Andrea Il mar 30 ott 2018, 21:51 Torben Barsballe ha scritto: > gt-main and gt-data have now been merged on master. > I've also removed the lingering unused gt-style module. > > I've updated the "POST SPRINT RESIDUES" section of the sprint spreadsheet > accordingly. > >

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

gt-main and gt-data have now been merged on master. I've also removed the lingering unused gt-style module. I've updated the "POST SPRINT RESIDUES" section of the sprint spreadsheet accordingly. Cheers, Torben On Mon, Oct 29, 2018 at 2:09 PM Jody Garnett wrote: > I also feel discouraged but a

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

I also feel discouraged but agree we need to merge gt-main and gt-data. I would be willing to pull out some of the other components like gt-filter and gt-feature (if doing so can be handled without split packages). One thing this *does* show me is how difficult it may be to distribute gt-opengis i

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

PRs here: - https://github.com/geotools/geotools/pull/2154 - https://github.com/geoserver/geoserver/pull/3217 (No changes necessary in GWC) It looks like is still a little weirdness in the docs from the s/gt-data/gt-main/g replacement, so its probably best to hold off on merging until I ge

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

I agree I can't think of any solution - and I was just kicking common factory finder around over the weekend. Ian On Mon, 29 Oct 2018 at 16:36, Andrea Aime wrote: > On Mon, Oct 29, 2018 at 5:34 PM Torben Barsballe < > tbarsba...@boundlessgeo.com> wrote: > >> Given this, how does everyone feel a

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

On Mon, Oct 29, 2018 at 5:34 PM Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > Given this, how does everyone feel about merging gt-main and gt-data > together to resolve the remaining org.geotools.data package split? > I feel sad... but I cannot offer anything better, so go for it :-p

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

I also found several other interdependencies in gt-main when looking at this on Friday (what little updates I have on that are on Gitter; didn't get time to compile it into an email; there's also a WIP branch here ). - Many of the s

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

On Mon, Oct 29, 2018 at 6:18 AM Jody Garnett wrote: > Somewhat related question how much do we like the precompiled error > message bundles? > Personally I don't. > The main justification for this complexity (wasting strings in permgen > space) looks like it has been somewhat addressed in Java

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

Somewhat related question how much do we like the precompiled error message bundles? The main justification for this complexity (wasting strings in permgen space) looks like it has been somewhat addressed in Java 7 with string literals and string intern adding to a string pool - which is no longer

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

Okay I will have a look :) On Sun, Oct 28, 2018 at 1:41 PM Andrea Aime wrote: > Hi Jody, > I stopped after realizing the issues with common factory finder and > reverted the changes. So nope, no branch, sorry. > > Cheers > Andrea > > Il Dom 28 Ott 2018, 21:26 Jody Garnett ha > scritto: > >> And

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

Hi Jody, I stopped after realizing the issues with common factory finder and reverted the changes. So nope, no branch, sorry. Cheers Andrea Il Dom 28 Ott 2018, 21:26 Jody Garnett ha scritto: > Andrea do you have a branch started for this activity? > > I will also note that FileDataStoreFactory

Re: [Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

Andrea do you have a branch started for this activity? I will also note that FileDataStoreFactory lookup by common factory results in duplication, should delegate to DataStoreFactoryFinder (which delegates to DataAccessFactory). On Sun, Oct 28, 2018 at 1:57 AM Andrea Aime wrote: > Hi, > I was l

[Geotools-devel] Why gt-main cannot be split: CommonFactoryFinder

Hi, I was looking at splitting main into smaller bits to avoid some split package issues, ideally trying to to towards a gt-data (everything vector), gt-style (styling) and and almost empty gt-main to collect the residuals, with gt-main depending on the two above... and realized it's not possible.