Patch Set 1: Code-Review+2
How did you see this? Code review? Compiler warning?
The BSD manpage is not that clear here. As linep is NULL a new buffer will be
allocated which leads to updating these values. But there is no point to insist
on 2342 as initial value.
--
To view, visit
Patch Set 1: Code-Review+1
But max has a point on branch vs. tag. Feel free to fix. Can you re-submit some
of the failing builds as well?
--
To view, visit https://gerrit.osmocom.org/2293
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2288/2/src/common/pcu_sock.c
File src/common/pcu_sock.c:
Line 673: osmo_signal_dispatch(SS_FAIL, OSMO_EVT_PCU_VERS, "");
Why "" as signal_data? What happens if NULL is sent?
--
To view, visit https://gerrit.osmocom.org/2288
To
Patch Set 1: Code-Review+2
Let's fix the hnbgw issue and merge after the build is fixed.
--
To view, visit https://gerrit.osmocom.org/2285
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fac7cabedff74f8f6293ad8b54420229b80aa71
Patch Set 2: Code-Review+1
(3 comments)
https://gerrit.osmocom.org/#/c/2281/2//COMMIT_MSG
Commit Message:
Line 21: * SCCP: no Global Title Translatio (GTT) yet
If you rebase, add the 'n' to Translation
https://gerrit.osmocom.org/#/c/2281/2/stp/osmo_ss7_vty.c
File stp/osmo_ss7_vty.c:
Line
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7: When destroying an AS or a linkset, delete all routes
..
osmo_ss7: When destroying an AS or a linkset, delete all routes
When we destroy a
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7: Make sure to start server-side ASP FSM for
dynamically created ASPs
..
osmo_ss7: Make sure to start server-side ASP FSM for dynamically
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager
..
osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager
The M3UA RFC defines this
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7: Allocate local routing key ID and use it as lookup
key for AS
..
osmo_ss7: Allocate local routing key ID and use it as lookup key for AS
In
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7: Fix memory leak with sock_name on clients at
re-connect time
..
osmo_ss7: Fix memory leak with sock_name on clients at re-connect time
We
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7: destroy any ASPs allocated dynamically at accept()
time
..
osmo_ss7: destroy any ASPs allocated dynamically at accept() time
When we accept
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2307
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If586ac9f3449254973a19654dd13dce5793f285f
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2306
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07d69a0cd52a049a7a4bb0d996e95d39fee9a106
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2305
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dd079158a8c6b176a94dc251748924ef3e9c937
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2304
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I393400bc758c28997e16bc78e3142719b6a61be8
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2302
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e4e86f9b9d8ef4639c835878749ce8d8cc76f7c
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2303
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6798221ccb3c70186c1c51dd34b7823fefd6df58
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2301
to look at the new patch set (#2).
osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or server socket
Change-Id: I31e7de136545279a75a5faca0927d3dbf11ff46d
---
M src/osmo_ss7.c
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2299
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aa4eb421ecb483d3da1b0ce3aa6511d161c3750
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2303
to look at the new patch set (#2).
osmo_ss7: Fix memory leak with sock_name on clients at re-connect time
We cannot use osmo_talloc_replace_string() together with
osmo_sock_get_name(),
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2302
to look at the new patch set (#2).
osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager
The M3UA RFC defines this primitive to the layer manager, but we so far
didn't generate
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2307
to look at the new patch set (#2).
sccp_user: Make sure to create client-side AS with primary PC
When we are on the ASP (client) side, we must initialize the routing key
of the AS with
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2304
to look at the new patch set (#2).
osmo_ss7: When destroying an AS or a linkset, delete all routes
When we destroy a linkset, it make sense to remove all associated routes
pointing to
Harald Welte has submitted this change and it was merged.
Change subject: xua: Add value_string for routing key [de]registration results
..
xua: Add value_string for routing key [de]registration results
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: SCRC: Print NOTICE log message if we attempt to use (missing)
GT routing
..
SCRC: Print NOTICE log message if we attempt to use (missing) GT routing
Harald Welte has submitted this change and it was merged.
Change subject: Fix for SCCP CC without user data
..
Fix for SCCP CC without user data
When sending messages like CC (or SUA COAK) without user data, we must
make sure
Harald Welte has submitted this change and it was merged.
Change subject: SCCP SCOC: Ensure user primitive msgb->l2h always poinst to tail
..
SCCP SCOC: Ensure user primitive msgb->l2h always poinst to tail
In case there is no
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2297
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4dc954cc3f10860dea518f95e53f72c6a9a3de95
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2292
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If91edb526cbcd792ec5ebcb4518cf848feb69391
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie512fe063391e3a634097f555b9b0089d2981de9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2295
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb9ba227bab18f7f4f16518c0022c4f003cc8e9
Gerrit-PatchSet: 4
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2304
osmo_ss7: When destroying an AS or a linkset, delete all routes
When we destroy a linkset, it make sense to remove all associated routes
pointing to the linkset, as they would point to nowhere anyway.
Change-Id:
Review at https://gerrit.osmocom.org/2306
osmo_ss7: destroy any ASPs allocated dynamically at accept() time
When we accept SCTP connections from clients for whose IP/port we have
no matching local configurations, and it is permitted by local
configuration, we dynamically allocate
Review at https://gerrit.osmocom.org/2296
SCCP SCOC: Ensure user primitive msgb->l2h always poinst to tail
In case there is no user data in a CONNECT.conf primitive (or other CO
primitives), we must make sure that msgb->l2h = msgb->tail so that the
SCCP User can use msgb_l2len(msg) == 0 as
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-stp
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/Debian_8.0/x86_64
Package network:osmocom:nightly/osmo-stp failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-stp
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-stp
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/Debian_8.0/i586
Package network:osmocom:nightly/osmo-stp failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-stp
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-stp
Last lines of build log:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2295
to look at the new patch set (#4).
Add osmo_stream_{cli,srv_link}_set_nodelay() function
Using this function, the user can configure if sockets related to the
respective stream client
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2295
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb9ba227bab18f7f4f16518c0022c4f003cc8e9
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2295
to look at the new patch set (#3).
Add osmo_stream_{cli,srv_link}_set_nodelay() function
Using this function, the user can configure if sockets related to the
respective stream client
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2294
to look at the new patch set (#2).
Add gsm_bts_type_variant to gsm_bts struct
Previously it was only in gsm_bts_model which is not initialized on BTS
side. It's more convenient to have
Add osmo_stream_{cli,srv_link}_set_nodelay() function
Using this function, the user can configure if sockets related to the
respective stream client or server should have the NODELAY socket
option set in order to avoid Nagle algorithm or related algorithms
that may introduce packet delay on the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2286
to look at the new patch set (#3).
Move string - BTS type conversion to shared header
Move value_string definition and corresponding functions to shared
header to make it re-usable by
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2165
to look at the new patch set (#14).
Add SW Description (de)marshalling
* data structure representing 3GPP TS 52.021 ยง9.4.62 SW Description
* function to serialize it
Patch Set 2:
I think we should add it to debian/ as well.
--
To view, visit https://gerrit.osmocom.org/2281
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If32227b8d3127c6178e4ee45527ce65f69bc7b1e
Gerrit-PatchSet: 2
Gerrit-Project:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2285
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fac7cabedff74f8f6293ad8b54420229b80aa71
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1:
In the description you mention tag, in the code - branch. So which is it?
--
To view, visit https://gerrit.osmocom.org/2293
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74a802fd2ca65f4b6c2079550fbb6b0af3e8340
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2288
to look at the new patch set (#2).
Signal to BSC when PCU disconnects
Change-Id: I41a731bd719aee0bbb98d3236405fb3a7f3ddec0
Related: OS#1615
---
M src/common/pcu_sock.c
1 file changed,
50 matches
Mail list logo
