openbsc[master]: nat: Fix initial buffer size parameter for getline

2017-04-11 Thread Holger Freyther
Patch Set 1: Code-Review+2 How did you see this? Code review? Compiler warning? The BSD manpage is not that clear here. As linep is NULL a new buffer will be allocated which leads to updating these values. But there is no point to insist on 2342 as initial value. -- To view, visit https://ge

openbsc[master]: build: iu: use libosmo-sccp tag 'old_sua'

2017-04-11 Thread Holger Freyther
Patch Set 1: Code-Review+1 But max has a point on branch vs. tag. Feel free to fix. Can you re-submit some of the failing builds as well? -- To view, visit https://gerrit.osmocom.org/2293 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I

osmo-bts[master]: Signal to BSC when PCU disconnects

2017-04-11 Thread Holger Freyther
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/2288/2/src/common/pcu_sock.c File src/common/pcu_sock.c: Line 673: osmo_signal_dispatch(SS_FAIL, OSMO_EVT_PCU_VERS, ""); Why "" as signal_data? What happens if NULL is sent? -- To view, visit https://gerrit.osmocom.org/2288 To uns

openbsc[master]: nat: Use equal func in bsc_sccp

2017-04-11 Thread Holger Freyther
Patch Set 1: Code-Review+2 Let's fix the hnbgw issue and merge after the build is fixed. -- To view, visit https://gerrit.osmocom.org/2285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fac7cabedff74f8f6293ad8b54420229b80aa71 Gerrit-Pa

libosmo-sccp[master]: Add osmo-stp executable as new "Osmocom Signaling Transfer P...

2017-04-11 Thread Holger Freyther
Patch Set 2: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/2281/2//COMMIT_MSG Commit Message: Line 21: * SCCP: no Global Title Translatio (GTT) yet If you rebase, add the 'n' to Translation https://gerrit.osmocom.org/#/c/2281/2/stp/osmo_ss7_vty.c File stp/osmo_ss7_vty.c: Line 226

[MERGED] libosmo-sccp[master]: osmo_ss7: Instruct libosmo-netif to use {TCP, SCTP}_NODELAY o...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Instruct libosmo-netif to use {TCP,SCTP}_NODELAY on all sockets .. osmo_ss7: Instruct libosmo-netif to use {TCP,SCTP}_NODELAY on all sockets I

[MERGED] libosmo-sccp[master]: osmo_ss7: When destroying an AS or a linkset, delete all routes

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: When destroying an AS or a linkset, delete all routes .. osmo_ss7: When destroying an AS or a linkset, delete all routes When we destroy a link

[MERGED] libosmo-sccp[master]: osmo_ss7: Make sure to start server-side ASP FSM for dynamic...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Make sure to start server-side ASP FSM for dynamically created ASPs .. osmo_ss7: Make sure to start server-side ASP FSM for dynamically created

[MERGED] libosmo-sccp[master]: osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager .. osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager The M3UA RFC defines this prim

[MERGED] libosmo-sccp[master]: sccp_user: Make sure to create client-side AS with primary PC

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp_user: Make sure to create client-side AS with primary PC .. sccp_user: Make sure to create client-side AS with primary PC When we are on the ASP (cl

[MERGED] libosmo-sccp[master]: osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or server socket .. osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or server socket

[MERGED] libosmo-sccp[master]: osmo_ss7: Allocate local routing key ID and use it as lookup...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Allocate local routing key ID and use it as lookup key for AS .. osmo_ss7: Allocate local routing key ID and use it as lookup key for AS In M3

[MERGED] libosmo-sccp[master]: osmo_ss7: Use proper string name for dynamically-created ASP

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Use proper string name for dynamically-created ASP .. osmo_ss7: Use proper string name for dynamically-created ASP Change-Id: Id346002c79ba2aba

[MERGED] libosmo-sccp[master]: osmo_ss7: Fix memory leak with sock_name on clients at re-co...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: Fix memory leak with sock_name on clients at re-connect time .. osmo_ss7: Fix memory leak with sock_name on clients at re-connect time We cann

[MERGED] libosmo-sccp[master]: osmo_ss7: destroy any ASPs allocated dynamically at accept()...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ss7: destroy any ASPs allocated dynamically at accept() time .. osmo_ss7: destroy any ASPs allocated dynamically at accept() time When we accept SC

libosmo-sccp[master]: osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or...

2017-04-11 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2301 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31e7de136545279a75a5faca0927d3dbf11ff46d Gerrit-PatchSet: 3 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

[PATCH] libosmo-sccp[master]: osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or...

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2301 to look at the new patch set (#3). osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or server socket Change-Id: I31e7de136545279a75a5faca0927d3dbf11ff46d --- M src/osmo_ss7.c 1

libosmo-sccp[master]: osmo_ss7: Allocate local routing key ID and use it as lookup...

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2308 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89a0abcf66228ce092126a497cc7971df3a6af71 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: sccp_user: Make sure to create client-side AS with primary PC

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2307 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If586ac9f3449254973a19654dd13dce5793f285f Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: osmo_ss7: destroy any ASPs allocated dynamically at accept()...

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2306 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07d69a0cd52a049a7a4bb0d996e95d39fee9a106 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: osmo_ss7: Make sure to start server-side ASP FSM for dynamic...

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2305 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dd079158a8c6b176a94dc251748924ef3e9c937 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: osmo_ss7: When destroying an AS or a linkset, delete all routes

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2304 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I393400bc758c28997e16bc78e3142719b6a61be8 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2302 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e4e86f9b9d8ef4639c835878749ce8d8cc76f7c Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: osmo_ss7: Fix memory leak with sock_name on clients at re-co...

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2303 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6798221ccb3c70186c1c51dd34b7823fefd6df58 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or...

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2301 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31e7de136545279a75a5faca0927d3dbf11ff46d Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

[PATCH] libosmo-sccp[master]: osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or...

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2301 to look at the new patch set (#2). osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or server socket Change-Id: I31e7de136545279a75a5faca0927d3dbf11ff46d --- M src/osmo_ss7.c 1

libosmo-sccp[master]: osmo_ss7: Instruct libosmo-netif to use {TCP, SCTP}_NODELAY o...

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2299 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aa4eb421ecb483d3da1b0ce3aa6511d161c3750 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: osmo_ss7: Use proper string name for dynamically-created ASP

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2300 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id346002c79ba2aba2183ebd46bead372a727316d Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

[PATCH] libosmo-sccp[master]: osmo_ss7: Allocate local routing key ID and use it as lookup...

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2308 to look at the new patch set (#2). osmo_ss7: Allocate local routing key ID and use it as lookup key for AS In M3UA RKM we need a "Local Routing Key ID" which uniquely identifies a given

[PATCH] libosmo-sccp[master]: osmo_ss7: Fix memory leak with sock_name on clients at re-co...

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2303 to look at the new patch set (#2). osmo_ss7: Fix memory leak with sock_name on clients at re-connect time We cannot use osmo_talloc_replace_string() together with osmo_sock_get_name(),

[PATCH] libosmo-sccp[master]: osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2302 to look at the new patch set (#2). osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager The M3UA RFC defines this primitive to the layer manager, but we so far didn't generate it

[PATCH] libosmo-sccp[master]: osmo_ss7: Make sure to start server-side ASP FSM for dynamic...

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2305 to look at the new patch set (#2). osmo_ss7: Make sure to start server-side ASP FSM for dynamically created ASPs Change-Id: I5dd079158a8c6b176a94dc251748924ef3e9c937 --- M src/osmo_ss7.

[PATCH] libosmo-sccp[master]: sccp_user: Make sure to create client-side AS with primary PC

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2307 to look at the new patch set (#2). sccp_user: Make sure to create client-side AS with primary PC When we are on the ASP (client) side, we must initialize the routing key of the AS with

[PATCH] libosmo-sccp[master]: osmo_ss7: When destroying an AS or a linkset, delete all routes

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2304 to look at the new patch set (#2). osmo_ss7: When destroying an AS or a linkset, delete all routes When we destroy a linkset, it make sense to remove all associated routes pointing to t

[PATCH] libosmo-sccp[master]: osmo_ss7: destroy any ASPs allocated dynamically at accept()...

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2306 to look at the new patch set (#2). osmo_ss7: destroy any ASPs allocated dynamically at accept() time When we accept SCTP connections from clients for whose IP/port we have no matching l

[MERGED] libosmo-sccp[master]: SCCP SCOC: Ensure user primitive msgb->l2h always poinst to ...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: SCCP SCOC: Ensure user primitive msgb->l2h always poinst to tail .. SCCP SCOC: Ensure user primitive msgb->l2h always poinst to tail In case there is no

[MERGED] libosmo-sccp[master]: xua: Add value_string for routing key [de]registration results

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: xua: Add value_string for routing key [de]registration results .. xua: Add value_string for routing key [de]registration results Change-Id: If8f0a0ad0837

[MERGED] libosmo-sccp[master]: SCRC: Print NOTICE log message if we attempt to use (missing...

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: SCRC: Print NOTICE log message if we attempt to use (missing) GT routing .. SCRC: Print NOTICE log message if we attempt to use (missing) GT routing Cha

[MERGED] libosmo-sccp[master]: Fix for SCCP CC without user data

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix for SCCP CC without user data .. Fix for SCCP CC without user data When sending messages like CC (or SUA COAK) without user data, we must make sure t

libosmo-sccp[master]: xua: Add value_string for routing key [de]registration results

2017-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2298 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8f0a0ad0837810388cfe65a7b571b6ce4df33e3 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: SCRC: Print NOTICE log message if we attempt to use (missing...

2017-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2297 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dc954cc3f10860dea518f95e53f72c6a9a3de95 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: Fix for SCCP CC without user data

2017-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2292 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If91edb526cbcd792ec5ebcb4518cf848feb69391 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-sccp[master]: SCCP SCOC: Ensure user primitive msgb->l2h always poinst to ...

2017-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2296 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie512fe063391e3a634097f555b9b0089d2981de9 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-netif[master]: Add osmo_stream_{cli, srv_link}_set_nodelay() function

2017-04-11 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2295 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb9ba227bab18f7f4f16518c0022c4f003cc8e9 Gerrit-PatchSet: 4 Gerrit-Project: libosmo-netif Gerrit-Branch: master G

[MERGED] libosmo-netif[master]: Add osmo_stream_{cli, srv_link}_set_nodelay() function

2017-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add osmo_stream_{cli,srv_link}_set_nodelay() function .. Add osmo_stream_{cli,srv_link}_set_nodelay() function Using this function, the user can configur

[PATCH] libosmo-sccp[master]: osmo_ss7: Allocate local routing key ID and use it as lookup...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2308 osmo_ss7: Allocate local routing key ID and use it as lookup key for AS In M3UA RKM we need a "Local Routing Key ID" which uniquely identifies a given routing key locally at the node. Allocate this value and store it in each osmo_ss7_as, as well as add

[PATCH] libosmo-sccp[master]: osmo_ss7: When destroying an AS or a linkset, delete all routes

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2304 osmo_ss7: When destroying an AS or a linkset, delete all routes When we destroy a linkset, it make sense to remove all associated routes pointing to the linkset, as they would point to nowhere anyway. Change-Id: I393400bc758c28997e16bc78e3142719b6a61be

[PATCH] libosmo-sccp[master]: osmo_ss7: destroy any ASPs allocated dynamically at accept()...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2306 osmo_ss7: destroy any ASPs allocated dynamically at accept() time When we accept SCTP connections from clients for whose IP/port we have no matching local configurations, and it is permitted by local configuration, we dynamically allocate osmo_ss7_asp's

[PATCH] libosmo-sccp[master]: osmo_ss7: Make sure to start server-side ASP FSM for dynamic...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2305 osmo_ss7: Make sure to start server-side ASP FSM for dynamically created ASPs Change-Id: I5dd079158a8c6b176a94dc251748924ef3e9c937 --- M src/osmo_ss7.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sc

[PATCH] libosmo-sccp[master]: osmo_ss7: Instruct libosmo-netif to use {TCP, SCTP}_NODELAY o...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2299 osmo_ss7: Instruct libosmo-netif to use {TCP,SCTP}_NODELAY on all sockets If we don't do this, we get some nasty packet delays, which are sufficient enough to trigger re-transmissions of an M3UA ASP-UP packet even over loopback/localhost on an otherwise

[PATCH] libosmo-sccp[master]: osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2301 osmo_ss7: Send M-SCTP_RELEASE.ind for close of xUA client or server socket Change-Id: I31e7de136545279a75a5faca0927d3dbf11ff46d --- M src/osmo_ss7.c 1 file changed, 22 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-scc

[PATCH] libosmo-sccp[master]: osmo_ss7: Use proper string name for dynamically-created ASP

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2300 osmo_ss7: Use proper string name for dynamically-created ASP Change-Id: Id346002c79ba2aba2183ebd46bead372a727316d --- M src/osmo_ss7.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/00

[PATCH] libosmo-sccp[master]: sccp_user: Make sure to create client-side AS with primary PC

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2307 sccp_user: Make sure to create client-side AS with primary PC When we are on the ASP (client) side, we must initialize the routing key of the AS with the proper primary point code of the system. Only this way, the correct point code will be used during

[PATCH] libosmo-sccp[master]: osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2302 osmo_ss7: Generate M-SCTP_RESTART.ind towards Layer Manager The M3UA RFC defines this primitive to the layer manager, but we so far didn't generate it. Let's inform the Layer Manager about such events, in case it wants to take appropriate action. Chan

[PATCH] libosmo-sccp[master]: xua: Add value_string for routing key [de]registration results

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2298 xua: Add value_string for routing key [de]registration results Change-Id: If8f0a0ad0837810388cfe65a7b571b6ce4df33e3 --- M src/xua_internal.h M src/xua_rkm.c 2 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/li

[PATCH] libosmo-sccp[master]: SCRC: Print NOTICE log message if we attempt to use (missing...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2297 SCRC: Print NOTICE log message if we attempt to use (missing) GT routing Change-Id: I4dc954cc3f10860dea518f95e53f72c6a9a3de95 --- M src/sccp_scrc.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp r

[PATCH] libosmo-sccp[master]: osmo_ss7: Fix memory leak with sock_name on clients at re-co...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2303 osmo_ss7: Fix memory leak with sock_name on clients at re-connect time We cannot use osmo_talloc_replace_string() together with osmo_sock_get_name(), as the latter already creates a dynamically allocated string, and the former will then make a copy of t

[PATCH] libosmo-sccp[master]: Fix for SCCP CC without user data

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2292 to look at the new patch set (#2). Fix for SCCP CC without user data When sending messages like CC (or SUA COAK) without user data, we must make sure to not include the optional data pa

[PATCH] libosmo-sccp[master]: SCCP SCOC: Ensure user primitive msgb->l2h always poinst to ...

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2296 SCCP SCOC: Ensure user primitive msgb->l2h always poinst to tail In case there is no user data in a CONNECT.conf primitive (or other CO primitives), we must make sure that msgb->l2h = msgb->tail so that the SCCP User can use msgb_l2len(msg) == 0 as indi

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.04/x86_64

2017-04-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build l

Build failure of network:osmocom:nightly/osmo-stp in Debian_8.0/x86_64

2017-04-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-stp failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.10/x86_64

2017-04-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build l

Build failure of network:osmocom:nightly/osmo-stp in Debian_8.0/i586

2017-04-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/Debian_8.0/i586 Package network:osmocom:nightly/osmo-stp failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log: [ 61

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.04/i586

2017-04-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log:

Build failure of network:osmocom:nightly/osmo-stp in xUbuntu_16.10/i586

2017-04-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-stp/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-stp failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-stp Last lines of build log:

[PATCH] libosmo-netif[master]: Add osmo_stream_{cli, srv_link}_set_nodelay() function

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2295 to look at the new patch set (#4). Add osmo_stream_{cli,srv_link}_set_nodelay() function Using this function, the user can configure if sockets related to the respective stream client o

libosmo-netif[master]: Add osmo_stream_{cli, srv_link}_set_nodelay() function

2017-04-11 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2295 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb9ba227bab18f7f4f16518c0022c4f003cc8e9 Gerrit-PatchSet: 3 Gerrit-Project: libosmo-netif Gerrit-Branch: master G

[PATCH] libosmo-netif[master]: Add osmo_stream_{cli, srv_link}_set_nodelay() function

2017-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2295 to look at the new patch set (#3). Add osmo_stream_{cli,srv_link}_set_nodelay() function Using this function, the user can configure if sockets related to the respective stream client o

[PATCH] openbsc[master]: Add gsm_bts_type_variant to gsm_bts struct

2017-04-11 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2294 to look at the new patch set (#2). Add gsm_bts_type_variant to gsm_bts struct Previously it was only in gsm_bts_model which is not initialized on BTS side. It's more convenient to have

[PATCH] openbsc[master]: Make BTS type and variant convertors shareable

2017-04-11 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2286 to look at the new patch set (#4). Make BTS type and variant convertors shareable * move value_string definition and corresponding functions for BTS type to shared header to make it r

[PATCH] libosmo-netif[master]: Add osmo_stream_{cli, srv_link}_set_nodelay() function

2017-04-11 Thread Harald Welte
Add osmo_stream_{cli,srv_link}_set_nodelay() function Using this function, the user can configure if sockets related to the respective stream client or server should have the NODELAY socket option set in order to avoid Nagle algorithm or related algorithms that may introduce packet delay on the t

[PATCH] libosmo-netif[master]: Add void osmo_stream_{cli, srv_link}_set_nodelay() function

2017-04-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/2295 Add void osmo_stream_{cli,srv_link}_set_nodelay() function Using this function, the user can configure if sockets related to the respective stream client or server should have the NODELAY socket option set in order to avoid Nagle algorithm or related al

[PATCH] openbsc[master]: Move gsm_bts_type_variant to gsm_bts struct

2017-04-11 Thread Max
Review at https://gerrit.osmocom.org/2294 Move gsm_bts_type_variant to gsm_bts struct Previously it was in gsm_bts_model which is not initialized on BTS side. It's more convenient to have it in the struct which is available to both BSC and BTS. Change-Id: I54fde8c4ccd5d994af08074f5864446e79a93

[PATCH] openbsc[master]: Move string - BTS type conversion to shared header

2017-04-11 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2286 to look at the new patch set (#3). Move string - BTS type conversion to shared header Move value_string definition and corresponding functions to shared header to make it re-usable by O

[PATCH] libosmocore[master]: Add SW Description (de)marshalling

2017-04-11 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2165 to look at the new patch set (#14). Add SW Description (de)marshalling * data structure representing 3GPP TS 52.021 ยง9.4.62 SW Description * function to serialize it into

libosmo-sccp[master]: Add osmo-stp executable as new "Osmocom Signaling Transfer P...

2017-04-11 Thread Max
Patch Set 2: I think we should add it to debian/ as well. -- To view, visit https://gerrit.osmocom.org/2281 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32227b8d3127c6178e4ee45527ce65f69bc7b1e Gerrit-PatchSet: 2 Gerrit-Project: libos

openbsc[master]: nat: Use equal func in bsc_sccp

2017-04-11 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2285 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fac7cabedff74f8f6293ad8b54420229b80aa71 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

openbsc[master]: build: iu: use libosmo-sccp tag 'old_sua'

2017-04-11 Thread Max
Patch Set 1: In the description you mention tag, in the code - branch. So which is it? -- To view, visit https://gerrit.osmocom.org/2293 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74a802fd2ca65f4b6c2079550fbb6b0af3e8340 Gerrit-Patc

[PATCH] osmo-bts[master]: Signal to BSC when PCU disconnects

2017-04-11 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2288 to look at the new patch set (#2). Signal to BSC when PCU disconnects Change-Id: I41a731bd719aee0bbb98d3236405fb3a7f3ddec0 Related: OS#1615 --- M src/common/pcu_sock.c 1 file changed, 2