[MERGED] openbsc[master]: Use define for limit on number of BTS features

2017-05-10 Thread Max
Max has submitted this change and it was merged. Change subject: Use define for limit on number of BTS features .. Use define for limit on number of BTS features Change-Id: Ief81db0b3653fec180e60776ff9bcb0ac1357217 Related: OS#

[MERGED] osmo-bts[master]: Set BTS variant while initializing BTS model

2017-05-10 Thread Max
Max has submitted this change and it was merged. Change subject: Set BTS variant while initializing BTS model .. Set BTS variant while initializing BTS model This will allow proper BTS attribute reporting via OML in follow-up p

osmo-bts[master]: Implement basic Get Attribute responder

2017-05-10 Thread Max
Patch Set 1: Could you elaborate please - which functions exactly should be covered by tests in this case? -- To view, visit https://gerrit.osmocom.org/2545 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09f95ed995fab5def9dc6e8cc201012

[PATCH] osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

2017-05-10 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2541 to look at the new patch set (#3). Log network activity using tcpdump for nitb interface Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af --- M src/osmo_gsm_tester/osmo_nitb.py A sr

libosmocore[master]: timer: add osmo_timer_setup()

2017-05-10 Thread Pablo Neira Ayuso
Patch Set 6: Reason for upstreaming this non-inlined version is the following: This new osmo_timer_setup() should be called from the configuration path once and never ever again to set up the callback and data. So this is not fast path at all. Using a function instead for slow path code is goo

[MERGED] libosmocore[master]: timer: add osmo_timer_setup()

2017-05-10 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: timer: add osmo_timer_setup() .. timer: add osmo_timer_setup() Add a new function timer function to set up the timer, similar to what we have in the

[PATCH] openbsc[master]: src: use osmo_timer_setup()

2017-05-10 Thread Pablo Neira Ayuso
Review at https://gerrit.osmocom.org/2549 src: use osmo_timer_setup() Use new function available in libosmocore to set up timers. Compile tested only. Change-Id: Ibcfd915688e97d370a88a83a7c95cbe16819 --- M openbsc/src/gprs/gprs_gmm.c M openbsc/src/gprs/gprs_sgsn.c M openbsc/src/gprs/gtphub

[PATCH] osmo-gsm-tester[master]: readme: format so that dependencies can be copy-pasted to te...

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2550 readme: format so that dependencies can be copy-pasted to terminal Change-Id: I455cb75d6cdd583d31ab0188476bee813a2ab789 --- M doc/README.txt 1 file changed, 14 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester re

[PATCH] openbsc[master]: Get basic BTS attributes

2017-05-10 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2544 to look at the new patch set (#2). Get basic BTS attributes Request BTS attributes via OML on connection and parse the response: request/parse incoming response as sw-config. Note: onl

[PATCH] openbsc[master]: Prepare for BTS attribute reporting via OML

2017-05-10 Thread Max
Review at https://gerrit.osmocom.org/2551 Prepare for BTS attribute reporting via OML * use define for number of attributes instead of magic number * add sub_model to gsm_bts struct * expand number of BTS features * mark attributes parameter to abis_nm_get_attr() as const Change-Id: I7ecb0c433

[PATCH] osmo-bts[master]: Implement basic Get Attribute responder

2017-05-10 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2545 to look at the new patch set (#2). Implement basic Get Attribute responder Add 3GPP TS 52.021 §8.11.2 Get Attribute Response handling: * report OsmoBTS version * report sy

openbsc[master]: Get basic BTS attributes

2017-05-10 Thread Max
Patch Set 2: > Is the SW config contents not again "juts" some kind of TLV structure? Unfortunately not. Neither Get Attribute Response Info nor SW-Config are TLV-type structures. I've added clarifying comments and references to the spec. I think those are too specific to attempt to accommodat

[PATCH] libosmocore[master]: doc: fix incorrect return value description

2017-05-10 Thread Max
Review at https://gerrit.osmocom.org/2552 doc: fix incorrect return value description Change-Id: Ieba009273f911bc4217122a6346220aeb29e8bc4 Related: OS#1614 --- M src/gsm/abis_nm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/

[PATCH] osmo-gsm-tester[master]: util: simplify listdict

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2553 util: simplify listdict listdict came into the code base from some other python code of mine, for no apparent reason: it is actually not used here at all. However, an upcoming patch will use a dict of lists. Also, the listdict implementation is convolu

[PATCH] osmo-gsm-tester[master]: ofono/dbus: detach from signals as appropriate

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2554 ofono/dbus: detach from signals as appropriate In the dbus_connect() code path, return the subscription token. In the Modem class, use this token to disconnect signal callbacks when an interface is removed. Generalize the signal connect/disconnect han

osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

2017-05-10 Thread Neels Hofmeyr
Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/2541/3/src/osmo_gsm_tester/util.py File src/osmo_gsm_tester/util.py: Line 46: if 'inet' in line and ' ' + ip + '/' in line: (indent too deep) -- To view, visit https://gerrit.osmocom.org/2541 To unsubsc

osmo-gsm-tester[master]: readme: format so that dependencies can be copy-pasted to te...

2017-05-10 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2550 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I455cb75d6cdd583d31ab0188476bee813a2ab789 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

2017-05-10 Thread Pau Espin Pedrol
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2541 to look at the new patch set (#4). Log network activity using tcpdump for nitb interface Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af --- M src/osmo_gsm_tester/os

osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

2017-05-10 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2541 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[MERGED] osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

2017-05-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: Log network activity using tcpdump for nitb interface .. Log network activity using tcpdump for nitb interface Change-Id: I4c5d0e2d9857160f905e743517

[PATCH] osmo-gsm-tester[master]: cosmetic: lock test: add quotes

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2556 cosmetic: lock test: add quotes Mostly to clarify an empty lock in the end. Change-Id: If80960b331d30125e97878d52edba9b4a63e87c7 --- M selftest/lock_test.ok M selftest/lock_test.sh 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://ger

[PATCH] osmo-gsm-tester[master]: lock test: make more robust against timing

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2555 lock test: make more robust against timing Remove the stdout printing from the lock_test_help.py, so that there is no problem with a failing test because one output ending up in stdout before the other. So only output the current lock from lock_test.sh.

[PATCH] osmo-gsm-tester[master]: ofono/dbus: detach from signals as appropriate

2017-05-10 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2554 to look at the new patch set (#2). ofono/dbus: detach from signals as appropriate In the dbus_connect() code path, return the subscription token. In the Modem class, use this token to

[PATCH] osmo-gsm-tester[master]: util: simplify listdict

2017-05-10 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2553 to look at the new patch set (#3). util: simplify listdict listdict came into the code base from some other python code of mine, for no apparent reason: it is actually not used here at

osmo-gsm-tester[master]: lock test: make more robust against timing

2017-05-10 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2555/1/selftest/lock_test_help.py File selftest/lock_test_help.py: Line 20: sys.stdout.flush() I guess these flush() (and above the same) are not needed anymore. -- To view, visit https://gerrit.osmocom.org/2555 To unsubscribe, visi

osmo-gsm-tester[master]: ofono/dbus: detach from signals as appropriate

2017-05-10 Thread Pau Espin Pedrol
Patch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/2554/3/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 157: for subscription in subscriptions: missing indent here? It does makes no sense to iterate over subrscription if it's None right? Lin

[PATCH] openbsc[master]: osmo-nitb: change default db name to sms.db

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2564 osmo-nitb: change default db name to sms.db libvlr now delegates subscriber management to osmo-hlr, so the database no longer represents a HLR. It basically only stores SMS, so reflect that fact in the default database name. Change-Id: Ibf766d9f7f67aae

[PATCH] openbsc[master]: IuPS adjustments

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2566 IuPS adjustments SGSN: Don't indicate GERAN in Iu mode PDP CTX ACT REQ to GGSN sgsn_ranap_iu_event: handle some events without valid MM context sgsn init: pass sgsn_config pointer to sgsn_vty_init(), not sgsn_parse_config IuPS: cosmetic: explicitly c

[PATCH] openbsc[master]: osmo-nitb: change default config file name to osmo-nitb.cfg

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2565 osmo-nitb: change default config file name to osmo-nitb.cfg Since the VLR development marks a move away from the 'openbsc' name, now is a good opportunity to also change the default config file name to the more accurate and obvious 'osmo-nitb.cfg'. Cha

[PATCH] openbsc[master]: temporary dev: set debug log level almost everywhere

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2571 temporary dev: set debug log level almost everywhere Change-Id: I0d5a36560e7edde27497de57e579f5b1d00eb525 --- M openbsc/src/libcommon/debug.c 1 file changed, 17 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/chan

[ABANDON] openbsc[master]: GPRS/IuPS: remove all 3G authentication dev hacks

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: GPRS/IuPS: remove all 3G authentication dev hacks .. Abandoned accidental branch push. -- To view, visit https://gerrit.osmocom.org/2557 To unsubscribe, visit https://

[PATCH] openbsc[master]: GPRS/IuPS: remove all 3G authentication dev hacks

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2557 GPRS/IuPS: remove all 3G authentication dev hacks UMTS auth works now with the external OsmoHLR. Change-Id: I1204f388cf1311ec98b3eaf7505d7e18e73f03d0 --- M openbsc/src/gprs/gprs_gmm.c M openbsc/src/libiu/iu.c 2 files changed, 2 insertions(+), 44 deleti

[PATCH] openbsc[master]: Add msc_vlr test suite for MSC+VLR end-to-end tests

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2562 Add msc_vlr test suite for MSC+VLR end-to-end tests Change-Id: Ic073f3a069a7f5e7e421e0e56140f069ee9b10b8 --- M openbsc/.gitignore M openbsc/configure.ac M openbsc/tests/Makefile.am A openbsc/tests/msc_vlr/Makefile.am A openbsc/tests/msc_vlr/msc_vlr_test

[PATCH] openbsc[master]: Use libvlr in libmsc (large refactoring)

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2561 Use libvlr in libmsc (large refactoring) Original libvlr code is by Harald Welte , polished and tweaked by Neels Hofmeyr . This is a long series of development collapsed in one patch. The original history may still be available as branch neels/vlr_orig

[PATCH] openbsc[master]: SI3: indicate R99+ MSC to GSM MS to enable UMTS AKA

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2563 SI3: indicate R99+ MSC to GSM MS to enable UMTS AKA Change-Id: Iaf11218327f139e8cabfbc5f9916505c66eadbd8 --- M openbsc/src/libbsc/bsc_init.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes

[PATCH] openbsc[master]: Implement IuCS (large refactoring and addition)

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2568 Implement IuCS (large refactoring and addition) osmo-nitb becomes osmo-msc add DIUCS debug log constant add iucs.[hc] add msc vty, remove nitb vty add libiudummy, to avoid linking Iu deps in tests Use new msc_tx_dtap() instead of gsm0808_submit_dtap() l

[PATCH] openbsc[master]: mgcp: hack RAB success from nano3G: patch first RTP payload

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2569 mgcp: hack RAB success from nano3G: patch first RTP payload The ip.access nano3G needs the first RTP payload's first two bytes to read hex 'e400', or it will reject the RAB assignment. Add flag patched_first_rtp_payload to mgcp_rtp_state to detect the f

[PATCH] openbsc[master]: contrib: Add osmo-msc service file

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2572 contrib: Add osmo-msc service file Change-Id: I3cb8a90010451bed3a1462ac9ba48275c28d48aa --- A openbsc/contrib/systemd/osmo-msc.service 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/72/2

[PATCH] openbsc[master]: gsup_client: allow passing a unit id to identify with HLR

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2558 gsup_client: allow passing a unit id to identify with HLR Before, each GSUP client would contact the HLR with an identical unit id, i.e. "SGSN-00-00-00-00-00-00", with the result that some messages were sucked off by the wrong client. Pass explicit uni

[PATCH] openbsc[master]: mscsplit: various preparations to separate MSC from BSC

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2567 mscsplit: various preparations to separate MSC from BSC Disable large parts of the code that depend on BSC presence. Don't set msg->lchan nor msg->dst. Don't use lchan in libmsc. Decouple lac from bts. Prepare entry/exit point for MSC -> BSC and MSC -

[PATCH] openbsc[master]: logging: auth request: use hexdump without spaces for RAND, ...

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2559 logging: auth request: use hexdump without spaces for RAND, AUTN Change-Id: I656d8619a1adc93e2f627f4e1ba21512a7374279 --- M openbsc/src/libmsc/gsm_04_08.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbs

[ABANDON] openbsc[master]: gsup_client: allow passing a unit id to identify with HLR

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: gsup_client: allow passing a unit id to identify with HLR .. Abandoned -- To view, visit https://gerrit.osmocom.org/2558 To unsubscribe, visit https://gerrit.osmocom.org

[ABANDON] openbsc[master]: Add libvlr implementation

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: Add libvlr implementation .. Abandoned -- To view, visit https://gerrit.osmocom.org/2560 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: a

[ABANDON] openbsc[master]: logging: auth request: use hexdump without spaces for RAND, ...

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: logging: auth request: use hexdump without spaces for RAND, AUTN .. Abandoned -- To view, visit https://gerrit.osmocom.org/2559 To unsubscribe, visit https://gerrit.osmo

[ABANDON] openbsc[master]: Add msc_vlr test suite for MSC+VLR end-to-end tests

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: Add msc_vlr test suite for MSC+VLR end-to-end tests .. Abandoned -- To view, visit https://gerrit.osmocom.org/2562 To unsubscribe, visit https://gerrit.osmocom.org/setti

[ABANDON] openbsc[master]: SI3: indicate R99+ MSC to GSM MS to enable UMTS AKA

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: SI3: indicate R99+ MSC to GSM MS to enable UMTS AKA .. Abandoned -- To view, visit https://gerrit.osmocom.org/2563 To unsubscribe, visit https://gerrit.osmocom.org/setti

[ABANDON] openbsc[master]: Use libvlr in libmsc (large refactoring)

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: Use libvlr in libmsc (large refactoring) .. Abandoned -- To view, visit https://gerrit.osmocom.org/2561 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit

[ABANDON] openbsc[master]: IuPS adjustments

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: IuPS adjustments .. Abandoned -- To view, visit https://gerrit.osmocom.org/2566 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon Ge

[ABANDON] openbsc[master]: osmo-nitb: change default config file name to osmo-nitb.cfg

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: osmo-nitb: change default config file name to osmo-nitb.cfg .. Abandoned -- To view, visit https://gerrit.osmocom.org/2565 To unsubscribe, visit https://gerrit.osmocom.o

[ABANDON] openbsc[master]: osmo-nitb: change default db name to sms.db

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: osmo-nitb: change default db name to sms.db .. Abandoned -- To view, visit https://gerrit.osmocom.org/2564 To unsubscribe, visit https://gerrit.osmocom.org/settings Ger

[ABANDON] openbsc[master]: mscsplit: various preparations to separate MSC from BSC

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: mscsplit: various preparations to separate MSC from BSC .. Abandoned -- To view, visit https://gerrit.osmocom.org/2567 To unsubscribe, visit https://gerrit.osmocom.org/s

[ABANDON] openbsc[master]: Implement IuCS (large refactoring and addition)

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: Implement IuCS (large refactoring and addition) .. Abandoned -- To view, visit https://gerrit.osmocom.org/2568 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] openbsc[master]: log protocol discriminators and message types by name

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: log protocol discriminators and message types by name .. Abandoned -- To view, visit https://gerrit.osmocom.org/2570 To unsubscribe, visit https://gerrit.osmocom.org/set

[ABANDON] openbsc[master]: mgcp: hack RAB success from nano3G: patch first RTP payload

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: mgcp: hack RAB success from nano3G: patch first RTP payload .. Abandoned -- To view, visit https://gerrit.osmocom.org/2569 To unsubscribe, visit https://gerrit.osmocom.o

[ABANDON] openbsc[master]: temporary dev: set debug log level almost everywhere

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: temporary dev: set debug log level almost everywhere .. Abandoned end of accidental branch push -- To view, visit https://gerrit.osmocom.org/2571 To unsubscribe, visit

[PATCH] openbsc[vlr_3G]: contrib: Add osmo-msc service file

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2573 contrib: Add osmo-msc service file Change-Id: I60b1b134beec741c50df4c32d44ed51b720e12c9 --- A openbsc/contrib/systemd/osmo-msc.service 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/73/2

[ABANDON] openbsc[master]: contrib: Add osmo-msc service file

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: contrib: Add osmo-msc service file .. Abandoned gerrit forces me to change the change-id and make this a new commit :( -- To view, visit https://gerrit.osmocom.org/2572

[MERGED] openbsc[vlr_3G]: contrib: Add osmo-msc service file

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: contrib: Add osmo-msc service file .. contrib: Add osmo-msc service file Change-Id: I60b1b134beec741c50df4c32d44ed51b720e12c9 --- A openbsc/contrib/syst

[PATCH] openbsc[vlr_3G]: examples: Change IP address of config files

2017-05-10 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2538 to look at the new patch set (#3). examples: Change IP address of config files This helps in providing 3G software packages for the sysmoNITB hardware. Change-Id: I99ba31

[MERGED] openbsc[vlr_3G]: examples: Change IP address of config files

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: examples: Change IP address of config files .. examples: Change IP address of config files This helps in providing 3G software packages for the sysmoNIT

osmo-bts[master]: Name systemd service after the software

2017-05-10 Thread Neels Hofmeyr
Patch Set 2: when Daniel is back, please see if he can help you out. -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie336292c275e7415a1deedab7c3b44966aacc3bf Gerrit-PatchSet: 2 Gerrit-Pro

libosmocore[master]: doc: fix incorrect return value description

2017-05-10 Thread Neels Hofmeyr
Patch Set 1: Code-Review+1 I guess this could use an entry in 'TODO-RELEASE' to note the fixed API? (even if it is just the API doc that was fixed) -- To view, visit https://gerrit.osmocom.org/2552 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Ch

libosmocore[master]: doc: fix incorrect return value description

2017-05-10 Thread Max
Patch Set 1: > I guess this could use an entry in 'TODO-RELEASE' to note the fixed API? Why? TODO-RELEASE is for keeping track of API/ABI changes so we bump corresponding versions when necessary. Docstring change requires neither API not ABI bump. -- To view, visit https://gerrit.osmocom.org

osmo-gsm-tester[master]: ofono/dbus: detach from signals as appropriate

2017-05-10 Thread Neels Hofmeyr
Patch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/2554/3/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 157: for subscription in subscriptions: > missing indent here? It does makes no sense to iterate over subrscription i it will never be None

[PATCH] osmo-gsm-tester[master]: ofono/dbus: detach from signals as appropriate

2017-05-10 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2554 to look at the new patch set (#4). ofono/dbus: detach from signals as appropriate In the dbus_connect() code path, return the subscription token. In the Modem class, use this token to

[MERGED] osmo-gsm-tester[master]: readme: format so that dependencies can be copy-pasted to te...

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: readme: format so that dependencies can be copy-pasted to terminal .. readme: format so that dependencies can be copy-pasted to terminal Change-Id: I45

[MERGED] osmo-gsm-tester[master]: run dir: add a second log file containing a non-debug log

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: run dir: add a second log file containing a non-debug log .. run dir: add a second log file containing a non-debug log Change-Id: Ic51b8f87abc52cc4af367

[ABANDON] osmo-gsm-tester[master]: dbus: handle missing interfaces by deferring, not by looping

2017-05-10 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: dbus: handle missing interfaces by deferring, not by looping .. Abandoned -- To view, visit https://gerrit.osmocom.org/2489 To unsubscribe, visit https://gerrit.osmocom.

[PATCH] osmo-gsm-tester[master]: cosmetic: cmdline help: add line breaks, fix typo

2017-05-10 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2495 to look at the new patch set (#3). cosmetic: cmdline help: add line breaks, fix typo Fix typo 'patch' -> 'match' Argparse has a peculiar way of treating the cmdline help strings. To be

osmo-gsm-tester[master]: ofono/dbus: detach from signals as appropriate

2017-05-10 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2554 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0939ef414bc599ee8742df48da04d8d9569d00ba Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: lock test: make more robust against timing

2017-05-10 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2555 to look at the new patch set (#3). lock test: make more robust against timing Remove the stdout printing from the lock_test_help.py, so that there is no problem with a failing test beca

osmo-gsm-tester[master]: lock test: make more robust against timing

2017-05-10 Thread Pau Espin Pedrol
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2555 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fe80a9de88ddee1d66ca5c692948fc9673e4230 Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[PATCH] osmo-bts[master]: Implement basic Get Attribute responder

2017-05-10 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2545 to look at the new patch set (#3). Implement basic Get Attribute responder Add 3GPP TS 52.021 §8.11.2 Get Attribute Response handling: * report OsmoBTS version * report sy

[PATCH] osmo-bts[master]: Prepare for BTS attribute reporting via OML

2017-05-10 Thread Max
Review at https://gerrit.osmocom.org/2574 Prepare for BTS attribute reporting via OML * move BTS model name resolution into separate function * add convenience wrappers for BTS type and number fo TRX and use then in L1 interface Change-Id: I4649100df8f1b8e095f210fc294567ba014c0b6a Related: O

[PATCH] osmo-bts[master]: Implement basic Get Attribute responder

2017-05-10 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2545 to look at the new patch set (#4). Implement basic Get Attribute responder Add 3GPP TS 52.021 §8.11.2 Get Attribute Response handling: * report OsmoBTS version * report sy

[PATCH] osmo-gsm-tester[master]: readme: add some ssh details

2017-05-10 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2575 readme: add some ssh details Change-Id: Idb5d254768b52300d99b5a1f11f92e8536aec371 --- M doc/README-sysmobts.txt M doc/README.txt 2 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/7

openbsc[master]: Get basic BTS attributes

2017-05-10 Thread Harald Welte
Patch Set 2: > > Is the SW config contents not again "juts" some kind of TLV > structure? > > Unfortunately not. Neither Get Attribute Response Info nor > SW-Config are TLV-type structures. I've added clarifying comments > and references to the spec. I think those are too specific to > att

osmo-bts[master]: Implement basic Get Attribute responder

2017-05-10 Thread Harald Welte
Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2545 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09f95ed995fab5def9dc6e8cc201012fba4db28d Gerrit-PatchSet: 4 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

osmo-bts[master]: Prepare for BTS attribute reporting via OML

2017-05-10 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2574 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4649100df8f1b8e095f210fc294567ba014c0b6a Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

libosmocore[master]: doc: fix incorrect return value description

2017-05-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2552 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba009273f911bc4217122a6346220aeb29e8bc4 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: doc: fix incorrect return value description

2017-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: doc: fix incorrect return value description .. doc: fix incorrect return value description Change-Id: Ieba009273f911bc4217122a6346220aeb29e8bc4 Related:

openbsc[master]: Prepare for BTS attribute reporting via OML

2017-05-10 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2551/1/openbsc/include/openbsc/abis_nm.h File openbsc/include/openbsc/abis_nm.h: Line 31: #define MAX_BTS_ATTR 5 can we please have a comment describing what this is about? There are many 'OML attributes' in a BTS, and I'm sure we can ha

openbsc[master]: src: use osmo_timer_setup()

2017-05-10 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2549 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcfd915688e97d370a88a83a7c95cbe16819 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

[MERGED] openbsc[master]: src: use osmo_timer_setup()

2017-05-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: src: use osmo_timer_setup() .. src: use osmo_timer_setup() Use new function available in libosmocore to set up timers. Compile tested only. Change-Id: I