[MERGED] osmo-pcu[master]: Cleanup FN scheduling

2017-05-26 Thread Max
Max has submitted this change and it was merged. Change subject: Cleanup FN scheduling .. Cleanup FN scheduling * replace magic number with defined constant * move copy-pasted code to inline functions * remove unused code Chan

[PATCH] libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-26 Thread blobb
Review at https://gerrit.osmocom.org/2742 Introduce build script for arm-none-eabi cross-compilations This is a necessary step to use libosmocore-arm dep in OsmocomBB. After this patch is submitted the "./contrib/jenkins.sh" line in libosmocore jenkins jobs [1][2] needs to be replaced with:

[PATCH] libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-26 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2742 to look at the new patch set (#2). Introduce build script for arm-none-eabi cross-compilations This is a necessary step to use libosmocore-arm dep in OsmocomBB. After this patch is sub

[PATCH] libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-26 Thread blobb
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2742 to look at the new patch set (#3). Introduce build script for arm-none-eabi cross-compilations This is a necessary step to use libosmocore-arm dep in OsmocomBB. After this patch is sub

libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-26 Thread blobb
Patch Set 3: Sure, I will apply mentioned changes! But, this commit needs to be reverted and [1] needs to be submitted. Because the "--enable-sanitize" option worked out locally, but not on jenkins build slave. New commit [1] has been tested in production [2] (changes have been reverted unt

[PATCH] libosmocore[master]: Revert "Introduce build script for arm-none-eabi cross-compi...

2017-05-26 Thread blobb
Review at https://gerrit.osmocom.org/2743 Revert "Introduce build script for arm-none-eabi cross-compilations" "--enable-sanitize" does not work on jenkins build slave (debian8), although it worked out locally for me. Following patch will introduce corrected arm build script without "--enabl

libosmocore[master]: Revert "Introduce build script for arm-none-eabi cross-compi...

2017-05-26 Thread blobb
blobb has reverted this change. Change subject: Revert "Introduce build script for arm-none-eabi cross-compilations" .. Uploaded patch set 1. -- To view, visit https://gerrit.osmocom.org/2743 To unsubscribe, visit https://ger

libosmocore[master]: Revert "Introduce build script for arm-none-eabi cross-compi...

2017-05-26 Thread blobb
Patch Set 1: >> Harald Welte: will you take care of respective jenkins changes as outlined >> in the commit message? thanks! Sure, I will apply mentioned changes in [1]! But, this commit needs to be reverted and [1] needs to be submitted. Because the "--enable-sanitize" option worked out loc

libosmocore[master]: Revert "Introduce build script for arm-none-eabi cross-compi...

2017-05-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2743 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I644114679db1394e75ff12b0203ae8e568aff82c Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Introduce build script for arm-none-eabi cross-compilations .. Introduce build script for arm-none-eabi cross-compilations This is a necessary step to us

libosmocore[master]: Introduce build script for arm-none-eabi cross-compilations

2017-05-26 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2742 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0db83ad2c94ada65c00fd1bcf867830dec80085d Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

osmo-bts[master]: scheduler_trx.c: Fix typos, improve comments, cosmetics

2017-05-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2740 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e2ce70aea8d62657ce3a7d6c16e5a7f8b76c22f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

[MERGED] libosmocore[master]: Revert "Introduce build script for arm-none-eabi cross-compi...

2017-05-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Revert "Introduce build script for arm-none-eabi cross-compilations" .. Revert "Introduce build script for arm-none-eabi cross-compilations" "--enable-s

osmo-bts[master]: scheduler_trx.c: Avoid code duplication for BER10k computation

2017-05-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2741 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e76a4707968e428cbd2e43d5df71ef445efece Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

libosmo-abis[master]: ipacces.c: Remove ipa_bts_id_resp() and use libosmocore

2017-05-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2737 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I858920db1fb5f5d66e71b676d28c84d330d7904a Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Ge

osmo-bts[master]: Remove unusued left-over gsm0503_conv.c

2017-05-26 Thread Harald Welte
Patch Set 1: Code-Review-1 there's also a header file... -- To view, visit https://gerrit.osmocom.org/2739 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdcca1bc55a83c76ec47918dc4dd301155210091 Gerrit-PatchSet: 1 Gerrit-Project: osmo-b

[MERGED] libosmo-abis[master]: Add value_string for input signal names (e1inp_signal_names)

2017-05-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add value_string for input signal names (e1inp_signal_names) .. Add value_string for input signal names (e1inp_signal_names) Change-Id: I1662d4a969d2d126

[MERGED] libosmo-abis[master]: ipacces.c: Remove ipa_bts_id_resp() and use libosmocore

2017-05-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ipacces.c: Remove ipa_bts_id_resp() and use libosmocore .. ipacces.c: Remove ipa_bts_id_resp() and use libosmocore In Chanage-Id Icbcd8827a75fd5f3393351c

[PATCH] libosmocore[master]: socket: Add osmo_sock_init2_ofd() function

2017-05-26 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2744 socket: Add osmo_sock_init2_ofd() function Will be used by osmo-bts-trx Change-Id: I3c655a4af64fb80497a5aaa811cce8005dba9cd9 --- M include/osmocom/core/socket.h M src/socket.c 2 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.

[PATCH] osmo-bts[master]: trx: Save osmotrx base-port vty properties

2017-05-26 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2746 trx: Save osmotrx base-port vty properties Change-Id: I0898a8c4eb3899fc1c0f6b17da33b8c7851b90d6 --- M src/osmo-bts-trx/trx_vty.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/2746/1

[PATCH] osmo-bts[master]: trx: Allow BTS and TRX to be on different IPs

2017-05-26 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2745 trx: Allow BTS and TRX to be on different IPs Depends on libosmocore I3c655a4af64fb80497a5aaa811cce8005dba9cd9 Change-Id: I0bd34b7b02c1a9b0c6f6f89f327b486e5620c8d5 --- M include/osmo-bts/phy_link.h M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_if.c

[PATCH] osmo-gsm-manuals[master]: OsmoBTS: Update osmotrx ip to diff between local and remote

2017-05-26 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2747 OsmoBTS: Update osmotrx ip to diff between local and remote Change-Id: Ia4c70b3b8436e2647fc35d579a302dfbf32a83f0 --- M OsmoBTS/chapters/bts-models.adoc 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-

[PATCH] openbsc[master]: Enable optional static builds

2017-05-26 Thread Max
Review at https://gerrit.osmocom.org/2748 Enable optional static builds * use LT_INIT instead of AC_PROG_RANLIB * remove redundant libbsc entries The default (for both manual and .deb builds) is to use shared build (as before) - the static build is entirely optional. Based on work by Sergey K

[PATCH] libosmo-abis[master]: Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmoc...

2017-05-26 Thread Harald Welte
Review at https://gerrit.osmocom.org/2749 Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmocore" This reverts commit d517db06ced45bbe0a70799487964e52edd8a375, which for some reason broke the IPA client functionality. This needs to be investigated and properly fixed. But until that h

[MERGED] libosmo-abis[master]: Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmoc...

2017-05-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmocore" .. Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmocore" This reverts commit

libosmo-abis[master]: Revert "ipacces.c: Remove ipa_bts_id_resp() and use libosmoc...

2017-05-26 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2749 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic168f437c5bf1fcdb7441b0541c80a4805463004 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Ge

[ABANDON] openbsc[master]: lchan: add ms_timing_offset member to struct gsm_lchan

2017-05-26 Thread dexter
dexter has abandoned this change. Change subject: lchan: add ms_timing_offset member to struct gsm_lchan .. Abandoned -- To view, visit https://gerrit.osmocom.org/2409 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-bts[master]: measurement: fix measurement computation

2017-05-26 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2412 to look at the new patch set (#8). measurement: fix measurement computation Timing advance is currently not taken into account when computing the measurement results, this

[PATCH] osmo-bts[master]: measurement: Improve log output

2017-05-26 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2389 to look at the new patch set (#7). measurement: Improve log output The debug log does not print much information about the measured rxlev and rxqual values. This commit ad

osmo-bts[master]: measurement: fix measurement computation

2017-05-26 Thread Max
Patch Set 8: (2 comments) https://gerrit.osmocom.org/#/c/2412/8/src/common/measurement.c File src/common/measurement.c: Line 229: } else { I don't think we use empty-else-with-comment style anywhere else. Just the comment would be enough. Line 238: /*Do Nothing */

[PATCH] osmo-bts[master]: Implement basic Get Attribute responder

2017-05-26 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2545 to look at the new patch set (#7). Implement basic Get Attribute responder Add 3GPP TS 52.021 ยง8.11.2 Get Attribute Response handling: * report OsmoBTS version * report sy

[PATCH] osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-05-26 Thread blobb
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2465 to look at the new patch set (#9). Introduce artifacts holding dependencies to speed up builds. Basically, osmo-build.sh holds logic to check whether the necessary artifact

[PATCH] osmo-bts[master]: measurement: Improve log output

2017-05-26 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2389 to look at the new patch set (#8). measurement: Improve log output The debug log does not print much information about the measured rxlev and rxqual values. This commit ad

[PATCH] osmo-bts[master]: measurement: fix measurement computation

2017-05-26 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2412 to look at the new patch set (#9). measurement: fix measurement computation Timing advance is currently not taken into account when computing the measurement results, this

[PATCH] osmo-gsm-manuals[master]: osmo-sgsn: fix arrow tips in flow diagrams

2017-05-26 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2022 to look at the new patch set (#6). osmo-sgsn: fix arrow tips in flow diagrams The arrow style used to desribe the flowcharts in gsup.adoc does not match the arrow style u

osmo-bts[master]: measurement: fix measurement computation

2017-05-26 Thread Max
Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2412 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e0dfd13b53e8aa2822985f12bf2985e683ab553 Gerrit-PatchSet: 9 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

openggsn[master]: libgtp: improve error logging and propagation

2017-05-26 Thread Max
Patch Set 2: Looking at other functions in gtp.c I fail to determine common style. Some functions return 0 on errors, other return -1, yet other return 0 on success but EOF on errors. I can drop this part of the change - it turned out that the error I've been hunting down lies elsewhere so it

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_17.04/i586

2017-05-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/i586 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of b

Build failure of network:osmocom:nightly/libosmocore in Debian_8.0/i586

2017-05-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/i586 Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build lo

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.10/x86_64

2017-05-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.04/i586

2017-05-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of b