Max has submitted this change and it was merged.
Change subject: Move parameter file opening into separate function
..
Move parameter file opening into separate function
* use talloc for file path allocation
* print detailed er
Max has submitted this change and it was merged.
Change subject: lc15bts-mgr: use extended config file example
..
lc15bts-mgr: use extended config file example
Change-Id: I0ef9d00a031b7d7e59150a28a6972c620ff19e92
Related: SYS#3
Patch Set 5: Verified+1
--
To view, visit https://gerrit.osmocom.org/2893
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I840533d5bf9233822bc0534a25c252f1cab0a7b0
Gerrit-PatchSet: 5
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Own
Max has submitted this change and it was merged.
Change subject: Add script for fetching BTS-specific L1 headers
..
Add script for fetching BTS-specific L1 headers
Several of the supported BTS models require hw-specific L1 head
Patch Set 1: Code-Review-1
What's the point of accommodating for compiler bugs? There're too many of those
to change the code for each one of them. The proper fix would be to update
compiler to version which has this bug fixed.
--
To view, visit https://gerrit.osmocom.org/2955
To unsubscribe,
Patch Set 4:
> why not go for python without specifying a version number here?
Good idea - in this case we don't have change debian/control: AFAIK jenkins
buildslaves are not used for making .deb packages anyway and OBS have no
problems with python3.
--
To view, visit https://gerrit.osmocom.
Hello Vadim Yanitskiy, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2901
to look at the new patch set (#3).
Move NUM_BYTES macro to core library
It's universally useful so it make sense to have it in the shared core:
* move ma
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5386ba3e1f1cc153ba96c29dc71c9075a052aa02
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Review at https://gerrit.osmocom.org/2966
core/conv/viterbi.c: drop unused structure member
Change-Id: I81f7c35abf424f501ca53d6984c0d56f7936984b
---
M src/viterbi.c
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/2966/1
di
Review at https://gerrit.osmocom.org/2969
core/conv/viterbi.c: use static allocation for trellis
Allocation of a new memory is an expensive operation, which
takes place when it's initially unknown, how much memory will
we need, or in order to decrease total memory usage.
The trellis struct was
Review at https://gerrit.osmocom.org/2968
core/conv/viterbi.c: use static allocation for vdecoder
Allocation of a new memory is an expensive operation, which
takes place when it's initially unknown, how much memory will
we need, or in order to decrease total memory usage.
The vdecoder struct w
Review at https://gerrit.osmocom.org/2967
core/conv/viterbi.c: delete reset_decoder()
Currently this implementation exposes nothing than
osmo_conv_decode_acc(), so it wasn't possible to call
reset_decoder() from outside.
The method itself was used to initialize accumulated
path metrics and the
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2922
to look at the new patch set (#2).
vty: additional nodes for sccp-address configuration
The planned sccp-addressbook implementation in libosmo-sccp
requires two additiona
Review at https://gerrit.osmocom.org/2970
lc15: use generic L1 headers helper
* use generic L1 headers helper for both sysmocom-dsp and lc15bts-phy
options
* use sh instead of bash
Related: SYS#3683
Change-Id: I3dc621731f47650cbc15a5f17b9e899e9ed2770f
---
M contrib/jenkins.sh
1 file changed,
Review at https://gerrit.osmocom.org/2971
lc15: correct default master branch
Change-Id: I6e86edc34fdb8c7bc57f87c41e05dd2338dd2506
Related: SYS#3683
---
M scripts/osmo-layer1-headers.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/change
Review at https://gerrit.osmocom.org/2972
core/conv: use proper filenames
We already have generic convolutional transcoding implementation
written by Sylvain Munaut and named 'conv.c', so 'viterbi_*' names
looked a bit confusing.
Let's use a single naming scheme for Viterbi related code.
Chan
Review at https://gerrit.osmocom.org/2973
core/conv: update description headers for conv_acc_*
Change-Id: I00154776c8e7d346abcbaf9048ce04d9488bb458
---
M src/conv_acc.c
M src/conv_acc_generic.c
M src/conv_acc_sse.c
M src/conv_acc_sse_avx.c
M src/conv_acc_sse_impl.h
5 files changed, 10 insertion
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2969
to look at the new patch set (#2).
core/conv/conv_acc.c: use static allocation for trellis
Allocation of a new memory is an expensive operation, which
takes place when it's initially un
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2967
to look at the new patch set (#2).
core/conv/conv_acc.c: delete reset_decoder()
Currently this implementation exposes nothing than
osmo_conv_decode_acc(), so it wasn't possible to call
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2968
to look at the new patch set (#2).
core/conv/conv_acc.c: use static allocation for vdecoder
Allocation of a new memory is an expensive operation, which
takes place when it's initially u
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2972
to look at the new patch set (#2).
core/conv: use proper filenames
We already have generic convolutional transcoding implementation
written by Sylvain Munaut and named 'conv.c', so 'vit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2967
to look at the new patch set (#3).
core/conv/conv_acc.c: delete reset_decoder()
Currently this implementation exposes nothing than
osmo_conv_decode_acc(), so it wasn't possible to call
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2968
to look at the new patch set (#3).
core/conv/conv_acc.c: use static allocation for vdecoder
Allocation of a new memory is an expensive operation, which
takes place when it's initially u
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2972
to look at the new patch set (#3).
core/conv: use proper filenames
We already have generic convolutional transcoding implementation
written by Sylvain Munaut and named 'conv.c', so 'vit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2969
to look at the new patch set (#3).
core/conv/conv_acc.c: use static allocation for trellis
Allocation of a new memory is an expensive operation, which
takes place when it's initially un
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2966
to look at the new patch set (#2).
core/conv/conv_acc.c: drop unused structure member
Change-Id: I81f7c35abf424f501ca53d6984c0d56f7936984b
---
M src/conv_acc.c
1 file changed, 0 inserti
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2924
to look at the new patch set (#3).
sccp: add addressbook functionality for sccp addresses
SCCP addresses are defined through a number of compoinents, not
just an IP-Addre
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2894
to look at the new patch set (#8).
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC headers checkout into
shared jenkins helpe
Review at https://gerrit.osmocom.org/2974
Use generic L1 headers helper
Change-Id: I2253df3509595d7393ec6631ef846dbebae73ca4
---
M contrib/jenkins_lc15.sh
M contrib/jenkins_oct.sh
M contrib/jenkins_oct_and_bts_trx.sh
M contrib/jenkins_sysmobts.sh
4 files changed, 9 insertions(+), 55 deletions(-
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2891
to look at the new patch set (#8).
lc15: add jenkins helper
Add jenkins build helper for lc15 and separate header with BTS-agnostic
functions.
Change-Id: I
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2972
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61062a8d1fbf5f5fc85b4fac58dc4e9fa8b5ef90
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2966
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81f7c35abf424f501ca53d6984c0d56f7936984b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 2: Code-Review-1
In general, looks fine to me. Especially, it's very usable.
But if your commit message says: "Add macros ...", it would
be better to only add actual macros to keep it atomic.
The macros integration could be done in a separate one or in
a set of commits (prefered for me
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2924
to look at the new patch set (#4).
sccp: add addressbook functionality for sccp addresses
SCCP addresses are defined through a number of compoinents, not
just an IP-Addre
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2960
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c441b20b250c34656f1e8330d6bb4b1ce2b8423
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 5:
Have this been tested with .deb package building?
--
To view, visit https://gerrit.osmocom.org/2954
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1752cad1e34cb6e5f36edf3f538d803eff29d18c
Gerrit-PatchSet: 5
Gerrit-Project:
Review at https://gerrit.osmocom.org/2975
fix build: viterbi_sse: use AM_CFLAGS, not CFLAGS
This allows passing 'make CFLAGS+="..."' without breaking the build.
Suggested-by: zecke
Change-Id: I0628a9c739cded771605f5c55df7f21cb07beb3b
---
M src/Makefile.am
1 file changed, 4 insertions(+), 4 de
Patch Set 1:
this was built with this patch:
http://jenkins.osmocom.org/jenkins/job/Osmocom_Sanitizer/578/
It's red because of libsccp, but libosmocore worked.
--
To view, visit https://gerrit.osmocom.org/2975
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comm
Patch Set 1:
Afaics the called script isn't available (rebase?, see log):
+ osmo-layer1-headers.sh sysmo
./contrib/jenkins.sh: line 25: osmo-layer1-headers.sh: command not found
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Finishe
Patch Set 1:
Afaics invoked script is not available (rebase?), see log:
+ osmo-layer1-headers.sh sysmo master
./contrib/jenkins_sysmobts.sh: line 14: osmo-layer1-headers.sh: command not
found
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2857
to look at the new patch set (#3).
Add and use macros to set/get/clear/toggle bit flags
We extensively use bit masks and flags but do not have any convenience
wrappers
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2975
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0628a9c739cded771605f5c55df7f21cb07beb3b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2973
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00154776c8e7d346abcbaf9048ce04d9488bb458
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2972
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61062a8d1fbf5f5fc85b4fac58dc4e9fa8b5ef90
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2966
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81f7c35abf424f501ca53d6984c0d56f7936984b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2967
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f17cebf468cf0106927ccee091cfb2896649cb2
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2968
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b140d3cb61db7352dcfc217a8fc36091e945ab
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2969
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e448823ca5548a05a45824b0b1c06743dfe5a4
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/2924/4/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:
Line 1359: "nature-of-address-indicator <0-4294967295>",
where did you see that this could be 32bits? I can only see 7 bits in Q.713
Sec.3.4.2.3.1
--
To view, visit https://gerri
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2922
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42aa29c097f284b85801c5329b015b189640
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5386ba3e1f1cc153ba96c29dc71c9075a052aa02
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Max has submitted this change and it was merged.
Change subject: Move NUM_BYTES macro to core library
..
Move NUM_BYTES macro to core library
It's universally useful so it make sense to have it in the shared core:
* move macro
Patch Set 8:
basically waiting for Neels to voice his opinion on the latest patch and to
decide how to move ahead here.
--
To view, visit https://gerrit.osmocom.org/2891
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47f5a6cc88e784c56
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2820
to look at the new patch set (#4).
gsm0808: fix AoIP speech codec element parser/generator
The implementation of the parser/generator for the speech codec
information ele
Hello Max, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2812
to look at the new patch set (#6).
gsm0408: update bearer capability speech version
3GPP TS 24.008 specifies two new speech versions for half rate and
two new speech
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2936
to look at the new patch set (#2).
cosmetic: remove API documentation strings in header file
Typically we don't place comments with the function declarations
in .h files.
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2937
to look at the new patch set (#2).
cosmetic: Add codec references to Speech Version Indication
Add the information which GSM Speech codec version coresponds to
which bear
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2818
to look at the new patch set (#5).
gsm0808: add speech codec type constants
The codec type to be set in member type in struct gsm0808_speech_codec
has its own coding sche
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2831
to look at the new patch set (#5).
gsm0808: add function gsm0808_extrapolate_speech_codec()
The contents of the speech codec element (struct gsm0808_speech_codec),
that i
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2829
to look at the new patch set (#4).
gsm0808: add default speech codec configuration
In an AoIP scenario, the speech codec list field specifies the
codecs used in the RTP i
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2938
to look at the new patch set (#2).
cosmetic: Add info about corespondig codecs to permitted speech
The constants in enum gsm0808_permitted_speech are not very
expressive.
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2830
to look at the new patch set (#5).
gsm0808: add function to translate perm speech to speech codec type
The permitted speech field used in channel type element (struct
gsm
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2820
to look at the new patch set (#5).
gsm0808: fix AoIP speech codec element parser/generator
The implementation of the parser/generator for the speech codec
information ele
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2818
to look at the new patch set (#6).
gsm0808: add speech codec type constants
The codec type to be set in member type in struct gsm0808_speech_codec
has its own coding sche
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2830
to look at the new patch set (#6).
gsm0808: add function to translate perm speech to speech codec type
The permitted speech field used in channel type element (struct
gsm
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2831
to look at the new patch set (#6).
gsm0808: add function gsm0808_extrapolate_speech_codec()
The contents of the speech codec element (struct gsm0808_speech_codec),
that i
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2938
to look at the new patch set (#3).
cosmetic: Add info about corespondig codecs to permitted speech
The constants in enum gsm0808_permitted_speech are not very
expressive.
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2829
to look at the new patch set (#5).
gsm0808: add default speech codec configuration
In an AoIP scenario, the speech codec list field specifies the
codecs used in the RTP i
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2936
to look at the new patch set (#3).
cosmetic: remove API documentation strings in header file
Typically we don't place comments with the function declarations
in .h files.
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: core/conv/conv_acc.c: delete reset_decoder()
..
core/conv/conv_acc.c: delete reset_decoder()
Currently this implementation exposes nothing than
osmo_c
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: core/conv/conv_acc.c: drop unused structure member
..
core/conv/conv_acc.c: drop unused structure member
Change-Id: I81f7c35abf424f501ca53d6984c0d56f7
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: core/conv/conv_acc.c: use static allocation for trellis
..
core/conv/conv_acc.c: use static allocation for trellis
Allocation of a new memory is an ex
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: core/conv: use proper filenames
..
core/conv: use proper filenames
We already have generic convolutional transcoding implementation
written by Sylvain
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: core/conv: update description headers for conv_acc_*
..
core/conv: update description headers for conv_acc_*
Change-Id: I00154776c8e7d346abcbaf9048ce0
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: core/conv/conv_acc.c: use static allocation for vdecoder
..
core/conv/conv_acc.c: use static allocation for vdecoder
Allocation of a new memory is an
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2924
to look at the new patch set (#5).
sccp: add addressbook functionality for sccp addresses
SCCP addresses are defined through a number of compoinents, not
just an IP-Addre
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2975
to look at the new patch set (#3).
src/Makefile.am: fix build: use AM_CFLAGS, not CFLAGS
This allows passing 'make CFLAGS+="..."'
without breaking the build.
Suggested-by: zecke
Chang
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2975
to look at the new patch set (#2).
core/conv/Makefile.am: fix build: use AM_CFLAGS, not CFLAGS
This allows passing 'make CFLAGS+="..."'
without breaking the build.
Suggested-by: zecke
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2937
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9493fea139420a52c32b17d00ac7d0b2bf86967
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2812
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2835384c855f924332d38f01c73bd1cfdb62549
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2975
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0628a9c739cded771605f5c55df7f21cb07beb3b
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 3: Code-Review+2
yes, gsm0808_utils.c has complete api docs
--
To view, visit https://gerrit.osmocom.org/2936
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c4cb55be5ec59a6945b1720b875c5987f1cfaad
Gerrit-PatchSet: 3
Gerrit-Pr
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2938
to look at the new patch set (#4).
cosmetic: Add info about coresponding codecs to permitted speech consts
The constants in enum gsm0808_permitted_speech are not very expressive.
Add co
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2938
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9734f7c261becffe38ffd41c304d006d08530c1a
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2900
to look at the new patch set (#2).
Fix BTS features length check
While fixing potentially incorrect memory access, the check for maximum
number of supported BTS features
Patch Set 2:
> I think this is something that we can only do in close coordination
> with Nutaq, i.e. if they had some specific reason to not use the
> real path but rather go via the symlink. Minh, can you comment on
> that?
We had issue when using real path to /sys/devices/... when upgradin
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: src/Makefile.am: fix build: use AM_CFLAGS, not CFLAGS
..
src/Makefile.am: fix build: use AM_CFLAGS, not CFLAGS
This allows passing 'make CFLAGS+="..."
Review at https://gerrit.osmocom.org/2976
gitignore some tests
For some reasons, the following test executables
were not listed in .gitignore:
- tests/conv/conv_gsm0503_test
- tests/endian/endian_test
- tests/sercomm/sercomm_test
Change-Id: If85e665d1c2a0b55d23937db5725768cdbf14f58
---
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2831
to look at the new patch set (#7).
gsm0808: add function gsm0808_extrapolate_speech_codec()
The contents of the speech codec element (struct gsm0808_speech_codec),
that i
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2938
to look at the new patch set (#5).
cosmetic: Add info about corespondig codecs to permitted speech
The constants in enum gsm0808_permitted_speech are not very
expressive.
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2939
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22e0099abe601b0c59beee808f7560837c6977dd
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Tom Tsou has submitted this change and it was merged.
Change subject: common: Declare explicit Vector move constructor
..
common: Declare explicit Vector move constructor
Vector class already has a semantically odd non-const co
Tom Tsou has submitted this change and it was merged.
Change subject: sigProcLib: Remove trigonometric tables
..
sigProcLib: Remove trigonometric tables
Trigonometric sin/cos tables are unused after initialization.
There is no
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2941
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45bba5daf8610cbba6af95b92c2142f2256491ff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2942
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a838fe3139fa977dfe906246020a14451185714
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit
Tom Tsou has submitted this change and it was merged.
Change subject: sigProcLib: Use explicit NaN check in sinc table generation
..
sigProcLib: Use explicit NaN check in sinc table generation
Using "x < 0.01" is a crude check
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/2829/6/include/osmocom/gsm/protocol/gsm_08_08.h
File include/osmocom/gsm/protocol/gsm_08_08.h:
Line 459:* Configurations for the Adaptive Multi-Rate Codec Types */
As I said before: move this block up into the main
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2938/5//COMMIT_MSG
Commit Message:
Line 7: cosmetic: Add info about corespondig codecs to permitted speech
by uploading the patch again you overwrote my commit log fixes ... argh! There
isn't even any difference other than t
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2830/7/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 658:* (See also 3GPP TS 48.008, 3.2.2.11 and 3.2.2.103) */
and again, as I said before, you have to move this up and join with the main
API doc comme
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/2830/7/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 651: * \param[in] perm_spch to be converted
define which uint8_t you expect here, e.g. name the enum type
--
To view, visit https://gerrit.osmocom.org/2830
To unsubscri
1 - 100 of 121 matches
Mail list logo
