[ABANDON] libosmocore[master]: core/conv: combine Viterbi implementation into a single dir

2017-06-22 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change. Change subject: core/conv: combine Viterbi implementation into a single dir .. Abandoned -- To view, visit https://gerrit.osmocom.org/2782 To unsubscribe, visit https://gerrit.osmocom

[PATCH] libosmocore[master]: cosmetic: remove API documentation strings in header file

2017-06-22 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2936 to look at the new patch set (#6). cosmetic: remove API documentation strings in header file Typically we don't place comments with the function declarations in .h files.

[PATCH] libosmocore[master]: gsm0808: add function gsm0808_speech_codec_from_chan_type()

2017-06-22 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2831 to look at the new patch set (#9). gsm0808: add function gsm0808_speech_codec_from_chan_type() The contents of the speech codec element (struct gsm0808_speech_codec), tha

[PATCH] libosmocore[master]: gsm0808: add function gsm0808_chan_type_to_speech_code()

2017-06-22 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2830 to look at the new patch set (#9). gsm0808: add function gsm0808_chan_type_to_speech_code() The permitted speech field used in channel type element (struct gsm0808_channe

[PATCH] libosmo-sccp[master]: ss7: Fix compilation error (warning)

2017-06-22 Thread dexter
Review at https://gerrit.osmocom.org/3002 ss7: Fix compilation error (warning) In osmo_ss7_route_create() as is only initalized if lset can not be initalized. If lset can be initalized, as will not be used so everything is fine. However, the compiler complains that as may not be initalized. Ini

libosmocore[master]: lapd_test.c: Convert compilation warning to level message

2017-06-22 Thread Pau Espin Pedrol
Patch Set 2: As requested, I created an issue to track this: https://osmocom.org/issues/2336 -- To view, visit https://gerrit.osmocom.org/2953 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd Gerri

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-22 Thread Pau Espin Pedrol
Patch Set 3: I do think it's useful. At least to me it's clearer when looking at it, and easier to grep if I want to know when a bit it set or cleared or checked. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: co

[PATCH] libosmocore[master]: pseudotalloc: Add simplistic implementation of talloc_asprintf

2017-06-22 Thread Pau Espin Pedrol
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2961 to look at the new patch set (#2). pseudotalloc: Add simplistic implementation of talloc_asprintf fsm.c uses this function. When compiled with --enable-embedded, it trigg

[PATCH] libosmocore[master]: Fix warnings: tolower() and similar require uchar

2017-06-22 Thread Pau Espin Pedrol
Hello Max, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2963 to look at the new patch set (#2). Fix warnings: tolower() and similar require uchar utils.c: In function 'osmo_str2lower': utils.c:277:3: warning: array subscript h

libosmo-abis[master]: osmo_ortp.c: Fix warning: use updated ortp API

2017-06-22 Thread Pau Espin Pedrol
Patch Set 1: Indeed, I was wrong when looking at which ortp release contained the commit fixing the headers. It seems the commit was pushed between 0.22 and 0.24, and thus is available in ortp 0.24, not in 0.22. Debian still used 0.22, but my distro uses 1.0.1, so we have 2 possibilities: 1-

[MERGED] osmo-bts[master]: Copy sysmobts.service to osmo-bts-sysmo

2017-06-22 Thread Max
Max has submitted this change and it was merged. Change subject: Copy sysmobts.service to osmo-bts-sysmo .. Copy sysmobts.service to osmo-bts-sysmo This way the name of systemd service file will match the name of the binary sim

[MERGED] osmo-ci[master]: lc15: correct default master branch

2017-06-22 Thread Max
Max has submitted this change and it was merged. Change subject: lc15: correct default master branch .. lc15: correct default master branch Change-Id: I6e86edc34fdb8c7bc57f87c41e05dd2338dd2506 Related: SYS#3683 --- M scripts/os

osmo-ci[master]: lc15: correct default master branch

2017-06-22 Thread Max
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/2971 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e86edc34fdb8c7bc57f87c41e05dd2338dd2506 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Own

[MERGED] openbsc[master]: Fix BTS features length check

2017-06-22 Thread Max
Max has submitted this change and it was merged. Change subject: Fix BTS features length check .. Fix BTS features length check While fixing potentially incorrect memory access, the check for maximum number of supported BTS fea

[MERGED] osmo-bts[master]: OML: move BTS number check into separate function

2017-06-22 Thread Max
Max has submitted this change and it was merged. Change subject: OML: move BTS number check into separate function .. OML: move BTS number check into separate function * move code which checks for BTS number (obtained via OML)

[MERGED] openbsc[master]: Enable optional static builds

2017-06-22 Thread Max
Max has submitted this change and it was merged. Change subject: Enable optional static builds .. Enable optional static builds * use LT_INIT instead of AC_PROG_RANLIB * remove redundant libbsc entries The default (for both ma

[ABANDON] osmo-bts[master]: lc15: use directory instead of symlink

2017-06-22 Thread Max
Max has abandoned this change. Change subject: lc15: use directory instead of symlink .. Abandoned -- To view, visit https://gerrit.osmocom.org/2935 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType

[PATCH] osmo-bts[master]: Add missing header file

2017-06-22 Thread Max
Review at https://gerrit.osmocom.org/3003 Add missing header file This fixes compilation warning: implicit declaration of function ‘abis_bts_rsl_sendmsg’ Change-Id: I956561b2f953c7d380a26442fad84bc8262ea129 --- M src/common/l1sap.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ss

osmo-bts[master]: Add missing header file

2017-06-22 Thread Max
Patch Set 1: The main purpose of this tiny fix is to serve as a test for jenkins changes for lc15 builds. Feel free to +2 if it's ok it but please don't merge - I'll do it once lc15 jenkins tests are finished. -- To view, visit https://gerrit.osmocom.org/3003 To unsubscribe, visit https://ger

[PATCH] osmo-bts[master]: lc15: make jenkins helper executable

2017-06-22 Thread Max
Review at https://gerrit.osmocom.org/3004 lc15: make jenkins helper executable Change-Id: Icf06040d77180fb9d877ca52e00171b21b634ef8 Related: SYS#3682 --- M contrib/jenkins_lc15.sh 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/0

[PATCH] libosmo-abis[master]: osmo_ortp.c: Fix warning: check ortp API in rtp_session_sign...

2017-06-22 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2990 to look at the new patch set (#2). osmo_ortp.c: Fix warning: check ortp API in rtp_session_signal_connect Since ortp commit 5ab29c50adc7948b11449e3aeee66010379ff7dc preceeding ortp 0.24

[PATCH] osmo-pcu[master]: tests: remove unused definition

2017-06-22 Thread Max
Review at https://gerrit.osmocom.org/3005 tests: remove unused definition Fix compilation warning. Change-Id: I1c95c6ec8bee68773643f9646b0319a83fbc6cfa --- M tests/emu/openbsc_clone.c 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/cha

osmo-bts[master]: Add missing header file

2017-06-22 Thread Max
Patch Set 1: The main purpose of this tiny fix is to serve as a test for jenkins changes for lc15 builds. Feel free to +2 if it's ok it but please don't merge - I'll do it once lc15 jenkins tests are finished. -- To view, visit https://gerrit.osmocom.org/3003 To unsubscribe, visit https://ger

[PATCH] osmo-pcu[master]: lc15: use environment for firmware version

2017-06-22 Thread Max
Review at https://gerrit.osmocom.org/3006 lc15: use environment for firmware version This allows to specify firmware version to use by jenkins builder via environment variable. If environment variable does not exist than default master branch is used. Change-Id: If8b249aa00270e60a0449f089a1682

osmo-pcu[master]: lc15: use environment for firmware version

2017-06-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3006 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b249aa00270e60a0449f089a16823976e54d54 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit

osmo-pcu[master]: tests: remove unused definition

2017-06-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3005 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c95c6ec8bee68773643f9646b0319a83fbc6cfa Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit

[MERGED] osmo-pcu[master]: tests: remove unused definition

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: tests: remove unused definition .. tests: remove unused definition Fix compilation warning. Change-Id: I1c95c6ec8bee68773643f9646b0319a83fbc6cfa --- M t

osmo-bts[master]: Add missing header file

2017-06-22 Thread Harald Welte
Patch Set 1: Code-Review-1 you're not adding a header file, but an #include to a header file. please clarify. -- To view, visit https://gerrit.osmocom.org/3003 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I956561b2f953c7d380a26442fad8

[MERGED] osmo-pcu[master]: lc15: use environment for firmware version

2017-06-22 Thread Max
Max has submitted this change and it was merged. Change subject: lc15: use environment for firmware version .. lc15: use environment for firmware version This allows to specify firmware version to use by jenkins builder via env

[PATCH] osmo-bts[master]: Add missing include for abis.h header file

2017-06-22 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3003 to look at the new patch set (#2). Add missing include for abis.h header file This fixes compilation warning: implicit declaration of function ‘abis_bts_rsl_sendmsg’ Chan

libosmo-abis[master]: osmo_ortp.c: Fix warning: check ortp API in rtp_session_sign...

2017-06-22 Thread Harald Welte
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/2990/2/src/trau/osmo_ortp.c File src/trau/osmo_ortp.c: Line 353: #if HAVE_SIGNAL_CONNECT_PTR_TYPE why not simply hide this in a #define macro to avoid spreasding four copies of this around? Something like RT

libosmo-abis[master]: configure.ac: Use -Werror in C(PP)FLAGS

2017-06-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic674bf28d781b9806dc023777e1fea4ee1a0257a Gerrit-PatchSet: 2 Gerrit-Project: libosmo-abis Gerrit-Branch: master Ge

[MERGED] osmo-bts[master]: lc15: make jenkins helper executable

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: lc15: make jenkins helper executable .. lc15: make jenkins helper executable Change-Id: Icf06040d77180fb9d877ca52e00171b21b634ef8 Related: SYS#3682 --- M

osmo-bts[master]: lc15: make jenkins helper executable

2017-06-22 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3004 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf06040d77180fb9d877ca52e00171b21b634ef8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

libosmocore[master]: Fix warnings: tolower() and similar require uchar

2017-06-22 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2963 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fed2ab6a4efba9f8a21fcf84a5b3a91e8df084f Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: pseudotalloc: Add simplistic implementation of talloc_asprintf

2017-06-22 Thread Harald Welte
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/2961/2/src/pseudotalloc/pseudotalloc.c File src/pseudotalloc/pseudotalloc.c: Line 66: char *talloc_asprintf(const void *ctx, const char *fmt, ...) { coding style -- To view, visit https://gerrit.osmocom.org/2961 To unsubscribe, visit ht

[MERGED] libosmocore[master]: abis_test.c: Fix warning appearing on some buggy gcc versions

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: abis_test.c: Fix warning appearing on some buggy gcc versions .. abis_test.c: Fix warning appearing on some buggy gcc versions Change-Id: I31d5ffc0cf461d

libosmocore[master]: gsm0808: add function gsm0808_speech_codec_from_chan_type()

2017-06-22 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2831 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I257c972e9fdf0dfe940a8d483447085bd62e50a2 Gerrit-PatchSet: 9 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: gsm0808: add function gsm0808_chan_type_to_speech_code()

2017-06-22 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2830 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib26a9c20864459b2baaa04f49b6e7902ba44b7cb Gerrit-PatchSet: 9 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: cosmetic: remove API documentation strings in header file

2017-06-22 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2936 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c4cb55be5ec59a6945b1720b875c5987f1cfaad Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: gsm0808: add function gsm0808_chan_type_to_speech_code()

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0808: add function gsm0808_chan_type_to_speech_code() .. gsm0808: add function gsm0808_chan_type_to_speech_code() The permitted speech field used in c

[MERGED] libosmocore[master]: gsm0808: fix AoIP speech codec element parser/generator

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0808: fix AoIP speech codec element parser/generator .. gsm0808: fix AoIP speech codec element parser/generator The implementation of the parser/gener

[MERGED] libosmocore[master]: cosmetic: remove API documentation strings in header file

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: remove API documentation strings in header file .. cosmetic: remove API documentation strings in header file Typically we don't place comments

[MERGED] libosmocore[master]: gsm0808: add default speech codec configuration

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0808: add default speech codec configuration .. gsm0808: add default speech codec configuration In an AoIP scenario, the speech codec list field speci

[MERGED] libosmocore[master]: gsm0808: add function gsm0808_speech_codec_from_chan_type()

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0808: add function gsm0808_speech_codec_from_chan_type() .. gsm0808: add function gsm0808_speech_codec_from_chan_type() The contents of the speech cod

osmo-bts[master]: Add missing include for abis.h header file

2017-06-22 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3003 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I956561b2f953c7d380a26442fad84bc8262ea129 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

[PATCH] libosmocore[master]: pseudotalloc: Add simplistic implementation of talloc_asprintf

2017-06-22 Thread Pau Espin Pedrol
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2961 to look at the new patch set (#3). pseudotalloc: Add simplistic implementation of talloc_asprintf fsm.c uses this function. When compiled with --enable-embedded, it trigg

[PATCH] libosmo-abis[master]: osmo_ortp.c: Fix warning: check ortp API in rtp_session_sign...

2017-06-22 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2990 to look at the new patch set (#3). osmo_ortp.c: Fix warning: check ortp API in rtp_session_signal_connect Since ortp commit 5ab29c50adc7948b11449e3aeee66010379ff7dc preceeding ortp 0.24

osmo-trx[master]: sigProcLib: Replace dynamically allocated resampling buffers

2017-06-22 Thread Tom Tsou
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2978 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie836982794c10fb1b6334e40592d44b200454846 Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit

[MERGED] osmo-trx[master]: sigProcLib: Replace dynamically allocated resampling buffers

2017-06-22 Thread Tom Tsou
Tom Tsou has submitted this change and it was merged. Change subject: sigProcLib: Replace dynamically allocated resampling buffers .. sigProcLib: Replace dynamically allocated resampling buffers Instead use object allocated STL

osmo-trx[master]: sigProcLib: Specify standard namespace for isnan()

2017-06-22 Thread Tom Tsou
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2977 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49328c43fdd690a4e6a2b2e949411aaf5674ead1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit

[MERGED] osmo-trx[master]: sigProcLib: Specify standard namespace for isnan()

2017-06-22 Thread Tom Tsou
Tom Tsou has submitted this change and it was merged. Change subject: sigProcLib: Specify standard namespace for isnan() .. sigProcLib: Specify standard namespace for isnan() In commit a3dce85f "sigProcLib: Use explicit NaN che

libosmo-abis[master]: osmo_ortp.c: Fix warning: check ortp API in rtp_session_sign...

2017-06-22 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2990 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dbd0498d75160358eca4336850e1a0ad2efdbeb Gerrit-PatchSet: 3 Gerrit-Project: libosmo-abis Gerrit-Branch: master Ge

[MERGED] libosmo-abis[master]: configure.ac: Use -Werror in C(PP)FLAGS

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: configure.ac: Use -Werror in C(PP)FLAGS .. configure.ac: Use -Werror in C(PP)FLAGS Change-Id: Ic674bf28d781b9806dc023777e1fea4ee1a0257a --- M configure.a

[MERGED] libosmocore[master]: osmo-sim-test.c: Remove unused functions

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-sim-test.c: Remove unused functions .. osmo-sim-test.c: Remove unused functions Change-Id: I3060cfee8ece86c4c89a65f93c9f5424df0c410b --- M utils/osm

[MERGED] libosmo-abis[master]: configure.ac: Use -Wall in C(PP)FLAGS

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: configure.ac: Use -Wall in C(PP)FLAGS .. configure.ac: Use -Wall in C(PP)FLAGS Change-Id: I5033387e4a4206f7d34d1db3c6ede9255d199941 --- M configure.ac 1

[MERGED] libosmo-abis[master]: osmo_ortp.c: Fix warning: check ortp API in rtp_session_sign...

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ortp.c: Fix warning: check ortp API in rtp_session_signal_connect .. osmo_ortp.c: Fix warning: check ortp API in rtp_session_signal_connect Since o

[MERGED] libosmocore[master]: pseudotalloc: Add simplistic implementation of talloc_asprintf

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pseudotalloc: Add simplistic implementation of talloc_asprintf .. pseudotalloc: Add simplistic implementation of talloc_asprintf fsm.c uses this function

[MERGED] libosmo-abis[master]: osmo_ortp.c: Fix warning: implicit use of function

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_ortp.c: Fix warning: implicit use of function .. osmo_ortp.c: Fix warning: implicit use of function Explicitly state that we are using an internal A

[MERGED] libosmocore[master]: fsm.c: Fix compilation warning: Use PRIu32 for uint32_t

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fsm.c: Fix compilation warning: Use PRIu32 for uint32_t .. fsm.c: Fix compilation warning: Use PRIu32 for uint32_t Change-Id: I4c441b20b250c34656f1e8330d

libosmocore[master]: pseudotalloc: Add simplistic implementation of talloc_asprintf

2017-06-22 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2961 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61cd83d4c8570af1e452c945ac6f194baf7e6ac4 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: sercomm_test.c: return correctly in main

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sercomm_test.c: return correctly in main .. sercomm_test.c: return correctly in main Change-Id: I57fd3e1bf74ec24dec692710359a1ce00ecde75a --- M tests/ser

[MERGED] libosmocore[master]: timer_gettimeofday.c: Fix implicit use of timeradd

2017-06-22 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: timer_gettimeofday.c: Fix implicit use of timeradd .. timer_gettimeofday.c: Fix implicit use of timeradd timer_gettimeofday.c: In function 'osmo_gettimeo

[PATCH] osmo-bts[master]: lc15: fix jenkins build

2017-06-22 Thread Max
Review at https://gerrit.osmocom.org/3007 lc15: fix jenkins build * use proper fw headers include path * do not quote $PARALLEL_MAKE variable Change-Id: Ib67305ae858ce322f7ea4ac6c6ce5007ce8e7ab9 Related: SYS#3682 --- M contrib/jenkins_lc15.sh 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] osmo-bts[master]: Simplify jenkins build scripts

2017-06-22 Thread Max
Review at https://gerrit.osmocom.org/3008 Simplify jenkins build scripts * move duplicated code into separate functions in jenkins_common.sh * use that function in individual builds Change-Id: I4d09c5f2693b5ac0a4d8f2c840971e13d1ec58cf --- M contrib/jenkins_bts_trx.sh M contrib/jenkins_common.s

libosmocore[master]: configure.ac: Enable -Werror by default

2017-06-22 Thread Neels Hofmeyr
Patch Set 7: Code-Review-1 after discussion in chat, we should not have -Werror on by default, instead add it in the contrib/jenkins script, by means of 'make CFLAGS+="-Werror" CPPFLAGS+="-Werror"' -- To view, visit https://gerrit.osmocom.org/2954 To unsubscribe, visit https://gerrit.osmocom.

[PATCH] libosmo-abis[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3009 Revert "configure.ac: Use -Werror in C(PP)FLAGS" As discussed in chat, -Werror should not be enabled by default. Instead it should be added in our jenkins build scripts. This reverts commit 7d1f53143e8eaeb25bae8979fb80dac57ddbf827. Change-Id: Ied6e21b

libosmo-abis[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Neels Hofmeyr has reverted this change. Change subject: Revert "configure.ac: Use -Werror in C(PP)FLAGS" .. Uploaded patch set 1. -- To view, visit https://gerrit.osmocom.org/3009 To unsubscribe, visit https://gerrit.osmocom.o

libosmo-sccp[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Neels Hofmeyr has reverted this change. Change subject: Revert "configure.ac: Use -Werror in C(PP)FLAGS" .. Uploaded patch set 1. -- To view, visit https://gerrit.osmocom.org/3010 To unsubscribe, visit https://gerrit.osmocom.o

[PATCH] libosmo-sccp[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3010 Revert "configure.ac: Use -Werror in C(PP)FLAGS" As discussed in chat, -Werror should not be enabled by default. Instead it should be added in our jenkins build scripts. This reverts commit fc252ca38427bf77e55fd272a954dfe24f03a719. Change-Id: I92955c2

libosmo-abis[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3009 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied6e21b72b24fcb623fd945ed9560b742a8eedf5 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Ge

libosmo-sccp[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3010 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92955c2f74f9a5c40e80028459100cf5e79a537b Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

[PATCH] libosmo-sccp[master]: cosmetic: drop second ';;'

2017-06-22 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3011 cosmetic: drop second ';;' Change-Id: I861b87e485d94f17e4b4a800c8da865f98633c92 --- M include/osmocom/sigtran/osmo_ss7.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/11/3011/1 diff

[PATCH] libosmo-sccp[master]: add various debug logging to help figure out complex SCCP ro...

2017-06-22 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3012 add various debug logging to help figure out complex SCCP routing Change-Id: Ia3243606d6cad7721f7da7f6caba2caa90ae2bbd --- M src/m3ua.c M src/osmo_ss7.c M src/osmo_ss7_hmrt.c M src/sccp_scoc.c M src/sccp_scrc.c 5 files changed, 32 insertions(+), 2 delet

[PATCH] libosmo-sccp[master]: gen_mtp_transfer_req_xua(): add addr to error log for missin...

2017-06-22 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3013 gen_mtp_transfer_req_xua(): add addr to error log for missing DPC Change-Id: Icfd45bcbecc440b94893db2aca537a162f210abd --- M src/sccp_scrc.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/cha

[PATCH] libosmo-sccp[master]: sccp_user.c: add missing error logging

2017-06-22 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3014 sccp_user.c: add missing error logging Change-Id: I98e400e297f8fa83037a8e74a936e4ecc137099c --- M src/sccp_user.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/14/3014/1 diff --gi

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.04/i586

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586 Package network:osmocom:nightly/libosmocore failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of b

Build failure of network:osmocom:nightly/libosmo-abis in Debian_8.0/x86_64

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_8.0/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_16.04/x86_64

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lin

Build failure of network:osmocom:nightly/libosmo-abis in Debian_9.0/x86_64

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_9.0/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_16.10/i586

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_16.10/i586 Package network:osmocom:nightly/libosmo-abis failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines o

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_16.10/x86_64

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lin

Build failure of network:osmocom:nightly/libosmo-abis in Debian_9.0/i586

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_9.0/i586 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_17.04/x86_64

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lin

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_17.04/i586

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_17.04/i586 Package network:osmocom:nightly/libosmo-abis failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines o

Build failure of network:osmocom:nightly/libosmo-abis in xUbuntu_16.04/i586

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/xUbuntu_16.04/i586 Package network:osmocom:nightly/libosmo-abis failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines o

Build failure of network:osmocom:nightly/libosmo-abis in Debian_8.0/i586

2017-06-22 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_8.0/i586 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build

libosmo-sccp[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3010 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92955c2f74f9a5c40e80028459100cf5e79a537b Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Ge

libosmo-abis[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3009 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied6e21b72b24fcb623fd945ed9560b742a8eedf5 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Ge

[MERGED] libosmo-abis[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Revert "configure.ac: Use -Werror in C(PP)FLAGS" .. Revert "configure.ac: Use -Werror in C(PP)FLAGS" As discussed in chat, -Werror should not be enabled

[MERGED] libosmo-sccp[master]: Revert "configure.ac: Use -Werror in C(PP)FLAGS"

2017-06-22 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Revert "configure.ac: Use -Werror in C(PP)FLAGS" .. Revert "configure.ac: Use -Werror in C(PP)FLAGS" As discussed in chat, -Werror should not be enabled

libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-22 Thread Neels Hofmeyr
Patch Set 2: If I were a user of the HTML API doc, I would expect all data types to be listed and linked... I don't have a strong opinion really since I usually read the source code instead. -- To view, visit https://gerrit.osmocom.org/2979 To unsubscribe, visit https://gerrit.osmocom.org/set

libosmocore[master]: doxygen: linuxlist.h: fix some API doc to use doxygen Qt style

2017-06-22 Thread Neels Hofmeyr
Patch Set 2: ok, we can drop this -- To view, visit https://gerrit.osmocom.org/2984 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ae25c9bc6b7504402e583a6ce77b037083dcb80 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: ma

[PATCH] libosmocore[master]: doxygen: unify use of \file across the board

2017-06-22 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2987 to look at the new patch set (#3). doxygen: unify use of \file across the board Considering the various styles and implications found in the sources, edit scores of files

[PATCH] libosmocore[master]: doxygen: enable AUTOBRIEF, drop \brief

2017-06-22 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2983 to look at the new patch set (#3). doxygen: enable AUTOBRIEF, drop \brief Especially for short descriptions, it is annoying to have to type \brief for every single API doc

[ABANDON] libosmocore[master]: doxygen: linuxlist.h: fix some API doc to use doxygen Qt style

2017-06-22 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: doxygen: linuxlist.h: fix some API doc to use doxygen Qt style .. Abandoned -- To view, visit https://gerrit.osmocom.org/2984 To unsubscribe, visit https://gerrit.osmoco

libosmocore[master]: doxygen: enable AUTOBRIEF, drop \brief

2017-06-22 Thread Neels Hofmeyr
Patch Set 3: Code-Review+2 rebased and removed some more additions of \brief since the previous patch set, so reinstating previous +2. -- To view, visit https://gerrit.osmocom.org/2983 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a

libosmocore[master]: doxygen: unify use of \file across the board

2017-06-22 Thread Neels Hofmeyr
Patch Set 3: Code-Review+2 only rebase merge conflicts solved, reinstating previous +2 -- To view, visit https://gerrit.osmocom.org/2987 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa70e77e90462b5eb2b0457c70fd25275910c72b Gerrit-Patc

osmo-ci[master]: Introduce artifacts holding dependencies to speed up builds.

2017-06-22 Thread Neels Hofmeyr
Patch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/2465/10/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 170: branch_and_rev_of_remote_repo() { > Do you mean branch_and_rev_of{remote,local}_repo when speaking about "... n The comment means: can we have only one branch_and_rev() f

osmo-ci[master]: Use stow for dependency management

2017-06-22 Thread Neels Hofmeyr
Patch Set 3: Code-Review+1 (1 comment) I'd accept this, can someone else also approve please? https://gerrit.osmocom.org/#/c/2691/3/scripts/osmo-build-dep.sh File scripts/osmo-build-dep.sh: Line 54: mkdir -p "$inst/stow" > Yes, it does. ah ok, that explains it. -- To view, visit https://ger

  1   2   >