Patch Set 10: (1 comment)
https://gerrit.osmocom.org/#/c/2465/10/scripts/osmo-build.sh File scripts/osmo-build.sh: Line 170: branch_and_rev_of_remote_repo() { > Do you mean branch_and_rev_of{remote,local}_repo when speaking about "... n The comment means: can we have only one branch_and_rev() function replacing {remote,local}? Do we really need two separate ways to determine them? Fewer implementations means smaller error surface. -- To view, visit https://gerrit.osmocom.org/2465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifee0a2f837d23b19aa5326f810234d5452e47484 Gerrit-PatchSet: 10 Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Owner: André Boddenberg <dr.bl...@gmail.com> Gerrit-Reviewer: André Boddenberg <dr.bl...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
