Review at https://gerrit.osmocom.org/3046
Revert "SCOC: When sending a CORE/CR, SUA SRC_ADDR == CallingPartyAddress"
This reverts commit 5527df78adc08b76df07c4b682263b5bdd6181d4.
I tried some time to figure out what other changes are needed to make this
commit work and fix a confusion, until I
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3012
to look at the new patch set (#2).
add/tweak various logging to help figure out complex routing
Add function osmo_ss7_point_code_print2() to be able to print two point codes
in the same
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3014
to look at the new patch set (#2).
sccp_user.c: add missing error logging
Change-Id: I98e400e297f8fa83037a8e74a936e4ecc137099c
---
M src/sccp_user.c
1 file changed, 12 ins
Patch Set 4:
> we transmit an empty (all-zero) frame of 23 bytes
Why not dummy frame? Is this per some spec?
--
To view, visit https://gerrit.osmocom.org/3032
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd07a3f4a88c38398d3e844333c01
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3030
to look at the new patch set (#2).
fix compiler warning: xua_test: hexdump pointer type
Was recently introduced by a70b4599f63b50c4d654eb9e1b1a099a7c8cdc36.
Change-Id
Patch Set 1:
> It actually fails only for me because
> I build with -Werror locally.
Ah missed this comment. I'll cast precisely then.
--
To view, visit https://gerrit.osmocom.org/3030
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab
Neels Hofmeyr has submitted this change and it was merged.
Change subject: doxygen: gsm: do not exclude include/gsm/protocol/*
..
doxygen: gsm: do not exclude include/gsm/protocol/*
Clear out the EXCLUDE tag to not exclude anyt
Patch Set 5: Code-Review+2
tweaked commit log...
--
To view, visit https://gerrit.osmocom.org/2979
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib569a46f00866bdaa4017f803d85f625ae011316
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Ge
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2979
to look at the new patch set (#5).
doxygen: gsm: do not exclude include/gsm/protocol/*
Clear out the EXCLUDE tag to not exclude anything.
Tried to add API doc to gsm/prot
Patch Set 1:
(7 comments)
This patch came to be as I was hacking around to quickly see which code paths
are being taken, hence I didn't put much thought in the individual log
statements. All the more thanks for the detailed review! Update coming up...
https://gerrit.osmocom.org/#/c/3012/1//CO
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3030/1/tests/xua/xua_test.c
File tests/xua/xua_test.c:
Line 158: printf("%s\n", osmo_hexdump_nospc((void*)gt_in,
sizeof(struct osmo_sccp_gt)));
> It should be casted to const unsigned char *:
"void*" works just as well, it is ac
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/2817/1//COMMIT_MSG
Commit Message:
Line 7: adding dmo support
Not so critical, but it would be great to have a bit
more information about the change and DMO in general here.
https://gerrit.osmocom.org/#/c/2817/1/src/conv_enc_test.c
File
Patch Set 2:
> let's say if osmo-gsm-tester at least doesn't get worse with this.
Did you measured avarage clock jitter before and after this change?
Does this change solve the problem with osmo-gsm-tester?
--
To view, visit https://gerrit.osmocom.org/3037
To unsubscribe, visit https://gerrit.
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b5f934fc3bd00b0467d90029d3053b16594186
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3044
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51aeb17661dfd63ff347f7b2c0d7ffa383ec814c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3043
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac4e57a882e5a31143499c1662d8d8e52320938
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3041
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5031541d4ae4244a62a18acf71139db2874927fa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Patch Set 3:
Clean/good AM_CFLAGS is a nice goal.
@blobb: Does this interfere with how we will save artifacts with your scripts?
--
To view, visit https://gerrit.osmocom.org/2691
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5012419
18 matches
Mail list logo