Patch Set 1: (3 comments)
https://gerrit.osmocom.org/#/c/2817/1//COMMIT_MSG Commit Message: Line 7: adding dmo support Not so critical, but it would be great to have a bit more information about the change and DMO in general here. https://gerrit.osmocom.org/#/c/2817/1/src/conv_enc_test.c File src/conv_enc_test.c: PS1, Line 53: void dp_sap_udata_ind(enum tp_sap_data_type type, const uint8_t *bits, unsigned int len, void *priv) : { : } Why this is empty? Could you please explain, writing a few words comment inside the body, if this function makes sense. Otherwise, it shouldn't be here. https://gerrit.osmocom.org/#/c/2817/1/src/lower_mac/tetra_scramb.c File src/lower_mac/tetra_scramb.c: PS1, Line 34: #define SCRAMB_INIT 3 : #define SCRAMB_ZERO 0 Both already defined in lower_mac/tetra_scramb.h, so we can clean them out. -- To view, visit https://gerrit.osmocom.org/2817 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa5521d7313595384e74dd790a56550755b93fe9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-tetra Gerrit-Branch: laforge/sq5bpf-rebase-20161218 Gerrit-Owner: allesklar2 <jjuerg...@seemoo.tu-darmstadt.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
