Review at https://gerrit.osmocom.org/3152
sgsn: Add charging characteristics to GSUP
Reserve a new IE for the charging characteristics. We need to handle
them as a GGSN might otherwise reject the PDP context creation. For
the SGSN it is enough to send the two octets as it.
Pick the 0x1X range
Review at https://gerrit.osmocom.org/3151
sgsn: Fix numbering of QoS and add basic description for APN
QoS was supposed to be 13 as 12 has been used for the APN. Fix that
and document the APN.
Change-Id: Ib6113aa7c59841aada424e2cafd94ed88c7badc7
---
M OsmoSGSN/chapters/gsup.adoc
1 file changed
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/3103/3/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:
Line 1635: {
problem: this function osmo_ss7_vty_init_addr() cannot be called independently:
it depends on the L_CS7_NODE to be installed first. The other functions of the
Neels Hofmeyr has submitted this change and it was merged.
Change subject: simple-client/server: be able to decide on which ss7 instance
to bind
..
simple-client/server: be able to decide on which ss7 instance to bind
osmo_scc
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3104
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e608253212415bddbb4c7dcf5d3b5e79c8d28e
Gerrit-PatchSet: 4
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Ge
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3149
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ca3dd1c115fc6784e4dc26a5ff5bf35d65b4e22
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib: Disable doxygen doc generation
..
contrib: Disable doxygen doc generation
The --disable-doxygen was recently added to libosmocore and
libosmo-n
Patch Set 2:
(2 comments)
So a -1 from me.
https://gerrit.osmocom.org/#/c/3079/2/debian/control
File debian/control:
Line 8
yes
Line 22: Depends: ${shlibs:Depends}, ${misc:Depends}, libsqlite3-0
That is wrong. ${shlibs:Depends} will add dependencies for all libraries linked
against.. e.g. t
Review at https://gerrit.osmocom.org/3150
Move DL scheduling and RTS handler to trx level
Use TRX object directly instead of BTS singleton and trx_no.
Change-Id: Ia176245647c19fa1551fb6f5c8225b2529f73cbf
Related: OS#1541
---
M src/gprs_rlcmac.h
M src/gprs_rlcmac_sched.cpp
M src/pcu_l1_if.cpp
M
Review at https://gerrit.osmocom.org/3149
contrib: Disable doxygen doc generation
The --disable-doxygen was recently added to libosmocore and
libosmo-netif. No need to manually remove documentation anymore.
Change-Id: I3ca3dd1c115fc6784e4dc26a5ff5bf35d65b4e22
---
M contrib/jenkins-build-common
Patch Set 10:
Deprecation patch is available in #3148 , please also commet in OS#71 to make
sure we're on the same page with regards to deprecation/replacement.
--
To view, visit https://gerrit.osmocom.org/1582
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comm
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3144
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16294df6d5bc0065f8d2b49320ead61f535f271
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Review at https://gerrit.osmocom.org/3148
Ignore broken everything log level
Change-Id: I73d5c4f238beb88981ad25caa69f64ad6fb7209f
Related: OS#71
---
M src/vty/logging_vty.c
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/31
Review at https://gerrit.osmocom.org/3147
Deprecate wrappers around loglevel_strs
Add deprecation notice for public API use: it shouldn't be used outside
of libosmocore anyway.
Change-Id: I792e30dc44f027fd94e1f65af19fe08bac52b95c
Related: OS#71
---
M include/osmocom/core/logging.h
1 file chang
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3127
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8739b6e329ab02c0064270d02ad1d6ee245520d
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Patch Set 3:
It can now be reviewed.
--
To view, visit https://gerrit.osmocom.org/3129
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c0c325fee14143deca8310312fc530cd9ce92e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Bra
Review at https://gerrit.osmocom.org/3146
aoip_smpp: Disable check in esme_ms_sms_storeforward due to known issue
A test case checked in that test is known to be failing at the moment
due to missing correct implementation bits for AoIP software.
Comment it in a separate commit so that is easy
Patch Set 1:
Some compilation warnings ned to be fixed for BSD/clang before this one can be
merged.
--
To view, visit https://gerrit.osmocom.org/3138
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I065b18dd6c4f7616f981aa4273e68e23825a72
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3129
to look at the new patch set (#3).
Improve SMPP supported features and test coverage
esme: Add several bits to handle logic required by tests:
- Allow specifying the mode used to send a
Patch Set 1:
Some compilation warnings ned to be fixed for BSD/clang before this one can be
merged.
--
To view, visit https://gerrit.osmocom.org/3140
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I045536c21d7a0fa2fc23258c727d67bedf176e
Review at https://gerrit.osmocom.org/3145
Remove currently broken everything logging option
Change-Id: I52e370d59274e29502cd23690f0d5c73aa3a4cc7
Related: OS#71
---
M common/chapters/vty.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manua
Neels Hofmeyr has submitted this change and it was merged.
Change subject: set RANAP msgb headroom to 512 (times two)
..
set RANAP msgb headroom to 512 (times two)
With a headroom of 256, the SGSN crashes with:
msgb(0x6e3b90
Patch Set 1:
Do you see my updated code or do I have to push a button somewhere?
--
To view, visit https://gerrit.osmocom.org/2817
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa5521d7313595384e74dd790a56550755b93fe9
Gerrit-PatchSet:
Patch Set 1:
(1 comment)
> onee question though: This is submitted for the sq5bpf-rebase
> branch (which was basically just a quick test by me some time ago),
> but should actually go in master, or is there any specific
> dependency? If so, please explain.
There is no special dependency. I
Neels Hofmeyr has submitted this change and it was merged.
Change subject: rua_to_scu(): add debug log for calling/called addr
..
rua_to_scu(): add debug log for calling/called addr
This might help in resolving whether we are c
Neels Hofmeyr has submitted this change and it was merged.
Change subject: rua_to_scu(), rua_rx_init_connect(): add debug logging
..
rua_to_scu(), rua_rx_init_connect(): add debug logging
In rua_to_scu(), log domain indicator a
Neels Hofmeyr has submitted this change and it was merged.
Change subject: migrate osmo-hnbgw to libosmo-sigtran's SCCP/M3UA
..
migrate osmo-hnbgw to libosmo-sigtran's SCCP/M3UA
libosmo-sigtran now has a "proper" SCCP/M3UA stac
Neels Hofmeyr has submitted this change and it was merged.
Change subject: sccp_sap_up(): guard against NULL pointers
..
sccp_sap_up(): guard against NULL pointers
Change-Id: Icd64b92b00461cace5c476c8bcf69eec3fdbbdd3
---
M src/
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: move callers' common switch() into rua_to_scu()
..
cosmetic: move callers' common switch() into rua_to_scu()
Change-Id: If6274e3738dc04646d0dc
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3130
to look at the new patch set (#7).
Add release target to Makefile
Add simple helper target to automate basic release steps:
* version bump
* prepare release commit
* git commit, tag and
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: configure.ac: Add --disable-doxygen flag
..
configure.ac: Add --disable-doxygen flag
This flag, when set, allows to unconditionally disable doxygen
d
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3141/1/configure.ac
File configure.ac:
Line 69: AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test
"x$doxygen" = "xyes")
> could also use the and operator of 'test':
I could, I already checked. From "man test":
NOTE: Bina
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: configure.ac: Add --disable-doxygen flag
..
configure.ac: Add --disable-doxygen flag
This flag, when set, allows to unconditionally disable doxygen
d
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3127
to look at the new patch set (#4).
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no subsc
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3126
to look at the new patch set (#4).
smpp: fix return cause
Return cause 38 when default SMPP route is unavailable. This
is better than cause 1.
Change-Id: If3241d50a78fa611981e55fef6ae4
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3128
to look at the new patch set (#4).
04.08: find a portable way to obtain the timezone offset
Portable GMT offset calculation to display correct
time on GSM.
Change-Id: I673f17af2550c970
Patch Set 1:
i.e. there is a group that is given realtime priority permissions, which the
jenkins user is a member of.
--
To view, visit https://gerrit.osmocom.org/3080
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2452b9763960b2be37
Patch Set 1:
on osmo-gsm-tester we use /etc/security/limits.d as documented in
http://ftp.osmocom.org/docs/latest/osmo-gsm-tester-manual.pdf in 3.3.2
Allow Realtime Priority
--
To view, visit https://gerrit.osmocom.org/3080
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Mess
Review at https://gerrit.osmocom.org/3144
smpp_smsc.c: Log on sending deliver_sm message
Change-Id: Ie16294df6d5bc0065f8d2b49320ead61f535f271
---
M openbsc/src/libmsc/smpp_smsc.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/44/
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16b3502be3e32274f548da6a2a0b0363dd3bfe5d
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
G
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/3141/1/configure.ac
File configure.ac:
Line 69: AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false && test
"x$doxygen" = "xyes")
could also use the and operator of 'test':
test $DOXYGEN != false -a "x$doxygen" = "xyes"
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3140
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I045536c21d7a0fa2fc23258c727d67bedf176ece
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
G
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3141
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba1440292116af27b267c7a1fbec1c2336784efe
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Review at https://gerrit.osmocom.org/3143
Use release helper from libosmocore
Change-Id: Ib8efd2095fcf759276299b516d495219105c1f2b
Related: OS#1861
---
M Makefile.am
M configure.ac
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3130
to look at the new patch set (#6).
Add release target to Makefile
Add simple helper target to automate basic release steps:
* version bump
* prepare release commit
* git commit, tag and
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3130
to look at the new patch set (#5).
Add release target to Makefile
Add simple helper target to automate following release steps:
* cleanup TODO-RELEASE
* update debian/changelog
* git co
Review at https://gerrit.osmocom.org/3141
configure.ac: Add --disable-doxygen flag
This flag, when set, allows to unconditionally disable doxygen
documentation generation, even if doxygen command is found.
Change-Id: Iba1440292116af27b267c7a1fbec1c2336784efe
---
M configure.ac
1 file changed,
Review at https://gerrit.osmocom.org/3142
configure.ac: Add --disable-doxygen flag
This flag, when set, allows to unconditionally disable doxygen
documentation generation, even if doxygen command is found.
Change-Id: I16b3502be3e32274f548da6a2a0b0363dd3bfe5d
---
M configure.ac
1 file changed,
Review at https://gerrit.osmocom.org/3139
configure.ac: Use -Wall in C(PP)FLAGS
Change-Id: Ia1d7e99541089a92e6bc17798a94ac756047aeba
---
M configure.ac
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/39/3139/1
diff --git a/
Review at https://gerrit.osmocom.org/3140
contrib: Enable -Werror by default
Change-Id: I045536c21d7a0fa2fc23258c727d67bedf176ece
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/40/3140/1
diff --git a
Review at https://gerrit.osmocom.org/3137
configure.ac: Fix C(PP)FLAGS for BSD build
Issue first found in libosmocore. It seems the BSD build doesn't use
bash which means using += to append to a variable doesn't work
correctly.
Change-Id: Id509351104bc7466114d4b9be450814254110f44
---
M configu
Review at https://gerrit.osmocom.org/3138
contrib: Enable -Werror by default
Change-Id: I065b18dd6c4f7616f981aa4273e68e23825a7294
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/38/3138/1
diff --git a/
Review at https://gerrit.osmocom.org/3136
contrib: Enable -Werror by default
Change-Id: I16a8ca7f0bfabeed6a9b58cda5e60bd58889f74d
---
M configure.ac
M contrib/jenkins.sh
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/36/313
Patch Set 1:
Does osmo-gsm-tester use sudo to run osmo-trx?
--
To view, visit https://gerrit.osmocom.org/3080
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2452b9763960b2be37fbeee9d832554da68a53f
Gerrit-PatchSet: 1
Gerrit-Project: osm
Max has submitted this change and it was merged.
Change subject: deb: remove unused dependency
..
deb: remove unused dependency
The libdbd dependency is not used because libsqlite3 is used directly -
adjust debian/control to ma
55 matches
Mail list logo