Patch Set 1:

(1 comment)

> onee question though: This is submitted for the sq5bpf-rebase
 > branch (which was basically just a quick test by me some time ago),
 > but should actually go in master, or is there any specific
 > dependency?  If so, please explain.

There is no special dependency. I just stated developing on the 
sq5bpf-rebase-branch for other reasons. Now I decided to first commit my code 
here and wait for feedback. I through it would end in a mess if I start 
committing the same stuff in two branches.

https://gerrit.osmocom.org/#/c/2817/1/src/conv_enc_test.c
File src/conv_enc_test.c:

PS1, Line 53: void dp_sap_udata_ind(enum tp_sap_data_type type, const uint8_t 
*bits, unsigned int len, void *priv)
            : {
            : }
> Why this is empty?
I have not figured out why yet, but without this function I get some error 
during the compilation.


-- 
To view, visit https://gerrit.osmocom.org/2817
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa5521d7313595384e74dd790a56550755b93fe9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-tetra
Gerrit-Branch: laforge/sq5bpf-rebase-20161218
Gerrit-Owner: allesklar2 <jjuerg...@seemoo.tu-darmstadt.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: allesklar2 <jjuerg...@seemoo.tu-darmstadt.de>
Gerrit-HasComments: Yes

Reply via email to