Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4087/1/recipes-osmocom/openggsn/openggsn_git.bb
File recipes-osmocom/openggsn/openggsn_git.bb:
Line 1: DESCRITOPN = "OpenGGSN a Free Software GGSN"
DECROPITION ... and why bother to modify openggsn when we have osmo-ggsn?
--
To view,
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/4087/1/recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb
File recipes-osmocom/libosmo-sccp/libosmo-sccp_git.bb:
Line 7:
erm, wasn't the EXTRA_OECONF_remove just added in the preceding patch? Does it
make sense to squash
Patch Set 1: Code-Review+1
can't claim to understand
--
To view, visit https://gerrit.osmocom.org/4088
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80eea9ac888ab4b13614ff475bebacb94b72b0f2
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 1:
(1 comment)
why do we still have an openggsn? Does this one precede or follow the osmo-ggsn
patch?
https://gerrit.osmocom.org/#/c/4089/1/recipes-osmocom/openggsn/openggsn_git.bb
File recipes-osmocom/openggsn/openggsn_git.bb:
Line 1: DESCRITOPN = "OpenGGSN a Free Software GGSN"
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/4089
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib45238e95156f215412d51d975b1acb33633a3e1
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 1: Code-Review+1
(I don't understand but looks like you do)
--
To view, visit https://gerrit.osmocom.org/4090
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f27661d9e5241efe7725b7d1efcf4aef55e2efe
Gerrit-PatchSet: 1
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4091
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id82a12bbfb72b421c75140072048a963fb50f684
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 1:
(2 comments)
errors unrelated to this patch...
https://gerrit.osmocom.org/#/c/4091/1/recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
File recipes-osmocom/libosmo-sccp/libosmo-sccp.inc:
Line 1: DESCRITOPN = "An utility library for Open Source Mobile Communications"
DESCROMNOMNOM
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/4092/1/recipes-osmocom/openbsc/openbsc.inc
File recipes-osmocom/openbsc/openbsc.inc:
Line 3: HOMEPAGE = "http://openbsc.osmocom.org/;
Link to OsmoGGSN project page?
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4093/1/recipes-osmocom/libasn1c/libasn1c.inc
File recipes-osmocom/libasn1c/libasn1c.inc:
Line 1: SUMMARY = "Rruntime library of Lev Walkin's asn1c split out as separate
library"
untime! arriva!!
--
To view, visit
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/4095/1/recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
File recipes-osmocom/osmo-sgsn/osmo-sgsn.inc:
Line 2: HOMEPAGE = "https://osmocom.org/;
link to OsmoSGSN project page?
Line 25: PACKAGES =+ "osmo-gbproxy-doc osmo-gtphub-doc
Patch Set 1: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/4096/1/recipes-osmocom/osmo-mgw/osmo-mgw.inc
File recipes-osmocom/osmo-mgw/osmo-mgw.inc:
Line 2: HOMEPAGE = "https://osmocom.org/;
link to OsmoMGW project page?
Line 19:install -m 0644
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/4097/1/recipes-osmocom/osmo-hlr/osmo-hlr.inc
File recipes-osmocom/osmo-hlr/osmo-hlr.inc:
Line 2: HOMEPAGE = "https://osmocom.org/;
link to OsmoHLR project page?
Line 12: RDEPENDS_${PN} = "libdbd-sqlite3"
we should not
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/4098/1/recipes-osmocom/osmo-msc/osmo-msc.inc
File recipes-osmocom/osmo-msc/osmo-msc.inc:
Line 2: HOMEPAGE = "https://osmocom.org/;
link to OsmoMSC project page?
--
To view, visit https://gerrit.osmocom.org/4098
To
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4101/1/recipes-osmocom/osmo-msc/osmo-msc.inc
File recipes-osmocom/osmo-msc/osmo-msc.inc:
Line 2: HOMEPAGE = "https://osmocom.org/;
link to msc project page?
--
To view, visit https://gerrit.osmocom.org/4101
To unsubscribe, visit
Patch Set 1: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/4100/1/recipes-osmocom/openbsc/openbsc.inc
File recipes-osmocom/openbsc/openbsc.inc:
Line 10: file://osmo-bsc_mgcp.init \
shouln't osmo-bsc_mgcp come from osmo-mgw.git now?
Line 12:
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4101/1//COMMIT_MSG
Commit Message:
Line 7: osmo-msc: Avoid installed duplicated binaries in osmo-bsc
please name the binaries that are removed
--
To view, visit https://gerrit.osmocom.org/4101
To unsubscribe, visit
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins.sh: fix echo string to say osmo-sgsn, not msc
..
jenkins.sh: fix echo string to say osmo-sgsn, not msc
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4079
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e9a1503de55e939179c032c17df53d27b51
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/4106
doxygen: adjust copyright to include 2017
Change-Id: If7c09a676f67da15454aedcda99d0e9b301c9945
---
M src/application.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/4106/1
diff
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add basic CTRL interface tests
..
add basic CTRL interface tests
Prepare for adding tests of enable-/disable-/status-ps CTRL commands.
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add CTRL tests for enable-/disable-/status-ps
..
add CTRL tests for enable-/disable-/status-ps
Change-Id: I014437db9c0f15d818e04810f6cb14bf475ee002
---
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4064
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I014437db9c0f15d818e04810f6cb14bf475ee002
Gerrit-PatchSet: 3
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie195169c574716b514da7e04a3ce9727ef70a55e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4063
to look at the new patch set (#3).
add basic CTRL interface tests
Prepare for adding tests of enable-/disable-/status-ps CTRL commands.
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4064
to look at the new patch set (#3).
add CTRL tests for enable-/disable-/status-ps
Change-Id: I014437db9c0f15d818e04810f6cb14bf475ee002
---
M tests/ctrl_test_runner.py
A
Patch Set 1: Code-Review+1
> Build Started http://jenkins.osmocom.org/jenkins/job/osmo-msc-gerrit/368/
--
To view, visit https://gerrit.osmocom.org/4077
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4092
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6018ef78ff18f2e6809fee957c9d645e35c7c9a
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4095
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7e35660598bfd87917728c521c1fba827e98d68
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 2: Code-Review-2
external tests should be added to the jenkins.sh configure
--
To view, visit https://gerrit.osmocom.org/4063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie195169c574716b514da7e04a3ce9727ef70a55e
Review at https://gerrit.osmocom.org/4102
tweak common/mncc.adoc: use variable for program name
Change-Id: I993a3c3bf617b9823f49898364b5f728a4549330
---
M OsmoNITB/osmonitb-usermanual.adoc
M common/chapters/mncc.adoc
2 files changed, 32 insertions(+), 34 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4104
move smpp.adoc to common chapters
It will soon be referenced by OsmoMSC as well.
Change-Id: I15febdea6569316dad3eed5f9dc7158adb5b078c
---
M OsmoNITB/osmonitb-usermanual.adoc
R common/chapters/smpp.adoc
2 files changed, 8 insertions(+), 5 deletions(-)
Review at https://gerrit.osmocom.org/4103
mncc.adoc: clarify MNCC_BRIDGE, with future outlook
Change-Id: Ic71a83d71f2da87e1066fcc060b2b942643eddbc
---
M common/chapters/mncc.adoc
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/4105
mncc: not 'TCHF', rather 'TCH'
Change-Id: I0edf1763122f182c66ad4c7155ddd4bea0c1d608
---
M common/chapters/mncc.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/05/4105/1
Review at https://gerrit.osmocom.org/4095
osmo-sgsn: Introduce recipe
Change-Id: Ia7e35660598bfd87917728c521c1fba827e98d68
---
A recipes-osmocom/osmo-sgsn/osmo-sgsn.inc
A recipes-osmocom/osmo-sgsn/osmo-sgsn_git.bb
2 files changed, 48 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4087
Update osmocom versions to point to current master
New versions are required in order to build new git repositories which
will deprecate osmo-nitb soon.
Change-Id: If36b86a6a542af7381d9a07da51a330f2e44a96f
---
M
Review at https://gerrit.osmocom.org/4092
Drop openggsn and introduce osmo-ggsn
Take the opportunity to enable systemd service instead of sysvint like other
osmocom
services already do.
Change-Id: Ie6018ef78ff18f2e6809fee957c9d645e35c7c9a
---
M recipes-osmocom/openbsc/openbsc.inc
D
Review at https://gerrit.osmocom.org/4096
osmo-mgw: Introduce recipe
Change-Id: If9c2d6b5dd8dfd8a0b462d87e93e0733e57f7b0a
---
A recipes-osmocom/osmo-mgw/osmo-mgw.inc
A recipes-osmocom/osmo-mgw/osmo-mgw_git.bb
2 files changed, 29 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4091
libosmo-sccp: Install cfg and service file for osmo-stp
Patch with systemd service file is added while waiting to have it merged
in upstream.
Change-Id: Id82a12bbfb72b421c75140072048a963fb50f684
---
M recipes-osmocom/libosmo-sccp/libosmo-sccp.inc
M
Review at https://gerrit.osmocom.org/4097
osmo-hlr: Introduce recipe
Change-Id: Ie7f47dca8d7e5e50792104ae0c7cb557391542f7
---
A recipes-osmocom/osmo-hlr/osmo-hlr.inc
A recipes-osmocom/osmo-hlr/osmo-hlr_git.bb
2 files changed, 35 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4100
openbsc: Drop packages present in other recipes after split
The osmo-bsc one is renamed to osmo-bsc-sccplite and kept because the
code in the new osmo-bsc repository still doesn't support SCCPLite, this
this one can still be used by installing the
Review at https://gerrit.osmocom.org/4093
libasn1c: Introduce recipe
Change-Id: I50d990b06c56c3bfa71e7268694702300c0c9a26
---
A recipes-osmocom/libasn1c/libasn1c.inc
A recipes-osmocom/libasn1c/libasn1c_git.bb
2 files changed, 17 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4098
osmo-msc: Introduce recipe
Change-Id: I68715d1970fde83fd6647344b82c6a859404ef9e
---
A recipes-osmocom/osmo-msc/osmo-msc.inc
A recipes-osmocom/osmo-msc/osmo-msc_git.bb
2 files changed, 31 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4094
osmo-iuh: Introduce recipe
Change-Id: I33d6dccad2336b83f4b4e89769b0796d1c87ed94
---
A recipes-osmocom/osmo-iuh/osmo-iuh.inc
A recipes-osmocom/osmo-iuh/osmo-iuh_git.bb
2 files changed, 27 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4090
libosmo-abis: modify PV to match recent release
The upstream release commit is 7f17b8c45d094941292036143f3292a1d5789cf5.
This should fix current issue with 201705/nightly package feed:
$ opkg upgrade
Not selecting libosmo-abis 0.3.2+gitr0+d3292913ac
Review at https://gerrit.osmocom.org/4099
osmo-bsc: Introduce recipe
Change-Id: I06c529c01a72e16aa20a2c7a20e8b043718edab3
---
A recipes-osmocom/osmo-bsc/osmo-bsc.inc
A recipes-osmocom/osmo-bsc/osmo-bsc_git.bb
2 files changed, 44 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4101
osmo-msc: Avoid installed duplicated binaries in osmo-bsc
Those two binaries are currently being installed by osmo-bsc too.
Change-Id: Ic582450f1881373785f12714ffa3bd150d37417e
---
M recipes-osmocom/osmo-msc/osmo-msc.inc
1 file changed, 5
Review at https://gerrit.osmocom.org/4088
libosmo-sccp: Attempt to fix link issue on 201705-nightly builds
This project will build some static libraries needed for testing
and also for downstream users. Do not disable the static build on
newer Poky versions.
arm-poky-linux-gnueabi-libtool:
Review at https://gerrit.osmocom.org/4089
update PV versions for libosmocore, libosmo-sccp and openggsn
As we're building git master, we need to make sure PV is not lagging
behind. I wish there was some OE magic by which it could discover
PV from the source it builds.
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib: osmo-ggsn.service: Use expected suffix for cfg file
..
contrib: osmo-ggsn.service: Use expected suffix for cfg file
files in doc/examples/ dir
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4075
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c67809d095dd08b0f400de2a6f84f981411c5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3807
to look at the new patch set (#10).
Simplify TS alloc: adjust allocator signatures
* drop unused parameters (from both functions and structs)
* document used parameters
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3935
to look at the new patch set (#4).
Simplify TS alloc: move slot check into functions
Move timeslot applicability check outside of nested for loop into
separate functions and document
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#6).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note: the
Review at https://gerrit.osmocom.org/4085
Simplify TS alloc: avoid TS reassignment
Assign reserved_*_slots only when multislot masks are found to avoid
reassignment and make code easier to follow.
Change-Id: I9b0482f4ea75ead9855cd78e33c8e70d0ccf4484
Related: OS#2282
---
M
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3920
to look at the new patch set (#5).
Simplify TS alloc: use defines for constants
* define and use constant for occupied TFI instead copying the same
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3760
to look at the new patch set (#17).
Simplify TS alloc: internalize TRX check
Move TRX check inside local tfi_find_free() wrapper to make main
algorithm easier to follow.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3913
to look at the new patch set (#6).
Simplify TS alloc: split off RX mask computation
Move computation of RX mask into separate function and document it. This
allows to significantly
Review at https://gerrit.osmocom.org/4086
Simplify TS alloc: improve readability
* consistently format log messages to make it possible to grep for test
output in source code
* remove dead code
Change-Id: I31600462e48d945bc8b7abf86a3718ac83e1dcbb
Related: OS#2282
---
M
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3905
to look at the new patch set (#8).
Simplify TS alloc: move slot assignment
Move into separate functions:
* move timeslot reservation
* move UL timeslot
Hello André Boddenberg,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4056
to look at the new patch set (#3).
Use new GPRS repositories
* use coverity check on osmo-ggsn instead of openggsn
* move osmo-sgsn and osmo-ggsn from nightly-split into nightly
Max has abandoned this change.
Change subject: SGSN: log IMSI on PDP context creation/deletion
..
Abandoned
Superseded by #4073.
--
To view, visit https://gerrit.osmocom.org/3575
To unsubscribe, visit
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins: use osmo-ggsn for tests
..
jenkins: use osmo-ggsn for tests
Change-Id: I62b29b5531bfb9895318254c41a4e24ba1078fbf
---
M contrib/jenkins.sh
1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4080
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62b29b5531bfb9895318254c41a4e24ba1078fbf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/4080
jenkins: use osmo-ggsn for tests
Change-Id: I62b29b5531bfb9895318254c41a4e24ba1078fbf
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/80/4080/1
diff --git
Review at https://gerrit.osmocom.org/4079
jenkins.sh: fix echo string to say osmo-sgsn, not msc
Change-Id: I3e9a1503de55e939179c032c17df53d27b51
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4076
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic67ca94b27a4f36ba1bf655b4cd1c7e78fd06ab8
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4075
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I361c67809d095dd08b0f400de2a6f84f981411c5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
68 matches
Mail list logo
