Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4227/1//COMMIT_MSG
Commit Message:
Line 14: id is supplied with the DLCX command.
> is a missing call id compliant with MGCP?
Yes, it seems explicitly permitted to offer wild-carding.
See RFC3435 Section F.7
> In the second example, the
Patch Set 1:
(9 comments)
https://gerrit.osmocom.org/#/c/4150/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 583: self.log('Dial returned already existing call!')
> is it an error when the call object is already known? The log has an exclam
It c
Patch Set 1:
(9 comments)
https://gerrit.osmocom.org/#/c/4151/1/suites/aoip_debug/interactive.py
File suites/aoip_debug/interactive.py:
Line 26: cmd = prompt('Enter command: (q)uit (s)ms (g)et-registered
(w)ait-registered, call-list [], call-dial
, call-answer , call-hangup
')
> that pr
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4200
to look at the new patch set (#3).
add function msgb_printf() to print formatted text into msg buf
In ASCII string based protocols it a printf() version that prints
directly to the
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4200
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15e1af68616309555d0ed9ac5da027c9833d42e3
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Review at https://gerrit.osmocom.org/4231
Remove pkg-config file
It's an artefact of split which is unused anyway.
Change-Id: I15c0b4457c108c7791b0f30b79660d9e6d09b269
---
M Makefile.am
D osmo-msc.pc.in
2 files changed, 0 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:294
Review at https://gerrit.osmocom.org/4232
Fix race condition in attribute reporting
Previously it could be possible that the attribute request comes from
BSC before the TRX is properly initialized which would lead to SIGABRT
caused by OSMO_ASSERT() in PHY instantiation. Workaround this by
expli
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4231
to look at the new patch set (#2).
osmo-msc: remove pkg-config file
It's an artefact of split which is unused anyway.
Change-Id: I15c0b4457c108c7791b0f30b79660d9e6d09b269
---
M Makefil
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4231
to look at the new patch set (#3).
Remove pkg-config file
It's an artefact of split which is unused anyway.
Change-Id: I15c0b4457c108c7791b0f30b79660d9e6d09b269
---
M Makefile.am
M con
Patch Set 3: Code-Review-2
The cost of these clean-ups just seems to be too high. The commit message
should be "better", it required two tries on CI?
And most of it all.. is... it is wrong. osmo-msc _does_ install header files.
http://git.osmocom.org/osmo-msc/tree/include/osmocom/msc/Makefile.
Patch Set 1: Code-Review+1
(3 comments)
https://gerrit.osmocom.org/#/c/4232/1//COMMIT_MSG
Commit Message:
Line 21: it anyway.
It is good to show these reflections. What would need to happen to make this
work properly? E.g. the TRX gets an OPSTART and we should be able to delay the
ack until t
Patch Set 2:
(2 comments)
> tests/alloc/AllocTest.cpp requires updates to use/test the new classes as
> well.
^^^ Is this addressed?
https://gerrit.osmocom.org/#/c/4072/2//COMMIT_MSG
Commit Message:
Line 15: yet - this can be extended once we have such devices to test it.
How would you suppo
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4232/1/src/common/oml.c
File src/common/oml.c:
Line 212: bool processed;
> you can move that into the scope of the for loop
Hmm, I thought the style was to always put it in the beginning of the function.
What's the general rule?
-
Hello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4232
to look at the new patch set (#2).
Fix race condition in attribute reporting
Previously it could be possible that the attribute request comes from
BSC before the TRX is
Patch Set 2:
> Is this addressed?
Not yet - as I've said in the comment above, I'll get back to it in next
version. The current revision was published to split formatting changes from
new classes as per your feedback.
--
To view, visit https://gerrit.osmocom.org/4072
To unsubscribe, visit ht
Hello Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4231
to look at the new patch set (#4).
Remove pkg-config file
It's an artefact of split which is unused anyway.
Change-Id: I15c0b4457c108c7791b0f30b79660d9e6d09b269
---
M
Patch Set 3:
Good point. Is there reason why MSC should install those headers? Neels?
--
To view, visit https://gerrit.osmocom.org/4231
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15c0b4457c108c7791b0f30b79660d9e6d09b269
Gerrit-Patch
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/4231/4/include/osmocom/msc/Makefile.am
File include/osmocom/msc/Makefile.am:
Line 70
The build error you got was so obvious. In German we would say "Mit Anlauf
gegen die Wand".
Let me stretch the point of cost of clean-ups. I think the a
Review at https://gerrit.osmocom.org/4233
GGSN: Document how 'tunctl' is used for non-root; call netdev 'apn0'
* Some people want to manually create/configure their tun devices,
show them how to do this using tunctl with the correct parameters
* Let's not call the network device 'ggsn' but ra
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4147
to look at the new patch set (#7).
client: add ip address parsing to the client
Some MGCP messages (CRCX, MDCX) return IP-Addresses. Make use of
this inform
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4146
to look at the new patch set (#6).
client: add unified function to generate MGCP messages
currently the only way to generate MGCP messages is to use
mgcp_ms
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4227
to look at the new patch set (#2).
protocol: allow wildcarded DLCX
In many cases it is simpler to instruct the mgcp-gw to drop all
connections at once instead of removing
Patch Set 4: Code-Review+1
(1 comment)
except for the 'make distcheck' failure this patch is good, right? Do you have
other reasons to veto? (-2 means to me the entire direction of the patch is
wrong, which to me it isn't)
https://gerrit.osmocom.org/#/c/4231/4/include/osmocom/msc/Makefile.am
Patch Set 4: Code-Review-1
> (1 comment)
>
> except for the 'make distcheck' failure this patch is good, right?
> Do you have other reasons to veto? (-2 means to me the entire
> direction of the patch is wrong, which to me it isn't)
-2: Just because it is non-urgent cleanup that is only hal
Patch Set 1:
May be worth adding this one which worked for me and comes from iproute2
package which is usually more standard:
"ip tuntap add dev apn0 mode tun user root group root"
--
To view, visit https://gerrit.osmocom.org/4233
To unsubscribe, visit https://gerrit.osmocom.org/settings
Ger
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4233
to look at the new patch set (#2).
GGSN: Document how 'ip tuntap' is used for non-root; call netdev 'apn0'
* Some people want to manually create/configure their tun devices,
show them
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/4233/2/OsmoGGSN/chapters/configuration.adoc
File OsmoGGSN/chapters/configuration.adoc:
Line 250: achieved by mans such as
mans->means?
Line 253: * systemd .netdev and .netwrork files
netwrork->network
Line 267: device, i.e. the privil
Review at https://gerrit.osmocom.org/4234
Add doxygen docs
Make sure doxygen generates library documentation by default (can be
disabled at compile time).
To avoid complicating doxygen setup compared to other libraries example
config was moved to separate directory.
Change-Id: I2bf7438bcdde19
Review at https://gerrit.osmocom.org/4235
lib/tunc.c: tun_ipv6_linklocal_get(): fix memory leak with getifaddrs()
>From getifaddrs(3) man:
"The data returned by getifaddrs() is dynamically allocated and should
be freed using freeifaddrs() when no longer needed"
Change-Id: If6300d1c8d36fcafef29
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4235
to look at the new patch set (#2).
lib/tun.c: tun_ipv6_linklocal_get(): fix memory leak with getifaddrs()
>From getifaddrs(3) man:
"The data returned by getifaddrs() is dynamically allo
Patch Set 2:
(2 comments)
Some nitpicking.
https://gerrit.osmocom.org/#/c/4233/2/OsmoGGSN/chapters/configuration.adoc
File OsmoGGSN/chapters/configuration.adoc:
Line 300: <1> The netowrk device name, which must match the one in the
apn0.netdev script above
It's "unit file", not script.
Line
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.10/i586
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_17.04/i586
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/i586
Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build log:
[ 100
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_9.0/i586
Package network:osmocom:nightly/osmo-hlr failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build log:
[ 117
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_8.0/x86_64
Package network:osmocom:nightly/osmo-hlr failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build l
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_9.0/x86_64
Package network:osmocom:nightly/osmo-hlr failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build l
Review at https://gerrit.osmocom.org/4236
debian: 'make check' needs sqlite3, add to Build-Depends
At some point we should rather offer DB bootstrap as a DB API function instead
of an external .sql file, which would remove the dep on the sqlite3 binary.
For now, we need the binary to build debi
Patch Set 1: Code-Review+2
fast track to fix debian builds
--
To view, visit https://gerrit.osmocom.org/4236
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71938dff688675dcf1dbfbce2feb8b72b1de0910
Gerrit-PatchSet: 1
Gerrit-Project: osmo
Neels Hofmeyr has submitted this change and it was merged.
Change subject: debian: 'make check' needs sqlite3, add to Build-Depends
..
debian: 'make check' needs sqlite3, add to Build-Depends
At some point we should rather offe
Should be fixed by https://gerrit.osmocom.org/4236
The sqlite3 binary needs to be in Build-Depends.
~N
On Thu, Oct 12, 2017 at 08:08:57PM +, OBS Notification wrote:
> [ 93s] +DDB Unable to prepare SQL statement 'SELECT
> id,imsi,msisdn,vlr_number,sgsn_number,sgsn_address,periodic_lu_tmr,pe
Patch Set 3: Code-Review-1
(13 comments)
The implementation is almost perfect, but we need to improve on the API doc and
unit tests...
https://gerrit.osmocom.org/#/c/4200/3/src/msgb.c
File src/msgb.c:
Line 383: /*! Print a string to the end of message buffer
Always end with a full stop '.' as
46 matches
Mail list logo
