Holger Freyther has submitted this change and it was merged.
Change subject: osmocomBB: Begin with a manual for the "mobile" application
..
osmocomBB: Begin with a manual for the "mobile" application
Begin with manual for the
Holger Freyther has submitted this change and it was merged.
Change subject: mobile: Avoid msg_ref going out of sync
..
mobile: Avoid msg_ref going out of sync
It seemed like msg_ref could go out of sync. In some places we are
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5050
to look at the new patch set (#2).
HO prep: introduce per-BTS handover config, with defaults on net node
It is desirable to allow configuring handover for each individual network cell.
Patch Set 3: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5057
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a0684e567ae26ca8158fda56898eb683374d09
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ci
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jobs: describe how to install jenkins-jobs on deb 9
..
jobs: describe how to install jenkins-jobs on deb 9
Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5058
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc672879dcb3d38978e27b90c173f0aa950c4eb1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/jenkins.sh: rather git checkout -f instead of pull
..
contrib/jenkins.sh: rather git checkout -f instead of pull
Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5055
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce9ab992afa3c5a7a0bb13b55cae016bc8e805f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins docker: drop hardcoded osmo-deps.sh
..
jenkins docker: drop hardcoded osmo-deps.sh
The jenkins invocation of the docker image commonly includes
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins docker: also install py3 scripts of osmo-python-tests
..
jenkins docker: also install py3 scripts of osmo-python-tests
Allow using the
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5054
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27d02d516c1cccd5a2447ee8d76ae476d0951d56
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Review at https://gerrit.osmocom.org/5058
contrib/jenkins.sh: rather git checkout -f instead of pull
Change-Id: Idc672879dcb3d38978e27b90c173f0aa950c4eb1
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci
Review at https://gerrit.osmocom.org/5057
jobs: describe how to install jenkins-jobs on deb 9
Change-Id: Id3a0684e567ae26ca8158fda56898eb683374d09
---
M jobs/README.adoc
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/57/5057/1
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jobs: update-osmo-ci-on-slaves: remove build2-deb8build
..
jobs: update-osmo-ci-on-slaves: remove build2-deb8build
The node is offline and has been for
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jobs: add update-osmo-ci-on-slaves.yml
..
jobs: add update-osmo-ci-on-slaves.yml
Change-Id: Ia933288f87f53f832732f650ba4be30d58faea7f
---
A
Review at https://gerrit.osmocom.org/5055
jenkins docker: drop hardcoded osmo-deps.sh
The jenkins invocation of the docker image commonly includes the osmo-ci
scripts via binding ~/bin to an up-to-date checkout. We don't need another
version of osmo-deps.sh in /usr/local/bin.
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/jenkins.sh: update from current jenkins job
update-osmo-ci-on-slaves
..
contrib/jenkins.sh: update from current jenkins job
Review at https://gerrit.osmocom.org/5054
jenkins docker: also install py3 scripts of osmo-python-tests
Allow using the osmo_verify_transcript_{ctrl,vty}.py scripts from the docker
image.
Change-Id: I27d02d516c1cccd5a2447ee8d76ae476d0951d56
---
M docker/Dockerfile_osmocom_jenkins.amd64
1 file
Review at https://gerrit.osmocom.org/5056
jenkins docker: remove smalltalk things
I am personally not aware of any smalltalk related builds that might be using
our jenkins docker image. Let's remove this and see what falls on its face,
presumably nothing.
Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5051
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54d3f56a89934c1c7b0e445b5c447c91bf94d579
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Review at https://gerrit.osmocom.org/5053
jobs: update-osmo-ci-on-slaves: remove build2-deb8build
The node is offline and has been for a long time. The last osmo-ci-on-slaves
job ran for a week waiting for it to come back online.
Change-Id: I5a315d1ce3d7d5763ba07bf29f9cdd5d6f7c6491
---
M
Review at https://gerrit.osmocom.org/5051
contrib/jenkins.sh: update from current jenkins job update-osmo-ci-on-slaves
We're not calling this script on the update-osmo-ci-on-slaves job yet. To move
over to calling this script, apply some edits we made on the jenkins UI in the
meantime.
Neels Hofmeyr has submitted this change and it was merged.
Change subject: subscr_conn: introduce usage tokens for ref error tracking
..
subscr_conn: introduce usage tokens for ref error tracking
When hunting a conn use count
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix use after free: missing conn_get on CC paging response
..
fix use after free: missing conn_get on CC paging response
Adjust test expectations
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: log error when using a conn that's in release
..
cosmetic: log error when using a conn that's in release
If a conn is attempted to be used
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add msc_vlr_test_call to reproduce a sanitizer error
..
add msc_vlr_test_call to reproduce a sanitizer error
On MT call, there is a bug in CC conn use
Review at https://gerrit.osmocom.org/5048
examples: add osmo-bsc-minimal.cfg
An upcoming VTY test requires a cfg that doesn't have handover values set.
Prepare for that by adding a minimal BSC config. It is a version further
stripped down from the Osmocom Network In The Box wiki page.
Review at https://gerrit.osmocom.org/5050
HO prep: introduce per-BTS handover config, with defaults on net node
It is desirable to allow configuring handover for each individual network cell.
At the same time, it is desirable to set global defaults.
Treat the 'network' node handover
Review at https://gerrit.osmocom.org/5047
cosmetic: handover.h: use "#pragma once", declare structs, comments
Use new #pragma style instead of #ifndef dance.
Forward-declare all structs we're using pointers of.
Move function comments to their definitions in the .c file.
Change-Id:
Review at https://gerrit.osmocom.org/5049
HO prep: pass gsm_network to gsm_bts_alloc() already
Prepare for a future change that accesses bts->network during gsm_bts_alloc().
Currently, gsm_bts_alloc() takes a ctx parameter, and gsm_bts_alloc_register()
then gets the gsm_network pointer and
Vadim Yanitskiy has submitted this change and it was merged.
Change subject: doc/examples: add CalypsoBTS configuration example
..
doc/examples: add CalypsoBTS configuration example
Despite the CalypsoBTS transceiver is
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5043
to look at the new patch set (#2).
compiler warnings: add includes in abis_rsl.h, gsm_data_shared.h
Change-Id: Ic0b1410a352c7be399d16d5db7cfe7a62192df6f
---
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5046
to look at the new patch set (#2).
cleanup: gsm_data_shared.h: drop unused ROLE_*
While this header was still shared among several code trees, we had this ROLE
construct in place to
Review at https://gerrit.osmocom.org/5045
compiler warnings: constify in abis_nm.c
Constify in- and output arguments for Parse Attribute Response Info chain to
avoid compiler warnings, and more clearly indicate const data in the first
place.
Change-Id:
Review at https://gerrit.osmocom.org/5046
cleanup: gsm_data_shared.h: drop unused ROLE_*
While this header was still shared among several code trees, we had this ROLE
construct in place to exclude some parts in some trees. Since we're having one
copy per code base now, drop the ROLE #ifdefs
Review at https://gerrit.osmocom.org/5043
compiler warnings: add includes in abis_rsl.h, gsm_data_shared.h
Change-Id: Ic0b1410a352c7be399d16d5db7cfe7a62192df6f
---
M include/osmocom/bsc/abis_rsl.h
M include/osmocom/bsc/gsm_data_shared.h
2 files changed, 2 insertions(+), 0 deletions(-)
git
Review at https://gerrit.osmocom.org/5044
compiler warnings: drop some unused variables
Change-Id: I840b0cd8ee3e7c521e7c9053a992deeb9ec22ff4
---
M src/libbsc/abis_om2000_vty.c
M src/libbsc/pcu_sock.c
2 files changed, 0 insertions(+), 4 deletions(-)
git pull
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4971
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dd20ee56ce5ad7a90fcd03a06604c383e5eed54
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4972
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I259aa0eec41efebb4c8221275219433eafaa549b
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Use type bool for boolean fields in gsm48_si_ro_info
..
Use type bool for boolean fields in gsm48_si_ro_info
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5037
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1afe071038a3bb5871d7ff40f665c8644f801ec
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: vty: Add cmd to configure 3g Early Classmark Sending
..
vty: Add cmd to configure 3g Early Classmark Sending
In state prior to this patch, "3G Early
Harald Welte has submitted this change and it was merged.
Change subject: ctrl: make response easier to parse
..
ctrl: make response easier to parse
Previously ctrl request for all counters in
group (e. g.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5036
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0981fca96f4927717ca335be1dab00a5d17fd6c
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: Remove leftover comments and checks
..
Remove leftover comments and checks
It seems like rx previously had 'float' type. Remove the comments and
checks which are
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5014
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia962367bb93cb826002db6c950d23ae2102ac713
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Update rate_ctr description
..
Update rate_ctr description
* use example new counter names with ':' separator
* mention that 'counter' is obsolete
*
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5023
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a24cc307450efdcd28168fffe477320c59fcd36
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/5029/2/osmopy/rate_ctr2csv.py
File osmopy/rate_ctr2csv.py:
Line 71:
args.output.write('group,counter,absolute,second,minute,hour,day\n')
One can do it this way, but generally it would be better to use a python module
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5039
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4aad53667f88f9656c5bb1c52e7e75b385f446
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5038/1/osmopy/osmo_ctrl.py
File osmopy/osmo_ctrl.py:
PS1, Line 1: 3
this is not improving compatibility, but it is *mandating* python3
--
To view, visit https://gerrit.osmocom.org/5038
To unsubscribe, visit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4911
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bac5f06921b5fd85a98d97770d42d4858ca1c42
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4930
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0591bb2785232681b23e41368323f16d3c960c
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4932
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7ab34b1b85b62ef0e8fff347adccbc5dc414161
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5042
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f3ef3665352c4e74a2c2e8d345a408a2f52
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4771
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2456b7fae35546553c4805f12a40c0812d9255c
Gerrit-PatchSet: 5
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4909
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee1140e4848923c7270495c381bf87b7e3fddee1
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4931
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5df20a4ab79c06b515780675b6df2929aa976f0d
Gerrit-PatchSet: 3
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4839
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I355d2f8d15aeaa13abb1c5e4a8e0c958e5faf7f3
Gerrit-PatchSet: 4
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5040
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d52e5f61e77ef1ecf00aeecad85e56cbafb4379
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5041
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9348b3ed71a8490c03edda954402ab954f645b7c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 4:
(1 comment)
> > (1 comment)
> >
> > I see a number of other strcpy and strncpy instances around
> > osmo-mgw.git. I think at some point I replaced all with
> > osmo_strlcpy(), I wonder where all these are coming from now.
> Would
> > you mind to replace all of the occurences
Patch Set 1:
(1 comment)
Ok, I'll improvie the commit description
https://gerrit.osmocom.org/#/c/5011/1/suites/gprs/ping.py
File suites/gprs/ping.py:
Line 45: ctx_id_v4 = ms.activate_context(apn='internet',
protocol=ms.CTX_PROT_IPv4)
> is ms.activate_context() blocking? For the ms.attach()
dexter has submitted this change and it was merged.
Change subject: vty: simplify endpoint allocation
..
vty: simplify endpoint allocation
mgcp_parse_config() uses a helper function allocate_trunk() to
perform the trunk
dexter has submitted this change and it was merged.
Change subject: vty: do not change number_endpoints at runtime
..
vty: do not change number_endpoints at runtime
The variable number_endpoints is used as a length indicator
Review at https://gerrit.osmocom.org/5042
Print additional debug info for extended tests
The following error has been observed in gerrit test:
/usr/bin/python ./vty_test_runner.py -w /build -v
Traceback (most recent call last):
File "./vty_test_runner.py", line 26, in
from
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4771
to look at the new patch set (#5).
mobile: Begin with a primitive interface on top of the code
We want the script interface to interface through a primitive
interface.
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4839
to look at the new patch set (#4).
mobile: Add osmo.timeout for lua code to have timeouts
Allow to callback into lua code after a user configured timeout. Make
it only
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4932
to look at the new patch set (#3).
mobile: Inform the primitive layer about status and new sms
Inform the layer about new SMS and inform about the cause of
it. In both cases pass the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4931
to look at the new patch set (#3).
mobile: Directly inform the primitive layer about an event
Forward started/shutdown changes to the primitive layer which will
turn them into
Review at https://gerrit.osmocom.org/5041
WIP... compiler warning..
In file included from settings.c:27:0:
../../include/osmocom/bb/mobile/app_mobile.h:10:42: warning: ‘struct
osmocom_ms’ declared inside parameter list will not be visible outside of this
definition or declaration
int
Review at https://gerrit.osmocom.org/5040
WIP: start/stop for the MS..
Change-Id: I7d52e5f61e77ef1ecf00aeecad85e56cbafb4379
---
M src/host/layer23/src/mobile/script_lua.c
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb
Review at https://gerrit.osmocom.org/5039
Remove leftover comments and checks
It seems like rx previously had 'float' type. Remove the comments and
checks which are not relevant since rx is 'int'.
Change-Id: Idb4aad53667f88f9656c5bb1c52e7e75b385f446
Fixes: OS#2223
---
M
Review at https://gerrit.osmocom.org/5038
Improve python3 compatibility
* use print()
* use named exception
In case of osmo_ctrl.py we can already switch to python3 as it's a
standalone script. Other scripts might be used as a libraries so leave
the shebang without modifications for now.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4972
to look at the new patch set (#4).
subscr_conn: introduce usage tokens for ref error tracking
When hunting a conn use count bug, it was very hard to figure out who's (not)
using the
Patch Set 6: Code-Review+2
edited that line away, now it should be good
--
To view, visit https://gerrit.osmocom.org/4779
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3994af016fb96427263edbba05f560743f85fdd4
Gerrit-PatchSet: 6
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4779
to look at the new patch set (#6).
vty: do not change number_endpoints at runtime
The variable number_endpoints is used as a length indicator
for the array that contains the trunk
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/4779/5/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:
Line 1309: trunk->number_endpoints = trunk->vty_number_endpoints;
this seems wrong, in the commit by accident? ah, no harm done, but the same
Max has submitted this change and it was merged.
Change subject: Add osmo_ipa.py to setup's install
..
Add osmo_ipa.py to setup's install
When running jenkins job, osmo_ipa is not available despite latest
osmo-python-tests
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5035
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3e160c220ca6d2b55df0dfcdcdcb56e4e240bb3
Gerrit-PatchSet: 2
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch:
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/4972/3/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
Line 1362: transt->conn = msc_subscr_conn_get(conn,
MSC_CONN_USE_TRANS_CC);
wait what, this should have been added by https://gerrit.osmocom.org/4974
--
To view,
Patch Set 1:
This depends on I7a24cc307450efdcd28168fffe477320c59fcd36 - let's not merge it
before that.
--
To view, visit https://gerrit.osmocom.org/5029
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Max has submitted this change and it was merged.
Change subject: Add *.py from OsmoBSC
..
Add *.py from OsmoBSC
Those are generic enough and can be used as advanced example of uzing
CTRL interface from python on top of
Patch Set 5: Verified+1
--
To view, visit https://gerrit.osmocom.org/4992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e1155d3bd546feaabab34a46e354c69058056e
Gerrit-PatchSet: 5
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch:
Patch Set 2:
> > It appears that osmo-hnbgw *does* need -lsctp.
>
> Which particular libsctp API is used directly by osmo-hnbgw?
for the record: it turns out osmo-hnbgw still had an unused function that
called sctp_send() from an earlier code state. With that function dropped, all
worked
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e1155d3bd546feaabab34a46e354c69058056e
Gerrit-PatchSet: 5
Gerrit-Project: python/osmo-python-tests
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5032
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b1797de576ab987b05046aa9a9828858023ed3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
oh here it is. could be merged with that other patch...
--
To view, visit https://gerrit.osmocom.org/5035
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3e160c220ca6d2b55df0dfcdcdcb56e4e240bb3
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5029
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12b369434e4ee9b38f92872f297e1f3d4f0698c2
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Patch Set 5: Code-Review+1
ah, you may also want to add installed scripts to setup.py
--
To view, visit https://gerrit.osmocom.org/4992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e1155d3bd546feaabab34a46e354c69058056e
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4e1155d3bd546feaabab34a46e354c69058056e
Gerrit-PatchSet: 5
Gerrit-Project: python/osmo-python-tests
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/5028/1/osmopy/osmo_ipa.py
File osmopy/osmo_ipa.py:
Line 241: if s == self.CTRL_ERR:
so you are splitting bytes into smaller bytes, then you go on to compare
against string constants ... Instead, you may want to do
Patch Set 4:
> (1 comment)
>
> I see a number of other strcpy and strncpy instances around
> osmo-mgw.git. I think at some point I replaced all with
> osmo_strlcpy(), I wonder where all these are coming from now. Would
> you mind to replace all of the occurences in one fell swoop?
>
>
Patch Set 1: Code-Review+1
(1 comment)
the test is still incomplete, particularly the ping that the commit log talks
about is not there. It's ok for a first version, but say so in the commit log
https://gerrit.osmocom.org/#/c/5011/1/suites/gprs/ping.py
File suites/gprs/ping.py:
Line 45:
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5009/1/src/osmo_gsm_tester/modem.py
File src/osmo_gsm_tester/modem.py:
Line 340: CTX_PROT_IPv46 = 'dual'
> That's expected to be used by tests when telling the modem to create a IPv4
> The strings need to be that way
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5007/1/src/osmo_gsm_tester/bts_osmotrx.py
File src/osmo_gsm_tester/bts_osmotrx.py:
Line 51: self._pcu = pcu_osmo.OsmoPcu(self.suite_run, self, self.conf)
> From my point of view the pcu is always attached to a specific bts and
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/4906/6/src/libosmo-mgcp/mgcp_msg.c
File src/libosmo-mgcp/mgcp_msg.c:
Line 346:"endpoint:%x invalid ConnectionIdentifier
(empty)\n",
> ...
I don't understand why you keep insisting on using a LOG line formatting that's
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5006/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 58: 'bts[].direct_pcu': schema.BOOL_STR,
> See this option from osmo-bts-symo:
(ah now i remember. maybe we can add a "_dsp_" in the name for
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4911/1/src/host/layer23/src/mobile/gsm411_sms.c
File src/host/layer23/src/mobile/gsm411_sms.c:
Line 380: rc = gsm340_rx_tpdu(trans, msg, rph->msg_ref);
> Well. This is why the next patch is killing msg_ref from the sms structure.
I
Patch Set 6: Code-Review-1
(4 comments)
https://gerrit.osmocom.org/#/c/4906/6/src/libosmo-mgcp/mgcp_conn.c
File src/libosmo-mgcp/mgcp_conn.c:
Line 87:OSMO_ASSERT(strlen(id) < MGCP_CONN_ID_LENGTH);
-1: you ignored my earlier comment. It's ok to disagree but if you do, please
respond.
1 - 100 of 160 matches
Mail list logo
