Review at https://gerrit.osmocom.org/5205
db: wrap dbi querying to log actual SQL on debug and error
To be able to tell at all which DB query failed without introspecting the code
in gdb or similar, wrap the database query functions in local shims that log
the SQL.
Related: OS#2667, OS#2706
Ch
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5184/1/src/libmsc/db.c
File src/libmsc/db.c:
Line 955: free(q_msisdn);
> You shouldn't free memory if dbi_conn_quote_string_copy() failed to allocat
Agreed. If you look at this file before this patch, I just copied the scheme
from t
Review at https://gerrit.osmocom.org/5204
mobile/gsm48_rr.c: fix ACCH System Information parsing
According to GSM 04.08, the System Information messages, such as
SI5, SI5ter, SI5bis and SI6 (described in sections 9.1.37-40),
have no the 'L2 Pseudo Length' (10.5.2.19) field, unlike others.
So,
Harald Welte has submitted this change and it was merged.
Change subject: Remove utils imported from openbsc, fix building remaining util
smpp_mirror
..
Remove utils imported from openbsc, fix building remaining util smpp_mirro
Harald Welte has submitted this change and it was merged.
Change subject: Add missing CFLAGS
..
Add missing CFLAGS
Change-Id: I67b5d797a80b55e01dcdbb8c782748b049cf9199
---
M src/libcommon-cs/Makefile.am
M src/libcommon/Makefile
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5138
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67b5d797a80b55e01dcdbb8c782748b049cf9199
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: mncc: re-add lchan members to structs
..
mncc: re-add lchan members to structs
The lchan related struct members do not serve any useful purpose
in the ms
Harald Welte has submitted this change and it was merged.
Change subject: mncc: remove deprecated commandline option.
..
mncc: remove deprecated commandline option.
The commandline option -m has already been deprecated before t
Patch Set 1: Code-Review+2
fine with me, but we yet have to see if we actually want the #ifdef patch for
ipv6 support...
--
To view, visit https://gerrit.osmocom.org/5165
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f97bcd163b0458d0
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5164
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1a630b77a8c2f442e26dbef8e608882e8f9a71
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-
Review at https://gerrit.osmocom.org/5203
Revert "resources.conf: EC20 doesn't support SupplementaryServices"
This reverts commit 31b7f0f9dea3f6f00230022a12612b6750018be6.
EC20 actually supports the feature. I was wrong mainly due to 2 reasons:
- I somehow failed to set the modem Online before
Harald Welte has submitted this change and it was merged.
Change subject: TBF: fix compiler warning in test
..
TBF: fix compiler warning in test
tbf/TbfTest.cpp: In function ‘void egprs_spb_to_normal_validation(BTS*,
unsigned
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5180
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ba28b8771b12a4a924ac05937051ade47622e51
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5158/2/src/tbf.h
File src/tbf.h:
Line 179: void stop_t3169(const char *reason);
I'm not the C++ expert here, but to me this looks a lot like copy+paste
programming. We fundamentally have an object "a timer" and we want to have
mul
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5182
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f79c6153dc4073c9d293b2824979e6381576682
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5119
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf9e5f15faa7810411ed9d68ed43cf907eea2545
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5120
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e537416af9bec5d447356286f44e9e8bbf1b7a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Embedded: fix sercomm test
..
Embedded: fix sercomm test
The external sercomm_drv_[un]lock() functions are defined as stubs in
case of non-embedded build
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5159
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dab4f3348871b66b5d6c9fd10b2e448c61f9e73
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5186
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia02373a36df7605507ee3de49173a9fd6547b726
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Print error cause of pcu socket connect failure
..
Print error cause of pcu socket connect failure
This log is useful to quickly debug scenarions in whic
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5198
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fd5736b5916cbad72b96f064929bb667ff97ded
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5179
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ce91eab415c19bb811fbb2fd617d5ce2b58d41
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5193
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4e1dab415a70ded5c65c21752dca497856e96f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: OsmoPCU: add rate counter documentation
..
OsmoPCU: add rate counter documentation
Change-Id: Ieb4e1dab415a70ded5c65c21752dca497856e96f
---
A OsmoPCU/cha
Harald Welte has submitted this change and it was merged.
Change subject: OsmoMSC: add rate counter documentation
..
OsmoMSC: add rate counter documentation
Change-Id: Idc105fd16511c6ea4f5069a57b217ea3319bdbec
---
A OsmoMSC/cha
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5194
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c5d5744f961a92bc7cca739d1e8a8a0be9c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5191
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8711dd4bc9db36a7121552dc067c7afb1051b0a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: OsmoSGSN: add rate counter documentation
..
OsmoSGSN: add rate counter documentation
Change-Id: I4c5d5744f961a92bc7cca739d1e8a8a0be9c
---
A OsmoSGSN/
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5192
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc105fd16511c6ea4f5069a57b217ea3319bdbec
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: OsmoBSC: add rate counter documentation
..
OsmoBSC: add rate counter documentation
Change-Id: Ia8711dd4bc9db36a7121552dc067c7afb1051b0a
---
A OsmoBSC/cha
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: resources.conf: sierra modems support gprs
..
resources.conf: sierra modems support gprs
At least the signalling support we are currently running, so
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: resources.conf: EC20 doesn't support SupplementaryServices
..
resources.conf: EC20 doesn't support SupplementaryServices
As the interface never appea
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5200
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If17ff9f3d9c4c74bf0aa7966b1dd2f878175a8f0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5201
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68fcf2b9083966ad42940e1629abe2a1a6b74095
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: resources.conf: Label modems according to their type
..
resources.conf: Label modems according to their type
It's difficult to know which path is whi
Hello Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5179
to look at the new patch set (#2).
osmocom-nightly/latest: check if osc is installed
Change-Id: I10ce91eab415c19bb811fbb2fd617d5ce2b58d41
---
M scripts/osmocom-latest-packages.sh
M scripts
Patch Set 1:
will update it
--
To view, visit https://gerrit.osmocom.org/5179
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ce91eab415c19bb811fbb2fd617d5ce2b58d41
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerri
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5171
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1c060d8fdbe0a309366ed7bd1e79f40625405c
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: ortp: Move DEPENDS to inc file and fix whitespace
..
ortp: Move DEPENDS to inc file and fix whitespace
Change-Id: Idf1c060d8fdbe0a309366ed7bd1e79f406
Patch Set 1: Verified+1
(1 comment)
https://gerrit.osmocom.org/#/c/5171/1/recipes-misc/ortp/ortp.inc
File recipes-misc/ortp/ortp.inc:
PS1, Line 2: LGPLv2.1
> attention: libortp changed license recently. It used to be LGPL, now it's G
Good to know, but it seems the change is done during release
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: ortp: Remove unused old ortp 0.16.5
..
ortp: Remove unused old ortp 0.16.5
A new version 0.25.0 was added around 3 years ago and has been used
since
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5170
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica158e8ddabf5a8ce2a2254ca4fabdc35e7db668
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5178
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a4c7d4a5e3e58c413c82b75f442ae9321d64998
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-sgsn: Install example osmo-gtphub config file
..
osmo-sgsn: Install example osmo-gtphub config file
Change-Id: Ie8ee1e4b1e0d0a7ca00764a1906b1ff2
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmocom: Use CONFFILES for cfg files
..
osmocom: Use CONFFILES for cfg files
Change-Id: I4a4c7d4a5e3e58c413c82b75f442ae9321d64998
---
M recipes-osmoc
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5177
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8ee1e4b1e0d0a7ca00764a1906b1ff26b7bea4d
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: libosmo-abis: Split libosmotrau into its own package
..
libosmo-abis: Split libosmotrau into its own package
Change-Id: Ica8b6c39aed9f3370aeab84e821c
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5169
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica8b6c39aed9f3370aeab84e821c8de871d2f0be
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Ger
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5198
to look at the new patch set (#2).
Print error cause of pcu socket connect failure
This log is useful to quickly debug scenarions in which pcu never
connects to bts. For instance, if bt
Patch Set 1:
Wops sorry, you are correct.
I thought it returned -errno or similar and got confused by the fact that I
received -1 which after a quick look seemed like the error type I was expecting
(bad permission or something like that).
--
To view, visit https://gerrit.osmocom.org/5198
To
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5178
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a4c7d4a5e3e58c413c82b75f442ae9321d64998
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5177
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8ee1e4b1e0d0a7ca00764a1906b1ff26b7bea4d
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5200
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If17ff9f3d9c4c74bf0aa7966b1dd2f878175a8f0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5201
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68fcf2b9083966ad42940e1629abe2a1a6b74095
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5202
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04459786ba76813ebaa7867bcc86afb4fa9700b9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5171/1/recipes-misc/ortp/ortp.inc
File recipes-misc/ortp/ortp.inc:
PS1, Line 2: LGPLv2.1
attention: libortp changed license recently. It used to be LGPL, now it's GPL!
--
To view, visit https://gerrit.osmocom.org/5171
To unsubscribe, vi
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5170
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica158e8ddabf5a8ce2a2254ca4fabdc35e7db668
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5171
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf1c060d8fdbe0a309366ed7bd1e79f40625405c
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5169
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica8b6c39aed9f3370aeab84e821c8de871d2f0be
Gerrit-PatchSet: 2
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Review at https://gerrit.osmocom.org/5202
resources.conf: sierra modems support gprs
At least the signalling support we are currently running, so let's add
the gprs feature to them as they can be used to run the current tests.
Change-Id: I04459786ba76813ebaa7867bcc86afb4fa9700b9
---
M example/
Review at https://gerrit.osmocom.org/5201
resources.conf: EC20 doesn't support SupplementaryServices
As the interface never appears, tests using the modem fail because we
wait for all the interfaces to be available based on the features
attribute.
Change-Id: I68fcf2b9083966ad42940e1629abe2a1a6
Review at https://gerrit.osmocom.org/5200
resources.conf: Label modems according to their type
It's difficult to know which path is which, and actually in the prod env
gobi_0 is given to gobi 2000 instead of EC20, which means the attributes
would be applying to the wrong resource.
Change-Id: I
Harald Welte has submitted this change and it was merged.
Change subject: ggsn: Ignore PCO with length 0, don't abort processing
..
ggsn: Ignore PCO with length 0, don't abort processing
The existing code would abort iterating
Harald Welte has submitted this change and it was merged.
Change subject: ggsn.c: Fix byte order of IPCP IPv4 DNS servers
..
ggsn.c: Fix byte order of IPCP IPv4 DNS servers
... this probably didn't show up as 8.8.8.8 is dual-en
Max has submitted this change and it was merged.
Change subject: Log APN and tun names for packets
..
Log APN and tun names for packets
Change-Id: I6f7ce33f6585b2b78e2b8a5c0f7111f0316d6ddd
---
M ggsn/ggsn.c
1 file changed, 4 in
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5176
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36660566a8ee2ca80ae6ee99c86e167e7c208df2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5151
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4bcac5fcebfc24760432eb66be258a01d78f65f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Max has submitted this change and it was merged.
Change subject: Fix display of GTP addresses
..
Fix display of GTP addresses
Previously we've tried to convert addresses manually which lead to
wrongly displayed GTP addresses (e
Max has submitted this change and it was merged.
Change subject: Show GTP version for PDP context in vty
..
Show GTP version for PDP context in vty
Change-Id: Id1692e99ae0d2b78e9473f6139e6e430fcd6a607
---
M src/gprs/sgsn_vty.c
Patch Set 1: Code-Review+2
strictly speaking, it is "not found" and not "not installed" but ok...
--
To view, visit https://gerrit.osmocom.org/5179
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ce91eab415c19bb811fbb2fd617d5ce2b58d41
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5181
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If127d0e852ea8e321461d6aa709621167a0a8ecb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5183/1/src/libmsc/db.c
File src/libmsc/db.c:
Line 844: if (*vsub->msisdn == '\0')
I would have thought "strlen(vsub->msisdn) == 0" is more readble, but anyway,
we an expect people to know how C strings work ;)
--
To
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5187
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23d492a839aae85470e39b0d0ad8f57b0d38f7e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5198/1/src/osmobts_sock.cpp
File src/osmobts_sock.cpp:
Line 263: rc = connect(bfd->fd, (struct sockaddr *) &local, namelen);
TURN VALUE
If the connection or binding succeeds, zero is returned. On error, -1
is returned,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5199
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1692e99ae0d2b78e9473f6139e6e430fcd6a607
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerri
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5195
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f7ce33f6585b2b78e2b8a5c0f7111f0316d6ddd
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerri
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5197
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I695a9c9497d675564a088b002299096e0dcd267d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerri
Review at https://gerrit.osmocom.org/5199
Show GTP version for PDP context in vty
Change-Id: Id1692e99ae0d2b78e9473f6139e6e430fcd6a607
---
M src/gprs/sgsn_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/99/5199/1
diff --g
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5197
to look at the new patch set (#2).
Fix display of GTP addresses
Previously we've tried to convert addresses manually which lead to
wrongly displayed GTP addresses (e. g. '4.0.0.0' inste
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5195
to look at the new patch set (#3).
Log APN and tun names for packets
Change-Id: I6f7ce33f6585b2b78e2b8a5c0f7111f0316d6ddd
---
M ggsn/ggsn.c
1 file changed, 4 insertions(+), 3 deletions(
Max has submitted this change and it was merged.
Change subject: Log filenames on L1 errors
..
Log filenames on L1 errors
Change-Id: I7e73374f3f1da662ebed52548d29b6b76443c81b
---
M src/osmo-bts-sysmo/l1_transp_hw.c
1 file chang
Review at https://gerrit.osmocom.org/5198
Print error cause of pcu socket connect failure
Change-Id: I6fd5736b5916cbad72b96f064929bb667ff97ded
---
M src/osmobts_sock.cpp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/5198/1
di
Review at https://gerrit.osmocom.org/5197
Fix display of GTP control addresses
Previously we've tried to convert addresses manually which lead to
wrongly displayed GTP addresses (e. g. '4.0.0.0'). Use libgtp function
for conversion to fix it.
Change-Id: I695a9c9497d675564a088b002299096e0dcd267
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5196
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81751d774ec1f61b01ccef6c21c9d38807d5d1fc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Bra
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: bts_octphy: Use OsmoPcu instead of OsmoPcuSysmo
..
bts_octphy: Use OsmoPcu instead of OsmoPcuSysmo
Change-Id: I81751d774ec1f61b01ccef6c21c9d38807d5d1
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/5195/2/ggsn/ggsn.c
File ggsn/ggsn.c:
PS2, Line 664: Received packet APN(%s) from tun %s
this is a bit awkward: You're receiving a packet from the tun device _for_ a
given APN, but you're not receiving a 'packet APN' from tun.
Line 693
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5190
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2768100e69dcd7d8d77533688585dd9b43c4a5e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Harald Welte has submitted this change and it was merged.
Change subject: vty: show asciidoc counters: don't create an empty table for
osmo_counters
..
vty: show asciidoc counters: don't create an empty table for osmo_counters
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5189
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9068231d71876e06d27ee67a688d7fb611ac3a1b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5188
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e73374f3f1da662ebed52548d29b6b76443c81b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: counters: add osmo_counters_count() returns the amount of
counters
..
counters: add osmo_counters_count() returns the amount of counters
Change-Id: I906
Review at https://gerrit.osmocom.org/5196
bts_octphy: Use OsmoPcu instead of OsmoPcuSysmo
Change-Id: I81751d774ec1f61b01ccef6c21c9d38807d5d1fc
---
M src/osmo_gsm_tester/bts_octphy.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/c
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5195
to look at the new patch set (#2).
Log APN and tun names for packets
Change-Id: I6f7ce33f6585b2b78e2b8a5c0f7111f0316d6ddd
---
M ggsn/ggsn.c
1 file changed, 4 insertions(+), 3 deletions(
Patch Set 1:
@laforge: I'm unsure if the chapter is at the right position.
--
To view, visit https://gerrit.osmocom.org/5191
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8711dd4bc9db36a7121552dc067c7afb1051b0a
Gerrit-PatchSet: 1
Gerr
Review at https://gerrit.osmocom.org/5195
Log APN and tun names for forwarded packets
Change-Id: I6f7ce33f6585b2b78e2b8a5c0f7111f0316d6ddd
---
M ggsn/ggsn.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/95/5195/1
diff --git a/g
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5190
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2768100e69dcd7d8d77533688585dd9b43c4a5e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Review at https://gerrit.osmocom.org/5191
OsmoBSC: add rate counter documentation
Change-Id: Ia8711dd4bc9db36a7121552dc067c7afb1051b0a
---
A OsmoBSC/chapters/counters.adoc
A OsmoBSC/chapters/counters_generated.adoc
M OsmoBSC/osmobsc-usermanual.adoc
3 files changed, 82 insertions(+), 0 deletions
Review at https://gerrit.osmocom.org/5192
OsmoMSC: add rate counter documentation
Change-Id: Idc105fd16511c6ea4f5069a57b217ea3319bdbec
---
A OsmoMSC/chapters/counters.adoc
A OsmoMSC/chapters/counters_generated.adoc
M OsmoMSC/osmomsc-usermanual.adoc
3 files changed, 46 insertions(+), 0 deletions
Review at https://gerrit.osmocom.org/5193
OsmoPCU: add rate counter documentation
Change-Id: Ieb4e1dab415a70ded5c65c21752dca497856e96f
---
A OsmoPCU/chapters/counters.adoc
A OsmoPCU/chapters/counters_generated.adoc
M OsmoPCU/osmopcu-usermanual.adoc
3 files changed, 184 insertions(+), 0 deletion
1 - 100 of 179 matches
Mail list logo
