Patch Set 1:
(6 comments)
seems to me a lot of nice tries but no firm grip on the problem. BTW, parallel
build of osmo-bsc hasn't failed for me (TM) yet. Is there a particular reason
why it started failing for you?
https://gerrit.osmocom.org/#/c/5084/1//COMMIT_MSG
Commit Message:
Line 10:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5075
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I663e03046cde3c786af72d15681bf7497330d7f9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5217
target/firmware: fix Mediatek firmware compilation
The existing Makefile.mtk isn't compatible with the current
Makefile scheme, so nothing would happen when it was called.
This change updates the Makefile.mtk, so the Mediatek firmware
can be
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5216
to look at the new patch set (#2).
Add support for IPv4v6 End User Addresses
Before this commit, when an MS requested an ipv4v6 context osmo-ggsn
returned an error stating the type was
Review at https://gerrit.osmocom.org/5216
Add support for IPv4v6 User End Addresses
Before this commit, when an MS requested an ipv4v6 context osmo-ggsn
returned an error stating the type was unknown, and this text was
printed in the log:
Processing create PDP context request for APN 'ims'
Review at https://gerrit.osmocom.org/5215
Introduce LOGTBF* for consistent logging
When troubleshooting complex issues with TBF lifecycle, it's much easier
to follow the logs which are consistently formatted. Add LOGTBF*() macro
similar to struct-specific log routines we use in other Osmocom
Patch Set 1: Code-Review-2
osmopy should actually be installed in /var/lib/python/ or
/usr/local/lib/python/, only the runnable scripts go to /usr/local/bin. See
setup.py
This patch will not help you in any way, since the contents of /usr/local/bin
do not change while the tests are running,
Review at https://gerrit.osmocom.org/5213
cosmetic: remove unused variable
Change-Id: Ie724e2e5875020aa835b4cd57ab96966aee283e1
---
M tests/agch/agch_test.c
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/5213/1
diff --git
Review at https://gerrit.osmocom.org/5210
cosmetic: fix wrong comment
Change-Id: Id228620ccf5a40c8089ae1914d59b19e808ea151
---
M tests/meas/meas_test.c
M tests/meas/meas_test.ok
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts
Review at https://gerrit.osmocom.org/5212
cosmetic: remove unused variable
Change-Id: Ied484e3e2d3006eb0f03516ceaed3e0e802d51e4
---
M tests/power/power_test.c
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/5212/1
diff --git
Review at https://gerrit.osmocom.org/5211
cosmetic: remove excess whitespaces in Makefile.am
Change-Id: I7090d46ae72183014e6c74d6ddb240af8d66e0b4
---
M tests/Makefile.am
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/5211/1
Review at https://gerrit.osmocom.org/5214
osmo-bts-trx: add error concealment unit for GSM-FR
When a bad GSM-FR voice frame is received, the frame replaced
ith a slince frame. This may cause unpleasant audio effects.
Add a function to craft a replacement frame from the last
known good frame.
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5164/1/jobs/gerrit-verifications.yml
File jobs/gerrit-verifications.yml:
Line 109: cmd: GTP="$GTP" ./contrib/jenkins.sh
interesting though to pass in the GTP env var as the contents of the GTP env
var :) ...
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/5103/4/src/timer.c
File src/timer.c:
Line 202: if (clock_gettime(CLOCK_MONOTONIC, _now) != 0) {
some while ago, we added a clock wrapper to be able to set artificial times for
unit tests. Have you made sure that applying this to
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/5181
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If127d0e852ea8e321461d6aa709621167a0a8ecb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5179
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ce91eab415c19bb811fbb2fd617d5ce2b58d41
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 2: Verified+1
--
To view, visit https://gerrit.osmocom.org/5181
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If127d0e852ea8e321461d6aa709621167a0a8ecb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmocom-nightly/latest: document which debian packages are
required
..
osmocom-nightly/latest: document which debian packages are required
Change-Id:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5209
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I348ba89bdda2b44c7019e9c893c764ee08c80bec
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4955
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31d503af700ec3364042ff7e661710953cacf9f8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5207
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I217f4c4bac21dd584c8682928a080a1a6e9507e1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4636
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4174703808335c19341cd5b5f4422496d958967f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5209
TBF: log source of state transitions
We use the same approach for osmo_fsm: when state transition happens,
it's not very useful to always log the transition function itself, it's
much more useful to see where the actual transition comes from.
Patch Set 2: Code-Review+1
(1 comment)
looks sane enough, but would be nice to hint at a caller, given that there is
none in this patch
https://gerrit.osmocom.org/#/c/4955/2/src/mslot_class.h
File src/mslot_class.h:
Line 31: #define MS_NA 255 /* N/A */
unrelated cosmetic
--
To view,
Patch Set 1:
well I'll just submit it and done.
--
To view, visit https://gerrit.osmocom.org/4947
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2acab2af8d67bccb2bc495512c1f259ae649a832
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Neels Hofmeyr has submitted this change and it was merged.
Change subject: use _NUM_CHREQ_T to define the size of ctype_by_chreq
..
use _NUM_CHREQ_T to define the size of ctype_by_chreq
Make it future compatible for changes.
Patch Set 1:
lynxis?
--
To view, visit https://gerrit.osmocom.org/4947
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2acab2af8d67bccb2bc495512c1f259ae649a832
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2:
added feature request https://osmocom.org/issues/2712
--
To view, visit https://gerrit.osmocom.org/4927
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If92a18bb3dc24c2cf6498aa2da29266267488240
Gerrit-PatchSet: 2
Patch Set 3:
yes, we need a +V vote that someone verifies that the patch works when applied
to current master. In the lack of an automatic test on jenkins, someone should
run this manually and add V+1
--
To view, visit https://gerrit.osmocom.org/2691
To unsubscribe, visit
Neels Hofmeyr has abandoned this change.
Change subject: contrib: Add osmo-msc service file
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2537
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/5208
TBF: log timer invocation source
When troubleshooting TBF timers we're not only interested in timer
duration but also in the code which triggered it. Let's use LOGPSRC to
log it.
Change-Id: If5f883ae52c469e5158bad24da9904fdc455582f
Related: OS#2407
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5205/1/src/libmsc/db.c
File src/libmsc/db.c:
Line 197: dbi_result queryf(dbi_conn conn, const char *format, ...)
> That's just SQL injection waiting to happen. Too bad libdbi does not suppor
Our invocation of libdbi has always worked like
Neels Hofmeyr has submitted this change and it was merged.
Change subject: sms db: don't attempt to query pending SMS for unset MSISDN
..
sms db: don't attempt to query pending SMS for unset MSISDN
When the subscriber has no
Review at https://gerrit.osmocom.org/5207
Make TBF state private
Let's make sure no external function can mess with the TBF state.
Change-Id: I217f4c4bac21dd584c8682928a080a1a6e9507e1
---
M src/tbf.cpp
M src/tbf.h
2 files changed, 2 insertions(+), 5 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5206
vty: print class and TBFs for each MS
It's handy for troubleshooting to get quick overview of per-MS TBF
allocations and MS [EGPRS] classes.
Change-Id: Ie79c20f86da6db4565654b0f5856f4fddd83ef96
---
M src/pcu_vty_functions.cpp
1 file changed, 6
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Revert "resources.conf: EC20 doesn't support
SupplementaryServices"
..
Revert "resources.conf: EC20 doesn't support SupplementaryServices"
This
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5203
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ad35b718e20168a75930498901015ca2015a52
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5204
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9166996f146af7973bf02a8a1c965581dc58a4a5
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1:
What's the point of introducing the error in new code just because old code
have it in some other place as well? And than fixing that in another patch.
I think you should do the right thing in this patch and than fix other places
in a separate patch (as time permits).
--
To
39 matches
Mail list logo
