libgtpnl[master]: Makefile: Build gtp-{link, tunnel} by default, but don't inst...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6517 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd2b3a66e5968686e6bbff59dbc89b7673def8dd Gerrit-PatchSet: 1 Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit

[MERGED] libgtpnl[master]: Makefile: Build gtp-{link, tunnel} by default, but don't inst...

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Makefile: Build gtp-{link,tunnel} by default, but don't install them .. Makefile: Build gtp-{link,tunnel} by default, but don't install them They used t

libosmocore[master]: gsmtap_sendmsg(): clarify API doc concerning msgb ownership

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 we could have added a new function that includes the free, something lie gsmtap_sendmsg_free() and then migrate new cold over, deprecate the old API, ... -- To view, visit https://gerrit.osmocom.org/6512 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerr

libosmocore[master]: memleak: _gsmtap_raw_output(): free msg in case of vsnprintf...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6515 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51431ae7baca33ce5bab085cc3efe25f1a10b6d1 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: memleak: fix all libosmocore callers of gsmtap_sendmsg() to ...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6514 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf64ed9b14247298ed8b4ab8735627f8235a499 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: memleak: gsmtap_sendmsg(): don't return 0 when no data was w...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6513 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I099ae1c663c018da5db884f7e9d52c45af3ed817 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: utils: add osmo-gsmtap-sink, simplistic UDP receiver

2018-02-16 Thread Harald Welte
Patch Set 1: what's the purpose of the tool? is it generically useful to the normal user? If yes, bin_PROGRAMS is fine (but debian/* must be updated, too!). If it's just a hack for developers, then noinst_PROGRAMS might be a better place, i.e. not installing it during "make install". -- To

osmo-bsc[master]: vty: 'show bts': list the TRXs' ARFCNs

2018-02-16 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c File src/libbsc/bsc_vty.c: Line 285: vty_out(vty, " ARFCNs:"); > actually the hopping is in the trx->ts, so I need to iterate all the ts fir yes, or be cheap and simply state "ARFCNs: Hopping" for now. I

osmo-bsc[master]: vty: 'show bts': print neighbor cells

2018-02-16 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6479/1/src/libbsc/bsc_vty.c File src/libbsc/bsc_vty.c: Line 380: case NL_MODE_MANUAL_SI5SEP: I'm not sure if this leads to the correct result. MANUAL_SI5SEP basically means that the neighbor list for BCCH (SI2) is different from th

osmo-msc[master]: iucs: Add a function to return the connection ID for the IU ...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6501 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica4a7f463fcf1bd67fe082296cecea8d10f2fc5b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit

osmo-msc[master]: libmsc: Add a function to return a unique ID of the subscrib...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6502 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b875772e3994ad3458ee60dbf880604486d9afd Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit

[MERGED] osmo-msc[master]: libmsc: Add a function to return a unique ID of the subscrib...

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libmsc: Add a function to return a unique ID of the subscriber conn .. libmsc: Add a function to return a unique ID of the subscriber conn The ID will i

[MERGED] osmo-msc[master]: iucs: Add a function to return the connection ID for the IU ...

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: iucs: Add a function to return the connection ID for the IU SCCP conn .. iucs: Add a function to return the connection ID for the IU SCCP conn Change-Id

osmo-msc[master]: libmsc: bssap: Fix compilation warning

2018-02-16 Thread Harald Welte
Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/5424/4/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: Line 313: memcpy(msg->l3h, TLVP_VAL(tp, GSM0808_IE_LAYER_3_INFORMATION), msgb_l3len(msg)); > As the FIXME comment indicates, current code seems a bit hackish, like m

osmo-bsc[master]: handover_logic.c: always do inter-cell channel activation

2018-02-16 Thread Harald Welte
Patch Set 1: I think this deserves a FIXME in the code and/or a separate redmine issue to make sure we don't forget to work on the intra-BTS assignment later on? -- To view, visit https://gerrit.osmocom.org/6493 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: com

osmo-bsc[master]: handover_logic.c: on HO command, send new lchan's MS power

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6494 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90eda8405f2d2eddfb041ca38b34fe30c397e09d Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: logging: more logs, and more concise logging

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6467 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3999755cdd4e0c2861582b20e2dbb7e1538e074 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: add new_lchan_type arg to bsc_handover_start()

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6463 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4478ebcaada00897cc38c5a299e07661139ed3c5 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: move penalty timers to own file as proper API

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6468 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife975a1c7c17a500b1693be620475a8bea72f86f Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: clearly mark conn penalty timer member for hodec2

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6495 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6c2bc2b10dc424dfd94a9e11a9a62f51c48aa10 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: cosmetic: handover_decision.c: make process_meas_rep() r...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6496 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id455a8becbb43884e8205d87b0371b216d0119fc Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: introduce ho decision callbacks

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6497 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b64504007fe03e0406a4b395cd0359232b77d2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: cosmetic: getting a chan activ nack on a non-ho lchan is...

2018-02-16 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6498 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66c4f45afda614f874c9cdf0c22552f492315b71 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

osmo-bsc[master]: HO: Implement load based handover, as handover_decision_2.c

2018-02-16 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c File src/libbsc/handover_decision_2.c: Line 7: * Author: Andreas Eversberg Andreas' code is not copyright by sysmocom. So it must be copyright by sysmocom + andreas, not "(C) sysmocom, authors an

[PATCH] libosmocore[master]: Support decoding of more cell ID list types in libosmocore.

2018-02-16 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6509 to look at the new patch set (#2). Support decoding of more cell ID list types in libosmocore. Extend gsm0808_dec_cell_id_list() with support for more types of cell identifier lists. Th

[PATCH] libosmocore[master]: Support decoding of more cell ID list types in libosmocore.

2018-02-16 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6509 to look at the new patch set (#3). Support decoding of more cell ID list types in libosmocore. Extend gsm0808_dec_cell_id_list() with support for more types of cell identifier lists. Th

[PATCH] osmo-msc[master]: libmsc: bssap: Remove fixme and properly update msgb tail

2018-02-16 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5424 to look at the new patch set (#5). libmsc: bssap: Remove fixme and properly update msgb tail Change-Id: I28073efd5cff58cd212341bceee784caf08d5ad8 --- M src/libmsc/a_iface_

[PATCH] osmo-msc[master]: Track libosmocore API change in osmo-msc.

2018-02-16 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/6518 Track libosmocore API change in osmo-msc. struct gsm0808_cell_id_list in libosmocore is changed by https://gerrit.osmocom.org/#/c/6509/ This updates the only API user I am aware of. Change-Id: I67377270cf3b081ac5dc9cd7b4dc28f74143753a Depends: Ib7e754

[PATCH] osmo-bsc[master]: Add support for Access Control Class ramping.

2018-02-16 Thread Stefan Sperling
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6324 to look at the new patch set (#6). Add support for Access Control Class ramping. Access Control Class (ACC) ramping is used to slowly make the cell available to an increas

[ABANDON] osmo-bts[master]: Name systemd service after the software

2018-02-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has abandoned this change. Change subject: Name systemd service after the software .. Abandoned -- To view, visit https://gerrit.osmocom.org/2225 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerr

[ABANDON] osmo-pcu[master]: Name systemd service after the software

2018-02-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has abandoned this change. Change subject: Name systemd service after the software .. Abandoned -- To view, visit https://gerrit.osmocom.org/2224 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerr

[PATCH] osmo-gsm-tester[master]: modem: deactive_context: Log when context is successfully de...

2018-02-16 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6519 modem: deactive_context: Log when context is successfully deactivated Change-Id: Ibe40a954aa4548e54b48c444014d7dbd2da9d956 --- M src/osmo_gsm_tester/modem.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo

[PATCH] osmo-gsm-tester[master]: modem: Remove ctx after deactivating it

2018-02-16 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6520 modem: Remove ctx after deactivating it Change-Id: Ib0e2a8ae8d9885fa44c9cc1f7dc7c7948abd683c --- M src/osmo_gsm_tester/modem.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/20/6

osmo-pcu[master]: Use explicit type for pcu_lsb()

2018-02-16 Thread Stefan Sperling
Patch Set 3: The sister function pcu_bitcount() is used on wider types (e.g. see find_multi_slots() which uses it with unsigned int). I think from an API point of view it makes more sense to keep both functions consistent. Is the goal to get rid of templates? In that case, why not use uint32_

osmo-msc[master]: libmsc: bssap: Remove fixme and properly update msgb tail

2018-02-16 Thread Stefan Sperling
Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5424 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28073efd5cff58cd212341bceee784caf08d5ad8 Gerrit-PatchSet: 5 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit

osmo-pcu[master]: Move paging generation into PDCH

2018-02-16 Thread Stefan Sperling
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/6193/2/src/bts.cpp File src/bts.cpp: Line 971: return false; You could change the return type from bool to int and then return -ENOMEM here, instead of encoding the knowledge that 'return false' implies ENOMEM in the caller

osmo-bsc[master]: HO: Implement load based handover, as handover_decision_2.c

2018-02-16 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c File src/libbsc/handover_decision_2.c: Line 7: * Author: Andreas Eversberg > Andreas' code is not copyright by sysmocom. So it must be copyright by sys On the original handover_decision_2.c from b

osmo-bsc[master]: HO: Implement load based handover, as handover_decision_2.c

2018-02-16 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c File src/libbsc/handover_decision_2.c: Line 7: * Author: Andreas Eversberg > On the original handover_decision_2.c from branch jolly/new_handover, the c The other files like handover_cfg.c and hand

[PATCH] libosmocore[master]: Support for more cell ID list types in libosmocore.

2018-02-16 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6509 to look at the new patch set (#4). Support for more cell ID list types in libosmocore. Extend gsm0808_dec_cell_id_list() with support for additional types of cell identifier lists. The

[PATCH] osmo-bsc[master]: HO: Implement load based handover, as handover_decision_2.c

2018-02-16 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6499 to look at the new patch set (#2). HO: Implement load based handover, as handover_decision_2.c Change-Id: Ie597eae82722baf32546331e443dd9d94f1f25e6 --- M configure.ac M doc/examples/osm

[PATCH] osmo-bsc[master]: cosmetic: adjust copyrights on handover_cfg.c, _vty.c

2018-02-16 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/6521 cosmetic: adjust copyrights on handover_cfg.c,_vty.c They are based on work by jolly, so it can't hurt to mark his copyright. Change-Id: Id3856cf34d85d6354510a94960fe5ce810c10bc7 --- M src/libbsc/handover_cfg.c M src/libbsc/handover_vty.c 2 files chang

[PATCH] osmo-bsc[master]: handover_logic.c: always do inter-cell channel activation

2018-02-16 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6493 to look at the new patch set (#2). handover_logic.c: always do inter-cell channel activation In commit [1], the channel activation kind was modified out-of-context to use Immediate Assi

osmo-bsc[master]: handover_logic.c: always do inter-cell channel activation

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6493 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d979094fa16620f1acc5933418797829710ba8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

[MERGED] osmo-bsc[master]: HO: add new_lchan_type arg to bsc_handover_start()

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: add new_lchan_type arg to bsc_handover_start() .. HO: add new_lchan_type arg to bsc_handover_start() Upcoming handover_decision_2 will want to be abl

[MERGED] osmo-bsc[master]: HO: cfg: tweak vty write

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: cfg: tweak vty write .. HO: cfg: tweak vty write Have expicitly named vty write functions for bts and net levels, so that it is trivial to add comman

[MERGED] osmo-bsc[master]: HO: cosmetic: bsc_handover_start(): "fix" memcpy for AMR config

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: cosmetic: bsc_handover_start(): "fix" memcpy for AMR config .. HO: cosmetic: bsc_handover_start(): "fix" memcpy for AMR config memcpy obviously needs

[MERGED] osmo-bsc[master]: HO: store speech codec list from BSSMAP Assignment in conn

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: store speech codec list from BSSMAP Assignment in conn .. HO: store speech codec list from BSSMAP Assignment in conn On BSSMAP Assignment Request rec

[MERGED] osmo-bsc[master]: handover_logic.c: always do inter-cell channel activation

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: handover_logic.c: always do inter-cell channel activation .. handover_logic.c: always do inter-cell channel activation In commit [1], the channel activat

[MERGED] osmo-bsc[master]: HO: logging: more logs, and more concise logging

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: logging: more logs, and more concise logging .. HO: logging: more logs, and more concise logging Explicitly log "Handover" or "Assignment", add more

[MERGED] osmo-bsc[master]: HO: bsc_handover_start_lchan_change(): set MS to max power o...

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: bsc_handover_start_lchan_change(): set MS to max power on handover .. HO: bsc_handover_start_lchan_change(): set MS to max power on handover For re-

[MERGED] osmo-bsc[master]: HO: cosmetic: bsc_handover_start_lchan_change(): tweak local...

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: cosmetic: bsc_handover_start_lchan_change(): tweak local vars .. HO: cosmetic: bsc_handover_start_lchan_change(): tweak local vars To keep this cosm

[MERGED] osmo-bsc[master]: HO: process_meas_rep: guard against modulo zero

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: process_meas_rep: guard against modulo zero .. HO: process_meas_rep: guard against modulo zero Fixes: CID#182318 Change-Id: I3ad9d01cbffa287adce55b35

[MERGED] osmo-bsc[master]: HO: always do async handover

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: always do async handover .. HO: always do async handover We're really only interested in async handover so far. Set ho->async to true always. Change

[MERGED] osmo-bsc[master]: handover_logic.c: on HO command, send new lchan's MS power

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: handover_logic.c: on HO command, send new lchan's MS power .. handover_logic.c: on HO command, send new lchan's MS power Change-Id: I90eda8405f2d2eddfb04

osmo-msc[master]: libmsc: bssap: Remove fixme and properly update msgb tail

2018-02-16 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5424 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28073efd5cff58cd212341bceee784caf08d5ad8 Gerrit-PatchSet: 5 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit

[MERGED] osmo-msc[master]: libmsc: bssap: Remove fixme and properly update msgb tail

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libmsc: bssap: Remove fixme and properly update msgb tail .. libmsc: bssap: Remove fixme and properly update msgb tail Change-Id: I28073efd5cff58cd212341

[MERGED] osmo-bsc[master]: HO: move penalty timers to own file as proper API

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: HO: move penalty timers to own file as proper API .. HO: move penalty timers to own file as proper API Separate penalty timers API from specific struct m

osmo-gsm-tester[master]: modem: Remove ctx after deactivating it

2018-02-16 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6520 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0e2a8ae8d9885fa44c9cc1f7dc7c7948abd683c Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

osmo-gsm-tester[master]: modem: deactive_context: Log when context is successfully de...

2018-02-16 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6519 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe40a954aa4548e54b48c444014d7dbd2da9d956 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master

[MERGED] osmo-gsm-tester[master]: modem: Remove ctx after deactivating it

2018-02-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: modem: Remove ctx after deactivating it .. modem: Remove ctx after deactivating it Change-Id: Ib0e2a8ae8d9885fa44c9cc1f7dc7c7948abd683c --- M src/osm

[MERGED] osmo-gsm-tester[master]: modem: deactive_context: Log when context is successfully de...

2018-02-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: modem: deactive_context: Log when context is successfully deactivated .. modem: deactive_context: Log when context is successfully deactivated Chang

[PATCH] osmo-bsc[master]: vty: 'show bts': list the TRXs' ARFCNs

2018-02-16 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6478 to look at the new patch set (#4). vty: 'show bts': list the TRXs' ARFCNs Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995 --- M src/libbsc/bsc_vty.c 1 file changed, 33 insertions(+

[PATCH] osmo-bsc[master]: vty: 'show bts': print neighbor cells

2018-02-16 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6479 to look at the new patch set (#2). vty: 'show bts': print neighbor cells Print out the current neighbor cell list, works both for manual and automatically populated modes. Examples of

osmo-bsc[master]: HO: Implement load based handover, as handover_decision_2.c

2018-02-16 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6499/1/src/libbsc/handover_decision_2.c File src/libbsc/handover_decision_2.c: Line 7: * Author: Andreas Eversberg > The other files like handover_cfg.c and handover_vty.c also have such copyr other files: see https://gerrit.osmocom.org/

[PATCH] osmo-sip-connector[master]: contrib: Add systemd service file

2018-02-16 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6522 contrib: Add systemd service file Change-Id: I36dd16b75beb4d9bd8081aca6e44c5b72e58fead --- A contrib/systemd/osmo-sip-connector.service 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs

osmo-sip-connector[master]: contrib: Add systemd service file

2018-02-16 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6522 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36dd16b75beb4d9bd8081aca6e44c5b72e58fead Gerrit-PatchSet: 1 Gerrit-Project: osmo-sip-connector Gerrit-Branch: mas

[MERGED] osmo-sip-connector[master]: contrib: Add systemd service file

2018-02-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: contrib: Add systemd service file .. contrib: Add systemd service file Change-Id: I36dd16b75beb4d9bd8081aca6e44c5b72e58fead --- A contrib/systemd/osm

osmo-bsc[master]: HO: cfg: separate hodec1 from hodec2 parameters

2018-02-16 Thread Pau Espin Pedrol
Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/6471/3//COMMIT_MSG Commit Message: Line 38: handover2 window rxlev averaging 7 What about using a node instead of prepending the algorithm to each command? https://gerrit.osmocom.org/#/c/6471/3/src/libbsc/handover_decision.c File s

[PATCH] osmo-gsm-manuals[master]: Improve error message when libosmocom directory cannot be fo...

2018-02-16 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/6523 Improve error message when libosmocom directory cannot be found. The rules in build/Makefile.vty-reference.inc require a libosmocore source tree. Make the top-level Makefile check that LIBOSMO_DIR is set to a valid directory before running the build. T

[PATCH] meta-telephony[201705]: Add osmo-sip-connector recipe

2018-02-16 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6524 Add osmo-sip-connector recipe Change-Id: Iaf7f1c2c611dccbd13bcdd6a5b53d52bee0e84c6 --- A recipes-osmocom/osmo-sip-connector/osmo-sip-connector.inc A recipes-osmocom/osmo-sip-connector/osmo-sip-connector_git.bb 2 files changed, 28 insertions(+), 0 deleti

meta-telephony[201705]: Add osmo-sip-connector recipe

2018-02-16 Thread Pau Espin Pedrol
Patch Set 1: Verified+1 Once it's merged, we need to merge in meta-sysmocom-bsp: branch pespin/osmo-sip-connector to 201705 to have it included in the feeds. -- To view, visit https://gerrit.osmocom.org/6524 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] meta-telephony[201705]: osmo-msc: Drop no longer needed manual removal of files duri...

2018-02-16 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6525 osmo-msc: Drop no longer needed manual removal of files during install osmo-msc a55dda703fc5e367bd58b5f9f6986d62ffbbdb6c dropped those utils as they were already being built by osmo-bsc. Related:OS#2522 Change-Id: Ic048ffc500a56f775046943e0eea89b5d939

meta-telephony[201705]: osmo-msc: Drop no longer needed manual removal of files duri...

2018-02-16 Thread Pau Espin Pedrol
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6525 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic048ffc500a56f775046943e0eea89b5d939b372 Gerrit-PatchSet: 1 Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Ger

[PATCH] osmo-ttcn3-hacks[master]: Osmocom_Types: Add bool2bit() and bool2bit_templ()

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6527 Osmocom_Types: Add bool2bit() and bool2bit_templ() Those can be very handy to convert boolean values and templates to the BIT1 type that is used a lot in Ericsson code. Change-Id: I137595edabd2bbf5e6cf8bf9bdb73b3589c94c64 --- M library/Osmocom_Types.tt

[PATCH] osmo-ttcn3-hacks[master]: Osmocom_Gb_Types: Add ts_BSSGP_UL_UD and tr_BSSGP_PS_PAGING

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6533 Osmocom_Gb_Types: Add ts_BSSGP_UL_UD and tr_BSSGP_PS_PAGING Change-Id: I0504ee9137eef08c2ab0c710d1b57b2c19bf0db8 --- M library/Osmocom_Gb_Types.ttcn 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-

[PATCH] osmo-ttcn3-hacks[master]: Add L3_Common for shared L3 functions between MSC and SGSN t...

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6530 Add L3_Common for shared L3 functions between MSC and SGSN testing Change-Id: I16e80df610235849180dc946f9457302deafb9d2 --- A library/L3_Common.ttcn M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn M msc/gen_links.sh 4 files changed, 35 insertions(

[PATCH] osmo-ttcn3-hacks[master]: bool2bit_tmpl(): Fix for '?' template case

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6531 bool2bit_tmpl(): Fix for '?' template case Change-Id: I6dd3c4afdf61689a23aefc277a70cf298cb24c96 --- M library/Osmocom_Types.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31

[PATCH] osmo-ttcn3-hacks[master]: BSSGP_Emulation: Remove one level of indent (like most other...

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6526 BSSGP_Emulation: Remove one level of indent (like most other code) Change-Id: I1d6de5404dbf907f663ec89b1847c6de84d5d858 --- M library/BSSGP_Emulation.ttcn 1 file changed, 226 insertions(+), 223 deletions(-) git pull ssh://gerrit.osmocom.org:29418/os

[PATCH] osmo-ttcn3-hacks[master]: L3_Templates: Add various GMM related templates

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6528 L3_Templates: Add various GMM related templates ... needed for upcoming SGSN testing Change-Id: I2026c5db3d709566dc3764515d3711b361d82a06 --- M library/L3_Templates.ttcn 1 file changed, 317 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom

[PATCH] osmo-ttcn3-hacks[master]: bool2bit_tmpl(): Print unsupported template in failure case

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6532 bool2bit_tmpl(): Print unsupported template in failure case Change-Id: I53c65e3a2b71e4c9b6691969d50def69b25ddfd0 --- M library/Osmocom_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: L3_Templates: Fix ts_MI_TMSI_TLV / ts_MI_IMSI_LV / ts_MI_IME...

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6535 L3_Templates: Fix ts_MI_TMSI_TLV / ts_MI_IMSI_LV / ts_MI_IMEI_LV It seems not all encoder paths properly set typeOfIdentity, so let's make sure we set it correctly. Change-Id: Ie35dcf7fec901b786eb2127c1a23f5c161c5778c --- M library/L3_Templates.ttcn 1

[PATCH] osmo-ttcn3-hacks[master]: msc: move f_gen_{imei, imsi, msisdn} to L3_Templates.ttcn

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6529 msc: move f_gen_{imei,imsi,msisdn} to L3_Templates.ttcn This allows them to be reused in upcoming SGSN tests. Change-Id: I0459eeb44e58342da656f2312560466698374b72 --- M library/L3_Templates.ttcn M msc/MSC_Tests.ttcn 2 files changed, 21 insertions(+), 2

[PATCH] osmo-ttcn3-hacks[master]: L3_Templates: More GMM related templates

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6534 L3_Templates: More GMM related templates Change-Id: Idf305731afb9a4c316e7320553705946c3edb633 --- M library/L3_Templates.ttcn 1 file changed, 158 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34

osmo-bsc[master]: vty: 'show bts': list the TRXs' ARFCNs

2018-02-16 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6478 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

[MERGED] osmo-bsc[master]: vty: 'show bts': list the TRXs' ARFCNs

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: 'show bts': list the TRXs' ARFCNs .. vty: 'show bts': list the TRXs' ARFCNs Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995 --- M src/libbsc/bs

[MERGED] osmo-bsc[master]: vty: 'show bts': print neighbor cells

2018-02-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vty: 'show bts': print neighbor cells .. vty: 'show bts': print neighbor cells Print out the current neighbor cell list, works both for manual and automa

osmo-bsc[master]: vty: 'show bts': print neighbor cells

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6479 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57dae0e01b81a6f028b39f3edcaf430251ca8fe2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit

[PATCH] osmo-ttcn3-hacks[master]: sgsn: Skeleton of a SGSN test fremwork

2018-02-16 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6404 to look at the new patch set (#3). sgsn: Skeleton of a SGSN test fremwork Based on the exsting NS/BSSGP emulation as well as the VTY, GSUP and CTRL implementations, we are now building

[PATCH] osmo-ttcn3-hacks[master]: WIP: First actual SGSN test case

2018-02-16 Thread Harald Welte
Review at https://gerrit.osmocom.org/6536 WIP: First actual SGSN test case Change-Id: Id66ddf8dbe1c5cfa96a087235588ba67763b7f05 --- M library/BSSGP_Emulation.ttcn A library/LLC_Templates.ttcn M sgsn/SGSN_Tests.ttcn M sgsn/gen_links.sh M sgsn/regen_makefile.sh 5 files changed, 786 insertions(+),

[PATCH] osmo-ttcn3-hacks[master]: gprs: Move NS Types/CodecPort/Emulation to library directory

2018-02-16 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6399 to look at the new patch set (#3). gprs: Move NS Types/CodecPort/Emulation to library directory Change-Id: I876ce0e981d70ff0e737175983002268fd690989 --- M gprs_gb/gen_links.sh R library

osmo-ttcn3-hacks[master]: L3_Templates: Add various GMM related templates

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6528 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2026c5db3d709566dc3764515d3711b361d82a06 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: msc: move f_gen_{imei, imsi, msisdn} to L3_Templates.ttcn

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6529 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0459eeb44e58342da656f2312560466698374b72 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: Add L3_Common for shared L3 functions between MSC and SGSN t...

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6530 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e80df610235849180dc946f9457302deafb9d2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: sgsn: Skeleton of a SGSN test fremwork

2018-02-16 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6404 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce90f9d8a680c7a523163e2c0bc03d12ff857e2 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: L3_Templates: More GMM related templates

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6534 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf305731afb9a4c316e7320553705946c3edb633 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: Osmocom_Gb_Types: Add ts_BSSGP_UL_UD and tr_BSSGP_PS_PAGING

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6533 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0504ee9137eef08c2ab0c710d1b57b2c19bf0db8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: bool2bit_tmpl(): Print unsupported template in failure case

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6532 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53c65e3a2b71e4c9b6691969d50def69b25ddfd0 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: bool2bit_tmpl(): Fix for '?' template case

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6531 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6dd3c4afdf61689a23aefc277a70cf298cb24c96 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: L3_Templates: Fix ts_MI_TMSI_TLV / ts_MI_IMSI_LV / ts_MI_IME...

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6535 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie35dcf7fec901b786eb2127c1a23f5c161c5778c Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

osmo-ttcn3-hacks[master]: Osmocom_Types: Add bool2bit() and bool2bit_templ()

2018-02-16 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6527 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I137595edabd2bbf5e6cf8bf9bdb73b3589c94c64 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: maste

  1   2   >