Harald Welte has submitted this change and it was merged.
Change subject: mgcp_protocol: Don't print osmux stats if it is off
..
mgcp_protocol: Don't print osmux stats if it is off
Otherwise we get Osmux stats during a session
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6598
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4db7f6d18f650f36f3186965096771f748de5fd
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6599
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I814b2051edc85ad5cbd04c96b785c208f6606683
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: HO: vty: clearly mark 'handover foo' as legacy alias for
'handover1 foo'
..
HO: vty: clearly mark 'handover foo' as legacy alias for 'handover1 foo'
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6601
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86be674d82242f9ca73a4d0040015c1c79f2422d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6602/1/include/osmocom/iuh/hnbgw.h
File include/osmocom/iuh/hnbgw.h:
Line 102: bool hnb_registered;
maybe RUA rx code should reject messages for !hnb_registered ? Can that occur?
--
To view, visit https://gerrit.osmocom.org/6602
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6602/1/src/hnbgw_hnbap.c
File src/hnbgw_hnbap.c:
Line 430: talloc_free(name);
At this point I ask myself: who is deallocating a rejected hnb_context? As it
is now, any failed HNBAP request leaves a hnb_context
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/i586
Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bsc
Last lines of build log:
Harald Welte has submitted this change and it was merged.
Change subject: Move PDCH-related functions into separate files
..
Move PDCH-related functions into separate files
The PDCH class and corresponding functions are rather
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6053
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie05e25361e6741a81b024679f9675c98d4923683
Gerrit-PatchSet: 6
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6602
ensure unique CellIDs in HNB-GW
If we receive a HNB-REGISTER-REQ with a cell ID which is already used
by another registered NNB, log an error and send HNB-REGISTER-REJECT.
Tested manually by running two 'hnb-test' programs concurrently (they
need to
HO: vty: clearly mark 'handover foo' as legacy alias for 'handover1 foo'
The ALIAS_DEPRECATED causes the legacy commands to no longer show up in the
command listing, hence making it more clear which commands are general and
which are for hodec1 only:
== BEFORE: ==
OsmoBSC(config-net)# list
Review at https://gerrit.osmocom.org/6601
HO: vty: clearly mark 'handover foo' as legacy alias for 'handover1 foo'
The ALIAS_DEPRECATED causes the legacy commands to no longer show up in the
command listing, hence making it more clear which commands are general and
which are for hodec1 only:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#26).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3905
to look at the new patch set (#16).
Simplify TS alloc: move slot assignment
Move into separate functions:
* move timeslot reservation
* move UL timeslot
Neels Hofmeyr has submitted this change and it was merged.
Change subject: drop unused libmsc/meas_feed.h
..
drop unused libmsc/meas_feed.h
Change I0d57ac214e574e267fa9752daf76566197b9aa64 forgot to remove this
file along with
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6600
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2566013dd30b21ce2774cd4cc7dcba2408f938f
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6600
to look at the new patch set (#4).
drop unused libmsc/meas_feed.h
Change I0d57ac214e574e267fa9752daf76566197b9aa64 forgot to remove this
file along with meas_feed.c.
Note also the
Patch Set 2: Code-Review-1
I want to discuss this one with Daniel before merging, so -1 for now.
--
To view, visit https://gerrit.osmocom.org/6598
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4db7f6d18f650f36f3186965096771f748de5fd
Patch Set 2:
Once merged, it needs to be fw-ported to osmo-mgw in
src/libosmo-mgcp/mgcp_stat.c
--
To view, visit https://gerrit.osmocom.org/6599
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I814b2051edc85ad5cbd04c96b785c208f6606683
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6053
to look at the new patch set (#6).
Move PDCH-related functions into separate files
The PDCH class and corresponding functions are rather self-contained and
independent
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6598
to look at the new patch set (#2).
bsc-nat: Enable octet-aligned when ensuring mode set
>From RFC 4857:
octet-align: Permissible values are 0 and 1. If 1, octet-aligned
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6600
to look at the new patch set (#3).
drop unused libmsc/meas_feed.h
Change I0d57ac214e574e267fa9752daf76566197b9aa64 forgot to remove this
file along with meas_feed.c.
meas_feed from
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6600
to look at the new patch set (#2).
drop unused libmsc/meas_feed.h
meas_feed from the old osmo-nitb (openbsc.git) has / should have moved to
osmo-bsc. There are no measurement reports
Patch Set 2: Code-Review+2
triviality +2
--
To view, visit https://gerrit.osmocom.org/6600
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2566013dd30b21ce2774cd4cc7dcba2408f938f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: cosmetic: getting a chan activ nack on a non-ho lchan is
not an error
..
HO: cosmetic: getting a chan activ nack on a non-ho lchan is not an error
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: cosmetic: handover_decision.c: make process_meas_rep()
return void
..
HO: cosmetic: handover_decision.c: make process_meas_rep() return void
The
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: Implement load based handover, as handover_decision_2.c
..
HO: Implement load based handover, as handover_decision_2.c
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: adjust copyrights on handover_cfg.c,_vty.c
..
cosmetic: adjust copyrights on handover_cfg.c,_vty.c
They are based on work by jolly, so it
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: introduce ho decision callbacks
..
HO: introduce ho decision callbacks
Instead of reacting on S_LCHAN* signals in the handover decision code,
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: clearly mark conn penalty timer member for hodec2
..
HO: clearly mark conn penalty timer member for hodec2
The conn's penalty timers will be used
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: vty: rename ho decision 1 vty to 'handover1' with
'handover' alias
..
HO: vty: rename ho decision 1 vty to 'handover1' with 'handover' alias
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6599
to look at the new patch set (#2).
mgcp_protocol: Don't print osmux stats if it is off
Otherwise we get Osmux stats during a session using RTP, which is
confusing.
Change-Id:
Patch Set 1:
> If log_target_create_gsmtap() is called with add_sink==true (which
> it is from logging_vty.c) then the GSMTAP packets are both
> originated and received by the program. No additional tool should
> be required.
What about sysmoBTS sending gsmtap to a different machine, and
Patch Set 5: Code-Review+2
only trivial merge conflict resolution / tweak since +2 on patch set 1
--
To view, visit https://gerrit.osmocom.org/6495
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c2bc2b10dc424dfd94a9e11a9a62f51c48aa10
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6500
to look at the new patch set (#4).
HO: vty: rename ho decision 1 vty to 'handover1' with 'handover' alias
Handover decision 2 arguments are now configured by 'handover2
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6499
to look at the new patch set (#4).
HO: Implement load based handover, as handover_decision_2.c
Change-Id: Ie597eae82722baf32546331e443dd9d94f1f25e6
---
M configure.ac
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6495
to look at the new patch set (#5).
HO: clearly mark conn penalty timer member for hodec2
The conn's penalty timers will be used only for handover decision 2, make it
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6495
to look at the new patch set (#4).
HO: clearly mark conn penalty timer member for hodec2
The conn's penalty timers will be used only for handover decision 2, make it
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6495
to look at the new patch set (#3).
HO: clearly mark conn penalty timer member for hodec2
The conn's penalty timers will be used only for handover decision 2, make it
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: lchan: store last seen measurement report nr, tweak log
..
HO: lchan: store last seen measurement report nr, tweak log
Handover decision 2 will
Neels Hofmeyr has submitted this change and it was merged.
Change subject: HO: cfg: separate hodec1 from hodec2 parameters
..
HO: cfg: separate hodec1 from hodec2 parameters
Do not share config items between the current
Patch Set 3:
(just to note, I actually missed that mail on openbsc@ telling me to not bother
about this in the first place, sorry about that. For that matter, this patch
took like half an hour to write and test.)
--
To view, visit https://gerrit.osmocom.org/6471
To unsubscribe, visit
Review at https://gerrit.osmocom.org/6600
drop unused libmsc/meas_feed.h
Change-Id: Ib2566013dd30b21ce2774cd4cc7dcba2408f938f
---
D src/libmsc/meas_feed.h
1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/00/6600/1
diff --git
Review at https://gerrit.osmocom.org/6598
bsc-nat: Enable octet-aligned when ensuring mode set
>From RFC 4857:
octet-align: Permissible values are 0 and 1. If 1, octet-aligned
operation SHALL be used. If 0 or if not present,
bandwidth-efficient operation
Review at https://gerrit.osmocom.org/6599
mgcp_protocol: Don't print osmux stats if it is off
Otherwise we get Osmux stats during a session using RTP, which is
confusing.
Change-Id: I814b2051edc85ad5cbd04c96b785c208f6606683
---
M openbsc/src/libmgcp/mgcp_protocol.c
1 file changed, 18
Harald Welte has submitted this change and it was merged.
Change subject: sysmo+lc15: Add missign include for readv/writev
..
sysmo+lc15: Add missign include for readv/writev
This avoids compiler warnings like this:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6597
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If988a7679f3a9253fab1a4d177a276d8ecaf794f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6595
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic748038e6f25ec18ccb4a2f2503ca567fb00a586
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6596
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic67d369a3ca33bfa636ace9f272f1c7257de86e1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: sysmo: Fix compiler warnings in eeprom.c
..
sysmo: Fix compiler warnings in eeprom.c
This avoids compiler warnings like
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#7).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#5).
Support for more cell ID list types in libosmocore.
Extend gsm0808_dec_cell_id_list() with support for additional types of
cell identifier lists. The
Patch Set 4:
> > The concept oft lac/RAC/Rai/cid/CGI is mich More generic than
> > 08.08. We should use some generic type to represent one such
> > identity
>
> In gsm23003.h we alreay have various structures that could be
> re-used, I presume?
Two of them can be used: osmo_cell_global_id
Review at https://gerrit.osmocom.org/6596
sysmo+lc15: Add missign include for readv/writev
This avoids compiler warnings like this:
../../src/osmo-bts-sysmo/l1_transp_hw.c:130:13: warning: implicit declaration
of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]
Review at https://gerrit.osmocom.org/6597
trx: make l1if_fill_meas_res() static
it's not used anywhere outside of l1_if.c, so make it a static function
Change-Id: If988a7679f3a9253fab1a4d177a276d8ecaf794f
---
M src/osmo-bts-trx/l1_if.c
M src/osmo-bts-trx/l1_if.h
2 files changed, 1
Review at https://gerrit.osmocom.org/6595
sysmo: Fix compiler warnings in eeprom.c
This avoids compiler warnings like
../../src/osmo-bts-sysmo/eeprom.c: In function ‘eeprom_WriteSysInfo’:
../../src/osmo-bts-sysmo/eeprom.c:605:58: warning: cast from pointer to integer
of different size
Harald Welte has submitted this change and it was merged.
Change subject: Add tests for OS#2714, "close RSL connections from unknown Unit
ID".
..
Add tests for OS#2714, "close RSL connections from unknown Unit ID".
This adds
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6406
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a947d7411a016e4d7650031396cae3575756453
Gerrit-PatchSet: 6
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6406
to look at the new patch set (#6).
Add tests for OS#2714, "close RSL connections from unknown Unit ID".
This adds two new tests: One for RSL, and a second one which performs
the same
Patch Set 4:
> The concept oft lac/RAC/Rai/cid/CGI is mich More generic than
> 08.08. We should use some generic type to represent one such
> identity
In gsm23003.h we alreay have various structures that could be re-used, I
presume?
--
To view, visit https://gerrit.osmocom.org/6509
To
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: Pretend MNCC requested release in handle_error()
..
libmsc: Pretend MNCC requested release in handle_error()
Send a release request to the MS so
Patch Set 1: Code-Review+1
@neels (or others): Do you think we should install an alias for backwards
compatibility? I think it's not worth it. It's not a config node (i.e. no old
config files relevant) and only a debugging command anyway...
--
To view, visit https://gerrit.osmocom.org/6593
Harald Welte has submitted this change and it was merged.
Change subject: bssmap_handle_assignm_req(): Use more conscise error/log
message texts
..
bssmap_handle_assignm_req(): Use more conscise error/log message texts
Harald Welte has submitted this change and it was merged.
Change subject: SIGTRAN: correct wrong log category
..
SIGTRAN: correct wrong log category
osmo_bsc_sigtran.c uses DRANAP instead of DMSC in two places,
this is not
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6594
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Permit set of multiple different A5 ciphers
..
Permit set of multiple different A5 ciphers
So far, the administrator had to pick one particular cipher
Harald Welte has submitted this change and it was merged.
Change subject: logging: Remove obsolete log categories
..
logging: Remove obsolete log categories
About half of our log categories/subsystems were inherited from
Harald Welte has submitted this change and it was merged.
Change subject: bssmap_handle_assignm_req(): Don't print log statemens in
malloc failure case
..
bssmap_handle_assignm_req(): Don't print log statemens in malloc
Harald Welte has submitted this change and it was merged.
Change subject: bssmap_handle_assignm_req(): Use proper cause values
..
bssmap_handle_assignm_req(): Use proper cause values
The BSSMAP Cause value should give a clear
Harald Welte has submitted this change and it was merged.
Change subject: chan_compat_with_mode: signalling works over all channel types
..
chan_compat_with_mode: signalling works over all channel types
chan_compat_with_mode()
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6592
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85ffcbd32ccd2617c897edb3b904f56bacd0684f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6591
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85528689b5298a13c60ae80fabd8d66459f730a9
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6590
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbdfd7591aaeedf24ff0de5f34093be78e2833a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6589
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86adcae2950cbea6dcac4551cfde1054cb0abad1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6544
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d1c8131855bcab2392b4f27f6216bdb2fae10e0
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6588
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1594d1906cf7d053d00fff52e9dc0ddfd097ed6e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 4:
> You wrote "fixed" but I don't see that next patch yet?
It seems I somehow forgot to push this patchset to gerrit. Sorry about that.
I've just pushed it.
--
To view, visit https://gerrit.osmocom.org/6406
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6406
to look at the new patch set (#4).
Add tests for OS#2714, "close RSL connections from unknown Unit ID".
This adds two new tests: One for RSL, and a second one which performs
the same
Review at https://gerrit.osmocom.org/6593
Align syntax of "handover" + "assignment" command with that of lchan act/deact
We already have other commands that operate on a given bts/trx/ts/ss,
let's make sure they have a shared/common syntax for consistency.
This also fixes the issue that the
Review at https://gerrit.osmocom.org/6594
bsc_vty: Merge more VTY documentation string #defines
Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f
---
M src/libbsc/bsc_vty.c
1 file changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/6592
chan_compat_with_mode: signalling works over all channel types
chan_compat_with_mode() currently only considered the requirements of
voice/csd services. It failed to realize that GSM48_CMODE_SIGN
can also be performed over a SDCCH, resulting in
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6544
to look at the new patch set (#5).
Permit set of multiple different A5 ciphers
So far, the administrator had to pick one particular cipher which
would then be used
Review at https://gerrit.osmocom.org/6591
bssmap_handle_assignm_req(): Don't print log statemens in malloc failure case
Change-Id: I85528689b5298a13c60ae80fabd8d66459f730a9
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 1 insertion(+), 4 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6590
bssmap_handle_assignm_req(): Use more conscise error/log message texts
Change-Id: Iffbdfd7591aaeedf24ff0de5f34093be78e2833a
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6589
bssmap_handle_assignm_req(): Use proper cause values
The BSSMAP Cause value should give a clear indication of why a given
operation failed. Previously we were unconditionally sending
GSM0808_CAUSE_NO_RADIO_RESOURCE_AVAILABLE even in cases where
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6544
to look at the new patch set (#4).
Permit set of multiple different A5 ciphers
So far, the administrator had to pick one particular cipher which
would then be used
Review at https://gerrit.osmocom.org/6588
SIGTRAN: correct wrong log category
osmo_bsc_sigtran.c uses DRANAP instead of DMSC in two places,
this is not correct.
- change wrong DRANAP to DMSC
Change-Id: I1594d1906cf7d053d00fff52e9dc0ddfd097ed6e
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file
Harald Welte has submitted this change and it was merged.
Change subject: osmo-mgw: Add talloc context introspection via VTY
..
osmo-mgw: Add talloc context introspection via VTY
This requires libosmocore with Change-Id
Harald Welte has submitted this change and it was merged.
Change subject: build: Fix typo in the CFLAGS-variable for libosmodsp
..
build: Fix typo in the CFLAGS-variable for libosmodsp
Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6364
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida258588538a8a76d97a8c1e8855b2fd28c63be7
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: transceiver: Fix RSP SETSLOT format
..
transceiver: Fix RSP SETSLOT format
According to osmo-trx README:
SETSLOT sets the format of the uplink timeslots
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/6457
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: transceiver: Fix RSP SETSLOT format
..
transceiver: Fix RSP SETSLOT format
According to osmo-trx README:
SETSLOT sets the format of the uplink timeslots
1 - 100 of 154 matches
Mail list logo
