Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/6319/1//COMMIT_MSG
Commit Message:
Line 18: OS#2710
in order to be easily picked up by robots, please put this on the same line.
Also drop the blank line between this and the Change-Id.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6618
to look at the new patch set (#4).
Depend on libosmocore and enable talloc reports
Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
---
M Transceiver52M/Makefile.am
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6620
to look at the new patch set (#4).
Logger: Use libosmocore logging system
We still need an intermediate class Logger due to osmo-trx being
multi-threaded and requiring to have a lock
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6619
to look at the new patch set (#4).
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6613
to look at the new patch set (#2).
Logger: Drop syslog support
This feature is currently not being used, so let's drop it to make it
easier to integrate into libosmocore logging system
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6619
to look at the new patch set (#3).
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't
Patch Set 2:
Depends on libosmocore Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9 (6623)
--
To view, visit https://gerrit.osmocom.org/6619
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad
Review at https://gerrit.osmocom.org/6624
contrib: jenkins.sh: Disable doxygen in libosmocore build
Change-Id: I12d995c0c993483ed940fc173904d6e686fbe0ab
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh
Review at https://gerrit.osmocom.org/6625
contrib: jenkins.sh: Disable doxygen in libosmocore build
Change-Id: I7befa0cb4e72a6ad086e3c2d290546dbf22f1676
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector
Review at https://gerrit.osmocom.org/6623
ports.h: Add VTY and CTRL ports for osmo-trx
Change-Id: Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9
---
M include/osmocom/ctrl/ports.h
M include/osmocom/vty/ports.h
2 files changed, 4 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6622
contrib: jenkins.sh: Disable doxygen in libosmocore build
Change-Id: I52fc3931ef072075561858bb7173f58a8503e499
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis
Review at https://gerrit.osmocom.org/6621
contrib: jenkins.sh: Disable doxygen in libosmocore build
Change-Id: I7abc8862a63d448408ae43802da689fe436a0ff0
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp
Depend on libosmocore and enable talloc reports
Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
---
M Transceiver52M/Makefile.am
M Transceiver52M/osmo-trx.cpp
M configure.ac
M contrib/jenkins.sh
4 files changed, 56 insertions(+), 15 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6620
Logger: Use libosmocore logging system
We still need an intermediate class Logger due to osmo-trx being
multi-threaded and requiring to have a lock to use libosmocore, which is
not thread safe.
Change-Id: I30baac89f53e927f8699d0586b43cccf88ecd493
---
Patch Set 1: Code-Review-1
Don't merge yet starting from this commit, since VTY parameter reading is still
not done. It will come in next commits together with dropping parameters other
than -C (which will be reconverted to -c).
--
To view, visit https://gerrit.osmocom.org/6619
To
Review at https://gerrit.osmocom.org/6619
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't have a lot of use yet.
Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad
---
M
Review at https://gerrit.osmocom.org/6615
Logger: Remove unused includes
Change-Id: I4d26c0b4f36ee3c66ed1a9e2e9fa2fa8272da16d
---
M CommonLibs/Logger.h
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/6615/1
diff --git
Review at https://gerrit.osmocom.org/6616
Logger: Remove gLogToConsole flag
No code is using it and we always lock to console anyways.
Change-Id: I5fde99c6af5a845e635b5d27abab855682071f14
---
M CommonLibs/Logger.cpp
M CommonLibs/Logger.h
2 files changed, 8 insertions(+), 15 deletions(-)
Review at https://gerrit.osmocom.org/6617
configure.ac: Check for pkg-config
Change-Id: I1a851181a99f2f35ea4ff1b38c7afe27a04e5f18
---
M configure.ac
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/17/6617/1
diff --git
Review at https://gerrit.osmocom.org/6618
Depend on libosmocore and enable talloc reports
Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
---
M Transceiver52M/Makefile.am
M Transceiver52M/osmo-trx.cpp
M configure.ac
3 files changed, 39 insertions(+), 14 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6614
Logger: Drop support to log into file
This feature is currently not being used, so let's simplify current code
to move to libosmocore logging system in the future.
Change-Id: If2c77c776823f595130edac963be953026049423
---
M CommonLibs/Logger.cpp
1 file
Review at https://gerrit.osmocom.org/6612
Logger: get rid of alarm APIs
It's only used internally inside the Logger module, and in case there's
an "alarm" (level more than critical) we still print on cerr, so we can
just rely on our system catching stderr instead of stdout to handle it.
Review at https://gerrit.osmocom.org/6613
Logger: Drop syslog support
This feature is currently not being used, so let's drop it to make it
easier to integrate into libosmocore logging system in the future.
Change-Id: I8282745ef0282d41599eaf94fe460a1d29b18e2a
---
M CommonLibs/Logger.cpp
M
Review at https://gerrit.osmocom.org/6611
Logger: Remove unused logging macros
Change-Id: I1133e181183bec8dabe2fa77d0385f783458503f
---
M CommonLibs/Logger.h
1 file changed, 0 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/6611/1
diff --git
Review at https://gerrit.osmocom.org/6610
Logger: Drop unused gLogEarly
Change-Id: I2c8f24fbf453e0a94d7a95c3df7cc75f0e4bd456
---
M CommonLibs/Logger.cpp
M CommonLibs/Logger.h
2 files changed, 0 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: legacy: mgcp_protocol: Don't print osmux stats if it is off
..
legacy: mgcp_protocol: Don't print osmux stats if it is off
Otherwise we get Osmux
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: mgcp_stat: Don't print osmux stats if it is off
..
mgcp_stat: Don't print osmux stats if it is off
Otherwise we get Osmux stats during a session
Harald Welte has submitted this change and it was merged.
Change subject: drop unused libbsc/meas_proc.c
..
drop unused libbsc/meas_proc.c
The file meas_proc.c seems to be an earlier stage of development of the meas
rep
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6603
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If30724e3c638b191d20d00b897731762fb4896d5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6605
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fcd680a073fbf8769488ffa2b2b32098c87edf4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6604
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9031350242dd37ce255631c20eed33976887faa6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6608
IPA_Emulation: Make dependencies to RSL/MGCP/SCCP/GSUP conditional
Let's use the preprocessor to avoid IPA_Emulation pulling *all*
dependencies into each and any of our projects. The code readability
suffers a bit from the many #ifdefs, but
Review at https://gerrit.osmocom.org/6607
RSL_Types: Add templates for "BSC side"
So far, the RSL templates have been used for BSC testing, i.e.
TTCN3 behaving like a BTS. Now we want to test the BTS, so we
have to "invert" the receive/send direction and hence also need
the inverse templates.
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6606
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7e1d4815d72b8e0bbc6ccd68078a78de19d73b0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix handover_test link error
..
fix handover_test link error
Fix undefined references during link stage when building handover_test.
The archive
Review at https://gerrit.osmocom.org/6606
fix handover_test link error
Fix undefined references during link stage when building handover_test.
The archive libbsc.a needs to be listed before the various .so files.
Change-Id: Ie7e1d4815d72b8e0bbc6ccd68078a78de19d73b0
---
M
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/6319/1/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:
Line 240: osmo_strlcpy(mgcp_msg.endpoint, mgcp_ctx->rtp_endpoint,
sizeof(mgcp_msg.endpoint));
This change removes a check for truncation. Is this intended?
You could keep
Review at https://gerrit.osmocom.org/6604
legacy: mgcp_protocol: Don't print osmux stats if it is off
Otherwise we get Osmux stats during a session using RTP, which is
confusing.
Forward-ported from openbsc e39e18992a3b966581f06fa632d6342643996aaa.
Change-Id:
Review at https://gerrit.osmocom.org/6605
mgcp_stat: Don't print osmux stats if it is off
Otherwise we get Osmux stats during a session using RTP, which is
confusing.
Change-Id: I6fcd680a073fbf8769488ffa2b2b32098c87edf4
---
M src/libosmo-mgcp/mgcp_stat.c
M tests/mgcp/mgcp_test.c
M
Max has submitted this change and it was merged.
Change subject: Simplify TS alloc: don't use PDCH for free TFI
..
Simplify TS alloc: don't use PDCH for free TFI
Don't use PDCH from free TFI lookup routine. This allows for
Max has submitted this change and it was merged.
Change subject: Simplify TS alloc: constify max dl slot func
..
Simplify TS alloc: constify max dl slot func
Constify parameters of gprs_alloc_max_dl_slots_per_ms().
Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#6).
support for more cell ID list types in libosmocore
Extend gsm0808_dec_cell_id_list() with support for additional types of
cell identifier lists. The
Review at https://gerrit.osmocom.org/6603
drop unused libbsc/meas_proc.c
The file meas_proc.c seems to be an earlier stage of development of the meas
rep handling now in handover_decision.c, and to have been inadvertently added
to the git tree in:
commit
43 matches
Mail list logo
