Change in osmo-sgsn[master]: WIP: tests: remove gmm unit tests

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9258 ) Change subject: WIP: tests: remove gmm unit tests .. Patch Set 1: According to the build/check log, it makes sense to update the 'sgsn_tes

Change in osmo-sgsn[master]: WIP: tests: remove gmm unit tests

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9258 ) Change subject: WIP: tests: remove gmm unit tests .. Patch Set 1: Ah, Harald most likely meant -2... -- To view, visit https://gerrit.os

Change in osmo-ci[master]: add "osmocom-workstation" role

2018-06-10 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9522 Change subject: add "osmocom-workstation" role .. add "osmocom-workstation" role this role can be used to provision developer workstations, wh

Change in osmo-ci[master]: gerrit/gerrit: Add osmo-sysmon build verification

2018-06-10 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9521 Change subject: gerrit/gerrit: Add osmo-sysmon build verification .. gerrit/gerrit: Add osmo-sysmon build verification Change-Id: I41411123836

Change in osmo-ci[master]: add "osmocom-workstation" role

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9522 ) Change subject: add "osmocom-workstation" role .. add "osmocom-workstation" role this role can be used to provision developer worksta

Change in osmo-ci[master]: gerrit/gerrit: Add osmo-sysmon build verification

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9521 ) Change subject: gerrit/gerrit: Add osmo-sysmon build verification .. gerrit/gerrit: Add osmo-sysmon build verification Change-Id: I41

Change in osmo-ci[master]: gerrit/gerrit: Add osmo-sysmon build verification

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9521 ) Change subject: gerrit/gerrit: Add osmo-sysmon build verification .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.

Change in osmo-ci[master]: add "osmocom-workstation" role

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9522 ) Change subject: add "osmocom-workstation" role .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9522 To

Change in osmo-ttcn3-hacks[master]: msc/USSD: add unknown request code testcase

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9470 ) Change subject: msc/USSD: add unknown request code testcase .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/9470 To

Change in osmo-ttcn3-hacks[master]: msc/USSD: test USSD-request during an active call

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9471 ) Change subject: msc/USSD: test USSD-request during an active call .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/94

Change in osmo-msc[master]: libmsc/ussd.c: use connection ref-counting and transactions

2018-06-10 Thread Vadim Yanitskiy
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7699 to look at the new patch set (#2). Change subject: libmsc/ussd.c: use connection ref-counting and transactions .

Change in osmo-msc[master]: libmsc/ussd.c: FIX: properly indicate errors

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9523 Change subject: libmsc/ussd.c: FIX: properly indicate errors .. libmsc/ussd.c: FIX: properly indicate errors There are error and problem co

Change in osmo-ttcn3-hacks[master]: msc/USSD: test USSD-request during an active call

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9471 ) Change subject: msc/USSD: test USSD-request during an active call .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-ttcn3-hacks[master]: msc/USSD: add unknown request code testcase

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9470 ) Change subject: msc/USSD: add unknown request code testcase .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9470

Change in osmo-ttcn3-hacks[master]: msc/USSD: add unknown request code testcase

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9470 ) Change subject: msc/USSD: add unknown request code testcase .. msc/USSD: add unknown request code testcase The idea of this testcase

Change in osmo-ttcn3-hacks[master]: msc/USSD: test USSD-request during an active call

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9471 ) Change subject: msc/USSD: test USSD-request during an active call .. msc/USSD: test USSD-request during an active call The idea of th

Change in osmo-msc[master]: libmsc/ussd.c: FIX: properly indicate errors

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9523 ) Change subject: libmsc/ussd.c: FIX: properly indicate errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9523

Change in osmo-msc[master]: libmsc/ussd.c: use connection ref-counting and transactions

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/7699 ) Change subject: libmsc/ussd.c: use connection ref-counting and transactions .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom

Change in osmo-msc[master]: libmsc/ussd.c: FIX: properly indicate errors

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9523 ) Change subject: libmsc/ussd.c: FIX: properly indicate errors .. libmsc/ussd.c: FIX: properly indicate errors There are error and prob

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #150

2018-06-10 Thread jenkins
See -- [...truncated 2.08 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host sy

Change in osmo-msc[master]: libmsc/ussd.c: use connection ref-counting and transactions

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/7699 ) Change subject: libmsc/ussd.c: use connection ref-counting and transactions .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/76

Change in osmo-msc[master]: libmsc: properly name the MSC_CONN_USE token for SS

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9524 Change subject: libmsc: properly name the MSC_CONN_USE token for SS .. libmsc: properly name the MSC_CONN_USE token for SS Previously the M

Change in osmo-msc[master]: libmsc/ussd.c: use connection ref-counting and transactions

2018-06-10 Thread Vadim Yanitskiy
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7699 to look at the new patch set (#3). Change subject: libmsc/ussd.c: use connection ref-counting and transactions ...

Change in osmo-bts[master]: lc15: Use correct type got hLayer1 field

2018-06-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/9525 Change subject: lc15: Use correct type got hLayer1 field .. lc15: Use correct type got hLayer1 field It also fixes a compilation warning i

Change in osmo-bts[master]: lc15: Use correct type for hLayer1 field

2018-06-10 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/9525 ) Change subject: lc15: Use correct type for hLayer1 field .. lc15: Use correct type for hLayer1 field It also fixes a compilation warning in

Change in osmo-ttcn3-hacks[master]: bts: More complete AGCH / IMM.ASS testing

2018-06-10 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9526 Change subject: bts: More complete AGCH / IMM.ASS testing .. bts: More complete AGCH / IMM.ASS testing The existing test simply sent 1000 mess

Change in osmo-bts[master]: lc15: Use correct type for hLayer1 field

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9525 ) Change subject: lc15: Use correct type for hLayer1 field .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9525 To

Change in osmo-ttcn3-hacks[master]: bts: More complete AGCH / IMM.ASS testing

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9526 ) Change subject: bts: More complete AGCH / IMM.ASS testing .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9526 To

Change in osmo-ttcn3-hacks[master]: bts: More complete AGCH / IMM.ASS testing

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9526 ) Change subject: bts: More complete AGCH / IMM.ASS testing .. bts: More complete AGCH / IMM.ASS testing The existing test simply sent

Change in osmo-bts[master]: lc15: Use correct type for hLayer1 field

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9525 ) Change subject: lc15: Use correct type for hLayer1 field .. lc15: Use correct type for hLayer1 field It also fixes a compilation warn

Change in osmo-msc[master]: libmsc: properly name the MSC_CONN_USE token for SS

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9524 ) Change subject: libmsc: properly name the MSC_CONN_USE token for SS .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.o

Change in osmo-msc[master]: libmsc: properly name the MSC_CONN_USE token for SS

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9524 ) Change subject: libmsc: properly name the MSC_CONN_USE token for SS .. libmsc: properly name the MSC_CONN_USE token for SS Previously

Change in osmo-msc[master]: libmsc/ussd.c: use connection ref-counting and transactions

2018-06-10 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/7699 ) Change subject: libmsc/ussd.c: use connection ref-counting and transactions .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.o

Change in osmo-msc[master]: libmsc/ussd.c: use connection ref-counting and transactions

2018-06-10 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/7699 ) Change subject: libmsc/ussd.c: use connection ref-counting and transactions .. libmsc/ussd.c: use connection ref-counting and transact

Change in osmo-bsc[master]: remove traces of osmo-bsc_nat in python test (osmoappdesc/test_runner)

2018-06-10 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9527 Change subject: remove traces of osmo-bsc_nat in python test (osmoappdesc/test_runner) .. remove traces of osmo-bsc_nat in python test (osmoap

Change in libosmocore[master]: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9528 Change subject: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag() .. gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag() In some cases,

Change in libosmocore[master]: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

2018-06-10 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9528 to look at the new patch set (#2). Change subject: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag() .. gsm/gsm0480

Change in libosmocore[master]: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie()

2018-06-10 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/9529 Change subject: gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie() .. gsm/gsm0480: refactor and expose gsm0480_parse_facility_ie()