Change in docker-playground[master]: Add ttcn3-bscnat-test docker image

2018-11-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11657 ) Change subject: Add ttcn3-bscnat-test docker image .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11657 To unsubscribe, o

Change in osmo-gsm-tester[master]: iperf3: Fix parsing of incorrect json from iperf3

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11712 ) Change subject: iperf3: Fix parsing of incorrect json from iperf3 .. iperf3: Fix parsing of incorrect json from iperf3 Change-Id

Change in libosmo-sccp[master]: Make pointcode width function public

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11709 ) Change subject: Make pointcode width function public .. Patch Set 2: Code-Review-1 Why is it needed to be public? Please state so in the

Change in libosmo-sccp[master]: Log ip:port for created SS7 server

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11708 ) Change subject: Log ip:port for created SS7 server .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11708/2/src

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11716/1/sr

Change in osmo-bsc[master]: vty: add command to show TRX selectively

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11721 ) Change subject: vty: add command to show TRX selectively .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11721

Change in libosmo-sccp[master]: SS7: safeguard against wrong number of pointcode component

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11707 ) Change subject: SS7: safeguard against wrong number of pointcode component .. Patch Set 1: Code-Review-1 (1 comment) This function is s

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11724 Change subject: unix-time-to-fmt.py: fix crash without argument .. unix-time-to-fmt.py: fix crash without argument Print "unknown" to stdout when un

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: make clean: also rm *.html

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11723 Change subject: Makefile.asciidoc.inc: make clean: also rm *.html .. Makefile.asciidoc.inc: make clean: also rm *.html HTML files get created when a

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11722 Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Makefile.asciidoc.inc: always exit 1 on a2x error a2x wraps asciidoc. When a2x

Change in osmo-gsm-manuals[master]: move project specific manuals to their own repos

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11725 Change subject: move project specific manuals to their own repos .. move project specific manuals to their own repos * use autotools (so we can "mak

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11727 Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. merge_doc.xsl: move to osmo-gsm-manuals.git Allows building the manuals without the c

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11722/1/bu

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: make clean: also rm *.html

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11723 ) Change subject: Makefile.asciidoc.inc: make clean: also rm *.html .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmoco

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Wouldn't it make more sense to take now() as date or 0?

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Why is this needed? Where is it called without arguments

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: Can you add a link here as a comment to the commit adding th

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > Where is it called without arguments and why? https://git.osmoco

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11722/1/build/Makefil

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: > Can you add a link here as a comment to the commit adding this to >

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: What about fixing the Makefile lines to include -C or wh

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: > > Can you add a link here as a comment to the commit addin

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > What about fixing the Makefile lines to include -C or whatever wh

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: always exit 1 on a2x error

2018-11-12 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11722 ) Change subject: Makefile.asciidoc.inc: always exit 1 on a2x error .. Makefile.asciidoc.inc: always exit 1 on a2x error a2x wraps asciidoc.

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Code-Review+1 > > What about fixing the Makefile lines t

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11728 Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. gsm0808: add message generator for BSSMAP HANDOVER PERFORMED We curr

Change in osmo-sgsn[master]: fix bogus assertion in encode_comp_field()

2018-11-12 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11729 Change subject: fix bogus assertion in encode_comp_field() .. fix bogus assertion in encode_comp_field() Fix an obvious logic bug in an as

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-12 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11730 Change subject: fix bogus error check in gprs_sndcp_comp_create() .. fix bogus error check in gprs_sndcp_comp_create() The function gprs_s

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed te...

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11731 Change subject: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed template .. BSSMAP_Templates: Add missing field in tr_BSSMAP_Hand

Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11733 Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. BSC_Tests: expect a HANDOVER PERFORMED message on internal ha

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed...

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11732 Change subject: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed template .. BSSMAP_Templates: do not match on omit in tr_BSSMA

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11734 Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. handover_fsm: send HANDOVER PERFORMED msg on internal ho When an interna

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11735 Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. bts: Allocate TRX for BTS dynamically, deprecate -t No need to pas

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/

Change in osmo-sgsn[master]: fix bogus assertion in encode_comp_field()

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11729 ) Change subject: fix bogus assertion in encode_comp_field() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11730 ) Change subject: fix bogus error check in gprs_sndcp_comp_create() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11730/1/sr

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed...

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11732 ) Change subject: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed template .. Patch Set 1: Code-Review+1 -- To vie

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed te...

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11731 ) Change subject: BSSMAP_Templates: Add missing field in tr_BSSMAP_HandoverPerformed template .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed...

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11732 ) Change subject: BSSMAP_Templates: do not match on omit in tr_BSSMAP_HandoverPerformed template .. Patch Set 1: Code-Review+2 -- To vie

Change in osmo-gsm-manuals[master]: move project specific files to their own repos

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11738 Change subject: move project specific files to their own repos .. move project specific files to their own repos Related: OS#3385 Change-Id: Ib234fe

Change in osmo-gsm-manuals[master]: Makefile: move dep-check code to check-depends.sh

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11737 Change subject: Makefile: move dep-check code to check-depends.sh .. Makefile: move dep-check code to check-depends.sh Make it possible to run the d

Change in osmo-gsm-manuals[master]: merge_doc.xsl: move from libosmocore.git

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11736 Change subject: merge_doc.xsl: move from libosmocore.git .. merge_doc.xsl: move from libosmocore.git Allow building manuals without the libosmocore

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11739 Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. merge_doc.xsl: move to osmo-gsm-manuals.git Allows building the manuals without the c

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/117

Change in osmo-gsm-manuals[master]: merge_doc.xsl: move from libosmocore.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11736 ) Change subject: merge_doc.xsl: move from libosmocore.git .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/117

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/11727 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Abandoned New version with updated depends ID: https://gerrit.osmocom.org/#/c/libosmocore/+/1

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11739 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: The file gets added here: https://gerrit.osmocom.org/#/c/osmo-gsm-manua

Change in osmo-gsm-manuals[master]: Makefile: move dep-check code to check-depends.sh

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11737 ) Change subject: Makefile: move dep-check code to check-depends.sh .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Keith Whyte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11716 to look at the new patch set (#2). Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Allow GSM340_

Change in osmo-gsm-manuals[master]: move project specific files to their own repos

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11738 ) Change subject: move project specific files to their own repos .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.o

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11739 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/

Change in osmo-gsm-manuals[master]: merge_doc.xsl: move from libosmocore.git

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11736 ) Change subject: merge_doc.xsl: move from libosmocore.git .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/117

Change in osmo-msc[master]: move project specific manuals to their own repos

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/11716/2/sr

Change in osmo-sgsn[master]: fix bogus assertion in encode_comp_field()

2018-11-12 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11729 ) Change subject: fix bogus assertion in encode_comp_field() .. fix bogus assertion in encode_comp_field() Fix an obvious logic bug

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11735 ) Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. Patch Set 1: Code-Review-1 (7 comments) https://gerrit.osmocom.or

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/11656/

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-12 Thread Stefan Sperling
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11656 to look at the new patch set (#2). Change subject: use enums consistently instead of falling back to int ..

Change in osmo-gsm-manuals[master]: Makefile.common.inc: add publish target

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11740 Change subject: Makefile.common.inc: add publish target .. Makefile.common.inc: add publish target Publishes all generated PDFs to rita.osmocom.org.

Change in pysim[master]: pySim/transport: introduce Calypso based reader interface

2018-11-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/11480 ) Change subject: pySim/transport: introduce Calypso based reader interface .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/

Change in pysim[master]: pySim-*.py: refactor card reader driver initialization

2018-11-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/11481 ) Change subject: pySim-*.py: refactor card reader driver initialization .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/114

Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-12 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11741 Change subject: gitignore: add make/ and net/ (with exceptions) .. gitignore: add make/ and net/ (with exceptions) Ignore all files and folders that

Change in osmo-gsm-manuals[master]: Makefile.common.inc: add publish target

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11740 ) Change subject: Makefile.common.inc: add publish target .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/1174

Change in osmo-bsc[master]: always directly send BSSMAP Clear Request

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11700 ) Change subject: always directly send BSSMAP Clear Request .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11700 To unsu

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11735 to look at the new patch set (#2). Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t ..

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11735 ) Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11735/1/

Change in osmo-ttcn3-hacks[master]: bsc: add inter-bsc ho incoming failure tests

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11699 ) Change subject: bsc: add inter-bsc ho incoming failure tests .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11699/1/bsc/BSC_Tests.ttcn

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #305

2018-11-12 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host sy

Change in osmo-bsc[master]: abis_rsl.c: drop unused enum sacch_deact

2018-11-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11665 ) Change subject: abis_rsl.c: drop unused enum sacch_deact .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11665 To unsub

Change in pysim[master]: pySim-*.py: refactor card reader driver initialization

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11481 ) Change subject: pySim-*.py: refactor card reader driver initialization .. pySim-*.py: refactor card reader driver initialization

Change in pysim[master]: pySim/transport: introduce Calypso based reader interface

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11480 ) Change subject: pySim/transport: introduce Calypso based reader interface .. pySim/transport: introduce Calypso based reader inter

Change in pysim[master]: pySim-*.py: add command line option for Calypso reader

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11482 ) Change subject: pySim-*.py: add command line option for Calypso reader .. pySim-*.py: add command line option for Calypso reader

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11742 Change subject: coverity: gscon_forget_lchan: squelch forward-null .. coverity: gscon_forget_lchan: squelch forward-null conn->fi should act

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11735 to look at the new patch set (#3). Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t ..

Change in osmo-bts[master]: bts: Allocate TRX for BTS dynamically, deprecate -t

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11735 ) Change subject: bts: Allocate TRX for BTS dynamically, deprecate -t .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmoc

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

2018-11-12 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11743 Change subject: support odd-length calling MSISDN in MSC tests .. support odd-length calling MSISDN in MSC tests MSC tests were unable to

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Keith Whyte
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11716 to look at the new patch set (#3). Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. ...

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

2018-11-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11637 ) Change subject: hlr: Fix DTE by requesting the correct type .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/1

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11637 ) Change subject: hlr: Fix DTE by requesting the correct type .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/116

Change in osmo-ttcn3-hacks[master]: hlr: Fix DTE by requesting the correct type

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11637 ) Change subject: hlr: Fix DTE by requesting the correct type .. hlr: Fix DTE by requesting the correct type Previous commit d686a8a5

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11743 ) Change subject: support odd-length calling MSISDN in MSC tests .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

2018-11-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11743 ) Change subject: support odd-length calling MSISDN in MSC tests .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11743/1/librar

Change in osmo-ttcn3-hacks[master]: support odd-length calling MSISDN in MSC tests

2018-11-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11743 ) Change subject: support odd-length calling MSISDN in MSC tests .. Patch Set 1: Sure, thanks! -- To view, visit https://gerrit.osmocom.o

Change in libosmo-abis[master]: osmo_ortp: Log domain and fix strings without endl char

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11744 Change subject: osmo_ortp: Log domain and fix strings without endl char .. osmo_ortp: Log domain and fix strings without endl char Change

Change in osmo-bsc[master]: coverity: gscon_forget_lchan: squelch forward-null

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11742 ) Change subject: coverity: gscon_forget_lchan: squelch forward-null .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11742/1/s

Change in osmo-sip-connector[master]: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg.

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osm

Change in osmo-gsm-tester[master]: default-suites: Enable tests for LimeSDR-USB

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11745 Change subject: default-suites: Enable tests for LimeSDR-USB .. default-suites: Enable tests for LimeSDR-USB Change-Id: I896ea76f1d2847ec

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 1: Code-Review+1 (4 comments) patch looks good, but

Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11733 ) Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. Patch Set 1: Code-Review+1 (1 comment) https://ger

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11734/

Change in osmo-msc[master]: Store subscriber's cell identity

2018-11-12 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11746 Change subject: Store subscriber's cell identity .. Store subscriber's cell identity It's defined similar to LAC and could be potentially useful for co

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. Patch Set 4: Code-Review+2 (1 comment) though I'm not familiar I'm goin

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. Patch Set 4: added bonus if you include the change-id of a patch using t

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11701 ) Change subject: BSC_ConnectionHandler: make VTY interface available .. Patch Set 2: Code-Review+2 added bonus if you include the change-id

Change in osmo-msc[master]: vlr: use unused is_ps parameter in vlr_subscr_req_lu()

2018-11-12 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11563 ) Change subject: vlr: use unused is_ps parameter in vlr_subscr_req_lu() .. Patch Set 1: Code-Review-1 let's rather drop the argument and alw

  1   2   >