Change in osmo-gsm-manuals[master]: use autotools to add "make install" target

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11725 ) Change subject: use autotools to add "make install" target .. Patch Set 5: Code-Review+1 would +2 but you wrote you'd still update check-de

Change in osmo-gsm-manuals[master]: prepare for autotools: add git-version-gen

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11797 ) Change subject: prepare for autotools: add git-version-gen .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1179

Change in osmo-gsm-manuals[master]: make check: properly reference dependencies

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11794 ) Change subject: make check: properly reference dependencies .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11794

Change in osmo-gsm-manuals[master]: copy NITB's osmobsc-usermanual.adoc to OsmoBSC

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11805 ) Change subject: copy NITB's osmobsc-usermanual.adoc to OsmoBSC .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/

Change in osmo-gsm-manuals[master]: cosmetic: update usage of OSMO_GSM_MANUALS_DIR

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11806 ) Change subject: cosmetic: update usage of OSMO_GSM_MANUALS_DIR .. Patch Set 2: I mean ../osmo-gsm-manuals/ by default, and reconfigurable b

Change in osmo-gsm-manuals[master]: cosmetic: update usage of OSMO_GSM_MANUALS_DIR

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11806 ) Change subject: cosmetic: update usage of OSMO_GSM_MANUALS_DIR .. Patch Set 2: I kind of imagined that I just place osmo-gsm-manuals.git ne

Change in osmo-gsm-manuals[master]: remove project specific files

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11738 ) Change subject: remove project specific files .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11738/5//COMMIT_MSG

Change in osmo-gsm-manuals[master]: publish from project repos, not this repo anymore

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11740 ) Change subject: publish from project repos, not this repo anymore .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c

Change in osmo-gsm-manuals[master]: *.adoc: use {srcdir} for out-of-tree builds

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11804 ) Change subject: *.adoc: use {srcdir} for out-of-tree builds .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/118

Change in osmo-gsm-manuals[master]: Makefile.*.inc: adjust to out-of-tree building

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11803 ) Change subject: Makefile.*.inc: adjust to out-of-tree building .. Patch Set 1: Code-Review-1 (3 comments) (this is a -0.5) https://gerrit

Change in osmo-gsm-manuals[master]: vty_reference_combine.sh: add *reference.xml arg

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11801 ) Change subject: vty_reference_combine.sh: add *reference.xml arg .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in osmo-gsm-manuals[master]: Osmo*/Makefile.am: use $(srcdir)

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11802 ) Change subject: Osmo*/Makefile.am: use $(srcdir) .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11802/1/OsmoBSC/

Change in osmo-gsm-manuals[master]: *-vty-reference.xml: use ./common, not ../common

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11800 ) Change subject: *-vty-reference.xml: use ./common, not ../common .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in osmo-gsm-manuals[master]: *.adoc: include from ./common, not ../common

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11799 ) Change subject: *.adoc: include from ./common, not ../common .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11

Change in osmo-gsm-manuals[master]: *filter.conf/*.sty: use symlinks to build, common

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11798 ) Change subject: *filter.conf/*.sty: use symlinks to build, common .. Patch Set 1: Code-Review+2 (3 comments) https://gerrit.osmocom.org/#/

Change in osmo-gsm-manuals[master]: s/TOPDIR/OSMO_GSM_MANUALS_DIR/g

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11796 ) Change subject: s/TOPDIR/OSMO_GSM_MANUALS_DIR/g .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11796 To unsubs

Change in osmo-gsm-manuals[master]: tests: add shared content pdf build tests

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11795 ) Change subject: tests: add shared content pdf build tests .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11795

Change in osmo-msc[master]: move project specific manuals to their own repos

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 2: Code-Review-1 (1 comment) looks mint except for myscript.

Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11741 ) Change subject: gitignore: add make/ and net/ (with exceptions) .. gitignore: add make/ and net/ (with exceptions) Ignore all files

Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11741 ) Change subject: gitignore: add make/ and net/ (with exceptions) .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.

Change in osmo-dev[master]: gitignore: update src/ whitelist

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11759 ) Change subject: gitignore: update src/ whitelist .. gitignore: update src/ whitelist gits has replaced most shell scripts from src.

Change in osmo-dev[master]: gitignore: update src/ whitelist

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11759 ) Change subject: gitignore: update src/ whitelist .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/117

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 3: Code-Review+1 this issue looks like it is growing a beard? St

Change in libosmocore[master]: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11833 ) Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK .. Patch Set 1: Code-Review+2 add the comment if you like, I think

Change in osmo-mgw[master]: add DLCX command statistics to osmo-mgw

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11521 ) Change subject: add DLCX command statistics to osmo-mgw .. Patch Set 4: (5 comments) https://gerrit.osmocom.org/#/c/11521/1/src/libosmo-mg

Change in osmo-msc[master]: osmo_msc: remove unused parameter from msc_dtap()

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11835 ) Change subject: osmo_msc: remove unused parameter from msc_dtap() .. Patch Set 2: (I fixed the invocation from iucs.c) -- To view, visit

Change in osmo-msc[master]: osmo_msc: remove unused parameter from msc_dtap()

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded a new patch set (#2) to the change originally created by dexter. ( https://gerrit.osmocom.org/11835 ) Change subject: osmo_msc: remove unused parameter from msc_dtap() .. osmo_msc: remove unused parame

Change in osmo-msc[master]: osmo_msc: remove unused parameter from msc_dtap()

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11835 ) Change subject: osmo_msc: remove unused parameter from msc_dtap() .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11734/

Change in osmo-bts[master]: bts-trx: Allow re-try without exit if POWERON fails in osmo-trx

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11768 ) Change subject: bts-trx: Allow re-try without exit if POWERON fails in osmo-trx .. Patch Set 3: Code-Review+2 (1 comment) https://gerrit.o

Change in osmo-bts[master]: bts-trx: setup timer once at creation time

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11766 ) Change subject: bts-trx: setup timer once at creation time .. Patch Set 3: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/11766

Change in osmo-bsc[master]: bsc: si: Fix SI2ter L2 pseudo length

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11830 ) Change subject: bsc: si: Fix SI2ter L2 pseudo length .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11830 To u

Change in osmo-bsc[master]: bsc: si: Fix SI2bis L2 pseudo length

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11829 ) Change subject: bsc: si: Fix SI2bis L2 pseudo length .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11829 To u

Change in osmo-bsc[master]: bsc: Prefix log string with related SI type during call to list_arfcn

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11828 ) Change subject: bsc: Prefix log string with related SI type during call to list_arfcn .. Patch Set 1: Code-Review+2 -- To view, visit htt

Change in osmo-bsc[master]: bsc: Enable force-combined-si on nanoBTS by default

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11834 ) Change subject: bsc: Enable force-combined-si on nanoBTS by default .. Patch Set 1: Code-Review+2 (2 comments) https://gerrit.osmocom.org/

Change in osmo-trx[master]: UHDDevice: setRxGain on chan 0 when using multi-arfcn

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11571 ) Change subject: UHDDevice: setRxGain on chan 0 when using multi-arfcn .. Patch Set 3: can't vote because this makes zero sense to me. Set t

Change in osmo-bsc[master]: bsc: vty: Verify and warn on invalid arfcn passed

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11791 ) Change subject: bsc: vty: Verify and warn on invalid arfcn passed .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c

Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11789 ) Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc .. Patch Set 1: Code-Review-1 (2 comments) https:

Change in osmo-msc[master]: msc: vty: Fix integer printf formatting

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11824 ) Change subject: msc: vty: Fix integer printf formatting .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11824 T

Change in osmo-bsc[master]: ipaccess-config: Use stderr for debug type messages when using -G

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11687 ) Change subject: ipaccess-config: Use stderr for debug type messages when using -G .. Patch Set 6: I'd still prefer if (!quiet)

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11837 ) Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. Patch Set 2: Code-Review-1 similar things as for the MO-forwardSM patc

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11836 ) Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. Patch Set 2: Code-Review-1 (12 comments) I'm sorry to criticise

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-11-19 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11836 to look at the new patch set (#2). Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/11837 ) Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. chapters/gsup.adoc: document READY-FOR-SM message Change-Id: I549b6c88

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document READY-FOR-SM message

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11837 Change subject: chapters/gsup.adoc: document READY-FOR-SM message .. chapters/gsup.adoc: document READY-FOR-SM message Change-Id: I549b6c8

Change in osmo-gsm-manuals[master]: chapters/gsup.adoc: document MO-/MT-forwardSM messages

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11836 Change subject: chapters/gsup.adoc: document MO-/MT-forwardSM messages .. chapters/gsup.adoc: document MO-/MT-forwardSM messages Change-Id

Change in libosmocore[master]: LCLS: add GCR routines

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS: add GCR routines .. Patch Set 4: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/11827/4/include/osmoco

Change in libosmocore[master]: LCLS: add 48.008 parameter structure

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11703 ) Change subject: LCLS: add 48.008 parameter structure .. Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11703/3//

Change in osmo-msc[master]: osmo_msc: remove unused parameter from msc_dtap()

2018-11-19 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11835 Change subject: osmo_msc: remove unused parameter from msc_dtap() .. osmo_msc: remove unused parameter from msc_dtap() The parameter link_id in the

Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11789 ) Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc .. Patch Set 1: > Hi, > > > I could change th

Change in osmocom-bb[master]: mobile: fix vty bind ip override

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11457 ) Change subject: mobile: fix vty bind ip override .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11457 To un

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11787 ) Change subject: add/clean big-endian packed structs (struct_endianess.py) .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11

Change in osmo-bsc[master]: bsc: si: Fix SI2ter L2 pseudo length

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11830 ) Change subject: bsc: si: Fix SI2ter L2 pseudo length .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11830 To

Change in osmo-bsc[master]: bsc: si: Fix SI2bis L2 pseudo length

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11829 ) Change subject: bsc: si: Fix SI2bis L2 pseudo length .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11829 To

Change in osmo-bsc[master]: bsc: Prefix log string with related SI type during call to list_arfcn

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11828 ) Change subject: bsc: Prefix log string with related SI type during call to list_arfcn .. Patch Set 1: Code-Review+1 -- To view, visit h

Change in libosmocore[master]: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11833 ) Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.o

Change in libosmocore[master]: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11833 ) Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.

Change in libosmocore[master]: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11833 ) Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/1183

Change in osmo-bsc[master]: bsc: Enable force-combined-si on nanoBTS by default

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11834 Change subject: bsc: Enable force-combined-si on nanoBTS by default .. bsc: Enable force-combined-si on nanoBTS by default Some nanoBTS f

Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11789 ) Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc .. Patch Set 1: Hi, > I could change the commi

Change in osmocom-bb[master]: mobile: fix vty bind ip override

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11457 ) Change subject: mobile: fix vty bind ip override .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11457 To uns

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/1

Change in libosmocore[master]: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK

2018-11-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11833 ) Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11

Change in libosmocore[master]: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK

2018-11-19 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11833 Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK .. send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK In gprs

Change in osmocom-bb[master]: mobile: fix vty bind ip override

2018-11-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11457 ) Change subject: mobile: fix vty bind ip override .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11457 To unsubscribe, or for he

Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11733 ) Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. Patch Set 3: let's see... OK you're right. The spe

Change in libosmocore[master]: add/clean big-endian packed structs (struct_endianess.py)

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11787 ) Change subject: add/clean big-endian packed structs (struct_endianess.py) .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/1178

Change in osmo-ttcn3-hacks[master]: MSC_Tests: remove unused control interface

2018-11-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11690 ) Change subject: MSC_Tests: remove unused control interface .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11690/4/msc/MSC_Tests.ttcn File

Change in osmo-dev[master]: gits: use @{u} to get upstream branch, not origin/%s

2018-11-19 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11756 to look at the new patch set (#4). Change subject: gits: use @{u} to get upstream branch, not origin/%s .. gits: use @{u} to g

Change in osmo-dev[master]: gits: when asking for reset --hard, also offer push -f

2018-11-19 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11758 to look at the new patch set (#4). Change subject: gits: when asking for reset --hard, also offer push -f .. gits: when asking

Change in osmo-dev[master]: gits: remove code dup: ask_reset_hard()

2018-11-19 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11757 to look at the new patch set (#4). Change subject: gits: remove code dup: ask_reset_hard() .. gits: remove code dup: ask_reset

Change in osmo-dev[master]: gits: use @{u} to get upstream branch, not origin/%s

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11756 ) Change subject: gits: use @{u} to get upstream branch, not origin/%s .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11756/1/sr

Change in osmo-dev[master]: gits: when asking for reset --hard, also offer push -f

2018-11-19 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11758 to look at the new patch set (#3). Change subject: gits: when asking for reset --hard, also offer push -f .. gits: when asking

Change in osmo-dev[master]: gits: remove code dup: ask_reset_hard()

2018-11-19 Thread Neels Hofmeyr
Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11757 to look at the new patch set (#3). Change subject: gits: remove code dup: ask_reset_hard() .. gits: remove code dup: ask_reset

Change in osmo-dev[master]: gits: fix git_can_fast_forward: use arg instead of HEAD

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11755 ) Change subject: gits: fix git_can_fast_forward: use arg instead of HEAD .. gits: fix git_can_fast_forward: use arg instead of HEAD

Change in osmo-dev[master]: gits: fix git_can_fast_forward: use arg instead of HEAD

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11755 ) Change subject: gits: fix git_can_fast_forward: use arg instead of HEAD .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https:/

Change in osmo-ttcn3-hacks[master]: bsc: add inter-bsc ho incoming failure tests

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11699 ) Change subject: bsc: add inter-bsc ho incoming failure tests .. bsc: add inter-bsc ho incoming failure tests Change-Id: I849e4c0a14

Change in osmo-ttcn3-hacks[master]: bsc: add inter-bsc ho incoming failure tests

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11699 ) Change subject: bsc: add inter-bsc ho incoming failure tests .. Patch Set 2: Code-Review+2 whitespace fixed -- To view, visit https://ger

Change in osmo-ttcn3-hacks[master]: bsc: add inter-bsc ho incoming failure tests

2018-11-19 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11699 to look at the new patch set (#2). Change subject: bsc: add inter-bsc ho incoming failure tests .. bsc:

Change in libosmocore[master]: add contrib/struct_endianess.py

2018-11-19 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11786 to look at the new patch set (#3). Change subject: add contrib/struct_endianess.py .. add contrib/s

Change in libosmocore[master]: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc

2018-11-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11789 ) Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc .. Patch Set 1: > osmo_gsm_arfcn2band That sounds better.

Change in libosmocore[master]: add contrib/struct_endianess.py

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11786 ) Change subject: add contrib/struct_endianess.py .. Patch Set 2: (6 comments) more replies in the form of comments in the next patch set...

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #312

2018-11-19 Thread jenkins
See -- [...truncated 3.74 KB...] checking build system type... x86_64-unknown-linux-gnu checking host system type... x8

Change in osmo-msc[master]: Use libosmocore to function to parse cipher mode reject cause

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11832 ) Change subject: Use libosmocore to function to parse cipher mode reject cause .. Patch Set 1: -Code-Review (2 comments) https://gerrit.

Jenkins build is back to normal : master-osmo-bts » lc15,v2017.01,default,osmocom-master-debian9 #1435

2018-11-19 Thread jenkins
See

Jenkins build is back to normal : master-osmo-bts » oct,master,default,osmocom-master-debian9 #1435

2018-11-19 Thread jenkins
See

Change in osmo-msc[master]: Use libosmocore to function to parse cipher mode reject cause

2018-11-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11832 ) Change subject: Use libosmocore to function to parse cipher mode reject cause .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11832/1/src/

Change in libosmocore[master]: gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie

2018-11-19 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11788 ) Change subject: gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie .. gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie Th

Change in osmo-msc[master]: Use BSSAP-specific TLV parser from libosmocore

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11831 ) Change subject: Use BSSAP-specific TLV parser from libosmocore .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.or

Change in osmo-trx[master]: UHDDevice: setRxGain on chan 0 when using multi-arfcn

2018-11-19 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11571 ) Change subject: UHDDevice: setRxGain on chan 0 when using multi-arfcn .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osm

Change in osmo-msc[master]: Use libosmocore to function to parse cipher mode reject cause

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11832 ) Change subject: Use libosmocore to function to parse cipher mode reject cause .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.

Change in osmo-msc[master]: Use BSSAP-specific TLV parser from libosmocore

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11831 ) Change subject: Use BSSAP-specific TLV parser from libosmocore .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.o

Change in osmo-msc[master]: Use libosmocore to function to parse cipher mode reject cause

2018-11-19 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11832 Change subject: Use libosmocore to function to parse cipher mode reject cause .. Use libosmocore to function to parse cipher mode reject cause This all

Change in osmo-msc[master]: Use BSSAP-specific TLV parser from libosmocore

2018-11-19 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11831 Change subject: Use BSSAP-specific TLV parser from libosmocore .. Use BSSAP-specific TLV parser from libosmocore Change-Id: Iae1a3ffcebf1b0b95e61cd5dff

Change in osmo-bsc[master]: bsc: si: Fix SI2bis L2 pseudo length

2018-11-19 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11829 to look at the new patch set (#2). Change subject: bsc: si: Fix SI2bis L2 pseudo length .. bsc: si: Fix SI2bis L2 pse

Change in osmo-bsc[master]: bsc: si: Fix SI2ter L2 pseudo length

2018-11-19 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11830 to look at the new patch set (#2). Change subject: bsc: si: Fix SI2ter L2 pseudo length .. bsc: si: Fix SI2ter L2 pse

Change in osmo-bsc[master]: bsc: si: Fix SI2bis L2 pseudo length

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11829 Change subject: bsc: si: Fix SI2bis L2 pseudo length .. bsc: si: Fix SI2bis L2 pseudo length 3GPP TS 04.08 V7.21.0, section "9.1.33 Syste

Change in osmo-bsc[master]: bsc: si: Fix SI2ter L2 pseudo length

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11830 Change subject: bsc: si: Fix SI2ter L2 pseudo length .. bsc: si: Fix SI2ter L2 pseudo length 3GPP TS 04.08 V7.21.0, section "9.1.34 Syste

Change in osmo-bsc[master]: bsc: Prefix log string with related SI type during call to list_arfcn

2018-11-19 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11828 Change subject: bsc: Prefix log string with related SI type during call to list_arfcn .. bsc: Prefix log string with related SI type duri

Change in osmo-bsc[master]: vty: add command to show TRX selectively

2018-11-19 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11721 ) Change subject: vty: add command to show TRX selectively .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11721 To unsubscribe, o

  1   2   >