Change in osmo-mgw[master]: mgcp_client: logging tweaks

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12270 Change subject: mgcp_client: logging tweaks .. mgcp_client: logging tweaks Fix typos, use osmo_sock_get_name2() to show the tx source and ta

Change in osmo-mgw[master]: drop/replace very weird logging in mgcp_client.c

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12269 Change subject: drop/replace very weird logging in mgcp_client.c .. drop/replace very weird logging in mgcp_client.c mgcp_do_write() is the

Change in libosmocore[master]: add to osmo_sock_get_name*() API

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12268 Change subject: add to osmo_sock_get_name*() API .. add to osmo_sock_get_name*() API Basically, I am applying code review that I would have

Change in osmo-msc[master]: vty: show subscriber: put() before printing the use count

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12266 Change subject: vty: show subscriber: put() before printing the use count .. vty: show subscriber: put() before printing the use count Do no

Change in osmo-msc[master]: log: by default start with all categories on LOGL_NOTICE

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12267 Change subject: log: by default start with all categories on LOGL_NOTICE .. log: by default start with all categories on LOGL_NOTICE They we

Jenkins build is back to normal : master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7409

2018-12-11 Thread jenkins
See

Build failed in Jenkins: master-osmo-msc » --enable-iu,0,a3=default,a4=default,osmocom-master-debian9 #7408

2018-12-11 Thread jenkins
See -- [...truncated 24.06 KB...] CC bits.lo CC bitcomp.lo CC counter.lo

Change in osmo-mgw[master]: check_rtp: on IP:port errors, log the IP and port

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12265 Change subject: check_rtp: on IP:port errors, log the IP and port .. check_rtp: on IP:port errors, log the IP and port Half of those are obv

Change in osmo-bsc[master]: paging: Properly enclose logging imsi filter scope

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12251 ) Change subject: paging: Properly enclose logging imsi filter scope .. paging: Properly enclose logging imsi filter scope Otherwi

Change in osmo-bsc[master]: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12250 ) Change subject: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet .. VTY: Allow logging filter imsi statem

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12256 ) Change subject: bsc: bssap: Set subscr log context during paging .. bsc: bssap: Set subscr log context during paging Change-Id:

Change in osmo-bsc[master]: bsc: rsl: Set subscr log context during meas report

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12254 ) Change subject: bsc: rsl: Set subscr log context during meas report .. bsc: rsl: Set subscr log context during meas report Chang

Change in osmo-bsc[master]: bsc: Set subscr log context during complete_layer3

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12253 ) Change subject: bsc: Set subscr log context during complete_layer3 .. bsc: Set subscr log context during complete_layer3 Change-

Change in osmo-bsc[master]: bsc_main: filter_fn: Compare imsi values instead of subscr pointers

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12252 ) Change subject: bsc_main: filter_fn: Compare imsi values instead of subscr pointers .. bsc_main: filter_fn: Compare imsi values

Change in osmo-bsc[master]: bsc: dtap: Set subscr log context

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12255 ) Change subject: bsc: dtap: Set subscr log context .. bsc: dtap: Set subscr log context Change-Id: I362a7d10f5ca9a95b594f7caafd7e

Change in osmo-bsc[master]: paging: fix whitespace

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12249 ) Change subject: paging: fix whitespace .. paging: fix whitespace Change-Id: I81c4a9f0dbd708df27a485ef764c9524a36d548a --- M src/

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12256 ) Change subject: bsc: bssap: Set subscr log context during paging .. Patch Set 2: Code-Review+2 Adding +2 myself since I fixed the cosmet

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12256 to look at the new patch set (#2). Change subject: bsc: bssap: Set subscr log context during paging .. bsc: bssap: Se

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12256 ) Change subject: bsc: bssap: Set subscr log context during paging .. Patch Set 1: (1 comment) cosmetic issue, otherwise fine with me. https

Change in osmo-bsc[master]: bsc: dtap: Set subscr log context

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12255 ) Change subject: bsc: dtap: Set subscr log context .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12255 To unsub

Change in osmo-bsc[master]: bsc_main: filter_fn: Compare imsi values instead of subscr pointers

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12252 ) Change subject: bsc_main: filter_fn: Compare imsi values instead of subscr pointers .. Patch Set 1: Code-Review+2 -- To view, visit https:

Change in osmo-bsc[master]: bsc: rsl: Set subscr log context during meas report

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12254 ) Change subject: bsc: rsl: Set subscr log context during meas report .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.

Change in osmo-bsc[master]: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12250 ) Change subject: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet .. Patch Set 1: Code-Review+2 -- To view, visit ht

Change in osmo-bsc[master]: paging: Properly enclose logging imsi filter scope

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12251 ) Change subject: paging: Properly enclose logging imsi filter scope .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.o

Change in osmo-bsc[master]: bsc: Set subscr log context during complete_layer3

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12253 ) Change subject: bsc: Set subscr log context during complete_layer3 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.o

Change in osmo-bsc[master]: paging: fix whitespace

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12249 ) Change subject: paging: fix whitespace .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12249 To unsubscribe, or

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

2018-12-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12238 ) Change subject: MGCP: remove commented variants .. MGCP: remove commented variants It's unclear why those variants were commented -

Change in docker-playground[master]: osmo-msc: set bind ip for SGs-interface

2018-12-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12248 ) Change subject: osmo-msc: set bind ip for SGs-interface .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12248/1//C

Change in osmo-msc[master]: fix regression: mgcp FSM: accept Assignment Complete early

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/12257 ) Change subject: fix regression: mgcp FSM: accept Assignment Complete early .. Abandoned reverted original patch instead -- To view, visit https://ger

Change in osmo-msc[master]: jenkins: always enable -Werror

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12263 Change subject: jenkins: always enable -Werror .. jenkins: always enable -Werror Change-Id: If7cf70641114482b42b36489ec8562e5c069825b --- M

Change in osmo-msc[master]: move ASS-COMPL MGCP handling out of a_iface_bssap.c

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12201 ) Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c .. Patch Set 3: (1 comment) This patch was reverted in 85cb2538f4cb4c6

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add message parsing methods

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12261 ) Change subject: trx_toolkit/data_if.py: add message parsing methods .. trx_toolkit/data_if.py: add message parsing methods This c

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12258 ) Change subject: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling .. trx_toolkit/ctrl_if_bb.py: fix SETTA command handling Si

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. trx_toolkit/ctrl_if_*.py: transparently pass UDP

Change in osmocom-bb[master]: trx_toolkit/ctrl_if.py: read data from socket in handle_rx()

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12260 ) Change subject: trx_toolkit/ctrl_if.py: read data from socket in handle_rx() .. trx_toolkit/ctrl_if.py: read data from socket in h

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add optional legacy message coding flag

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12262 ) Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: Code-Review+2 -- To view, visit https://

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add optional legacy message coding flag

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12262 ) Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add message parsing methods

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12261 ) Change subject: trx_toolkit/data_if.py: add message parsing methods .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmo

Change in osmocom-bb[master]: trx_toolkit/ctrl_if.py: read data from socket in handle_rx()

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12260 ) Change subject: trx_toolkit/ctrl_if.py: read data from socket in handle_rx() .. Patch Set 1: Code-Review+2 -- To view, visit https://ge

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: Code-Review+1 -- To view, visit https://

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12259 ) Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12258 ) Change subject: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.os

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add message parsing methods

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12261 Change subject: trx_toolkit/data_if.py: add message parsing methods .. trx_toolkit/data_if.py: add message parsing methods This change ext

Change in osmocom-bb[master]: trx_toolkit/data_if.py: add optional legacy message coding flag

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12262 Change subject: trx_toolkit/data_if.py: add optional legacy message coding flag .. trx_toolkit/data_if.py: add optional legacy message codi

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12259 Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments .. trx_toolkit/ctrl_if_*.py: transparently pass UDPLink argu

Change in osmocom-bb[master]: trx_toolkit/ctrl_if.py: read data from socket in handle_rx()

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12260 Change subject: trx_toolkit/ctrl_if.py: read data from socket in handle_rx() .. trx_toolkit/ctrl_if.py: read data from socket in handle_rx(

Change in osmocom-bb[master]: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling

2018-12-11 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12258 Change subject: trx_toolkit/ctrl_if_bb.py: fix SETTA command handling .. trx_toolkit/ctrl_if_bb.py: fix SETTA command handling Since I8fd2

Change in docker-playground[master]: osmo-msc: set bind ip for SGs-interface

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12248 ) Change subject: osmo-msc: set bind ip for SGs-interface .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1224

Change in osmo-trx[master]: tests: rename convolve_test -> ConvolveTest

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12244 ) Change subject: tests: rename convolve_test -> ConvolveTest .. Patch Set 1: Code-Review-1 > hmm, the others are *.cpp files and this is

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12245 ) Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg .. Patch Set 2: Code-Review-1 (6 comments) https://gerrit.osmocom.org/#

Change in osmo-msc[master]: fix regression: mgcp FSM: accept Assignment Complete early

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12257 Change subject: fix regression: mgcp FSM: accept Assignment Complete early .. fix regression: mgcp FSM: accept Assignment Complete early In

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12243 ) Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12237 ) Change subject: MGCP: fix pattern warning .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12237 To unsubscri

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12237 ) Change subject: MGCP: fix pattern warning .. Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/12237 To unsubscri

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has removed a vote on this change. Change subject: MGCP: fix pattern warning .. Removed Code-Review-1 by Pau Espin Pedrol -- To view, visit https://gerrit.osmocom.org/12237 To unsubscribe, or for help writing m

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12238 ) Change subject: MGCP: remove commented variants .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12238 To uns

Change in osmo-ttcn3-hacks[master]: Remove -Wall for autogenerated code

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12241 ) Change subject: Remove -Wall for autogenerated code .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12241 To

Change in osmo-bsc[master]: bsc: dtap: Set subscr log context

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12255 Change subject: bsc: dtap: Set subscr log context .. bsc: dtap: Set subscr log context Change-Id: I362a7d10f5ca9a95b594f7caafd7ed5b10fd05

Change in osmo-bsc[master]: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12250 Change subject: VTY: Allow logging filter imsi statements for IMSIs we haven't seen yet .. VTY: Allow logging filter imsi statements for

Change in osmo-bsc[master]: bsc: bssap: Set subscr log context during paging

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12256 Change subject: bsc: bssap: Set subscr log context during paging .. bsc: bssap: Set subscr log context during paging Change-Id: I3998a35f

Change in osmo-bsc[master]: paging: fix whitespace

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12249 Change subject: paging: fix whitespace .. paging: fix whitespace Change-Id: I81c4a9f0dbd708df27a485ef764c9524a36d548a --- M src/osmo-bsc/

Change in osmo-bsc[master]: paging: Properly enclose logging imsi filter scope

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12251 Change subject: paging: Properly enclose logging imsi filter scope .. paging: Properly enclose logging imsi filter scope Otherwise all lo

Change in osmo-bsc[master]: bsc: Set subscr log context during complete_layer3

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12253 Change subject: bsc: Set subscr log context during complete_layer3 .. bsc: Set subscr log context during complete_layer3 Change-Id: I162a

Change in osmo-bsc[master]: bsc_main: filter_fn: Compare imsi values instead of subscr pointers

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12252 Change subject: bsc_main: filter_fn: Compare imsi values instead of subscr pointers .. bsc_main: filter_fn: Compare imsi values instead o

Change in osmo-bsc[master]: bsc: rsl: Set subscr log context during meas report

2018-12-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/12254 Change subject: bsc: rsl: Set subscr log context during meas report .. bsc: rsl: Set subscr log context during meas report Change-Id: Idc

Change in docker-playground[master]: osmo-msc: set bind ip for SGs-interface

2018-12-11 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12248 Change subject: osmo-msc: set bind ip for SGs-interface .. osmo-msc: set bind ip for SGs-interface By default the SGs interface binds on 127.0.0.1 b

Change in osmo-ttcn3-hacks[master]: WIP: MSC_Tests: Add SGs testcases

2018-12-11 Thread dexter
dexter has uploaded a new patch set (#16) to the change originally created by Harald Welte. ( https://gerrit.osmocom.org/11488 ) Change subject: WIP: MSC_Tests: Add SGs testcases .. WIP: MSC_Tests: Add SGs testcases This extens

Change in osmo-pcu[master]: cosmetic: move bit counter outside of egprs_window_size()

2018-12-11 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12247 Change subject: cosmetic: move bit counter outside of egprs_window_size() .. cosmetic: move bit counter outside of egprs_window_size() As a preparation

Change in osmo-pcu[master]: cosmetic: use const pointer for bts_data

2018-12-11 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12246 Change subject: cosmetic: use const pointer for bts_data .. cosmetic: use const pointer for bts_data It's used several time for logging so let's call i

Change in osmo-trx[master]: tests: rename convolve_test -> ConvolveTest

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12244 ) Change subject: tests: rename convolve_test -> ConvolveTest .. Patch Set 1: Code-Review-1 hmm, the others are *.cpp files and this is a *.c

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

2018-12-11 Thread osmith
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/12245 ) Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg .. LMSDevice: make use of dev-args in osmo-trx.cfg Allow selecting a specific LimeSDR

Change in osmo-trx[master]: LMSDevice: make use of dev-args in osmo-trx.cfg

2018-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12245 Change subject: LMSDevice: make use of dev-args in osmo-trx.cfg .. LMSDevice: make use of dev-args in osmo-trx.cfg Allow selecting a specific LimeSD

Change in osmo-trx[master]: tests: rename convolve_test -> ConvolveTest

2018-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/12244 Change subject: tests: rename convolve_test -> ConvolveTest .. tests: rename convolve_test -> ConvolveTest Make the test's name consistent with all

Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: add link to related Debian bug in comment

2018-12-11 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12239 ) Change subject: regen-makefile.sh: add link to related Debian bug in comment .. regen-makefile.sh: add link to related Debian bug in comment

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-11 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12242/1/s

Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

2018-12-11 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12243 Change subject: make gsup ipa name configurable in osmo-sgsn.cfg .. make gsup ipa name configurable in osmo-sgsn.cfg Add a 'ipa-name' VTY

Change in osmo-sgsn[master]: remove pointless declaration of struct gsm_network

2018-12-11 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/12242 Change subject: remove pointless declaration of struct gsm_network .. remove pointless declaration of struct gsm_network Stop passing a NU

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-12-11 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11697 To u

Change in osmo-ttcn3-hacks[master]: MSC_Tests: remove unused control interface

2018-12-11 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11690 ) Change subject: MSC_Tests: remove unused control interface .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11690 To unsubs

Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10189 ) Change subject: port rest octets encoding code from osmo-bsc .. Patch Set 5: Marking as WIP until we get a written statement by Jolly abo

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 7: Marked as WIP until we get a written statement by Jolly abo

Change in osmo-trx[master]: configure.ac: check boost only if USRP1 support is enabled

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has removed dexter from this change. ( https://gerrit.osmocom.org/12088 ) Change subject: configure.ac: check boost only if USRP1 support is enabled .. Removed reviewer dexter. -- To view, visit https://gerrit.os

Change in osmo-trx[master]: configure.ac: check boost only if USRP1 support is enabled

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has removed dexter from this change. ( https://gerrit.osmocom.org/12088 ) Change subject: configure.ac: check boost only if USRP1 support is enabled .. Removed reviewer dexter. -- To view, visit https://gerrit.os

Change in osmo-trx[master]: configure.ac: check boost only if USRP1 support is enabled

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12088 ) Change subject: configure.ac: check boost only if USRP1 support is enabled .. Patch Set 1: (sorry for the noise, trying to figure out a UI

Change in osmo-trx[master]: configure.ac: check boost only if USRP1 support is enabled

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has removed dexter from this change. ( https://gerrit.osmocom.org/12088 ) Change subject: configure.ac: check boost only if USRP1 support is enabled .. Removed reviewer dexter. -- To view, visit https://gerrit.os

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has removed dexter from this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Removed reviewer dexter. -- To view, visit https://gerrit.osmocom.org/101

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 7: Please don't merge this yet. There has been no written stat

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10185 to look at the new patch set (#7). Change subject: port arfcn range encode support from osmo-bsc ...

Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

2018-12-11 Thread Max
Hello dexter, Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12237 to look at the new patch set (#2). Change subject: MGCP: fix pattern warning ..

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 6: (3 comments) https://gerrit.osmocom.org/#/c/10185/6/tests/

Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

2018-12-11 Thread Max
Hello dexter, Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12238 to look at the new patch set (#2). Change subject: MGCP: remove commented variants

Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

2018-12-11 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12177 ) Change subject: make gsup ipa name configurable in osmo-msc.cfg .. make gsup ipa name configurable in osmo-msc.cfg Add a 'ipa-nam

Change in osmo-msc[master]: provide software version information to gsup peer

2018-12-11 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/12178 ) Change subject: provide software version information to gsup peer .. provide software version information to gsup peer Provide so

Change in osmo-ttcn3-hacks[master]: Remove -Wall for autogenerated code

2018-12-11 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12241 Change subject: Remove -Wall for autogenerated code .. Remove -Wall for autogenerated code There seems to be no option for ttcn3_makefilegen to disable

Change in libosmocore[master]: port arfcn range encode support from osmo-bsc

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10185 ) Change subject: port arfcn range encode support from osmo-bsc .. Patch Set 6: Code-Review-1 (3 comments) sorry, missed before: either not

Change in osmo-bsc[master]: trigger acc ramping based on trx rf-locked state

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/7732 ) Change subject: trigger acc ramping based on trx rf-locked state .. Patch Set 4: (4 comments) https://gerrit.osmocom.org/#/c/7732/1/src/l

Change in libosmocore[master]: port rest octets encoding code from osmo-bsc

2018-12-11 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10189 ) Change subject: port rest octets encoding code from osmo-bsc .. Patch Set 3: > Patch Set 3: > > has anything changed about the licensing?

  1   2   >