Build failed in Jenkins: master-simtrace2 » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #256

2019-01-17 Thread jenkins
See -- [...truncated 99.70 KB...] [COMPILING ./atmel_softpack_libraries/usb/device/core/USBD.c]

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12625 ) Change subject: assignment_fsm: fix channel allocator preferences .. Patch Set 1: (2 comments)

Change in osmo-bsc[master]: bsc_vty: add features to shun specific lchans

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12624 ) Change subject: bsc_vty: add features to shun specific lchans .. Patch Set 1: (1 comment) Also, why not to call this flag 'ignored' or

Change in osmo-bsc[master]: lchan_select: Do not unsolicitedly select a TCH/F

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12623 ) Change subject: lchan_select: Do not unsolicitedly select a TCH/F .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: lchan_select: dont allow half rate EFR to be selected

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12622 ) Change subject: lchan_select: dont allow half rate EFR to be selected .. Patch Set 1: Code-Review-1 (2 comments)

Change in osmo-bsc[master]: chan_alloc: remove references to lchan_alloc()

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12621 ) Change subject: chan_alloc: remove references to lchan_alloc() .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-msc[master]: vty: make 'sh connect/transact' readable again

2019-01-17 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12626 Change subject: vty: make 'sh connect/transact' readable again .. vty: make 'sh connect/transact' readable again After recent changes to

Change in osmo-bsc[master]: bsc_vty: add features to shun specific lchans

2019-01-17 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12624 Change subject: bsc_vty: add features to shun specific lchans .. bsc_vty: add features to shun specific lchans In some test and debug situations it

Change in osmo-bsc[master]: chan_alloc: remove references to lchan_alloc()

2019-01-17 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12621 Change subject: chan_alloc: remove references to lchan_alloc() .. chan_alloc: remove references to lchan_alloc() The function lchan_alloc() does

Change in osmo-bsc[master]: lchan_select: Do not unsolicitedly select a TCH/F

2019-01-17 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12623 Change subject: lchan_select: Do not unsolicitedly select a TCH/F .. lchan_select: Do not unsolicitedly select a TCH/F The function

Change in osmo-bsc[master]: lchan_select: dont allow half rate EFR to be selected

2019-01-17 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12622 Change subject: lchan_select: dont allow half rate EFR to be selected .. lchan_select: dont allow half rate EFR to be selected The function

Change in osmo-bsc[master]: assignment_fsm: fix channel allocator preferences

2019-01-17 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12625 Change subject: assignment_fsm: fix channel allocator preferences .. assignment_fsm: fix channel allocator preferences When the MSC allocates a

Change in osmo-ttcn3-hacks[master]: WIP: BSC_Tests: Add tests to check channel allocator

2019-01-17 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/12620 Change subject: WIP: BSC_Tests: Add tests to check channel allocator .. WIP: BSC_Tests: Add tests to check channel allocator When a channel is

Change in osmo-ci[master]: nightly packages: Build libosmo-dsp

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12619 ) Change subject: nightly packages: Build libosmo-dsp .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12619 To

Change in osmo-ci[master]: nightly packages: Build libosmo-dsp

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12619 ) Change subject: nightly packages: Build libosmo-dsp .. nightly packages: Build libosmo-dsp Change-Id:

Change in osmo-ci[master]: nightly packages: Build libosmo-dsp

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12619 ) Change subject: nightly packages: Build libosmo-dsp .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/12619 To

Change in libosmocore[master]: Add function to combine nibbles into byte

2019-01-17 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/12573 ) Change subject: Add function to combine nibbles into byte .. Abandoned -- To view, visit https://gerrit.osmocom.org/12573 To unsubscribe, or for help writing

Change in libosmocore[master]: socket: add define for socket name length

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12554 ) Change subject: socket: add define for socket name length .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12554

Change in osmo-ci[master]: nightly packages: Build libosmo-dsp

2019-01-17 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/12619 Change subject: nightly packages: Build libosmo-dsp .. nightly packages: Build libosmo-dsp Change-Id:

Change in libosmocore[master]: socket: add define for socket name length

2019-01-17 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/12554 ) Change subject: socket: add define for socket name length .. Patch Set 2: (1 comment) > Build Started

Change in libosmocore[master]: socket: add define for socket name length

2019-01-17 Thread dexter
Hello Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12554 to look at the new patch set (#3). Change subject: socket: add define for socket name length ..

Change in osmo-msc[master]: Add SGs Interface

2019-01-17 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 ) Change subject: Add SGs Interface .. Patch Set 30: > Also I think we don't have any TTCN3 test that verifies the periodic LU for > 2G. If

Change in osmo-bts[master]: Rename oc2g config file to match new naming scheme

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12617 ) Change subject: Rename oc2g config file to match new naming scheme .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: LCLS: constify helper parameters

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12485 ) Change subject: LCLS: constify helper parameters .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12485/1/src/osmo-bsc/osmo_bsc_lcls.c

Change in osmo-bsc[master]: LCLS: constify helper parameters

2019-01-17 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/12485 ) Change subject: LCLS: constify helper parameters .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12485 To unsubscribe,

Change in osmo-bts[master]: dump_docs: Use new config file naming scheme

2019-01-17 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/12618 Change subject: dump_docs: Use new config file naming scheme .. dump_docs: Use new config file naming scheme Change-Id:

Change in osmo-bts[master]: Rename oc2g config file to match new naming scheme

2019-01-17 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/12617 Change subject: Rename oc2g config file to match new naming scheme .. Rename oc2g config file to match new naming scheme

Change in libosmocore[master]: LCLS: add status parameter to Assignment Completed message

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12483 ) Change subject: LCLS: add status parameter to Assignment Completed message .. Patch Set 4: (2 comments) This change is ready for review.

Change in osmo-bsc[master]: LCLS: constify helper parameters

2019-01-17 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12485 to look at the new patch set (#2). Change subject: LCLS: constify helper parameters .. LCLS: constify

Change in meta-telephony[201705]: Update libosmocore to work with newer oc2g osmo-bts

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12616 ) Change subject: Update libosmocore to work with newer oc2g osmo-bts .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/12616

Change in osmo-iuh[master]: ranap_msg_factory.h: fix enum def within function signature

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12591 ) Change subject: ranap_msg_factory.h: fix enum def within function signature .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: fix lchan modifications: switch off re-using lchan during assignment

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12401 ) Change subject: fix lchan modifications: switch off re-using lchan during assignment .. Patch Set 3: Code-Review-1 (2 comments) It seems like this

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12603 ) Change subject: Cosmetic: Fix spelling in smpp vty .. Cosmetic: Fix spelling in smpp vty Change-Id:

Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12608 ) Change subject: Handle LCLS-NOTIFICATION message from BSS .. Patch Set 4: This change is ready for review. -- To view, visit

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME .. Make alert notifications vty configurable per ESME OSMO-MSC

Change in osmo-msc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12600 ) Change subject: Cosmetic: Fix spelling in smpp vty .. Cosmetic: Fix spelling in smpp vty Change-Id:

Change in osmo-msc[master]: VLR: use msgb_eq_data_print() for comparison

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12571 ) Change subject: VLR: use msgb_eq_data_print() for comparison .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG Commit

Change in osmo-msc[master]: VLR: use msgb_eq_data_print() for comparison

2019-01-17 Thread Max
Hello Stefan Sperling, Neels Hofmeyr, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12571 to look at the new patch set (#2). Change subject: VLR: use msgb_eq_data_print() for comparison

Change in osmo-msc[master]: Log transaction allocation errors as such

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12615 ) Change subject: Log transaction allocation errors as such .. Patch Set 1: (1 comment)

Jenkins build is back to normal : master-osmo-trx » --with-sse,1,a3=default,a4=default,osmocom-master-debian9 #818

2019-01-17 Thread jenkins
See

Change in osmo-msc[master]: Make alert notifications vty configurable per ESME

2019-01-17 Thread Keith Whyte
Keith Whyte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12597 ) Change subject: Make alert notifications vty configurable per ESME .. Make alert notifications vty configurable per ESME Adds (no)

Change in osmo-msc[master]: Don't send Alert Notifications to ESME not bound for RX

2019-01-17 Thread Keith Whyte
Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/12599 ) Change subject: Don't send Alert Notifications to ESME not bound for RX .. Patch Set 2: > Why is that? In short, I guess I was thinking to

Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12608 ) Change subject: Handle LCLS-NOTIFICATION message from BSS .. Patch Set 2: (1 comment)

Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

2019-01-17 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12608 ) Change subject: Handle LCLS-NOTIFICATION message from BSS .. Patch Set 2: This change is ready for review. -- To view, visit

Change in osmocom-bb[master]: trxcon/l1ctl.c: fix memleak triggered by unsupported messages

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12604 ) Change subject: trxcon/l1ctl.c: fix memleak triggered by unsupported messages .. trxcon/l1ctl.c: fix memleak triggered by

Change in meta-telephony[201705]: Update libosmocore to work with newer oc2g osmo-bts

2019-01-17 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/12616 Change subject: Update libosmocore to work with newer oc2g osmo-bts .. Update libosmocore to work with newer oc2g osmo-bts The version of osmo-bts

Change in osmocom-bb[master]: trxcon/l1ctl_link.c: refactor l1ctl_link_init()

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12583 ) Change subject: trxcon/l1ctl_link.c: refactor l1ctl_link_init() .. trxcon/l1ctl_link.c: refactor l1ctl_link_init() The main

Change in osmocom-bb[master]: trxcon/trx_if: refactor trx_if_open()

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12582 ) Change subject: trxcon/trx_if: refactor trx_if_open() .. trxcon/trx_if: refactor trx_if_open() The main changes are: - return

Change in osmocom-bb[master]: trxcon: register both l1ctl_fsm and trx_fsm on DSO load

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12586 ) Change subject: trxcon: register both l1ctl_fsm and trx_fsm on DSO load .. trxcon: register both l1ctl_fsm and trx_fsm on DSO

Change in osmocom-bb[master]: trxcon: do not include trxcon.h everywhere

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12581 ) Change subject: trxcon: do not include trxcon.h everywhere .. trxcon: do not include trxcon.h everywhere Change-Id:

Change in osmocom-bb[master]: trxcon/trxcon.c: do not expose tall_trx_ctx

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12584 ) Change subject: trxcon/trxcon.c: do not expose tall_trx_ctx .. trxcon/trxcon.c: do not expose tall_trx_ctx Both

Change in osmocom-bb[master]: trxcon/trx_if.c: check if trx_fsm allocation failed

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12588 ) Change subject: trxcon/trx_if.c: check if trx_fsm allocation failed .. trxcon/trx_if.c: check if trx_fsm allocation failed

Change in osmocom-bb[master]: trxcon/l1ctl_link.c: check if l1ctl_fsm allocation failed

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12587 ) Change subject: trxcon/l1ctl_link.c: check if l1ctl_fsm allocation failed .. trxcon/l1ctl_link.c: check if l1ctl_fsm allocation

Change in osmocom-bb[master]: trxcon/trxcon.c: do not expose tall_trx_ctx

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12584 ) Change subject: trxcon/trxcon.c: do not expose tall_trx_ctx .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: Log transaction allocation errors as such

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12615 ) Change subject: Log transaction allocation errors as such .. Patch Set 1: Code-Review+1 (1 comment) Fine, excluding changing the

Change in osmo-msc[master]: Log transaction allocation errors as such

2019-01-17 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12615 Change subject: Log transaction allocation errors as such .. Log transaction allocation errors as such While at it, use proper subsystem to log

Change in osmocom-bb[master]: trxcon/trxcon.h: do not expose pointer to trxcon_fsm instance

2019-01-17 Thread Vadim Yanitskiy
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12590 to look at the new patch set (#3). Change subject: trxcon/trxcon.h: do not expose pointer to trxcon_fsm instance

Change in osmocom-bb[master]: trxcon/trxcon.h: introduce and use struct 'trxcon_inst'

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12610 Change subject: trxcon/trxcon.h: introduce and use struct 'trxcon_inst' .. trxcon/trxcon.h: introduce and use struct 'trxcon_inst'

Change in osmocom-bb[master]: trxcon/l1ctl_link.h: get rid of pointer to a trx_instance

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12614 Change subject: trxcon/l1ctl_link.h: get rid of pointer to a trx_instance .. trxcon/l1ctl_link.h: get rid of pointer to a trx_instance

Change in osmocom-bb[master]: trxcon/l1ctl.c: accept band_arfcn as a parameter

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12613 Change subject: trxcon/l1ctl.c: accept band_arfcn as a parameter .. trxcon/l1ctl.c: accept band_arfcn as a parameter Change-Id:

Change in osmocom-bb[master]: trxcon/l1ctl.c: pass trxcon_inst pointer to RX handlers

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12612 Change subject: trxcon/l1ctl.c: pass trxcon_inst pointer to RX handlers .. trxcon/l1ctl.c: pass trxcon_inst pointer to RX handlers

Change in osmocom-bb[master]: trxcon/l1ctl_link.c: use TRXCON_EV_L1CTL_REQ event

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/12611 Change subject: trxcon/l1ctl_link.c: use TRXCON_EV_L1CTL_REQ event .. trxcon/l1ctl_link.c: use TRXCON_EV_L1CTL_REQ event Change-Id:

Change in osmocom-bb[master]: trxcon/trxcon.c: do not expose tall_trx_ctx

2019-01-17 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12584 to look at the new patch set (#3). Change subject: trxcon/trxcon.c: do not expose tall_trx_ctx .. trxcon/trxcon.c:

Change in osmo-asf4-dfu[master]: remove OCTSIM in USB ID

2019-01-17 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/12609 Change subject: remove OCTSIM in USB ID .. remove OCTSIM in USB ID this bootloader is initiated and meant for the sysmo-OCTSIM, but it can be

Change in osmo-hlr[master]: docs: running: document --db-upgrade

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12606 ) Change subject: docs: running: document --db-upgrade .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12606 To

Change in osmo-hlr[master]: docs: running: same argument order as osmo-hlr -h

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12605 ) Change subject: docs: running: same argument order as osmo-hlr -h .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-hlr[master]: docs: running: s/OsmoBTS/OsmoHLR

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12607 ) Change subject: docs: running: s/OsmoBTS/OsmoHLR .. docs: running: s/OsmoBTS/OsmoHLR Change-Id:

Change in osmo-hlr[master]: docs: running: same argument order as osmo-hlr -h

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12605 ) Change subject: docs: running: same argument order as osmo-hlr -h .. docs: running: same argument order as osmo-hlr -h Change the

Change in osmo-hlr[master]: docs: running: s/OsmoBTS/OsmoHLR

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12607 ) Change subject: docs: running: s/OsmoBTS/OsmoHLR .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12607 To

Change in osmo-gsm-manuals[master]: common: extend glossary.adoc

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12567 ) Change subject: common: extend glossary.adoc .. Patch Set 2: (1 comment)

Change in osmo-msc[master]: Handle LCLS-NOTIFICATION message from BSS

2019-01-17 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12608 Change subject: Handle LCLS-NOTIFICATION message from BSS .. Handle LCLS-NOTIFICATION message from BSS Change-Id:

Change in osmo-bsc[master]: Log MDCX ACK for established lchan

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12596 ) Change subject: Log MDCX ACK for established lchan .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12596 To

Change in osmo-bsc[master]: Log MDCX ACK for established lchan

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12596 ) Change subject: Log MDCX ACK for established lchan .. Log MDCX ACK for established lchan Previously LCHAN_RTP_EV_IPACC_MDCX_ACK was

Change in osmocom-bb[master]: trxcon/trxcon.h: do not expose pointer to trxcon_fsm instance

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12590 ) Change subject: trxcon/trxcon.h: do not expose pointer to trxcon_fsm instance .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon: make trxcon_fsm parent for both l1ctl_fsm and trx_fsm

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12589 ) Change subject: trxcon: make trxcon_fsm parent for both l1ctl_fsm and trx_fsm .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon/trxcon.h: do not expose tall_trx_ctx

2019-01-17 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12584 ) Change subject: trxcon/trxcon.h: do not expose tall_trx_ctx .. Patch Set 2: (1 comment)

Change in osmocom-bb[master]: trxcon/trxcon.h: do not expose tall_trx_ctx

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12584 ) Change subject: trxcon/trxcon.h: do not expose tall_trx_ctx .. Patch Set 2: (1 comment)

Change in osmocom-bb[master]: trxcon/l1ctl_link.c: refactor l1ctl_link_init()

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12583 ) Change subject: trxcon/l1ctl_link.c: refactor l1ctl_link_init() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon/trx_if: refactor trx_if_open()

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12582 ) Change subject: trxcon/trx_if: refactor trx_if_open() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12582 To

Change in osmocom-bb[master]: trxcon/trx_if.c: check if trx_fsm allocation failed

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12588 ) Change subject: trxcon/trx_if.c: check if trx_fsm allocation failed .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon: do not include trxcon.h everywhere

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12581 ) Change subject: trxcon: do not include trxcon.h everywhere .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon: register both l1ctl_fsm and trx_fsm on DSO load

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12586 ) Change subject: trxcon: register both l1ctl_fsm and trx_fsm on DSO load .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon/l1ctl_link.c: check if l1ctl_fsm allocation failed

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12587 ) Change subject: trxcon/l1ctl_link.c: check if l1ctl_fsm allocation failed .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon/sched_trx.c: use bool in sched_trx_reset()

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12580 ) Change subject: trxcon/sched_trx.c: use bool in sched_trx_reset() .. trxcon/sched_trx.c: use bool in sched_trx_reset() Change-Id:

Change in osmo-msc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12600 ) Change subject: Cosmetic: Fix spelling in smpp vty .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12600 To

Change in osmo-msc[master]: Make alert notifications vty configurable per ESME

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12597 ) Change subject: Make alert notifications vty configurable per ESME .. Patch Set 1: Code-Review+2 -- To view, visit

Change in openbsc[master]: Don't deliver alert notification to ESME not bound for RX

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12602 ) Change subject: Don't deliver alert notification to ESME not bound for RX .. Patch Set 1: (1 comment)

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: Don't send Alert Notifications to ESME not bound for RX

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12599 ) Change subject: Don't send Alert Notifications to ESME not bound for RX .. Patch Set 2: Why is that? I would argue there are many

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12603 ) Change subject: Cosmetic: Fix spelling in smpp vty .. Patch Set 1: Code-Review+2 forget my earlier comments, I now saw the MSC changes.

Change in openbsc[master]: Cosmetic: Fix spelling in smpp vty

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12603 ) Change subject: Cosmetic: Fix spelling in smpp vty .. Patch Set 1: good patch, but similarly, we should always work "mainline first" and

Change in osmo-msc[master]: SMS: remove code duplication in transaction init

2019-01-17 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/12578 ) Change subject: SMS: remove code duplication in transaction init .. SMS: remove code duplication in transaction init Move code which

Change in openbsc[master]: Don't deliver alert notification to ESME not bound for RX

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12602 ) Change subject: Don't deliver alert notification to ESME not bound for RX .. Patch Set 1: good patch, but similarly, we should always work

Change in openbsc[master]: Make alert notifications vty configurable per ESME

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12601 ) Change subject: Make alert notifications vty configurable per ESME .. Patch Set 1: I'm happy to merge this, but in general we should first

Change in osmo-asf4-dfu[master]: avoid mutli-packet USB transfer

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12595 ) Change subject: avoid mutli-packet USB transfer .. Patch Set 1: I'm not sure if we really want to mege this. The USB stack will also be

Change in osmo-asf4-dfu[master]: start application if valid at boot

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12592 ) Change subject: start application if valid at boot .. start application if valid at boot if the application is not valid, check and

Change in osmo-asf4-dfu[master]: reduce number of endpoints

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12594 ) Change subject: reduce number of endpoints .. reduce number of endpoints only endpoint 0 is used, thus there is no need to define

Change in osmo-asf4-dfu[master]: add README file

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12516 ) Change subject: add README file .. add README file this describes the project, how to compile, and how to flash the USB DFU

Change in osmo-asf4-dfu[master]: add button to force DFU bootloader

2019-01-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12593 ) Change subject: add button to force DFU bootloader .. add button to force DFU bootloader Change-Id:

Change in osmo-asf4-dfu[master]: add button to force DFU bootloader

2019-01-17 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12593 ) Change subject: add button to force DFU bootloader .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12593 To

  1   2   >