Change in libosmo-sccp[master]: improve logging for rejected AS in xua_rkm.c

2019-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13229 Change subject: improve logging for rejected AS in xua_rkm.c .. improve logging for rejected AS in xua_rkm.c Change a loglevel from NOTICE

Change in osmo-bsc[master]: incoming connect: don't crash if calling addr is missing

2019-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13227 Change subject: incoming connect: don't crash if calling addr is missing .. incoming connect: don't crash if calling addr is missing The

Change in osmo-bsc[master]: log N-CONNECT from MSC

2019-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13228 Change subject: log N-CONNECT from MSC .. log N-CONNECT from MSC Change-Id: I83f15c7231b2b766aba4d25339d08acbbca3a47e --- M

Build failure of network:osmocom:nightly/libosmo-netif in Debian_8.0/x86_64

2019-03-12 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_8.0/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines

Change in osmo-bsc[master]: Add configure flag to disable build of osmo-bsc

2019-03-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13226 ) Change subject: Add configure flag to disable build of osmo-bsc .. Patch Set 1: Code-Review-1 I'm really not even inclined to review this

Change in osmo-bsc[master]: Move LCLS references from gsm_data to osmo_bsc_lcls

2019-03-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13220 ) Change subject: Move LCLS references from gsm_data to osmo_bsc_lcls .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep

2019-03-12 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13218 ) Change subject: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: Build BTS related code in a library

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13225 ) Change subject: Build BTS related code in a library .. Patch Set 1: This commit and next one work fine, but it's more like an RFC

Change in osmo-bsc[master]: Build BTS related code in a library

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13225 Change subject: Build BTS related code in a library .. Build BTS related code in a library It will allow build ipaccess util tools and

Change in osmo-bsc[master]: Add configure flag to disable build of osmo-bsc

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13226 Change subject: Add configure flag to disable build of osmo-bsc .. Add configure flag to disable build of osmo-bsc This way only

Change in osmo-bsc[master]: net_init.c: remove unneeded header

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13224 Change subject: net_init.c: remove unneeded header .. net_init.c: remove unneeded header Change-Id:

Change in osmo-bsc[master]: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13223 Change subject: src/utils/Makefile.am: Drop unneeded sigtran and mgcp-client deps .. src/utils/Makefile.am: Drop unneeded sigtran and

Change in osmo-bsc[master]: Move msc related code from gsm_data to bsc_msc

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13221 Change subject: Move msc related code from gsm_data to bsc_msc .. Move msc related code from gsm_data to bsc_msc This way ipaccess utils

Change in osmo-bsc[master]: configure.ac: Add flag to enable/disable build of ipaccess related utils

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13222 Change subject: configure.ac: Add flag to enable/disable build of ipaccess related utils .. configure.ac: Add flag to enable/disable

Change in osmo-bsc[master]: Move LCLS references from gsm_data to osmo_bsc_lcls

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13220 Change subject: Move LCLS references from gsm_data to osmo_bsc_lcls .. Move LCLS references from gsm_data to osmo_bsc_lcls This commit

Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep

2019-03-12 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13218 to look at the new patch set (#2). Change subject: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep ..

Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13218 Change subject: ipaccess/Makefile.am: Remove unneeded libmgcp-client dep .. ipaccess/Makefile.am: Remove unneeded libmgcp-client dep

Change in osmo-bsc[master]: ipaccess/Makefile.am: Remove unneeded libosmo-sigtran dep

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13219 Change subject: ipaccess/Makefile.am: Remove unneeded libosmo-sigtran dep .. ipaccess/Makefile.am: Remove unneeded libosmo-sigtran dep

Change in mncc-python[master]: Add git-review config

2019-03-12 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13217 ) Change subject: Add git-review config .. Add git-review config Change-Id: I80c69ce43b6c0ad36f709340c8184620caf1cbf0 --- A .gitreview 1 file

Change in mncc-python[master]: Add git-review config

2019-03-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13217 ) Change subject: Add git-review config .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13217 To unsubscribe, or for help

Change in mncc-python[master]: Add git-review config

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13217 ) Change subject: Add git-review config .. Patch Set 1: @max, looks like you need to verify it yourself? -- To view, visit

Change in mncc-python[master]: Add git-review config

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13217 ) Change subject: Add git-review config .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13217 To unsubscribe,

Change in mncc-python[master]: Add git-review config

2019-03-12 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13217 Change subject: Add git-review config .. Add git-review config Change-Id: I80c69ce43b6c0ad36f709340c8184620caf1cbf0 --- A .gitreview 1 file changed, 3

Change in osmo-ci[master]: TTCN-3: add PCU tests

2019-03-12 Thread Max
Max has abandoned this change. ( https://gerrit.osmocom.org/11603 ) Change subject: TTCN-3: add PCU tests .. Abandoned -- To view, visit https://gerrit.osmocom.org/11603 To unsubscribe, or for help writing mail filters, visit

Change in osmo-msc[master]: vlr_subscr: use osmo_use_count

2019-03-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13136 ) Change subject: vlr_subscr: use osmo_use_count .. Patch Set 2: (1 comment) Not sure what's the status of libosmocore patch, but you can split this

Change in libosmocore[master]: Fix build on non-glibc systems

2019-03-12 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13209 ) Change subject: Fix build on non-glibc systems .. Fix build on non-glibc systems Change-Id: Id5d577522a4889e152158f7e93ee1c99d3a21003 --- M

Change in libosmocore[master]: Fix build on non-glibc systems

2019-03-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13209 ) Change subject: Fix build on non-glibc systems .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13209 To unsubscribe, or

Change in osmo-pcu[master]: Fix Channel Coding Command for MCS

2019-03-12 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13216 Change subject: Fix Channel Coding Command for MCS .. Fix Channel Coding Command for MCS Previously result of ".to_num() - 1" was used without any

Change in osmo-pcu[master]: MCS: add mcs_is_*() helpers

2019-03-12 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13214 Change subject: MCS: add mcs_is_*() helpers .. MCS: add mcs_is_*() helpers In preparation for Channel Coding Command encoder in follow-up patches

Change in osmo-pcu[master]: MCS: add Channel Coding Command encoder

2019-03-12 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13215 Change subject: MCS: add Channel Coding Command encoder .. MCS: add Channel Coding Command encoder Add function to encode MCS value as proper EDGE or

Change in osmocom-bb[master]: trxcon/scheduler: clarify decoding of incomplete xCCH blocks

2019-03-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13197 ) Change subject: trxcon/scheduler: clarify decoding of incomplete xCCH blocks .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmocom-bb[master]: trxcon/scheduler: clarify decoding of incomplete xCCH blocks

2019-03-12 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13197 ) Change subject: trxcon/scheduler: clarify decoding of incomplete xCCH blocks .. trxcon/scheduler: clarify decoding of incomplete

Change in osmo-ttcn3-hacks[master]: IPA: log host:port on listen errors

2019-03-12 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13202 ) Change subject: IPA: log host:port on listen errors .. IPA: log host:port on listen errors Change-Id:

Change in osmo-ttcn3-hacks[master]: IPA: log host:port on listen errors

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13202 ) Change subject: IPA: log host:port on listen errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13202

Change in libosmo-netif[master]: amr: cosmetic: correct sourcecode formatting

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13210 ) Change subject: amr: cosmetic: correct sourcecode formatting .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-netif[master]: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13211 ) Change subject: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-netif[master]: amr: make buffer in osmo_amr_bwe_to_oa() static

2019-03-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13212 ) Change subject: amr: make buffer in osmo_amr_bwe_to_oa() static .. Patch Set 1: Code-Review-1 I see no overhead in allocating that

Change in osmo-ttcn3-hacks[master]: IPA: log host:port on listen errors

2019-03-12 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13202 ) Change subject: IPA: log host:port on listen errors .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13202 To

Change in osmo-pcu[master]: MS store: move test helper to unit test

2019-03-12 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13213 Change subject: MS store: move test helper to unit test .. MS store: move test helper to unit test It's confusing to have test-specific helper with

Change in libosmocore[master]: Fix build on non-glibc systems

2019-03-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13209 ) Change subject: Fix build on non-glibc systems .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13209 To unsubscribe, or

Change in osmocom-bb[master]: trxcon/scheduler: clarify decoding of incomplete xCCH blocks

2019-03-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13197 ) Change subject: trxcon/scheduler: clarify decoding of incomplete xCCH blocks .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmo-netif[master]: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf

2019-03-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13211 ) Change subject: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmo-netif[master]: amr: cosmetic: correct sourcecode formatting

2019-03-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13210 ) Change subject: amr: cosmetic: correct sourcecode formatting .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13210 To

Change in osmo-mgw[master]: AMR: Add function to convert between bw-effient and octet aligned mode

2019-03-12 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13159 ) Change subject: AMR: Add function to convert between bw-effient and octet aligned mode .. Set Ready For Review -- To view, visit

Change in osmo-bts[master]: oc2g: l1if: delay trx initialization to avoid race condition

2019-03-12 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13208 ) Change subject: oc2g: l1if: delay trx initialization to avoid race condition .. Patch Set 2: > I think this commit is good as a proof of concept,

Change in libosmo-netif[master]: amr: cosmetic: correct sourcecode formatting

2019-03-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13210 Change subject: amr: cosmetic: correct sourcecode formatting .. amr: cosmetic: correct sourcecode formatting Change-Id:

Change in libosmo-netif[master]: amr: make buffer in osmo_amr_bwe_to_oa() static

2019-03-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13212 Change subject: amr: make buffer in osmo_amr_bwe_to_oa() static .. amr: make buffer in osmo_amr_bwe_to_oa() static The function

Change in libosmo-netif[master]: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf

2019-03-12 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13211 Change subject: amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf .. amr: be sure result of osmo_amr_bwe_to_oa() fits into int buf