Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/13395 )
Change subject: Use libosmocore for IMSI parsing
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13395/1/src/gprs_bssgp_pcu.c
Piotr Krysik has submitted this change and it was merged. (
https://gerrit.osmocom.org/13246 )
Change subject: Fix the TCH/H decoder and demapper XML definitions
..
Fix the TCH/H decoder and demapper XML definitions
- The secon
Piotr Krysik has posted comments on this change. (
https://gerrit.osmocom.org/13246 )
Change subject: Fix the TCH/H decoder and demapper XML definitions
..
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit https://gerri
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13163 )
Change subject: MCS: move Mode enum outside of class definition
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13163
T
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13390 )
Change subject: gsm_utils.h: remove unused include of gsm_08_08.h
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmoco
Max has posted comments on this change. ( https://gerrit.osmocom.org/13390 )
Change subject: gsm_utils.h: remove unused include of gsm_08_08.h
..
Patch Set 2:
Does this really depends on all the preceding patches or it can be r
Max has posted comments on this change. ( https://gerrit.osmocom.org/13394 )
Change subject: add osmo_str_startswith()
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/13394/1//COMMIT_MSG
Commit Message
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13396
Change subject: Revert "ipa_ccm_idtag_parse*: Fix reported length value"
..
Revert "ipa_ccm_idtag_parse*: Fix reported length value"
This reverts co
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13397
Change subject: Doxygen: fix incorrect / missing parameter description
..
Doxygen: fix incorrect / missing parameter description
Change-Id
Vadim Yanitskiy has uploaded a new patch set (#2). (
https://gerrit.osmocom.org/13399 )
Change subject: core/linuxlist.h: fix white-space and inconsistent alignment
..
core/linuxlist.h: fix white-space and inconsistent alignment
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13163 )
Change subject: MCS: move Mode enum outside of class definition
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/
Daniel Willmann has posted comments on this change. (
https://gerrit.osmocom.org/13360 )
Change subject: Remove custom alarms
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13360/1/src/osmo-bts-oc2g/oc2g_l1_if.c
F
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13399 )
Change subject: core/linuxlist.h: fix white-space and inconsistent alignment
..
Patch Set 2: Code-Review+1
I generally try to avoid such pat
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13398 )
Change subject: core/linuxlist.h: fix and unify Doxygen documentation
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmoco
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13397 )
Change subject: Doxygen: fix incorrect / missing parameter description
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.o
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13397 )
Change subject: Doxygen: fix incorrect / missing parameter description
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmoc
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13396 )
Change subject: Revert "ipa_ccm_idtag_parse*: Fix reported length value"
..
Revert "ipa_ccm_idtag_parse*: Fix reported length value"
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/13397 )
Change subject: Doxygen: fix incorrect / missing parameter description
..
Doxygen: fix incorrect / missing parameter description
Cha
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13396 )
Change subject: Revert "ipa_ccm_idtag_parse*: Fix reported length value"
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osm
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/13387 )
Change subject: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13398
Change subject: core/linuxlist.h: fix and unify Doxygen documentation
..
core/linuxlist.h: fix and unify Doxygen documentation
- drop in
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13399
Change subject: core/linuxlist.h: fix white-space and inconsistent alignment
..
core/linuxlist.h: fix white-space and inconsistent alignmen
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13163 )
Change subject: MCS: move Mode enum outside of class definition
..
MCS: move Mode enum outside of class definition
Move Mode (EDGE/GPRS) defi
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13398 )
Change subject: core/linuxlist.h: fix and unify Doxygen documentation
..
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/13398
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13399 )
Change subject: core/linuxlist.h: fix white-space and inconsistent alignment
..
Patch Set 2: Code-Review+2
--
To view, visit https://ge
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/13347
to look at the new patch set (#2).
Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket
..
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13347 )
Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket
..
Patch Set 1:
(3 comments)
Comments addressed, please have another look.
I hav
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13347 )
Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13400
Change subject: logging_gsmtap.c: document all params of
log_target_create_gsmtap()
..
logging_gsmtap.c: document all params of log_target
Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/13398 )
Change subject: core/linuxlist.h: fix and unify Doxygen documentation
..
Patch Set 1:
(4 comments)
https://gerrit.osmocom.org/#/c/13398/
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13401
Change subject: src/logging.c: fix syntax errors in Doxygen documentation
..
src/logging.c: fix syntax errors in Doxygen documentation
Thi
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/13398
to look at the new patch set (#2).
Change subject: core/linuxlist.h: fix and unify Doxygen documentation
...
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13398 )
Change subject: core/linuxlist.h: fix and unify Doxygen documentation
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.os
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13400 )
Change subject: logging_gsmtap.c: document all params of
log_target_create_gsmtap()
..
Patch Set 1: Code-Review+1
(1 comment)
https://
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13401 )
Change subject: src/logging.c: fix syntax errors in Doxygen documentation
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerri
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13348 )
Change subject: osmo-bsc-mgcp.service: Fix parsing of cmdline option s
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.o
Pau Espin Pedrol has submitted this change and it was merged. (
https://gerrit.osmocom.org/13387 )
Change subject: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init
..
talloc_ctx_init: Use public API osmo_signal_talloc
Pau Espin Pedrol has submitted this change and it was merged. (
https://gerrit.osmocom.org/13348 )
Change subject: osmo-bsc-mgcp.service: Fix parsing of cmdline option s
..
osmo-bsc-mgcp.service: Fix parsing of cmdline option s
Hello Daniel Willmann, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/13363
to look at the new patch set (#2).
Change subject: contrib: jenkins-build-osmo-pcu-oc2g: Enable oc2gbts-phy
...
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13402
Change subject: Update MCS selection for retransmission
..
Update MCS selection for retransmission
In 3GPP TS 44.060 the selection of MCS for retransmi
Max has posted comments on this change. ( https://gerrit.osmocom.org/13361 )
Change subject: Include pdch.h in bts.h even if we're not compiling C++
..
Patch Set 2: Code-Review+1
That's generic fix unrelated to oc2g in any way.
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13403
Change subject: bts.h: always include C-headers
..
bts.h: always include C-headers
Previously C-headers were only included if bts.h was used by C++ cod
Max has posted comments on this change. ( https://gerrit.osmocom.org/13401 )
Change subject: src/logging.c: fix syntax errors in Doxygen documentation
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13402 )
Change subject: Update MCS selection for retransmission
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/13402/1/src/coding_
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13403 )
Change subject: bts.h: always include C-headers
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/13403/1/src/bt
Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 )
Change subject: bts.h: always include C-headers
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13403/1/src/bts.h
File src/bts.h:
https:/
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13403 )
Change subject: bts.h: always include C-headers
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13403/1/src/bts.h
File src/b
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13404
Change subject: core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers
..
core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers
N
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13405
Change subject: core/msgb.h: drop meaningless parameter of msgb_eq_* helpers
..
core/msgb.h: drop meaningless parameter of msgb_eq_* helper
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13406
Change subject: Add ARQ type helpers
..
Add ARQ type helpers
Add functions to check/log EGPRS ARQ type (as described in 3GPP TS
44.060 ยง8.1.1). Note -
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13408
Change subject: core/msgb.h: fix incorrect Doxygen parameter description
..
core/msgb.h: fix incorrect Doxygen parameter description
cor
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13407
Change subject: src/msgb.c: fix Doxygen documentation for msgb_printf()
..
src/msgb.c: fix Doxygen documentation for msgb_printf()
This ch
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13410
Change subject: src/rate_ctr.c: drop some incorrect \ref references
..
src/rate_ctr.c: drop some incorrect \ref references
rate_ctr.c:41
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13409
Change subject: Doxygen: fix documentation of rate_ctr_for_each_counter()
..
Doxygen: fix documentation of rate_ctr_for_each_counter()
Dox
Vadim Yanitskiy has uploaded this change for review. (
https://gerrit.osmocom.org/13411
Change subject: Doxygen: fix documentation of osmo_timer_setup()
..
Doxygen: fix documentation of osmo_timer_setup()
This change fixes the
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13404 )
Change subject: core/msgb.h: fix dead msgb2 reference in msgb_eq_* helpers
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerr
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13407 )
Change subject: src/msgb.c: fix Doxygen documentation for msgb_printf()
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13405 )
Change subject: core/msgb.h: drop meaningless parameter of msgb_eq_* helpers
..
Patch Set 1: Code-Review+1
--
To view, visit https://ge
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13408 )
Change subject: core/msgb.h: fix incorrect Doxygen parameter description
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13409 )
Change subject: Doxygen: fix documentation of rate_ctr_for_each_counter()
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerri
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13410 )
Change subject: src/rate_ctr.c: drop some incorrect \ref references
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmo
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/13411 )
Change subject: Doxygen: fix documentation of osmo_timer_setup()
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom
Max has posted comments on this change. ( https://gerrit.osmocom.org/13214 )
Change subject: MCS: add mcs_is_*() helpers
..
Patch Set 5:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/13214
To u
Max has posted comments on this change. ( https://gerrit.osmocom.org/13215 )
Change subject: MCS: add Channel Coding Command encoder
..
Patch Set 5:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.or
Max has posted comments on this change. ( https://gerrit.osmocom.org/12961 )
Change subject: Rewrite Packet Uplink IA Rest Octets for MBA
..
Patch Set 9:
This change is ready for review.
--
To view, visit https://gerrit.osmoc
Max has posted comments on this change. ( https://gerrit.osmocom.org/13216 )
Change subject: Fix Channel Coding Command for MCS
..
Patch Set 6:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/132
Max has posted comments on this change. ( https://gerrit.osmocom.org/12956 )
Change subject: Use Timing Advance Index in UL assignments
..
Patch Set 12:
This change is ready for review.
--
To view, visit https://gerrit.osmoco
Max has posted comments on this change. ( https://gerrit.osmocom.org/13245 )
Change subject: Update IA Rest Octets encoding
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/13245
T
Max has posted comments on this change. ( https://gerrit.osmocom.org/12955 )
Change subject: Rewrite Packet Uplink IA Rest Octets for SBA
..
Patch Set 15:
This change is ready for review.
--
To view, visit https://gerrit.osmo
Max has posted comments on this change. ( https://gerrit.osmocom.org/13244 )
Change subject: TBF-DL: cosmetic update for helper routines
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmoco
Max has posted comments on this change. ( https://gerrit.osmocom.org/13243 )
Change subject: TBF: update MCS counters
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/13243
To unsu
Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 )
Change subject: bts.h: always include C-headers
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13403/1/src/bts.h
File src/bts.h:
https:/
72 matches
Mail list logo