Change in docker-playground[master]: RFC: allow to set configuration and/or specific testcases

2019-05-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14072 ) Change subject: RFC: allow to set configuration and/or specific testcases .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.os

Change in docker-playground[master]: RFC: allow to set configuration and/or specific testcases

2019-05-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14072 ) Change subject: RFC: allow to set configuration and/or specific testcases .. Patch Set 1: looks fine to me, but would be great to have some

Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add explicit ALIGN(left) attribute

2019-05-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/14073 ) Change subject: library/PCUIF_Types.ttcn: add explicit ALIGN(left) attribute .. library/PCUIF_Types.ttcn: add explicit ALIGN(left)

Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add explicit ALIGN(left) attribute

2019-05-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14073 ) Change subject: library/PCUIF_Types.ttcn: add explicit ALIGN(left) attribute .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit

Change in osmo-ci[master]: Fix oc2g poky SDK installation

2019-05-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14049 ) Change subject: Fix oc2g poky SDK installation .. Fix oc2g poky SDK installation It's poky_installer_file, not poky_install_file. A

Change in osmo-ttcn3-hacks[master]: library/PCUIF_Types.ttcn: add explicit ALIGN(left) attribute

2019-05-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/14073 Change subject: library/PCUIF_Types.ttcn: add explicit ALIGN(left) attribute .. library/PCUIF_Types.ttcn: add explicit ALIGN(left) attribut

Change in osmo-ci[master]: Fix oc2g poky SDK installation

2019-05-16 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/14049 ) Change subject: Fix oc2g poky SDK installation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/14049 To unsubscr

Change in docker-playground[master]: RFC: allow to set configuration and/or specific testcases

2019-05-16 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/14072 Change subject: RFC: allow to set configuration and/or specific testcases .. RFC: allow to set configuration and/or specific testcases Allows

Change in libosmocore[master]: Deprecate usage of osmo_counter_*

2019-05-16 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/13808 ) Change subject: Deprecate usage of osmo_counter_* .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13808 To unsub

Change in libosmocore[master]: Deprecate usage of osmo_counter_*

2019-05-16 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13808 ) Change subject: Deprecate usage of osmo_counter_* .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/13808/3/include/osmocom/cor

Change in openbsc[master]: nat: Allocate bsc_nat_parsed on the stack instead of heap

2019-05-16 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13843 ) Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit

Change in openbsc[master]: nat: Allocate bsc_nat_parsed on the stack instead of heap

2019-05-16 Thread Pau Espin Pedrol
Hello Daniel Willmann, Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13843 to look at the new patch set (#5). Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap .

Change in openbsc[master]: nat: Allocate bsc_nat_parsed on the stack instead of heap

2019-05-16 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13843 ) Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/138

Change in osmo-ttcn3-hacks[master]: start-testsuite.sh: remove superflouse `set -e`

2019-05-16 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/14071 Change subject: start-testsuite.sh: remove superflouse `set -e` .. start-testsuite.sh: remove superflouse `set -e` The set -e will not interf

Change in libosmo-sccp[master]: osmo-stp: refactor handling of both SIGINT and SIGTERM

2019-05-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/13971 ) Change subject: osmo-stp: refactor handling of both SIGINT and SIGTERM .. Abandoned -- To view, visit https://gerrit.osmocom.org/13971 To unsubscrib

Change in libosmo-sccp[master]: osmo-stp: track the use of NULL talloc-context

2019-05-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has abandoned this change. ( https://gerrit.osmocom.org/13972 ) Change subject: osmo-stp: track the use of NULL talloc-context .. Abandoned -- To view, visit https://gerrit.osmocom.org/13972 To unsubscribe, or fo

Change in openbsc[master]: nat: Allocate bsc_nat_parsed on the stack instead of heap

2019-05-16 Thread Holger Freyther
Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/13843 ) Change subject: nat: Allocate bsc_nat_parsed on the stack instead of heap .. Patch Set 4: (1 comment) Looks good. Just found the minor s

Change in libosmocore[master]: Cosmetic: GSUP: fix too long comment line

2019-05-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/14070 Change subject: Cosmetic: GSUP: fix too long comment line .. Cosmetic: GSUP: fix too long comment line Change-Id: I60ba8fef8924e58bc73cff5c7ff77ebb7

Change in osmo-msc[master]: libmsc/msc_vty.c: refactor 'show subscr / conn / trans' commands

2019-05-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14069 ) Change subject: libmsc/msc_vty.c: refactor 'show subscr / conn / trans' commands .. Set Ready For Review -- To view, visit https://gerri

Change in osmo-ccid-firmware[master]: ccid: Integrate libosmocore logging

2019-05-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14066 ) Change subject: ccid: Integrate libosmocore logging .. ccid: Integrate libosmocore logging Change-Id: I3436827f658653273af21f1deaf03

Change in osmo-msc[master]: libmsc/rtp_stream.c: prevent NULL-pointer dereference

2019-05-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13980 ) Change subject: libmsc/rtp_stream.c: prevent NULL-pointer dereference .. libmsc/rtp_stream.c: prevent NULL-pointer dereference Ch

Change in osmo-msc[master]: libmsc/rtp_stream.c: prevent NULL-pointer dereference

2019-05-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13980 ) Change subject: libmsc/rtp_stream.c: prevent NULL-pointer dereference .. Set Ready For Review -- To view, visit https://gerrit.osmocom.o

Change in osmo-msc[master]: libmsc/msc_vty.c: fix: use msub_for_vsub() in subscr_dump_full_vty()

2019-05-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14061 ) Change subject: libmsc/msc_vty.c: fix: use msub_for_vsub() in subscr_dump_full_vty() .. libmsc/msc_vty.c: fix: use msub_for_vsub() i

Change in osmo-msc[master]: libmsc/msc_vty.c: fix: use msub_for_vsub() in subscr_dump_full_vty()

2019-05-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14061 ) Change subject: libmsc/msc_vty.c: fix: use msub_for_vsub() in subscr_dump_full_vty() .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-msc[master]: libmsc/msc_vty.c: fix documentation of 'show subscriber id'

2019-05-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14062 ) Change subject: libmsc/msc_vty.c: fix documentation of 'show subscriber id' .. libmsc/msc_vty.c: fix documentation of 'show subscribe

Change in osmo-msc[master]: libmsc/msc_vty.c: use llist_count() in subscr_dump_full_vty()

2019-05-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14063 ) Change subject: libmsc/msc_vty.c: use llist_count() in subscr_dump_full_vty() .. libmsc/msc_vty.c: use llist_count() in subscr_dump_f

Change in osmo-msc[master]: libmsc/msc_vty.c: fix documentation of 'show subscriber id'

2019-05-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14062 ) Change subject: libmsc/msc_vty.c: fix documentation of 'show subscriber id' .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.

Change in osmo-msc[master]: libmsc/msc_vty.c: use llist_count() in subscr_dump_full_vty()

2019-05-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14063 ) Change subject: libmsc/msc_vty.c: use llist_count() in subscr_dump_full_vty() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerri