pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16201 )
Change subject: db v4: add column last_lu_seen_ps
..
Patch Set 6:
My question here has not yet been answered.
--
To view, visit
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/16189 )
Change subject: add osmo_gsup_make_response() and osmo_gsup_message_name_*()
..
Patch Set 3:
(3 comments)
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16203
to look at the new patch set (#12).
Change subject: add osmo-mslookup-client program
..
add
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16201
to look at the new patch set (#6).
Change subject: db v4: add column last_lu_seen_ps
..
db v4:
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16205
to look at the new patch set (#12).
Change subject: refactor: add and use lu_fsm, osmo_gsup_req, osmo_gt
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16209
to look at the new patch set (#12).
Change subject: D-GSM 1/n: add mslookup server in osmo-hlr
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16211
to look at the new patch set (#12).
Change subject: adoc: add D-GSM chapter to osmohlr-usermanual
neels has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16257 )
Change subject: D-GSM 2/n: implement mDNS method of mslookup server
..
D-GSM 2/n: implement mDNS method of mslookup server
Implement
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16202
to look at the new patch set (#12).
Change subject: add libosmo-mslookup abstract client
..
add
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hlr/+/16210
to look at the new patch set (#12).
Change subject: add mslookup_manual_test
..
add
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16202 )
Change subject: add libosmo-mslookup and mDNS implementation
..
Patch Set 11:
(7 comments)
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16202 )
Change subject: add libosmo-mslookup and mDNS implementation
..
Patch Set 11: Code-Review-1
(1 comment)
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/16215 )
Change subject: scheduler_trx.c: cast ptrdiff value to fix printf format
..
scheduler_trx.c: cast ptrdiff value to fix printf format
On an
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/16215 )
Change subject: scheduler_trx.c: cast ptrdiff value to fix printf format
..
Patch Set 2: Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16226 )
Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on
boot
..
Patch Set 2:
> maybe it's enabled by default
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )
Change subject: ansible: Fix several file permission mask format
..
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16186 )
Change subject: make e1cap format portable
..
Patch Set 4:
ideally it would of course be nice to auto-detect the format
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16187 )
Change subject: e1cap_dump: fix superchannel without pcap output
..
e1cap_dump: fix superchannel without pcap output
We have to check
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16187 )
Change subject: e1cap_dump: fix superchannel without pcap output
..
Patch Set 1: Verified+1
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16254 )
Change subject: enable the final slot
..
Patch Set 1:
commitlog could also be more verbose, stating that SERCOM7 is
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16255 )
Change subject: prettier slot bitmask code
..
Patch Set 1: Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16253 )
Change subject: first attempt at timeout handling
..
Patch Set 1:
might be relevant to state which timeout where in the
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16252 )
Change subject: remove old uart commands
..
Patch Set 1:
best to remove them (as a separate "remove" commit like here) at
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251 )
Change subject: cuart cleanup
..
Patch Set 1:
(1 comment)
commit log too short. I also think it's not just a cleanup,
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16250 )
Change subject: the magic sauce that makes it work
..
Patch Set 1: Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16249 )
Change subject: boost the uart interrupt priority
..
Patch Set 1:
(1 comment)
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16248 )
Change subject: pps warning
..
Patch Set 1: Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16246 )
Change subject: fsm completion event handling from main loop
..
Patch Set 1:
(1 comment)
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16247 )
Change subject: add a note for D=64 pecularities
..
Patch Set 1: Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16245 )
Change subject: fix power descriptor value
..
Patch Set 1:
might be worth to add a TODO/FIXME to commitlog and/or code
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16244 )
Change subject: better error handling
..
Patch Set 1:
(1 comment)
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16243 )
Change subject: dbg
..
Patch Set 1: Code-Review-1
can we please have a proper commitlog describing what it does?
--
To
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16242 )
Change subject: disable talloc_memlimit() and use existing msgb_context (pool)
..
Patch Set 1: Code-Review+2
--
To view,
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16241 )
Change subject: assert on free in interrupt, too
..
Patch Set 1: Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16240 )
Change subject: proper sercom config for the other 6 slots
..
Patch Set 1:
what is "proper"? Not a rherthorical
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16238 )
Change subject: attempt at handling card insertion/removal
..
Patch Set 1: Code-Review+1
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16239 )
Change subject: additional descriptor fixes
..
Patch Set 1:
what kind of fixes specifically? commitlog --verbose please,
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16235 )
Change subject: make it work, async uart (mode 0x1/0x7 does not matter),
requires delay
..
Patch Set 1:
(6 comments)
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237 )
Change subject: setparameters/PPS works
..
Patch Set 1:
(3 comments)
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16236 )
Change subject: prevent uart interrupts before having proper structs
..
Patch Set 1: Code-Review+2
that's a nice,
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15724 )
Change subject: WIP: attempt to use iso7816_fsm + Cuart from firmware
..
Patch Set 6:
same here. Ideally there's one
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15723 )
Change subject: WIP: Add card_uart driver for ASF4 USART
..
Patch Set 6:
normally we would now merge all (most of) the
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16226 )
Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on
boot
..
Patch Set 2:
(1 comment)
I'm not setting
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16247 )
Change subject: add a note for D=64 pecularities
..
add a note for D=64 pecularities
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16239 )
Change subject: additional descriptor fixes
..
additional descriptor fixes
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16252 )
Change subject: remove old uart commands
..
remove old uart commands
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16250 )
Change subject: the magic sauce that makes it work
..
the magic sauce that makes it work
1mio concurrent select mf
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16244 )
Change subject: better error handling
..
better error handling
Change-Id: I9983c2f58c7f420a0132d186f344ace1de616ba1
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16236 )
Change subject: prevent uart interrupts before having proper structs
..
prevent uart interrupts before having proper
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16248 )
Change subject: pps warning
..
pps warning
Change-Id: Ie0cbca9c901643268adddc69c08be494432a3235
---
M
Hello laforge,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16242
to review the following change.
Change subject: disable talloc_memlimit() and use existing msgb_context (pool)
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16255 )
Change subject: prettier slot bitmask code
..
prettier slot bitmask code
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16253 )
Change subject: first attempt at timeout handling
..
first attempt at timeout handling
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16246 )
Change subject: fsm completion event handling from main loop
..
fsm completion event handling from main loop
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16245 )
Change subject: fix power descriptor value
..
fix power descriptor value
The previous value would allow using the
Hoernchen has uploaded a new patch set (#6) to the change originally created by
laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15723 )
Change subject: WIP: Add card_uart driver for ASF4 USART
..
WIP: Add card_uart
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16251 )
Change subject: cuart cleanup
..
cuart cleanup
Change-Id: Ia5b66a86f0f53e5123139c3c5047f70582d1bf6e
---
M
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16249 )
Change subject: boost the uart interrupt priority
..
boost the uart interrupt priority
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16238 )
Change subject: attempt at handling card insertion/removal
..
attempt at handling card insertion/removal
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16241 )
Change subject: assert on free in interrupt, too
..
assert on free in interrupt, too
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16240 )
Change subject: proper sercom config for the other 6 slots
..
proper sercom config for the other 6 slots
Change-Id:
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16254 )
Change subject: enable the final slot
..
enable the final slot
Change-Id: I1c18459d7e43e6fbd1022fabb52138904f2bf480
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16243 )
Change subject: dbg
..
dbg
Change-Id: I4340cb53f0f903842eb1c4d60a36d44ac9e5cbde
---
M ccid_common/cuart.h
M
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16237 )
Change subject: setparameters/PPS works
..
setparameters/PPS works
Change-Id:
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16226 )
Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on
boot
..
Patch Set 2:
(1 comment)
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16226 )
Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on
boot
..
Patch Set 2: Code-Review-1
where do you
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )
Change subject: ansible: Fix several file permission mask format
..
Patch Set 1: Code-Review+2
--
To view, visit
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16227 )
Change subject: resources.conf: Mark osmo-bts-trx as supporting a5/3
..
resources.conf: Mark osmo-bts-trx as supporting a5/3
Change-Id:
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16224 )
Change subject: ansible: gsm-tester-prod: Set DNS server to a working service
..
ansible: gsm-tester-prod: Set DNS server to a working service
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16224 )
Change subject: ansible: gsm-tester-prod: Set DNS server to a working service
..
Patch Set 1: Verified+1
--
To view, visit
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16224 )
Change subject: ansible: gsm-tester-prod: Set DNS server to a working service
..
Patch Set 1: Code-Review+2
--
To view, visit
pespin has uploaded a new patch set (#2). (
https://gerrit.osmocom.org/c/osmo-ci/+/16226 )
Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on
boot
..
ansible: gsm-tester: Enable ip forwarding and
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/16234 )
Change subject: ansible: Fix several file permission mask format
..
ansible: Fix several file permission mask format
>From ansible
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16229 )
Change subject: process: Return proc in function helpers
..
Patch Set 1: Code-Review+1
--
To view, visit
laforge has submitted this change. (
https://gerrit.osmocom.org/c/simtrace2/+/16225 )
Change subject: qmod: lower VCC threshold to 2.5V
..
qmod: lower VCC threshold to 2.5V
on the QMOD board the VCC signal from the modem is
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/simtrace2/+/16225 )
Change subject: qmod: lower VCC threshold to 2.5V
..
Patch Set 1: Code-Review+2
--
To view, visit
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16202 )
Change subject: add libosmo-mslookup and mDNS implementation
..
Patch Set 11:
(1 comment)
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/16233 )
Change subject: l1sap.c: ensure ms power control loop is running
..
Patch Set 2:
(2 comments)
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16202 )
Change subject: add libosmo-mslookup and mDNS implementation
..
Patch Set 11:
(1 comment)
(marking all comments as resolved)
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/16170 )
Change subject: rsl: ensure measurement reports are sent
..
Patch Set 3: Code-Review+1
Leaving final review for @fixeria
--
To
osmith has uploaded a new patch set (#11) to the change originally created by
neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16202 )
Change subject: add libosmo-mslookup and mDNS implementation
..
add libosmo-mslookup and
osmith has uploaded a new patch set (#11) to the change originally created by
neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16205 )
Change subject: add lu_fsm and osmo_gsup_req
..
add lu_fsm and osmo_gsup_req
These are
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/16202 )
Change subject: add libosmo-mslookup and mDNS implementation
..
Patch Set 10:
(29 comments)
Thanks for the reviews! I've pushed an
osmith has uploaded a new patch set (#11) to the change originally created by
neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16210 )
Change subject: add mslookup_manual_test
..
add mslookup_manual_test
This can be used for
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/16233
to look at the new patch set (#2).
Change subject: l1sap.c: ensure ms power control loop is running
..
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16227 )
Change subject: resources.conf: Mark osmo-bts-trx as supporting a5/3
..
Patch Set 1: Code-Review+2
--
To view, visit
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/15888 )
Change subject: l1sap: add measurement related struct members
..
Patch Set 2:
(2 comments)
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16228 )
Change subject: bts_osmotrx: Allow Setting Rx/TX paths through resources.conf
..
Patch Set 1: Code-Review+1
--
To view,
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bts/+/16233 )
Change subject: l1sap.c: ensure ms power control loop is running
..
l1sap.c: ensure ms power control loop is running
When a bad
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16226 )
Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on
boot
..
Patch Set 1:
> Patch Set 1:
>
> as nothing
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16226 )
Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on
boot
..
Patch Set 1:
as nothing ever deletes or
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ci/+/16224 )
Change subject: ansible: gsm-tester-prod: Set DNS server to a working service
..
Patch Set 1: Code-Review+1
--
To view, visit
mqng2 has abandoned this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/15909 )
Change subject: RSL: Wrong CCCH_CONFIG in SI3 causes a lot of MO call setup
failed when the BTS configured with none combined CCCH mode.
..
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16232 )
Change subject: default-suites.confg: Add suites to test LimeNet-micro
..
default-suites.confg: Add suites to test
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16231 )
Change subject: bts_osmotrx: Add support to run osmo-trx on LimeNet-micro
..
bts_osmotrx: Add support to run osmo-trx on
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16228 )
Change subject: bts_osmotrx: Allow Setting Rx/TX paths through resources.conf
..
bts_osmotrx: Allow Setting Rx/TX paths
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16230 )
Change subject: process: Allow passing no local inst to copy_inst_ssh
..
process: Allow passing no local inst to
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16227 )
Change subject: resources.conf: Mark osmo-bts-trx as supporting a5/3
..
resources.conf: Mark osmo-bts-trx as supporting a5/3
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16229 )
Change subject: process: Return proc in function helpers
..
process: Return proc in function helpers
Caller may want to
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64
Package network:osmocom:nightly/osmo-bts failed to build in
Debian_Testing/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-bts
Last lines of
1 - 100 of 131 matches
Mail list logo
