Change in osmo-ci[master]: ansible: gsm-tester: Enable ip forwarding and masquerading on boot

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16226 ) Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on boot .. Patch Set 3: Code-Review+1 (1 comment) https://

Change in osmo-ccid-firmware[master]: fix the host/emulation build

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319 ) Change subject: fix the host/emulation build .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-ccid-firmware/+

Change in osmo-ccid-firmware[master]: add the talloc ctx to struct ccid_instance

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16318 ) Change subject: add the talloc ctx to struct ccid_instance .. Patch Set 1: (common usage wise, we often have talloc ctx as g

Change in libosmocore[master]: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14864 ) Change subject: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE .. Patch Set 3: (2 comments) This change is ready for revie

Change in libosmocore[master]: Add code coverage support

2019-11-29 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 ) Change subject: Add code coverage support .. Add code coverage support The coverage report shows what code is covered by tests and what is no

Change in osmo-ttcn3-hacks[master]: pcu: Add VTY support and use it to set (M)CS lqual thresholds

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16327 ) Change subject: pcu: Add VTY support and use it to set (M)CS lqual thresholds .. Patch Set 1: Code-Review+1 i don't understand

Change in osmo-pcu[master]: Clarify (M)CS related VTY attributes

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16317 ) Change subject: Clarify (M)CS related VTY attributes .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osm

Change in osmo-pcu[master]: Remove dash from name used in VTY cmd prompt

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16326 ) Change subject: Remove dash from name used in VTY cmd prompt .. Patch Set 1: Code-Review+2 (because this ttcn3 pattern expects only \w

Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests to check UL CS initial and max

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 ) Change subject: pcu: Introduce tests to check UL CS initial and max .. Patch Set 3: Code-Review+2 -- To view, visit https:/

Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests to check UL CS initial and max

2019-11-29 Thread pespin
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 to look at the new patch set (#3). Change subject: pcu: Introduce tests to check UL CS initial and max .

Change in osmo-ccid-firmware[master]: fix the host/emulation build

2019-11-29 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319 ) Change subject: fix the host/emulation build .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ccid-firmwar

Change in osmo-ccid-firmware[master]: fix the host/emulation build

2019-11-29 Thread Hoernchen
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16319 to look at the new patch set (#2). Change subject: fix the host/emulation build .. fi

Change in osmo-ccid-firmware[master]: add the talloc ctx to struct ccid_instance

2019-11-29 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/16318 ) Change subject: add the talloc ctx to struct ccid_instance .. Patch Set 1: > Patch Set 1: > > It's a bit of a question o

Change in docker-playground[master]: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16328 ) Change subject: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg .. Patch Set 1: Code-Review+1 -- To view, visit ht

Change in docker-playground[master]: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16328 ) Change subject: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg .. Patch Set 1: Code-Review+2 -- To view, visit ht

Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests to check UL CS initial and max

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 ) Change subject: pcu: Introduce tests to check UL CS initial and max .. Patch Set 2: Code-Review+1 (5 comments) Fine in gene

Change in osmo-ttcn3-hacks[master]: pcu: Add VTY support and use it to set (M)CS lqual thresholds

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16327 ) Change subject: pcu: Add VTY support and use it to set (M)CS lqual thresholds .. Patch Set 1: Code-Review+1 -- To view, vis

Change in osmo-pcu[master]: Remove dash from name used in VTY cmd prompt

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16326 ) Change subject: Remove dash from name used in VTY cmd prompt .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c

Change in osmo-pcu[master]: Clarify (M)CS related VTY attributes

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16317 ) Change subject: Clarify (M)CS related VTY attributes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/o

Change in libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc

2019-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 ) Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc .. Patch Set 7: (8 comments) https://gerrit

Change in osmo-gsm-tester[master]: WIP

2019-11-29 Thread pespin
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16173 ) Change subject: WIP .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/16173 To unsubscribe, or for help writ

Change in docker-playground[master]: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg

2019-11-29 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16328 ) Change subject: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg .. Patch Set 1: Verified+1 -- To view, visit https:

Change in osmo-ci[master]: ansible: gsm-tester: Enable ip forwarding and masquerading on boot

2019-11-29 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16226 ) Change subject: ansible: gsm-tester: Enable ip forwarding and masquerading on boot .. Patch Set 3: Verified+1 -- To view, visit http

Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests to check UL CS initial and max

2019-11-29 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 to look at the new patch set (#2). Change subject: pcu: Introduce tests to check UL CS initial and max ..

Change in osmo-ttcn3-hacks[master]: WIP

2019-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16337 ) Change subject: WIP .. WIP Change-Id: I3aa654e6f678698e5b8cb4914f1ca5b39fc08568 --- M pcu/PCU_Tests_RAW.ttcn 1 file changed,

Change in osmo-hlr[master]: add keepalive for gsup client/server, osmo-hlr

2019-11-29 Thread Hoernchen
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14741 to look at the new patch set (#3). Change subject: add keepalive for gsup client/server, osmo-hlr .. add

Change in osmo-hlr[master]: mdns: properly zero initialize result data

2019-11-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16335 ) Change subject: mdns: properly zero initialize result data .. mdns: properly zero initialize result data Otherwise, if a response con

Change in osmo-hlr[master]: gsup_server: send routing error back to the correct peer

2019-11-29 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16336 ) Change subject: gsup_server: send routing error back to the correct peer .. gsup_server: send routing error back to the correct peer

Change in osmo-hlr[master]: add libosmo-mslookup abstract client

2019-11-29 Thread neels
Hello fixeria, pespin, laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/16202 to look at the new patch set (#16). Change subject: add libosmo-mslookup abstract client ..

Change in osmo-hlr[master]: add mDNS lookup method to libosmo-mslookup

2019-11-29 Thread neels
Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/16256 to look at the new patch set (#7). Change subject: add mDNS lookup method to libosmo-mslookup ..

Change in docker-playground[master]: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg

2019-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/16328 ) Change subject: ttcn3-pcu: Set correct VTY listen addr in PCU_Tests.cfg .. ttcn3-pcu: Set correct VTY listen addr in PCU_Tes

Change in osmo-ttcn3-hacks[master]: pcu: Add VTY support and use it to set (M)CS lqual thresholds

2019-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16327 ) Change subject: pcu: Add VTY support and use it to set (M)CS lqual thresholds .. pcu: Add VTY support and use it to set (M)CS

Change in osmo-pcu[master]: Remove dash from name used in VTY cmd prompt

2019-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16326 ) Change subject: Remove dash from name used in VTY cmd prompt .. Remove dash from name used in VTY cmd prompt Others projects don't c

Change in osmo-hlr[master]: add mslookup_manual_test

2019-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16210 ) Change subject: add mslookup_manual_test .. Patch Set 20: we don't really need to merge this, it is a candidate for code rot -- To v

Change in osmo-trx[master]: Transceiver: Fix wrong response upon CMD HANDOVER failure

2019-11-29 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16261 ) Change subject: Transceiver: Fix wrong response upon CMD HANDOVER failure .. Transceiver: Fix wrong response upon CMD HANDOVER failure Change-I

Change in osmo-trx[master]: Transceiver: Fix wrong response upon CMD HANDOVER failure

2019-11-29 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16261 ) Change subject: Transceiver: Fix wrong response upon CMD HANDOVER failure .. Patch Set 1: Code-Review+2 -- To view, visit https://ge

Change in osmo-ttcn3-hacks[master]: pcu: Remove unneeded cfg files

2019-11-29 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 ) Change subject: pcu: Remove unneeded cfg files .. Patch Set 1: > Instead of only deleting the configs, I think it would make

Change in osmo-hlr[master]: add libosmo-mslookup abstract client

2019-11-29 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16202 ) Change subject: add libosmo-mslookup abstract client .. Patch Set 15: (1 comment) https://gerrit.osmocom.org/c/osmo-hlr/+/16202/9/sr

Change in osmo-hlr[master]: add mDNS lookup method to libosmo-mslookup

2019-11-29 Thread osmith
osmith has uploaded a new patch set (#6) to the change originally created by neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16256 ) Change subject: add mDNS lookup method to libosmo-mslookup .. add mDNS lookup method to libosm

Change in osmo-ttcn3-hacks[master]: pcu: Remove unneeded cfg files

2019-11-29 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16321 ) Change subject: pcu: Remove unneeded cfg files .. Patch Set 1: > I am sorry but I'm not understanding the rationale here. So

Change in libosmocore[master]: Add code coverage support

2019-11-29 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 ) Change subject: Add code coverage support .. Patch Set 7: Code-Review+2 Cool feature! > It seems the Docker containers are not us