Change in libosmo-abis[master]: Configure E1 pcap file per line

2021-04-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 ) Change subject: Configure E1 pcap file per line .. Patch Set 9: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-ab

Change in libosmo-abis[master]: Configure E1 pcap file per line

2021-04-14 Thread keith
Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118 to look at the new patch set (#9). Change subject: Configure E1 pcap file per line .

Change in libosmo-abis[master]: Configure E1 pcap file per line

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 ) Change subject: Configure E1 pcap file per line .. Patch Set 8: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmo-

Change in libosmo-abis[master]: Configure E1 pcap file per line

2021-04-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 ) Change subject: Configure E1 pcap file per line .. Patch Set 8: (7 comments) Thanks. https://gerrit.osmocom.org/c/libosmo-abis/+

Change in libosmo-abis[master]: Configure E1 pcap file per line

2021-04-14 Thread keith
Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118 to look at the new patch set (#8). Change subject: Configure E1 pcap file per line .

Change in osmo-bsc[master]: Send EUTRAN neighs based on whether Common Id msg contained Last used...

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 ) Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID .. Patch Set 2: (1 comment) h

Change in libosmocore[master]: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required

2021-04-14 Thread pespin
pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/23760 ) Change subject: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required .. gsm: Support Sending Last EUTRAN PLMN Id in Handover

Change in libosmocore[master]: gsm: Support Sending Las EUTRAN PLMN Id in Handover Required

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23760 ) Change subject: gsm: Support Sending Las EUTRAN PLMN Id in Handover Required .. gsm: Support Sending Las EUTRAN PLMN Id in Handove

Change in libosmocore[master]: cosmetic: Fix trailing whitespace

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23759 ) Change subject: cosmetic: Fix trailing whitespace .. cosmetic: Fix trailing whitespace Change-Id: Ib79b0e0c728a7f4de0b3884785c73a

Change in libosmocore[master]: gprs_ns2: implement local update weight procedure

2021-04-14 Thread lynxis lazus
lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23758 ) Change subject: gprs_ns2: implement local update weight procedure .. Abandoned dup of 23187 -- To view, visit https://gerrit.osmocom.

Change in libosmocore[master]: gprs_ns2: add functions for SNS add/del/change-weight messages

2021-04-14 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23186 ) Change subject: gprs_ns2: add functions for SNS add/del/change-weight messages .. Patch Set 2: This change is ready for revi

Change in libosmocore[master]: gprs_ns2: SNS: allow transition missing transition GPRS_SNS_ST_UNCONF...

2021-04-14 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23757 ) Change subject: gprs_ns2: SNS: allow transition missing transition GPRS_SNS_ST_UNCONFIGURED .. gprs_ns2: SNS: allow transit

Change in libosmocore[master]: gprs_ns2: implement local update weight procedure

2021-04-14 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23758 ) Change subject: gprs_ns2: implement local update weight procedure .. gprs_ns2: implement local update weight procedure When

Change in osmo-ttcn3-hacks[master]: ns: TC_sns_bss_change_weight_timeout rework TC to use g_handle_rx_alive

2021-04-14 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23756 ) Change subject: ns: TC_sns_bss_change_weight_timeout rework TC to use g_handle_rx_alive .. ns: TC_sns_bss_change_weigh

Change in osmo-ttcn3-hacks[master]: ns: TC_sns_bss_change_weight_timeout: fix expected SNS_SIZE PDU

2021-04-14 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23755 ) Change subject: ns: TC_sns_bss_change_weight_timeout: fix expected SNS_SIZE PDU .. ns: TC_sns_bss_change_weight_timeout

Change in osmo-bsc[master]: deprecation: use osmo_bts_features_*()

2021-04-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23728 ) Change subject: deprecation: use osmo_bts_features_*() .. deprecation: use osmo_bts_features_*() For "reported feature '%s'...", use the short f

Change in osmo-bsc[master]: drop unused gsm_bts_trx->description

2021-04-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23727 ) Change subject: drop unused gsm_bts_trx->description .. drop unused gsm_bts_trx->description Change-Id: I3c0778322b8c630b0eb9d9cd3ac3cc71386c9c1

Change in osmo-bsc[master]: drop unused func decl rsl_lchan_mark_broken()

2021-04-14 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23726 ) Change subject: drop unused func decl rsl_lchan_mark_broken() .. drop unused func decl rsl_lchan_mark_broken() Change-Id: Ib08e69720e2b9a6ea5f5b

Change in osmo-bsc[master]: Send EUTRAN neighs based on whether Common Id msg contained Last used...

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 ) Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID .. Patch Set 2: (1 comment) h

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Improve naming for detach event

2021-04-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23750 ) Change subject: mm_state_{gb,iu}_fsm: Improve naming for detach event .. mm_state_{gb,iu}_fsm: Improve naming for detach event The E_(P)MM_IMP

Change in osmo-bsc[master]: Send EUTRAN neighs based on whether Common Id msg contained Last used...

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 ) Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID .. Patch Set 2: (1 comment) h

Change in osmo-bsc[master]: Send EUTRAN neighs based on whether Common Id msg contained Last used...

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 ) Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID .. Patch Set 2: Code-Review+1

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Improve naming for detach event

2021-04-14 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23750 ) Change subject: mm_state_{gb,iu}_fsm: Improve naming for detach event .. Patch Set 1: Code-Review+2 Fine with this, the implicit det

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.o

Change in osmo-bsc[master]: cosmetic: Fix typo in func description

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23754 ) Change subject: cosmetic: Fix typo in func description .. cosmetic: Fix typo in func description Change-Id: I26cd31bc3e127cba17be508

Change in osmo-iuh[master]: ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE ...

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/23742 ) Change subject: ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE as a result .. Patch Set 2: Code-Review+1 --

Change in osmo-iuh[master]: ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE ...

2021-04-14 Thread pespin
Hello Jenkins Builder, laforge, daniel, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/23742 to look at the new patch set (#2). Change subject: ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE as a result .

Change in osmo-iuh[master]: ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE ...

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/23742 ) Change subject: ranap_iu_tx_release_free(): always trigger RANAP_IU_EVENT_IU_RELEASE as a result .. Patch Set 1: (1 comment) https

Change in osmo-bsc[master]: Send EUTRAN neighs based on whether Common Id msg contained Last used...

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 ) Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID .. Set Ready For Review -- To

Change in libosmocore[master]: cosmetic: tlv_parser: fix typo in func description

2021-04-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23752 ) Change subject: cosmetic: tlv_parser: fix typo in func description .. cosmetic: tlv_parser: fix typo in func description Change-Id: I27f2837

Change in libosmocore[master]: gsm_08_08.h: Add extra field elements defined in other sections

2021-04-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23751 ) Change subject: gsm_08_08.h: Add extra field elements defined in other sections .. gsm_08_08.h: Add extra field elements defined in other sec

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.o

Change in osmo-iuh[master]: iu_client: Log event sent to upper layer callback

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/23741 ) Change subject: iu_client: Log event sent to upper layer callback .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.os

Change in libosmocore[master]: cosmetic: tlv_parser: fix typo in func description

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23752 ) Change subject: cosmetic: tlv_parser: fix typo in func description .. Patch Set 1: Code-Review+2 -- To view, visit https://gerri

Change in libosmocore[master]: gsm_08_08.h: Add extra field elements defined in other sections

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23751 ) Change subject: gsm_08_08.h: Add extra field elements defined in other sections .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread fixeria
Hello osmith, Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 to look at the new patch set (#7). Change subject: TRXD: add documentation for TRXDv2 protocol ..

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-g

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-g

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Add missing license block, improve spec references

2021-04-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23749 ) Change subject: mm_state_{gb,iu}_fsm: Add missing license block, improve spec references .. mm_state_{gb,iu}_fsm: Add missing license block, i

Change in osmo-sgsn[master]: Iu: Drop timer X3314

2021-04-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23747 ) Change subject: Iu: Drop timer X3314 .. Iu: Drop timer X3314 This Iu timer is Osmocom specific, but is made to resemble T3314 timer from GERAN

Change in osmo-sgsn[master]: gprs_ranap.c: Clean up code path releasing IU conn

2021-04-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23748 ) Change subject: gprs_ranap.c: Clean up code path releasing IU conn .. gprs_ranap.c: Clean up code path releasing IU conn Let's always send the

Change in osmo-sgsn[master]: mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED

2021-04-14 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23743 ) Change subject: mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED .. mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE,

Change in libosmocore[master]: cosmetic: tlv_parser: fix typo in func description

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23752 ) Change subject: cosmetic: tlv_parser: fix typo in func description .. cosmetic: tlv_parser: fix typo in func description Change-I

Change in osmo-sgsn[master]: gprs_ranap.c: Clean up code path releasing IU conn

2021-04-14 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23748 ) Change subject: gprs_ranap.c: Clean up code path releasing IU conn .. Patch Set 1: Code-Review+2 -- To view, visit https://ge

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Improve naming for detach event

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23750 ) Change subject: mm_state_{gb,iu}_fsm: Improve naming for detach event .. Patch Set 1: > Patch Set 1: Code-Review+1 > > Not 100% sure

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Improve naming for detach event

2021-04-14 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23750 ) Change subject: mm_state_{gb,iu}_fsm: Improve naming for detach event .. Patch Set 1: Code-Review+1 Not 100% sure about this.

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Add missing license block, improve spec references

2021-04-14 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23749 ) Change subject: mm_state_{gb,iu}_fsm: Add missing license block, improve spec references .. Patch Set 1: Code-Review+2 -- To

Change in osmo-sgsn[master]: Iu: Drop timer X3314

2021-04-14 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23747 ) Change subject: Iu: Drop timer X3314 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+

Change in osmo-sgsn[master]: Iu: Drop timer X3314

2021-04-14 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23747 ) Change subject: Iu: Drop timer X3314 .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/23747

Change in osmo-sgsn[master]: mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED

2021-04-14 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23743 ) Change subject: mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED .. Patch Set 3: Code-Review+2 -- To vi

Change in libosmocore[master]: gsm_08_08.h: Add extra field elements defined in other sections

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23751 ) Change subject: gsm_08_08.h: Add extra field elements defined in other sections .. gsm_08_08.h: Add extra field elements defined i

Change in osmo-gsm-manuals[master]: TRXD: generalize description of the 'RFU' ('PAD') field

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23687 ) Change subject: TRXD: generalize description of the 'RFU' ('PAD') field .. Patch Set 4: Code-Review+1 -- To view, visit http

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-gs

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread fixeria
Hello osmith, Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 to look at the new patch set (#6). Change subject: TRXD: add documentation for TRXDv2 protocol ..

Change in osmo-gsm-manuals[master]: TRXD: generalize description of the 'RFU' ('PAD') field

2021-04-14 Thread fixeria
Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23687 to look at the new patch set (#4). Change subject: TRXD: generalize description of the 'RFU' ('PAD') field .

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-

Change in docker-playground[master]: ttcn3-pcu-sns: add vty parameter to allow ttcn3 to connect

2021-04-14 Thread daniel
daniel has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23740 ) Change subject: ttcn3-pcu-sns: add vty parameter to allow ttcn3 to connect .. ttcn3-pcu-sns: add vty parameter to allow ttcn3 to connec

Change in docker-playground[master]: ttcn3-pcu-sns: add vty parameter to allow ttcn3 to connect

2021-04-14 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23740 ) Change subject: ttcn3-pcu-sns: add vty parameter to allow ttcn3 to connect .. Patch Set 2: Verified+1 == PCU_Tests_SNS.T

Change in osmo-gbproxy[master]: gitignore: add gbproxy_vty_reference.xml

2021-04-14 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/23736 ) Change subject: gitignore: add gbproxy_vty_reference.xml .. gitignore: add gbproxy_vty_reference.xml Change-Id: I33a0df37b4446b12b53c9e1eac

Change in osmo-gbproxy[master]: gitignore: add gbproxy_vty_reference.xml

2021-04-14 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/23736 ) Change subject: gitignore: add gbproxy_vty_reference.xml .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.

Change in docker-playground[master]: osmo-gsm-tester: open5gs deps only for x86_64

2021-04-14 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23746 ) Change subject: osmo-gsm-tester: open5gs deps only for x86_64 .. osmo-gsm-tester: open5gs deps only for x86_64 mongo-db is only availa

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Improve naming for detach event

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23750 ) Change subject: mm_state_{gb,iu}_fsm: Improve naming for detach event .. mm_state_{gb,iu}_fsm: Improve naming for detach event The

Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Add missing license block, improve spec references

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23749 ) Change subject: mm_state_{gb,iu}_fsm: Add missing license block, improve spec references .. mm_state_{gb,iu}_fsm: Add missing licen

Change in simtrace2[master]: cardem: ensure VCC_PHONE is floating

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23621 ) Change subject: cardem: ensure VCC_PHONE is floating .. Patch Set 2: Code-Review+1 (1 comment) I do not have a good overview in the

Change in osmo-sgsn[master]: gprs_ranap.c: Clean up code path releasing IU conn

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23748 ) Change subject: gprs_ranap.c: Clean up code path releasing IU conn .. gprs_ranap.c: Clean up code path releasing IU conn Let's alwa

Change in osmo-sgsn[master]: Iu: Drop timer X3314

2021-04-14 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23747 ) Change subject: Iu: Drop timer X3314 .. Iu: Drop timer X3314 This Iu timer is Osmocom specific, but is made to resemble T3314 timer

Change in pysim[master]: cards.py: unify card programming

2021-04-14 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/15501 ) Change subject: cards.py: unify card programming .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15501 To unsubscribe, or for h

Change in pysim[master]: pySim-read: Migrate over to use shared argparse from transport

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23722 ) Change subject: pySim-read: Migrate over to use shared argparse from transport .. Patch Set 1: Code-Review+1 -- To view, visit https://

Change in pysim[master]: Move reader related argument parser to transport module

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23721 ) Change subject: Move reader related argument parser to transport module .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.

Change in pysim[master]: init_reader: Print device name/number of chosen reader

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23720 ) Change subject: init_reader: Print device name/number of chosen reader .. Patch Set 1: Code-Review-1 (1 comment) See comment, unfortuna

Change in osmo-gbproxy[master]: gitignore: add gbproxy_vty_reference.xml

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/23736 ) Change subject: gitignore: add gbproxy_vty_reference.xml .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.

Change in osmocom-bb[master]: trx_toolkit: fix encoding of TRXDv2 specific Power field

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23745 ) Change subject: trx_toolkit: fix encoding of TRXDv2 specific Power field .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.o

Change in docker-playground[master]: ttcn3-pcu-sns: add vty parameter to allow ttcn3 to connect

2021-04-14 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23740 ) Change subject: ttcn3-pcu-sns: add vty parameter to allow ttcn3 to connect .. Patch Set 2: Code-Review+2 -- To view, visit

Change in docker-playground[master]: osmo-gsm-tester: open5gs deps only for x86_64

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23746 ) Change subject: osmo-gsm-tester: open5gs deps only for x86_64 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerri

Change in osmo-gsm-manuals[master]: TRXD: add documentation for TRXDv2 protocol

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/22867 ) Change subject: TRXD: add documentation for TRXDv2 protocol .. Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-g

Change in osmo-gsm-manuals[master]: TRXD: rework description of the NOPE / IDLE frame indication

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23744 ) Change subject: TRXD: rework description of the NOPE / IDLE frame indication .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmocom-bb[master]: trx_toolkit: fix encoding of TRXDv2 specific Power field

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/23745 ) Change subject: trx_toolkit: fix encoding of TRXDv2 specific Power field .. Patch Set 1: Code-Review+1 -- To view, visit https://g

Change in osmo-gsm-manuals[master]: TRXD: generalze description of the 'RFU' ('PAD') field

2021-04-14 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/23687 ) Change subject: TRXD: generalze description of the 'RFU' ('PAD') field .. Patch Set 3: Code-Review+1 (1 comment) https://ger

Change in docker-playground[master]: osmo-gsm-tester: open5gs deps only for x86_64

2021-04-14 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23746 ) Change subject: osmo-gsm-tester: open5gs deps only for x86_64 .. Patch Set 3: Interesting, we also have a i386 jenkins node,

Change in docker-playground[master]: osmo-gsm-tester: open5gs deps only for x86_64

2021-04-14 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23746 ) Change subject: osmo-gsm-tester: open5gs deps only for x86_64 .. Patch Set 3: Verified+1 tested both code paths -- To view

Change in docker-playground[master]: osmo-gsm-tester: open5gs deps only for x86_64

2021-04-14 Thread osmith
Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/23746 to look at the new patch set (#3). Change subject: osmo-gsm-tester: open5gs deps only for x86_64 .. osmo

Change in docker-playground[master]: osmo-gsm-tester: open5gs deps only for x86_64

2021-04-14 Thread osmith
Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/23746 to look at the new patch set (#2). Change subject: osmo-gsm-tester: open5gs deps only for x86_64 .. osmo

Change in docker-playground[master]: osmo-gsm-tester: install mongo-db only for x86_64

2021-04-14 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/23746 ) Change subject: osmo-gsm-tester: install mongo-db only for x86_64 .. osmo-gsm-tester: install mongo-db only for x86_64 mong