Change in osmo-bsc[master]: vty-test: osmo-bsc.vty: test doc of lchan activate cmd

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24387 ) Change subject: vty-test: osmo-bsc.vty: test doc of lchan activate cmd .. vty-test: osmo-bsc.vty: test doc of lchan activate cmd A su

Change in osmo-bsc[master]: VTY: add lchan re-assignment command

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24381 to look at the new patch set (#4). Change subject: VTY: add lchan re-assignment command .. VTY: add lcha

Change in osmo-bsc[master]: VTY: add 'vamos-subslot' to activate a secondary lchan

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24380 to look at the new patch set (#4). Change subject: VTY: add 'vamos-subslot' to activate a secondary lchan ...

Change in osmo-bsc[master]: implement CHANnel ACTIVate to VAMOS mode

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24375 to look at the new patch set (#4). Change subject: implement CHANnel ACTIVate to VAMOS mode .. implement

Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24374 to look at the new patch set (#4). Change subject: implement Channel Mode Modify to VAMOS mode .. implem

Change in osmo-bsc[master]: no sigterm sleep

2021-05-23 Thread neels
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24386 ) Change subject: no sigterm sleep .. Abandoned accidental submission -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/24386 To unsubscr

Change in osmo-bsc[master]: add VAMOS secondary lchans to timeslot struct

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24377 to look at the new patch set (#2). Change subject: add VAMOS secondary lchans to timeslot struct .. add

Change in osmo-bsc[master]: no sigterm sleep

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24386 ) Change subject: no sigterm sleep .. no sigterm sleep Change-Id: Ic1c5df22e103fcb0b276cb347cb12dfa440eeb01 --- M src/osmo-bsc/osmo_bsc

Change in osmo-bsc[master]: add fields to reflect nr of lchans in ts struct

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24371 to look at the new patch set (#2). Change subject: add fields to reflect nr of lchans in ts struct .. ad

Change in osmo-bsc[master]: get_any_lchan(): reduce minor code dup

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24385 ) Change subject: get_any_lchan(): reduce minor code dup .. get_any_lchan(): reduce minor code dup Change-Id: I304a7333adc265e156f04b42

Change in osmo-bsc[master]: clarify bts_chan_load

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24384 ) Change subject: clarify bts_chan_load .. clarify bts_chan_load Change-Id: I9bd80a08472018e69360ac5739979c7056d4f063 --- M src/osmo-bs

Change in osmo-bsc[master]: log: assignment_fsm: tweak err msg for incompatible chan

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24383 ) Change subject: log: assignment_fsm: tweak err msg for incompatible chan .. log: assignment_fsm: tweak err msg for incompatible chan

Change in osmo-bsc[master]: log: assignment_fsm: drop newline from assignment_fail

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24382 ) Change subject: log: assignment_fsm: drop newline from assignment_fail .. log: assignment_fsm: drop newline from assignment_fail Drop

Change in osmo-bsc[master]: VTY: add lchan re-assignment command

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24381 ) Change subject: VTY: add lchan re-assignment command .. VTY: add lchan re-assignment command Add VTY command to trigger an intra-cell

Change in osmo-bsc[master]: VTY: 'show lchan': show that lchan is in VAMOS mode

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24379 ) Change subject: VTY: 'show lchan': show that lchan is in VAMOS mode .. VTY: 'show lchan': show that lchan is in VAMOS mode Related: S

Change in osmo-bsc[master]: VTY: add 'vamos-subslot' to activate a secondary lchan

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24380 ) Change subject: VTY: add 'vamos-subslot' to activate a secondary lchan .. VTY: add 'vamos-subslot' to activate a secondary lchan Rela

Change in osmo-bsc[master]: RSL: look up lchan by sign_link, not trx, for VAMOS

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24378 ) Change subject: RSL: look up lchan by sign_link, not trx, for VAMOS .. RSL: look up lchan by sign_link, not trx, for VAMOS So far we

Change in osmo-bsc[master]: add VAMOS secondary lchans to timeslot struct

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24377 ) Change subject: add VAMOS secondary lchans to timeslot struct .. add VAMOS secondary lchans to timeslot struct So far there is a bunc

Change in osmo-bsc[master]: RR Assignment for VAMOS: send TSC Set

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24376 ) Change subject: RR Assignment for VAMOS: send TSC Set .. RR Assignment for VAMOS: send TSC Set We already send the TSC Set in the RSL

Change in osmo-bsc[master]: implement Channel Mode Modify to VAMOS mode

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24374 ) Change subject: implement Channel Mode Modify to VAMOS mode .. implement Channel Mode Modify to VAMOS mode Related: SYS#5315 OS#4940

Change in osmo-bsc[master]: implement CHANnel ACTIVate to VAMOS mode

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24375 ) Change subject: implement CHANnel ACTIVate to VAMOS mode .. implement CHANnel ACTIVate to VAMOS mode Related: SYS#5315 OS#4940 Change

Change in osmo-bsc[master]: add VAMOS cmodes to chan_mode_to_rsl_cmod_spd()

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24373 ) Change subject: add VAMOS cmodes to chan_mode_to_rsl_cmod_spd() .. add VAMOS cmodes to chan_mode_to_rsl_cmod_spd() Related: SYS#5315

Change in osmo-bsc[master]: replace ts_*_for_each_lchan() with ts_for_n_lchans()

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24372 ) Change subject: replace ts_*_for_each_lchan() with ts_for_n_lchans() .. replace ts_*_for_each_lchan() with ts_for_n_lchans() So far w

Change in osmo-bsc[master]: add fields to reflect nr of lchans in ts struct

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24371 ) Change subject: add fields to reflect nr of lchans in ts struct .. add fields to reflect nr of lchans in ts struct So far the number

Change in osmo-bsc[master]: VTY: dump TSC Set and TSC for each timeslot

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24370 ) Change subject: VTY: dump TSC Set and TSC for each timeslot .. VTY: dump TSC Set and TSC for each timeslot This is particularly inter

Change in osmo-bsc[master]: allow explixit TSC Set and TSC on chan activ / modif / assignment

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24369 ) Change subject: allow explixit TSC Set and TSC on chan activ / modif / assignment .. allow explixit TSC Set and TSC on chan activ / m

Change in osmo-bsc[master]: gsm48_lchan2chan_desc(): expose TSC as param

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24368 ) Change subject: gsm48_lchan2chan_desc(): expose TSC as param .. gsm48_lchan2chan_desc(): expose TSC as param Expose the training sequ

Change in osmo-bsc[master]: add chan_mode_to_chan_type()

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24367 ) Change subject: add chan_mode_to_chan_type() .. add chan_mode_to_chan_type() Move the conversion from chan_mode to lchan type out of

Change in osmo-bsc[master]: add secondary RSL link for VAMOS (shadow TEI)

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24366 ) Change subject: add secondary RSL link for VAMOS (shadow TEI) .. add secondary RSL link for VAMOS (shadow TEI) Set up a secondary sig

Change in osmo-bsc[master]: RSL link: explicitly select rsl_link based on lchan

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24365 ) Change subject: RSL link: explicitly select rsl_link based on lchan .. RSL link: explicitly select rsl_link based on lchan Prepare fo

Change in osmo-bsc[master]: hodec 2: do intra-cell congestion resolution by Assignment

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24364 ) Change subject: hodec 2: do intra-cell congestion resolution by Assignment .. hodec 2: do intra-cell congestion resolution by Assignme

Change in osmo-bsc[master]: vty: actually trigger Assignment for 'assignment', not HO

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24363 ) Change subject: vty: actually trigger Assignment for 'assignment', not HO .. vty: actually trigger Assignment for 'assignment', not HO

Change in osmo-bsc[master]: handover_test: fix naming/wording: 'handover-req' should be 'handover...

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24360 ) Change subject: handover_test: fix naming/wording: 'handover-req' should be 'handover-cmd' .. handover_test: fix naming/wording: 'han

Change in osmo-bsc[master]: assignment_fsm: tweak state transitions (prep for reassignment)

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24361 ) Change subject: assignment_fsm: tweak state transitions (prep for reassignment) .. assignment_fsm: tweak state transitions (prep for r

Change in osmo-bsc[master]: assignment_fsm: allow assignment to a specific lchan

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24362 ) Change subject: assignment_fsm: allow assignment to a specific lchan .. assignment_fsm: allow assignment to a specific lchan So far t

Change in osmo-bsc[master]: handover dot charts: fix wrong transitions regarding MGW

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24359 ) Change subject: handover dot charts: fix wrong transitions regarding MGW .. handover dot charts: fix wrong transitions regarding MGW

Build failed in Jenkins: master-osmo-opencm3-projects ยป a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #17

2021-05-23 Thread jenkins
See Changes: -- Started by upstream project "master-osmo-opencm3-projects" build number 17

Change in osmo-bsc[master]: AMR config cleanup step 1: split lchan_mr_config()

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24356 ) Change subject: AMR config cleanup step 1: split lchan_mr_config() .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom

Change in osmo-bsc[master]: move lchan->csd_mode into channel_mode_and_rate

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24355 ) Change subject: move lchan->csd_mode into channel_mode_and_rate .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmo

Change in osmo-bsc[master]: eliminate lchan->rsl_cmode

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24354 ) Change subject: eliminate lchan->rsl_cmode .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/24354/

Change in osmo-bsc[master]: remove special case from assignment_count_result()

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24353 ) Change subject: remove special case from assignment_count_result() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.o

Change in osmo-bsc[master]: make sure channel mode and s15_s0 are updated only after an ACK

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24352 ) Change subject: make sure channel mode and s15_s0 are updated only after an ACK .. Patch Set 2: (5 comments) https://gerrit.osmocom

Change in osmo-bsc[master]: cosmetic scoping in reuse_existing_lchan()

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24351 ) Change subject: cosmetic scoping in reuse_existing_lchan() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.o

Change in osmo-bsc[master]: assignment_fsm: send BSSMAP response only after Assignment Request

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24350 ) Change subject: assignment_fsm: send BSSMAP response only after Assignment Request .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: AMR config cleanup step 2: filter modes also for VTY

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24357 to look at the new patch set (#2). Change subject: AMR config cleanup step 2: filter modes also for VTY .

Change in osmo-bsc[master]: move lchan->csd_mode into channel_mode_and_rate

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24355 to look at the new patch set (#2). Change subject: move lchan->csd_mode into channel_mode_and_rate .. mo

Change in osmo-bsc[master]: AMR config cleanup step 3: generate AMR LV on msg composition

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24358 to look at the new patch set (#2). Change subject: AMR config cleanup step 3: generate AMR LV on msg composition

Change in osmo-bsc[master]: AMR config cleanup step 1: split lchan_mr_config()

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24356 to look at the new patch set (#2). Change subject: AMR config cleanup step 1: split lchan_mr_config() ..

Change in osmo-bsc[master]: eliminate lchan->rsl_cmode

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24354 to look at the new patch set (#2). Change subject: eliminate lchan->rsl_cmode .. eliminate lchan->rsl_cm

Change in osmo-bsc[master]: remove special case from assignment_count_result()

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24353 to look at the new patch set (#2). Change subject: remove special case from assignment_count_result() ..

Change in osmo-bsc[master]: make sure channel mode and s15_s0 are updated only after an ACK

2021-05-23 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24352 to look at the new patch set (#2). Change subject: make sure channel mode and s15_s0 are updated only after an ACK ..

Change in osmo-bsc[master]: cosmetic scoping in reuse_existing_lchan()

2021-05-23 Thread neels
Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24351 to look at the new patch set (#2). Change subject: cosmetic scoping in reuse_existing_lchan() ..

Change in osmo-bsc[master]: assignment_fsm: send BSSMAP response only after Assignment Request

2021-05-23 Thread neels
Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/24350 to look at the new patch set (#2). Change subject: assignment_fsm: send BSSMAP response only after Assignment Request .

Change in osmo-sgsn[master]: add support for multiple encryption algorithms + a5/4

2021-05-23 Thread Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/24304 ) Change subject: add support for multiple encryption algorithms + a5/4 .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/o

Change in osmo-sgsn[master]: add support for multiple encryption algorithms + a5/4

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/24304 ) Change subject: add support for multiple encryption algorithms + a5/4 .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/os

Change in osmo-bsc[master]: cosmetic scoping in reuse_existing_lchan()

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24351 ) Change subject: cosmetic scoping in reuse_existing_lchan() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.o

Change in osmo-bsc[master]: assignment_fsm: send BSSMAP response only after Assignment Request

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24350 ) Change subject: assignment_fsm: send BSSMAP response only after Assignment Request .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-mgw[master]: mgcp_network: refactor MGCP_DUMMY_LOAD

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24315 ) Change subject: mgcp_network: refactor MGCP_DUMMY_LOAD .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/24315/1

Change in pysim[master]: execute unit tests via nose from "setup.py test"

2021-05-23 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/24349 to look at the new patch set (#2). Change subject: execute unit tests via nose from "setup.py test" .. exec

Change in pysim[master]: execute unit tests via nose from "setup.py test"

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24349 ) Change subject: execute unit tests via nose from "setup.py test" .. Patch Set 1: Would be good to see the motivation for this change in

Change in pysim[master]: Introduce unit test for bertlv_parse_one()

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24348 ) Change subject: Introduce unit test for bertlv_parse_one() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/

Change in pysim[master]: bertlv_parse_one: Also return remainder after end of TLV

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24347 ) Change subject: bertlv_parse_one: Also return remainder after end of TLV .. Patch Set 1: Code-Review+2 -- To view, visit https://gerri

Change in pysim[master]: add unit tests for BER-TLV encoder/decoder functions

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24346 ) Change subject: add unit tests for BER-TLV encoder/decoder functions .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.os

Change in pysim[master]: contrib: Add sim-rest-{server,client}.py

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24342 ) Change subject: contrib: Add sim-rest-{server,client}.py .. Patch Set 2: (7 comments) https://gerrit.osmocom.org/c/pysim/+/24342/2/con

Change in osmo-bsc[master]: AMR config cleanup step 3: generate AMR LV on msg composition

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24358 ) Change subject: AMR config cleanup step 3: generate AMR LV on msg composition .. AMR config cleanup step 3: generate AMR LV on msg com

Change in osmo-bsc[master]: move lchan->csd_mode into channel_mode_and_rate

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24355 ) Change subject: move lchan->csd_mode into channel_mode_and_rate .. move lchan->csd_mode into channel_mode_and_rate The GSM48_CMODE_DA

Change in osmo-bsc[master]: AMR config cleanup step 2: filter modes also for VTY

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24357 ) Change subject: AMR config cleanup step 2: filter modes also for VTY .. AMR config cleanup step 2: filter modes also for VTY The prev

Change in osmo-bsc[master]: eliminate lchan->rsl_cmode

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24354 ) Change subject: eliminate lchan->rsl_cmode .. eliminate lchan->rsl_cmode Change-Id: I1c167b22bb6638a929488d093bde0f1a5fb227ad --- M i

Change in osmo-bsc[master]: AMR config cleanup step 1: split lchan_mr_config()

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24356 ) Change subject: AMR config cleanup step 1: split lchan_mr_config() .. AMR config cleanup step 1: split lchan_mr_config() Split off tw

Change in osmo-bsc[master]: remove special case from assignment_count_result()

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24353 ) Change subject: remove special case from assignment_count_result() .. remove special case from assignment_count_result() The single p

Change in osmo-bsc[master]: make sure channel mode and s15_s0 are updated only after an ACK

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24352 ) Change subject: make sure channel mode and s15_s0 are updated only after an ACK .. make sure channel mode and s15_s0 are updated only

Change in osmo-bsc[master]: assignment_fsm: send BSSMAP response only after Assignment Request

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24350 ) Change subject: assignment_fsm: send BSSMAP response only after Assignment Request .. assignment_fsm: send BSSMAP response only after

Change in osmo-bsc[master]: cosmetic scoping in reuse_existing_lchan()

2021-05-23 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/24351 ) Change subject: cosmetic scoping in reuse_existing_lchan() .. cosmetic scoping in reuse_existing_lchan() cosmetic prep for Ie0da36124

Change in osmo-bts[2021q1]: gsm_data.h: fix wrong bit-mask in BSIC2BCC macro

2021-05-23 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24345 ) Change subject: gsm_data.h: fix wrong bit-mask in BSIC2BCC macro .. gsm_data.h: fix wrong bit-mask in BSIC2BCC macro BCC takes 3 LSB bits of t

Change in pysim[master]: execute unit tests via nose from "setup.py test"

2021-05-23 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24349 ) Change subject: execute unit tests via nose from "setup.py test" .. execute unit tests via nose from "setup.py test" Change-Id: I8b220

Change in pysim[master]: Introduce unit test for bertlv_parse_one()

2021-05-23 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24348 ) Change subject: Introduce unit test for bertlv_parse_one() .. Introduce unit test for bertlv_parse_one() Change-Id: I3adbe22afd4b6503a

Change in pysim[master]: cards: All USIM should use CLA 0x00 and request the FCP

2021-05-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24335 ) Change subject: cards: All USIM should use CLA 0x00 and request the FCP .. Patch Set 3: somehow I'm failing why FairwavesSIM is failing

Change in pysim[master]: cards: All USIM should use CLA 0x00 and request the FCP

2021-05-23 Thread laforge
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/24335 ) Change subject: cards: All USIM should use CLA 0x00 and request the FCP .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24335

Change in pysim[master]: add unit tests for BER-TLV encoder/decoder functions

2021-05-23 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24346 ) Change subject: add unit tests for BER-TLV encoder/decoder functions .. add unit tests for BER-TLV encoder/decoder functions ... and w

Change in pysim[master]: contrib: Add sim-rest-{server,client}.py

2021-05-23 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/24342 to look at the new patch set (#2). Change subject: contrib: Add sim-rest-{server,client}.py .. contrib: Add

Change in pysim[master]: bertlv_parse_one: Also return remainder after end of TLV

2021-05-23 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24347 ) Change subject: bertlv_parse_one: Also return remainder after end of TLV .. bertlv_parse_one: Also return remainder after end of TLV C

Change in pysim[master]: cards: All USIM should use CLA 0x00 and request the FCP

2021-05-23 Thread laforge
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/24335 to look at the new patch set (#3). Change subject: cards: All USIM should use CLA 0x00 and request the FCP .

Change in libosmocore[master]: kdf: add key derivation functions

2021-05-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24291 ) Change subject: kdf: add key derivation functions .. Patch Set 7: Code-Review-1 (4 comments) > Patch Set 7: > I'm not aware of

Change in osmo-bts[2021q1]: gsm_data.h: fix wrong bit-mask in BSIC2BCC macro

2021-05-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24345 ) Change subject: gsm_data.h: fix wrong bit-mask in BSIC2BCC macro .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osm

Change in pysim[master]: commands: remove superfluous getter/setter for cla_byte property

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24344 ) Change subject: commands: remove superfluous getter/setter for cla_byte property .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in pysim[master]: commands: resolve inconsistency on sel_ctrl

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24343 ) Change subject: commands: resolve inconsistency on sel_ctrl .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in pysim[master]: commands: remove superfluous getter/setter for cla_byte property

2021-05-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24344 ) Change subject: commands: remove superfluous getter/setter for cla_byte property .. commands: remove superfluous getter/setter for cla_byte proper

Change in pysim[master]: commands: resolve inconsistency on sel_ctrl

2021-05-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24343 ) Change subject: commands: resolve inconsistency on sel_ctrl .. commands: resolve inconsistency on sel_ctrl The code uses self.sel_ctrl everywhere

Change in pysim[master]: commands: remove superfluous getter/setter for cla_byte property

2021-05-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24344 ) Change subject: commands: remove superfluous getter/setter for cla_byte property .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in pysim[master]: commands: resolve inconsistency on sel_ctrl

2021-05-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24343 ) Change subject: commands: resolve inconsistency on sel_ctrl .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-bts[master]: [VAMOS] gsm_data.h: fix wrong bit-mask in BSIC2BCC macro

2021-05-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24337 ) Change subject: [VAMOS] gsm_data.h: fix wrong bit-mask in BSIC2BCC macro .. Patch Set 2: > Patch Set 1: Code-Review+2 > > that's act

Change in osmo-bts[2021q1]: gsm_data.h: fix wrong bit-mask in BSIC2BCC macro

2021-05-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/24345 ) Change subject: gsm_data.h: fix wrong bit-mask in BSIC2BCC macro .. gsm_data.h: fix wrong bit-mask in BSIC2BCC macro BCC takes 3 LS

Change in osmo-bts[master]: [VAMOS] osmo-bts-trx: rework and split up bts_sched_fn()

2021-05-23 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24323 ) Change subject: [VAMOS] osmo-bts-trx: rework and split up bts_sched_fn() .. [VAMOS] osmo-bts-trx: rework and split up bts_sched_fn() Currently

Change in pysim[master]: commands: remove superfluous getter/setter for cla_byte property

2021-05-23 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24344 ) Change subject: commands: remove superfluous getter/setter for cla_byte property .. commands: remove superfluous getter/setter for cla_

Change in pysim[master]: commands: resolve inconsistency on sel_ctrl

2021-05-23 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/24343 ) Change subject: commands: resolve inconsistency on sel_ctrl .. commands: resolve inconsistency on sel_ctrl The code uses self.sel_ctrl

Change in osmo-bts[master]: common: phy_links_open(): warn about dangling PHY instances

2021-05-23 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/24288 ) Change subject: common: phy_links_open(): warn about dangling PHY instances .. common: phy_links_open(): warn about dangling PHY instances Cha

Change in osmo-mgw[master]: mgcp_common, mgcp_udp_send: make parameter buf const

2021-05-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24314 ) Change subject: mgcp_common, mgcp_udp_send: make parameter buf const .. mgcp_common, mgcp_udp_send: make parameter buf const When mgcp_udp_sen

Change in osmo-mgw[master]: mgcp_network: refactor MGCP_DUMMY_LOAD

2021-05-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24315 ) Change subject: mgcp_network: refactor MGCP_DUMMY_LOAD .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-mgw[master]: mgcp_common, mgcp_udp_send: make parameter buf const

2021-05-23 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/24314 ) Change subject: mgcp_common, mgcp_udp_send: make parameter buf const .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit

Change in libosmocore[master]: gprs_ns2: vty: fix removing a bind from a SNS

2021-05-23 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24121 ) Change subject: gprs_ns2: vty: fix removing a bind from a SNS .. gprs_ns2: vty: fix removing a bind from a SNS Return 0 after removing a bi

  1   2   >