[S] Change in osmo-msc[master]: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios

2023-06-23 Thread falconia
Attention is currently required from: neels. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29973 ) Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios .. Patch Set 1:

[S] Change in pysim[master]: pySim-shell: Unregister profile commands during equip

2023-06-23 Thread iw0
iw0 has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33424 ) Change subject: pySim-shell: Unregister profile commands during equip .. pySim-shell: Unregister profile commands during equip Change-Id:

[S] Change in pysim[master]: pySim-shell: Unregister profile commands during equip

2023-06-23 Thread iw0
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/33424 to look at the new patch set (#2). Change subject: pySim-shell: Unregister profile commands during equip ..

[M] Change in libosmocore[master]: lapdm: cosmetic: simplify lapdm_phsap_up(), use OSMO_PRIM[_HDR]

2023-06-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33409 ) Change subject: lapdm: cosmetic: simplify lapdm_phsap_up(), use OSMO_PRIM[_HDR] .. lapdm: cosmetic: simplify lapdm_phsap_up(), us

[S] Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...

2023-06-23 Thread fixeria
Attention is currently required from: arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ..

[S] Change in osmo-msc[master]: smpp_handle_bind_tx: initialize tlv

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33395 ) Change subject: smpp_handle_bind_tx: initialize tlv .. Patch Set 1: Code-Review+2 --

[XS] Change in pysim[master]: test - please ignore

2023-06-23 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33410 ) Change subject: test - please ignore .. test - please ignore Change-Id: I7bd49c91b2de2fc8aae732e35082992de1697bbf --- A testme 1 file c

[S] Change in osmo-msc[master]: sdp_msg_test: fix dereference after null check

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33396 ) Change subject: sdp_msg_test: fix dereference after null check .. Patch Set 1: Code-Re

[S] Change in osmo-msc[master]: smpp_msc: submit_to_sms: check ud_len > sms_msg_len

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33397 ) Change subject: smpp_msc: submit_to_sms: check ud_len > sms_msg_len .. Patch Set 1: Co

[XS] Change in pysim[master]: test - please ignore

2023-06-23 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/33410 ) Change subject: test - please ignore .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33410 To unsubscribe, or for help writing

[S] Change in osmo-msc[master]: msc_ho_send_handover_request: fix check_after_deref

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33398 ) Change subject: msc_ho_send_handover_request: fix check_after_deref .. Patch Set 2: Co

[S] Change in osmo-msc[master]: smpp_handle_bind_tx: initialize tlv

2023-06-23 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33395 ) Change subject: smpp_handle_bind_tx: initialize tlv .. smpp_handle_bind_tx: initialize tlv Fixes: CID#272977 Change-Id: I22da1aa95bf19a9bb1d8e0

[S] Change in osmo-msc[master]: smpp_msc: submit_to_sms: check ud_len > sms_msg_len

2023-06-23 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33397 ) Change subject: smpp_msc: submit_to_sms: check ud_len > sms_msg_len .. smpp_msc: submit_to_sms: check ud_len > sms_msg_len Fixes: CID#240727 Ch

[S] Change in osmo-msc[master]: sdp_msg_test: fix dereference after null check

2023-06-23 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33396 ) Change subject: sdp_msg_test: fix dereference after null check .. sdp_msg_test: fix dereference after null check Fixes: CID#274690 Change-Id: I

[S] Change in osmo-msc[master]: msc_ho_send_handover_request: fix check_after_deref

2023-06-23 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33398 ) Change subject: msc_ho_send_handover_request: fix check_after_deref .. msc_ho_send_handover_request: fix check_after_deref Fixes: CID#211073 Ch

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread fixeria
Attention is currently required from: osmith, fixeria, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Se

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread pespin
Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Set 1: Code

[S] Change in libosmocore[master]: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx()

2023-06-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33411 ) Change subject: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx() .. coding: fix a copy-paste bug in gsm0503_tch_afs_d

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Set 1: (1 comment)

[S] Change in libosmocore[master]: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx()

2023-06-23 Thread osmith
Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33411 ) Change subject: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx() ...

[S] Change in libosmocore[master]: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx()

2023-06-23 Thread pespin
Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33411 ) Change subject: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx() ...

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread fixeria
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Set 1: (2

[S] Change in libosmocore[master]: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx()

2023-06-23 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33411 ) Change subject: coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx() .. coding: fix a copy-paste bug in gsm0503_tch_afs_decode_dtx()

[S] Change in osmo-ci[master]: obs: make limesuite build with debian 12

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33399 ) Change subject: obs: make limesuite build with debian 12 .. Patch Set 1: Code-Review+2

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread fixeria
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Set 1: (1

[S] Change in osmo-ci[master]: obs: make limesuite build with debian 12

2023-06-23 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33399 ) Change subject: obs: make limesuite build with debian 12 .. obs: make limesuite build with debian 12 Related: OS#6057 Change-Id: Ic81dfbfa232b92

[S] Change in osmo-hnbgw[master]: coverity: hnbgw_cn: avoid NULL deref in LOGP

2023-06-23 Thread fixeria
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33401 ) Change subject: coverity: hnbgw_cn: avoid NULL deref in LOGP .. Patch Set 1: Code-Rev

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Abandoned thanks for the review, needs to be split up in separate patches etc --

[S] Change in osmo-msc[master]: csd_bs_list_to_gsm0808_channel_type: fix rc check

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33393 ) Change subject: csd_bs_list_to_gsm0808_channel_type: fix rc check .. Patch Set 1: Code

[S] Change in osmo-msc[master]: csd_bs_list_to_gsm0808_channel_type: fix rc check

2023-06-23 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33393 ) Change subject: csd_bs_list_to_gsm0808_channel_type: fix rc check .. csd_bs_list_to_gsm0808_channel_type: fix rc check Check the return code be

[S] Change in osmo-msc[master]: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str .. Patch Set 1:

[S] Change in osmo-msc[master]: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str .. Patch Set 1:

[M] Change in libosmocore[master]: logging: add log level cache

2023-06-23 Thread fixeria
Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633 ) Change subject: logging: add log level cache .. Patch Set 12: (1 comme

[S] Change in osmo-msc[master]: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str

2023-06-23 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33394 ) Change subject: gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str .. gsm48_cc_tx_alerting: check rc of sdp_msg_from_sdp_str Fixes: CID#321

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Set 1: (1 comment)

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Set 1: (1 comment)

[S] Change in libosmocore[master]: Fix various uninitialized value errors

2023-06-23 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 ) Change subject: Fix various uninitialized value errors .. Patch Set 1: (1 comment)

[S] Change in osmo-bts[master]: gitignore: add arm-poky-linux-gnueabi-libtool

2023-06-23 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33412 ) Change subject: gitignore: add arm-poky-linux-gnueabi-libtool .. gitignore: add arm-poky-linux-gnueabi-libtool This file gets copied

[S] Change in osmo-bts[master]: osmo-bts-sysmo: trx_mute_on_init_cb: call bts_update_status

2023-06-23 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33413 ) Change subject: osmo-bts-sysmo: trx_mute_on_init_cb: call bts_update_status .. osmo-bts-sysmo: trx_mute_on_init_cb: call bts_update_s

[S] Change in osmo-bts[master]: gitignore: add arm-poky-linux-gnueabi-libtool

2023-06-23 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33412 ) Change subject: gitignore: add arm-poky-linux-gnueabi-libtool .. Patch Set 1: Code-Revi

[M] Change in osmocom-bb[master]: modem: properly handle Dedicated mode or TBF IE

2023-06-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33414 ) Change subject: modem: properly handle Dedicated mode or TBF IE .. modem: properly handle Dedicated mode or TBF IE We need to dis

[S] Change in osmo-hnbgw[master]: coverity: hnbgw_cn: avoid NULL deref in LOGP

2023-06-23 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33401 ) Change subject: coverity: hnbgw_cn: avoid NULL deref in LOGP .. coverity: hnbgw_cn: avoid NULL deref in LOGP Related: CID#321281 Change-Id: Ic

[M] Change in osmocom-bb[master]: modem: properly handle Dedicated mode or TBF IE

2023-06-23 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/33414 to look at the new patch set (#2). Change subject: modem: properly handle Dedicated mode or TBF IE

[M] Change in osmocom-bb[master]: modem: properly handle Dedicated mode or TBF IE

2023-06-23 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/33414 to look at the new patch set (#3). Change subject: modem: properly handle Dedicated mode or TBF IE

[M] Change in libosmocore[master]: gsm: add gsm0502_fn2ccch_block()

2023-06-23 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33402 ) Change subject: gsm: add gsm0502_fn2ccch_block() .. Patch Set 2: Code-Review+2 (1 c

[M] Change in libosmocore[master]: gsm: add gsm0502_fn2ccch_block()

2023-06-23 Thread fixeria
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33402 ) Change subject: gsm: add gsm0502_fn2ccch_block() .. Patch Set 2: (1 comment) File

[M] Change in osmo-bsc[master]: ctrl: Add setting SI5 neighbor list

2023-06-23 Thread neels
Attention is currently required from: laforge, pespin, matanp, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32761 ) Change subject: ctrl: Add setting SI5 neighbor list .. Patch Se

[S] Change in osmo-msc[master]: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios

2023-06-23 Thread neels
Attention is currently required from: falconia. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29973 ) Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios .. Patch Set 1:

[S] Change in osmo-msc[master]: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios

2023-06-23 Thread neels
Attention is currently required from: falconia. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29973 ) Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios .. Patch Set 1:

[S] Change in osmo-hnbgw[master]: ranap_rab_ass: be sure to initialize memory with 0

2023-06-23 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33391 ) Change subject: ranap_rab_ass: be sure to initialize memory with 0 .. ranap_rab_ass: be sure to initialize memory with 0 When we use the ASN.1

[M] Change in osmo-hnbgw[master]: ranap_rab_ass: do not free never allocated FieldItems

2023-06-23 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33390 ) Change subject: ranap_rab_ass: do not free never allocated FieldItems .. ranap_rab_ass: do not free never allocated FieldItems When we check f

[M] Change in osmocom-bb[master]: modem: properly handle Dedicated mode or TBF IE

2023-06-23 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33414 ) Change subject: modem: properly handle Dedicated mode or TBF IE .. Patch Set 3: Code

[S] Change in osmo-pcu[master]: tbf_ul: Avoid processing rx UL bocks for UL TBFs in RELEASING state

2023-06-23 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33415 ) Change subject: tbf_ul: Avoid processing rx UL bocks for UL TBFs in RELEASING state .. tbf_ul: Avoid processing rx UL bocks for UL T

[M] Change in osmo-pcu[master]: tbf_ul_fsm: Delay moving ul_tbf to FLOW

2023-06-23 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33416 ) Change subject: tbf_ul_fsm: Delay moving ul_tbf to FLOW .. tbf_ul_fsm: Delay moving ul_tbf to FLOW Otherwise the scheduler selects t

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: Add support for PCUIF protocol version 11

2023-06-23 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 ) Change subject: BTS_Tests: Add support for PCUIF protocol version 11 .. BTS_Tests: Add support for PCUIF protocol version 11

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: fix record PCUIF_pch_dt

2023-06-23 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 ) Change subject: PCUIF_Types: fix record PCUIF_pch_dt .. PCUIF_Types: fix record PCUIF_pch_dt The record PCUIF_pch_dt uses AL

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: fix record PCUIF_pch_dt

2023-06-23 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33417 ) Change subject: PCUIF_Types: fix record PCUIF_pch_dt .. Patch Set 1: Code-Revie

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: Add support for PCUIF protocol version 11

2023-06-23 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 ) Change subject: BTS_Tests: Add support for PCUIF protocol version 11 .. Patch S

[S] Change in osmo-msc[master]: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios

2023-06-23 Thread falconia
Attention is currently required from: neels. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29973 ) Change subject: msc_a: send MNCC_RTP_CONNECT in call waiting scenarios .. Patch Set 1:

[S] Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...

2023-06-23 Thread arehbein
Attention is currently required from: fixeria, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ..

[M] Change in libosmocore[master]: ecu: add is_dtx_pause() method

2023-06-23 Thread falconia
falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33419 ) Change subject: ecu: add is_dtx_pause() method .. ecu: add is_dtx_pause() method The ECU API of libosmocodec is unfortunately a

[S] Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...

2023-06-23 Thread arehbein
Attention is currently required from: fixeria, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ..