[M] Change in osmo-hnbgw[master]: rua: validate correct RUA ctx state per RUA message type

2023-12-11 Thread fixeria
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35329?usp=email ) Change subject: rua: validate correct RUA ctx state per RUA message type ..

[M] Change in osmo-hnbgw[master]: rua: validate correct RUA ctx state per RUA message type

2023-12-11 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35329?usp=email to look at the new patch set (#2). Change subject: rua: validate correct RUA ctx state per RUA message type

[M] Change in osmo-hnbgw[master]: rua: validate correct RUA ctx state per RUA message type

2023-12-11 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35329?usp=email ) Change subject: rua: validate correct RUA ctx state per RUA message type .. rua: validate correct RUA ctx state per RUA

[S] Change in osmo-ci[master]: Revert "coverity: build osmo-trx with USRP1 support"

2023-12-11 Thread laforge
laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35291?usp=email ) Change subject: Revert "coverity: build osmo-trx with USRP1 support" .. Abandoned we ignore libusrp stuff in coverity now instead.

[M] Change in libosmocore[master]: soft_uart: fix the Rx flushing logic, add a unit test

2023-12-11 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35297?usp=email ) Change subject: soft_uart: fix the Rx flushing logic, add a unit test .. soft_uart: fix the Rx flushing logic, add a unit test

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with inefficient polling

2023-12-11 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35327?usp=email ) Change subject: soft_uart: demonstrate a problem with inefficient polling .. soft_uart: demonstrate a problem with inefficient

[S] Change in libosmocore[master]: soft_uart: demonstrate a problem with manual flush()ing

2023-12-11 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35326?usp=email ) Change subject: soft_uart: demonstrate a problem with manual flush()ing .. soft_uart: demonstrate a problem with manual

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with inefficient polling

2023-12-11 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35327?usp=email ) Change subject: soft_uart: demonstrate a problem with inefficient polling

[S] Change in libosmocore[master]: soft_uart: demonstrate a problem with manual flush()ing

2023-12-11 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35326?usp=email ) Change subject: soft_uart: demonstrate a problem with manual flush()ing

[M] Change in libosmocore[master]: soft_uart: fix the Rx flushing logic, add a unit test

2023-12-11 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35297?usp=email ) Change subject: soft_uart: fix the Rx flushing logic, add a unit test ..

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

2023-12-11 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info() .. socket: Introduce API

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

2023-12-11 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

2023-12-11 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with inefficient polling

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35327?usp=email ) Change subject: soft_uart: demonstrate a problem with inefficient polling

[S] Change in libosmocore[master]: soft_uart: demonstrate a problem with manual flush()ing

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35326?usp=email ) Change subject: soft_uart: demonstrate a problem with manual flush()ing ..

[S] Change in libosmocore[master]: tests/iuup: fix assert()s in test_decode_passive_init_2_rfci_no_iptis()

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35325?usp=email ) Change subject: tests/iuup: fix assert()s in test_decode_passive_init_2_rfci_no_iptis()

[S] Change in libosmocore[master]: tests/gsm0808: fix assert()s in test_gsm0808_dec_cell_id_list_srvcc()

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35324?usp=email ) Change subject: tests/gsm0808: fix assert()s in test_gsm0808_dec_cell_id_list_srvcc()

[S] Change in libosmocore[master]: tests/lapd: fix wrong size passed in test_lapdm_contention_resolution()

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35323?usp=email ) Change subject: tests/lapd: fix wrong size passed in test_lapdm_contention_resolution()

[S] Change in osmo-mgw[master]: mgcp: reserve once byte for '\0' in mgcp_do_read()

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35322?usp=email ) Change subject: mgcp: reserve once byte for '\0' in mgcp_do_read() .. Patch

[M] Change in libosmocore[master]: soft_uart: demonstrate a problem with inefficient polling

2023-12-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35327?usp=email ) Change subject: soft_uart: demonstrate a problem with inefficient polling .. soft_uart: demonstrate a problem with

[S] Change in libosmocore[master]: soft_uart: demonstrate a problem with manual flush()ing

2023-12-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35326?usp=email ) Change subject: soft_uart: demonstrate a problem with manual flush()ing .. soft_uart: demonstrate a problem with

[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp

2023-12-11 Thread fixeria
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp ..

[S] Change in osmo-msc[master]: sdp: allow more space for fmtp

2023-12-11 Thread fixeria
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35306?usp=email ) Change subject: sdp: allow more space for fmtp .. Patch Set 1: Code-Review+2

[S] Change in libosmocore[master]: tests/iuup: fix assert()s in test_decode_passive_init_2_rfci_no_iptis()

2023-12-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35325?usp=email ) Change subject: tests/iuup: fix assert()s in test_decode_passive_init_2_rfci_no_iptis() .. tests/iuup: fix assert()s

[S] Change in libosmocore[master]: tests/gsm0808: fix assert()s in test_gsm0808_dec_cell_id_list_srvcc()

2023-12-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35324?usp=email ) Change subject: tests/gsm0808: fix assert()s in test_gsm0808_dec_cell_id_list_srvcc() .. tests/gsm0808: fix assert()s

[S] Change in libosmocore[master]: tests/lapd: fix wrong size passed in test_lapdm_contention_resolution()

2023-12-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35323?usp=email ) Change subject: tests/lapd: fix wrong size passed in test_lapdm_contention_resolution() .. tests/lapd: fix wrong size

[S] Change in osmo-mgw[master]: mgcp: reserve once byte for '\0' in mgcp_do_read()

2023-12-11 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35322?usp=email ) Change subject: mgcp: reserve once byte for '\0' in mgcp_do_read() .. Patch

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-11 Thread pespin
Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in osmo-mgw[master]: mgcp: reserve once byte for '\0' in mgcp_do_read()

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35322?usp=email ) Change subject: mgcp: reserve once byte for '\0' in mgcp_do_read() .. Patch

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-11 Thread dexter
Attention is currently required from: laforge, neels, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-11 Thread dexter
Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[S] Change in osmo-mgw[master]: mgcp: simplify getting msgb tail in mgcp_msg_terminate_nul()

2023-12-11 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35321?usp=email ) Change subject: mgcp: simplify getting msgb tail in mgcp_msg_terminate_nul()

[S] Change in libosmocore[master]: utils: improve readability of OSMO_STRBUF_CHAR_COUNT

2023-12-11 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35313?usp=email ) Change subject: utils: improve readability of OSMO_STRBUF_CHAR_COUNT ..

[M] Change in libosmocore[master]: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly

2023-12-11 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35312?usp=email ) Change subject: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly

[M] Change in libosmocore[master]: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly

2023-12-11 Thread neels
Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35312?usp=email ) Change subject: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly

[S] Change in osmo-mgw[master]: mgcp: simplify getting msgb tail in mgcp_msg_terminate_nul()

2023-12-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35321?usp=email ) Change subject: mgcp: simplify getting msgb tail in mgcp_msg_terminate_nul() .. mgcp: simplify getting msgb tail in

[S] Change in osmo-mgw[master]: mgcp: reserve once byte for '\0' in mgcp_do_read()

2023-12-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35322?usp=email ) Change subject: mgcp: reserve once byte for '\0' in mgcp_do_read() .. mgcp: reserve once byte for '\0' in mgcp_do_read()

[S] Change in osmo-pcu[osmith/1.4.0]: Bump version: 1.3.1.6-8b8b → 1.4.0

2023-12-11 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35320?usp=email ) Change subject: Bump version: 1.3.1.6-8b8b → 1.4.0 .. Abandoned needs more discussion, see

[M] Change in osmo-pcu[osmith/1.4.0]: gprs_rlcmac_sched: fix condition for generating dummy blocks on idle

2023-12-11 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35319?usp=email ) Change subject: gprs_rlcmac_sched: fix condition for generating dummy blocks on idle .. Abandoned needs more discussion, see

[S] Change in osmo-pcu[osmith/1.4.0]: TBF status: Fix VTY output text

2023-12-11 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35317?usp=email ) Change subject: TBF status: Fix VTY output text .. Abandoned needs more discussion, see

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

2023-12-11 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF .. Abandoned needs more discussion, see

[S] Change in osmo-pcu[osmith/1.4.0]: Increase RR scheduler priority to 20, to avoid dropped bursts

2023-12-11 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35316?usp=email ) Change subject: Increase RR scheduler priority to 20, to avoid dropped bursts .. Abandoned needs more discussion, see

[S] Change in osmo-pcu[osmith/1.4.0]: systemd: remove RestartPreventExitStatus=1

2023-12-11 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35315?usp=email ) Change subject: systemd: remove RestartPreventExitStatus=1 .. Abandoned needs more discussion, see

[S] Change in osmo-pcu[osmith/1.4.0]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)

2023-12-11 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email ) Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) .. Abandoned needs more discussion, see

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

2023-12-11 Thread osmith
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF .. Patch Set 1: (1

[S] Change in osmo-pcu[osmith/1.4.0]: TBF status: Fix VTY output text

2023-12-11 Thread jolly
Attention is currently required from: osmith. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35317?usp=email ) Change subject: TBF status: Fix VTY output text .. Patch Set 1: Code-Review+1

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

2023-12-11 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF .. Patch Set 1: (1

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF .. Patch Set 1:

[S] Change in osmo-pcu[osmith/1.4.0]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

2023-12-11 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses .. stream_cli:

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

2023-12-11 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses .. Patch Set 3:

[S] Change in libosmo-netif[master]: stream_cli: Introduce API osmo_stream_srv_get_sockname()

2023-12-11 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email ) Change subject: stream_cli: Introduce API osmo_stream_srv_get_sockname() .. stream_cli: Introduce API

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

2023-12-11 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: pcu_l1_if: signal BTS model via PCUIF

[S] Change in libosmo-netif[master]: stream_cli: Introduce API osmo_stream_srv_get_sockname()

2023-12-11 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email ) Change subject: stream_cli: Introduce API osmo_stream_srv_get_sockname()

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

2023-12-11 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses

[M] Change in libosmo-netif[master]: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the ...

2023-12-11 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35287?usp=email ) Change subject: stream_srv_link: osmo_stream_srv_link_get_sockname() now returns the full set of addresses

[S] Change in libosmo-netif[master]: stream_cli: Introduce API osmo_stream_srv_get_sockname()

2023-12-11 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35286?usp=email ) Change subject: stream_cli: Introduce API osmo_stream_srv_get_sockname()

[S] Change in libosmo-netif[master]: stream_cli: osmo_stream_cli_get_sockname() now returns the full set o...

2023-12-11 Thread osmith
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35285?usp=email ) Change subject: stream_cli: osmo_stream_cli_get_sockname() now returns the full set of addresses

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

2023-12-11 Thread osmith
Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

2023-12-11 Thread pespin
Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

2023-12-11 Thread osmith
Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email ) Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

[M] Change in osmo-ci[master]: coverity: add job to check for failed uploads

2023-12-11 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35267?usp=email ) Change subject: coverity: add job to check for failed uploads .. coverity: add job to check for failed uploads Related: SYS#6685

[M] Change in osmo-pcu[osmith/1.4.0]: gprs_rlcmac_sched: fix condition for generating dummy blocks on idle

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35319?usp=email ) Change subject: gprs_rlcmac_sched: fix condition for generating dummy blocks on idle

[S] Change in osmo-pcu[osmith/1.4.0]: Bump version: 1.3.1.6-8b8b → 1.4.0

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35320?usp=email ) Change subject: Bump version: 1.3.1.6-8b8b → 1.4.0 .. Patch Set 1:

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF .. Patch Set 1:

[S] Change in osmo-pcu[osmith/1.4.0]: TBF status: Fix VTY output text

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35317?usp=email ) Change subject: TBF status: Fix VTY output text .. Patch Set 1:

[S] Change in osmo-pcu[osmith/1.4.0]: Increase RR scheduler priority to 20, to avoid dropped bursts

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35316?usp=email ) Change subject: Increase RR scheduler priority to 20, to avoid dropped bursts

[S] Change in osmo-pcu[osmith/1.4.0]: systemd: remove RestartPreventExitStatus=1

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35315?usp=email ) Change subject: systemd: remove RestartPreventExitStatus=1 .. Patch Set 1:

[S] Change in osmo-pcu[osmith/1.4.0]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)

2023-12-11 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email ) Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)

[M] Change in osmo-sip-connector[master]: verbosely log MNCC and SDP

2023-12-11 Thread fixeria
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email ) Change subject: verbosely log MNCC and SDP .. Patch Set 2:

[S] Change in libosmocore[master]: utils: improve readability of OSMO_STRBUF_CHAR_COUNT

2023-12-11 Thread pespin
Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35313?usp=email ) Change subject: utils: improve readability of OSMO_STRBUF_CHAR_COUNT

[S] Change in osmo-pcu[osmith/1.4.0]: Bump version: 1.3.1.6-8b8b → 1.4.0

2023-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35320?usp=email ) Change subject: Bump version: 1.3.1.6-8b8b → 1.4.0 .. Bump version: 1.3.1.6-8b8b → 1.4.0 Change-Id:

[M] Change in osmo-pcu[osmith/1.4.0]: gprs_rlcmac_sched: fix condition for generating dummy blocks on idle

2023-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35319?usp=email ) Change subject: gprs_rlcmac_sched: fix condition for generating dummy blocks on idle .. gprs_rlcmac_sched: fix condition

[S] Change in osmo-pcu[osmith/1.4.0]: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive)

2023-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35314?usp=email ) Change subject: bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) .. bts: bts_tfi_find_free(): fix

[S] Change in osmo-pcu[osmith/1.4.0]: systemd: remove RestartPreventExitStatus=1

2023-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35315?usp=email ) Change subject: systemd: remove RestartPreventExitStatus=1 .. systemd: remove RestartPreventExitStatus=1 Fix OsmoPCU not

[S] Change in osmo-pcu[osmith/1.4.0]: pcu_l1_if: signal BTS model via PCUIF

2023-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email ) Change subject: pcu_l1_if: signal BTS model via PCUIF .. pcu_l1_if: signal BTS model via PCUIF At the moment the PCU has

[S] Change in osmo-pcu[osmith/1.4.0]: TBF status: Fix VTY output text

2023-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35317?usp=email ) Change subject: TBF status: Fix VTY output text .. TBF status: Fix VTY output text The vty command 'show bts pdch' had

[S] Change in osmo-pcu[osmith/1.4.0]: Increase RR scheduler priority to 20, to avoid dropped bursts

2023-12-11 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35316?usp=email ) Change subject: Increase RR scheduler priority to 20, to avoid dropped bursts .. Increase RR scheduler priority to 20, to

[M] Change in libosmocore[master]: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly

2023-12-11 Thread pespin
Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35312?usp=email ) Change subject: utils: fix OSMO_STRBUF_REMAIN to handle sb.pos == NULL correctly

[M] Change in osmo-sip-connector[master]: verbosely log MNCC and SDP

2023-12-11 Thread pespin
Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/35308?usp=email ) Change subject: verbosely log MNCC and SDP .. Patch Set 2:

[M] Change in libosmocore[master]: soft_uart: fix the Rx flushing logic, add a unit test

2023-12-11 Thread pespin
Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35297?usp=email ) Change subject: soft_uart: fix the Rx flushing logic, add a unit test

[S] Change in osmo-msc[master]: sdp: allow more space for fmtp

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35306?usp=email ) Change subject: sdp: allow more space for fmtp .. Patch Set 1: Code-Review+1

[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()

2023-12-11 Thread pespin
Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email to look at the new patch set (#3). The following approvals got outdated and were

[S] Change in libosmo-netif[master]: netif: sctp.h: Introduce value_string for enum sctp_sstat_state

2023-12-11 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35283?usp=email ) Change subject: netif: sctp.h: Introduce value_string for enum sctp_sstat_state .. netif: sctp.h: Introduce value_string for

[S] Change in libosmo-netif[master]: netif: sctp.h: Introduce value_string for enum sctp_spinfo_state

2023-12-11 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35280?usp=email ) Change subject: netif: sctp.h: Introduce value_string for enum sctp_spinfo_state .. netif: sctp.h: Introduce value_string for

[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. Patch

[S] Change in osmo-ci[master]: Revert "coverity: build osmo-trx with USRP1 support"

2023-12-11 Thread fixeria
Attention is currently required from: laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35291?usp=email ) Change subject: Revert "coverity: build osmo-trx with USRP1 support"

[M] Change in osmo-msc[master]: implement re-assignment to match codecs

2023-12-11 Thread pespin
Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35051?usp=email ) Change subject: implement re-assignment to match codecs .. Patch Set

[M] Change in osmo-msc[master]: cc: remove code dup for / fix reading codecs from MNCC

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35305?usp=email ) Change subject: cc: remove code dup for / fix reading codecs from MNCC ..

[M] Change in osmo-ci[master]: coverity: add job to check for failed uploads

2023-12-11 Thread fixeria
Attention is currently required from: daniel, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35267?usp=email ) Change subject: coverity: add job to check for failed uploads ..

[S] Change in osmo-bts[master]: Handle empty (idle) PDCH blocks gracefully

2023-12-11 Thread jolly
jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35270?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Handle empty (idle) PDCH blocks gracefully

[M] Change in osmo-mgw[master]: drop (now) unused code

2023-12-11 Thread laforge
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35247?usp=email ) Change subject: drop (now) unused code .. Patch Set 4: Code-Review+2 -- To

[S] Change in osmo-ci[master]: Revert "coverity: build osmo-trx with USRP1 support"

2023-12-11 Thread laforge
Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35291?usp=email ) Change subject: Revert "coverity: build osmo-trx with USRP1 support"

[S] Change in osmo-mgw[master]: tweak DEBUG log

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35304?usp=email ) Change subject: tweak DEBUG log .. Patch Set 1: Code-Review+2 -- To view,

[S] Change in osmo-mgw[master]: mgw: do not fail MGCP on codec mismatch

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email ) Change subject: mgw: do not fail MGCP on codec mismatch .. Patch Set 1: (2

[S] Change in osmo-mgw[master]: mgcp_test: fix false negatives in test output

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35303?usp=email ) Change subject: mgcp_test: fix false negatives in test output .. Patch Set 1:

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-12-11 Thread pespin
Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp ..

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp .. Patch

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

2023-12-11 Thread jolly
jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email ) ( 7 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without

[M] Change in osmo-mgw[master]: drop (now) unused code

2023-12-11 Thread pespin
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35247?usp=email ) Change subject: drop (now) unused code .. Patch Set 4: Code-Review+1 -- To

  1   2   >