Max has posted comments on this change. ( https://gerrit.osmocom.org/11934 )
Change subject: ctrl2cgi: explicitly ignore arguments to lambda function
..
Patch Set 2:
(1 comment)
python tends to defer errors to the very last
Max has posted comments on this change. ( https://gerrit.osmocom.org/11934 )
Change subject: ctrl2cgi: explicitly ignore arguments to lambda function
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11934
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11934
Change subject: ctrl2cgi: explicitly ignore arguments to lambda function
..
ctrl2cgi: explicitly ignore arguments to lambda function
Change-Id
: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Max has posted comments on this change. ( https://gerrit.osmocom.org/11912 )
Change subject: ctrl: handle ECONNRESET on initial read gracefully
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11912
Max has posted comments on this change. ( https://gerrit.osmocom.org/11926 )
Change subject: ctrl: use #define for TRAP id
..
Patch Set 1:
(1 comment)
I think such questions better be addressed to ML where they could reach
Max has posted comments on this change. ( https://gerrit.osmocom.org/11927 )
Change subject: ctrl: clarify use of id = 0
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/11927/1/common/chapters/control_if.adoc
File
: Ic0147bffaf04b0baf97e5cca22948bd0e116668f
Gerrit-Change-Number: 11911
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Max has posted comments on this change. ( https://gerrit.osmocom.org/11911 )
Change subject: IPA: move duplicated error handling into function
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/11911/3/src/gsm/ipa.c
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11910 )
Change subject: ctrl: print textual error on IPA parsing failure
..
ctrl: print textual error on IPA parsing failure
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/11909 )
Change subject: osmo_ctrl.py: properly ignore out-of-order traps
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11909
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11930
Change subject: ctrl: cosmetic cleanup
..
ctrl: cosmetic cleanup
* remove unused function
* move internal function call outside of main
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11928
Change subject: ctrl: introduce constant for TRAP id
..
ctrl: introduce constant for TRAP id
Use it for TRAP message parsing and generation.
Change
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11927
Change subject: ctrl: clarify use of id = 0
..
ctrl: clarify use of id = 0
Change-Id: Ic00de5023e7a1ec6426a0178778d35b13c337271
---
M common/chapters
Max has posted comments on this change. ( https://gerrit.osmocom.org/11911 )
Change subject: IPA: move duplicated error handling into function
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11911
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11926
Change subject: ctrl: use #define for TRAP id
..
ctrl: use #define for TRAP id
We always use id = 0 when sending TRAP messages. Let's make this more
Max has posted comments on this change. ( https://gerrit.osmocom.org/11910 )
Change subject: ctrl: print textual error on IPA parsing failure
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11910
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11913 )
Change subject: Revert "gbproxy: fix formatting in gbproxy-state command"
..
Revert "gbproxy: fix formatting in gbprox
Max has posted comments on this change. ( https://gerrit.osmocom.org/11885 )
Change subject: Add OpenVPN status helper example from corresponding ticket
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/11921 )
Change subject: Remove ipaccess utils
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11921
To unsubscribe, or for help writing
Max has posted comments on this change. ( https://gerrit.osmocom.org/11910 )
Change subject: ctrl: print textual error on IPA parsing failure
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11910
Max has posted comments on this change. ( https://gerrit.osmocom.org/11913 )
Change subject: Revert "gbproxy: fix formatting in gbproxy-state command"
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom
Max has created a revert of this change. ( https://gerrit.osmocom.org/11894 )
Change subject: gbproxy: fix formatting in gbproxy-state command
..
--
To view, visit https://gerrit.osmocom.org/11894
To unsubscribe, or for help
Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ea17919ec3ed7e26044df8b5f8324717ee9e32c
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 1
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: daniel
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11912
Change subject: ctrl: handle ECONNRESET on initial read gracefully
..
ctrl: handle ECONNRESET on initial read gracefully
When we're reading CTRL
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11911
Change subject: IPA: move duplicated error handling into inline function
..
IPA: move duplicated error handling into inline function
The code is re
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11910
Change subject: ctrl: print textual error on IPA parsing failure
..
ctrl: print textual error on IPA parsing failure
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11909
Change subject: osmo_ctrl.py: properly ignore out-of-order traps
..
osmo_ctrl.py: properly ignore out-of-order traps
Sometimes when we set variable we
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11721 )
Change subject: vty: add command to show TRX selectively
..
vty: add command to show TRX selectively
Add following commands showing only TRX
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11896 )
Change subject: ctrl2cgi.py: log address on errors
..
ctrl2cgi.py: log address on errors
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11896
Change subject: ctrl2cgi.py: log address on errors
..
ctrl2cgi.py: log address on errors
Change-Id: I80cdcda134766c679c2b80b848fb9db853321cfd
Related
Max has posted comments on this change. ( https://gerrit.osmocom.org/11886 )
Change subject: Expand default config
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11886
To unsubscribe, or for help writing
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11894
Change subject: gbproxy: fix formatting in gbproxy-state command
..
gbproxy: fix formatting in gbproxy-state command
In ctrl protocol we don't need
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11895
Change subject: gbproxy: add number-of-peers ctrl command
..
gbproxy: add number-of-peers ctrl command
Return number of BTS peers. This is especially
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11887
Change subject: NS: fix formatting in gprs_nsvc_state_append()
..
NS: fix formatting in gprs_nsvc_state_append()
This function so far has been used
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11883 )
Change subject: Add osmo-sysmon to default depcheck config
..
Add osmo-sysmon to default depcheck config
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/11883 )
Change subject: Add osmo-sysmon to default depcheck config
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/11883
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11886
Change subject: Expand default config
..
Expand default config
* add file watcher example
* add more ctrl variables
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11885
Change subject: Add OpenVPN status helper from corresponding ticket
..
Add OpenVPN status helper from corresponding ticket
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/11882 )
Change subject: Add osmo-sysmon to coverity submission
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/11882
To unsubscribe
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11882 )
Change subject: Add osmo-sysmon to coverity submission
..
Add osmo-sysmon to coverity submission
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/11820 )
Change subject: LCLS: update parameter representation
..
Patch Set 3:
> Please have a look at it and submit a patch regarding this issue.
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11883
Change subject: Add osmo-sysmon to default depcheck config
..
Add osmo-sysmon to default depcheck config
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11882
Change subject: Add osmo-sysmon to coverity submission
..
Add osmo-sysmon to coverity submission
Change-Id: I1e753d2c14198eccb046c259b3eec582b1921431
Max has posted comments on this change. ( https://gerrit.osmocom.org/11880 )
Change subject: Update default config
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11880
To unsubscribe, or for help writing
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11868 )
Change subject: Update gsm0808_create_ass() doxygen
..
Update gsm0808_create_ass() doxygen
* add spec reference
* remove LCLS note: CI
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11877
Change subject: Add git-review config
..
Add git-review config
Change-Id: Ie49cfcf38cc28a42c97eb4119231d8d885443a26
---
A .gitreview
1 file changed, 3
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11880
Change subject: Update default config
..
Update default config
Rename default config to match the binary name and add config exampe.
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11879
Change subject: Report config file name on error
..
Report config file name on error
Change-Id: If3f97452e4defb5c8dd540dd75045d37824fb305
---
M
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11878
Change subject: Update gitignore
..
Update gitignore
Change-Id: I2e63890653240b641b3c8b4b92b76b3833667ff3
---
M .gitignore
1 file changed, 1 insertion
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11866 )
Change subject: Drop unused function
..
Drop unused function
Change-Id: Ib1ecc6dcb243da27976ca0e90a83aefa18a65b76
---
M include/osmo-bts
Max has posted comments on this change. ( https://gerrit.osmocom.org/11866 )
Change subject: Drop unused function
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11866
To unsubscribe, or for help writing
Max has abandoned this change. ( https://gerrit.osmocom.org/11865 )
Change subject: Don't traverse empty lists in llist_count()
..
Abandoned
Not needed indeed - see 11875.
--
To view, visit https://gerrit.osmocom.org/11865
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11875
Change subject: Add basic test for llist counter and empty check
..
Add basic test for llist counter and empty check
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11868
Change subject: Update gsm0808_create_ass() doxygen
..
Update gsm0808_create_ass() doxygen
* add spec reference
* remove LCLS note: CI parameter
Max has posted comments on this change. ( https://gerrit.osmocom.org/11820 )
Change subject: LCLS: update parameter representation
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11820
To unsubscribe
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11867
Change subject: Fix type mismatch
..
Fix type mismatch
llist_count() return unsigned value, let's use it for counter as well.
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11866
Change subject: Drop unused function
..
Drop unused function
Change-Id: Ib1ecc6dcb243da27976ca0e90a83aefa18a65b76
---
M include/osmo-bts
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11865
Change subject: Don't traverse empty lists in llist_count()
..
Don't traverse empty lists in llist_count()
While trying to debug odd crash
Max has posted comments on this change. ( https://gerrit.osmocom.org/11852 )
Change subject: mobile: use VTY bind addr from config, deprecate cmd line
options
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/11848 )
Change subject: Revert "mobile: fix vty bind ip override"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11832 )
Change subject: Use libosmocore to function to parse cipher mode reject cause
..
Use libosmocore to function to parse cipher mode reject
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11831 )
Change subject: Use BSSAP-specific TLV parser from libosmocore
..
Use BSSAP-specific TLV parser from libosmocore
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/11832 )
Change subject: Use libosmocore to function to parse cipher mode reject cause
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 )
Change subject: LCLS: add GCR routines
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 )
Change subject: LCLS: add GCR routines
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11842
Change subject: Add osmo_sockaddrin_to_str_and_uint()
..
Add osmo_sockaddrin_to_str_and_uint()
It's similar to osmo_sockaddr_to_str_and_uint
Max has posted comments on this change. ( https://gerrit.osmocom.org/11820 )
Change subject: LCLS: update parameter representation
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/11820/2/src/osmo-bsc
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11703 )
Change subject: LCLS: add 48.008 parameter structure
..
LCLS: add 48.008 parameter structure
It's convenient to hold all LCLS-related
Max has posted comments on this change. ( https://gerrit.osmocom.org/11703 )
Change subject: LCLS: add 48.008 parameter structure
..
Patch Set 4:
Feel free to correct typos directly - we don't have to wait for me to fix
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11838
Change subject: Fix IMSI padding in imsi-acl
..
Fix IMSI padding in imsi-acl
In I73fd54ad3a4ab8be5aff0fee5c722597ad766e9d incorrect fix was added
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11457 )
Change subject: mobile: fix vty bind ip override
..
mobile: fix vty bind ip override
Previously the vty bind config parameter was always
, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b873f9a3c5a5d33b438382971b3d92e40d48d62
Gerrit-Change-Number: 11703
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer
Max has posted comments on this change. ( https://gerrit.osmocom.org/11833 )
Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/11457 )
Change subject: mobile: fix vty bind ip override
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11457
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/11690 )
Change subject: MSC_Tests: remove unused control interface
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/11690/4/msc/MSC_Tests.ttcn
Max has posted comments on this change. ( https://gerrit.osmocom.org/11789 )
Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce
gsm_arfcn2band_rc
..
Patch Set 1:
> osmo_gsm_arfcn2band
That sounds bet
Max has posted comments on this change. ( https://gerrit.osmocom.org/11832 )
Change subject: Use libosmocore to function to parse cipher mode reject cause
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/11832/1/src
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11832
Change subject: Use libosmocore to function to parse cipher mode reject cause
..
Use libosmocore to function to parse cipher mode reject cause
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11831
Change subject: Use BSSAP-specific TLV parser from libosmocore
..
Use BSSAP-specific TLV parser from libosmocore
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/11721 )
Change subject: vty: add command to show TRX selectively
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11721
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/11707 )
Change subject: SS7: safeguard against wrong number of pointcode component
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/11826 )
Change subject: LCLS: add gsm0808_create_ass_ext()
..
Patch Set 7:
> Is it a different message from the existing function?
It's the same, I've ad
Max has posted comments on this change. ( https://gerrit.osmocom.org/11826 )
Change subject: LCLS: add gsm0808_create_ass_ext()
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11826
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 )
Change subject: LCLS: add GCR routines
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11827
Change subject: Add GCR routines
..
Add GCR routines
Add functions to create and decode Global Call Reference as per
3GPP TS 29.205 Table B 2.1.9.1
Max has posted comments on this change. ( https://gerrit.osmocom.org/11703 )
Change subject: LCLS: add 48.008 parameter structure
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11703
To unsubscribe
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11826
Change subject: LCLS: add gsm0808_create_ass_ext()
..
LCLS: add gsm0808_create_ass_ext()
It allows setting additional assingment parameters
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11825
Change subject: Fix build with latest libosmocore
..
Fix build with latest libosmocore
Remove locally defined function which conflicts with the one
Max has posted comments on this change. ( https://gerrit.osmocom.org/11552 )
Change subject: LCLS: add bts-loop variant
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11552
To unsubscribe, or for help
Max has posted comments on this change. ( https://gerrit.osmocom.org/11550 )
Change subject: RSL: restructure MDCX functions
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11550
To unsubscribe
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11823
Change subject: Add missing header include
..
Add missing header include
That's necessary for 'struct tlv_parsed' definition although lack of it
does
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11809 )
Change subject: BSC: log BTS number on failure
..
BSC: log BTS number on failure
It's useful to see which BTS exactly has failed the test
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11822
Change subject: Fix build with latest libosmocore
..
Fix build with latest libosmocore
Remove locally defined function which conflicts with the one
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11821
Change subject: Fix build with latest libosmocore
..
Fix build with latest libosmocore
Remove locally defined function which conflicts with the one
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11812 )
Change subject: mobile: log socket path on error
..
mobile: log socket path on error
Change-Id: I18eb46743e4c0e4e8f8032883f39fec355f03c78
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11814 )
Change subject: l1l2 interface: use LOGP for socket errors
..
l1l2 interface: use LOGP for socket errors
Log via LOGP() like the rest
Max has posted comments on this change. ( https://gerrit.osmocom.org/11814 )
Change subject: l1l2 interface: use LOGP for socket errors
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11814
To unsubscribe
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11813 )
Change subject: osmocon: log error cause for socket opening
..
osmocon: log error cause for socket opening
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/11813 )
Change subject: osmocon: log error cause for socket opening
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/11813
1201 - 1300 of 3542 matches
Mail list logo
